[SeaBIOS] Re: [PATCH] ahci: zero-initialize port struct

On Wed, Nov 13, 2019 at 05:03:58PM +0200, Sam Eiderman wrote: > Hi, > > Does this fix a bug that actually happened? Yes, "make check-qtest" may fail. It's kind of random though. > I just noticed that in my lchs patches I assumed that lchs struct is > zeroed out in all devices (not only ahci):

[SeaBIOS] Re: [PATCH] ahci: zero-initialize port struct

Links to latest commits from archive. You can see all changes in the cover letter. [SeaBIOS] [PATCH v4 0/5] Add Qemu to SeaBIOS LCHS interface https://mail.coreboot.org/hyperkitty/list/seabios@seabios.org/message/VLNFBEERTWLEUO6LM5BYLBNVIFCTP46M/ [SeaBIOS] [PATCH v4 1/5] geometry: Read LCHS from f

[SeaBIOS] Re: [PATCH] ahci: zero-initialize port struct

Sure, There are two issues here. The first issue is that my commits which applied to seabios master: * 9caa19b - geometry: Apply LCHS values for boot devices * cb56f61 - config: Add toggle for bootdevice information * ad29109 - geometry: Add boot_lchs_find_*() utility functions * b3d2120 - boot:

[SeaBIOS] Re: [PATCH] ahci: zero-initialize port struct

Hi Sam, On 11/13/19 4:03 PM, Sam Eiderman wrote: Hi, Does this fix a bug that actually happened? I just noticed that in my lchs patches I assumed that lchs struct is zeroed out in all devices (not only ahci): 9caa19be0e53 (geometry: Apply LCHS values for boot devices) Seems like this is not

[SeaBIOS] Re: [PATCH] ahci: zero-initialize port struct

Sorry the correct list (which includes ahci) is: git grep "drive_s * drive" src/hw/ahci.h:struct drive_s drive; src/hw/ata.h:struct drive_s drive; src/hw/esp-scsi.c:struct drive_s drive; src/hw/lsi-scsi.c:struct drive_s drive; src/hw/megasas.c:struct drive_s drive; src/hw/

[SeaBIOS] Re: [PING: PATCH v1] virtio: extend virtio queue size to 256

Thanks! Denis On 12.11.2019 12:36, Gerd Hoffmann wrote: >Hi, > >> -#define MAX_QUEUE_NUM (128) >> +#define MAX_QUEUE_NUM (256) > Committed to master (a while ago already, probably forgot to reply, > sorry ...) > > cheers, >Gerd > ___ S

[SeaBIOS] [PATCH v1--annotate] virtio: extend virtio queue size to 256

v1: * more verbose commit message [Gerd] --- The goal of the patch is to work around a performance bug in guest linux kernels. Old linux kernels has a performance flaw in virtio block device access: on some frequent disk access patterns, e.g. 1M read, the kernel produces more block requests th

[SeaBIOS] Re: [coreboot] Re: Booting Memtest86+ from CBFS fails

Hi Mike! Thank you so much for this, I was getting really frustrated with memtest and coreboot, but this solved it. The only problem that remains now, is memtest is now the first entry and thus default in seabios which is rather inconvenient. Have you tried changing the boot order too? I too

[SeaBIOS] [PING: PATCH v1] virtio: extend virtio queue size to 256

v1: * more verbose commit message [Gerd] --- The goal of the patch is to work around a performance bug in guest linux kernels. Old linux kernels has a performance flaw in virtio block device access: on some frequent disk access patterns, e.g. 1M read, the kernel produces more block requests th

[SeaBIOS] Re: [PATCH 0/2] tpm: Defend against TPM sending unexpected short packets

On Wed, Nov 06, 2019 at 04:35:58PM -0500, Stefan Berger wrote: > This series of patches addresses issues that may arise if a TPM sends > unexpected short packets. > >Stefan Thanks. I committed this series. -Kevin ___ SeaBIOS mailing list -- seabio

[SeaBIOS] Re: [PATCH] ahci: zero-initialize port struct

We should make sure drive.lchs is zeroed out for the following devices: git grep "drive_s drive" src/hw/ata.h:struct drive_s drive; src/hw/esp-scsi.c:struct drive_s drive; src/hw/lsi-scsi.c:struct drive_s drive; src/hw/megasas.c:struct drive_s drive; src/hw/mpt-scsi.c:struct d

[SeaBIOS] Re: [PATCH] ahci: zero-initialize port struct

Hi, Does this fix a bug that actually happened? I just noticed that in my lchs patches I assumed that lchs struct is zeroed out in all devices (not only ahci): 9caa19be0e53 (geometry: Apply LCHS values for boot devices) Seems like this is not the case but why only ahci is affected? The list of

[SeaBIOS] Re: [PATCH] ahci: zero-initialize port struct

On Wed, Nov 13, 2019 at 10:35:03AM +0100, Laszlo Ersek wrote: > On 11/13/19 10:18, Gerd Hoffmann wrote: > > Specifically port->driver.lchs needs clearing, otherwise seabios will > > s/driver/drive/ > Reviewed-by: Laszlo Ersek Typo fixed & pushed. thanks, Gerd

[SeaBIOS] Re: [PATCH] ahci: zero-initialize port struct

On 11/13/19 10:18, Gerd Hoffmann wrote: > Specifically port->driver.lchs needs clearing, otherwise seabios will s/driver/drive/ > try interpret whatever random crap happens to be there as disk geometry, > which may or may not break boot depending on how lucky you are. > > Signed-off-by: Gerd Hof

[SeaBIOS] [PATCH] ahci: zero-initialize port struct

Specifically port->driver.lchs needs clearing, otherwise seabios will try interpret whatever random crap happens to be there as disk geometry, which may or may not break boot depending on how lucky you are. Signed-off-by: Gerd Hoffmann --- src/hw/ahci.c | 1 + 1 file changed, 1 insertion(+) dif