Re: [SeaBIOS] [PATCH 5/6] sercon: split-output implementation

Hi, > > > Minor note - I realized after I sent my last patch that doing: > > > > > > SET_LOW(sercon_enable, (mode <= 0x07)); > > > > I don't think so.  0,1,2,3,7 are text modes, but 4,5,6 not. > > It's safe to enter the C code on 4,5,6 though.  Also, I don't think > it > was unusual to

Re: [SeaBIOS] [PATCH 5/6] sercon: split-output implementation

> On SeaVGABIOS, text writing now works in all graphic modes, though > not > all vgabios support that.  The original bochs vgabios didn't support > it in "direct" or "packed" modes, and I think it was broken for years > in planar mode.  So, it's rare for text writing to be seen in any > mode >

[SeaBIOS] [PATCH 4/6] add serial console support

Redirect int10 calls to serial console output. Parse serial input and queue key events. Signed-off-by: Gerd Hoffmann <kra...@redhat.com> --- Makefile | 2 +- src/util.h | 3 + src/clock.c | 1 + src/misc.c | 2 + src/optionroms.c | 7 +- src/sercon.c

[SeaBIOS] [PATCH 0/6] add serial console support

onvenience and will not be merged. It makes the seabios serial console a drop-in replacement for sgabios, i.e. it is possible to activate it using "qemu -device sga". Gerd Hoffmann (6): std: add cp437 to unicode map kbd: make enqueue_key public, add ascii_to_keycode paravirt: read QEMU_

[SeaBIOS] [PATCH 5/6] sercon: split-output implementation

Allows to run the serial console in parallel with a vga display. Output will show up on both vga and serial line. Input will be accepted from both keyboard and serial line. Signed-off-by: Gerd Hoffmann <kra...@redhat.com> --- src/optionroms.c | 2 ++ src/sercon.c

[SeaBIOS] [PATCH 2/6] kbd: make enqueue_key public, add ascii_to_keycode

serial console wants queue key events and needs to map ascii chars to the keycode, so make enqueue_key public and also exports a helper function so sercon can use the scan_to_keycode mapping table. Signed-off-by: Gerd Hoffmann <kra...@redhat.com> --- src/util.h | 2 ++ src/kbd.c

[SeaBIOS] [PATCH 6/6] [hack] ignore sgabios, enable sercon instead

Temporary, for testing convinience. --- src/optionroms.c | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/src/optionroms.c b/src/optionroms.c index 76a70ea686..7b1bc141eb 100644 --- a/src/optionroms.c +++ b/src/optionroms.c @@ -23,7 +23,7 @@ #include "tcgbios.h"

[SeaBIOS] [PATCH 1/6] std: add cp437 to unicode map

Signed-off-by: Gerd Hoffmann <kra...@redhat.com> --- Makefile| 1 + src/cp437.h | 1 + src/cp437.c | 275 3 files changed, 277 insertions(+) create mode 100644 src/cp437.h create mode 100644 src/cp437.c diff --git a/Ma

[SeaBIOS] [PATCH 3/6] paravirt: read QEMU_CFG_NOGRAPHIC, store in etc/sercon-enable romfile

Will be used as runtime switch to enable serial console support. Signed-off-by: Gerd Hoffmann <kra...@redhat.com> --- src/fw/paravirt.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/fw/paravirt.c b/src/fw/paravirt.c index 5b23d786be..e9cca4fe6e 100644 --- a/src/fw/paravirt.c

Re: [SeaBIOS] [PATCH 3/6] paravirt: read QEMU_CFG_NOGRAPHIC, store in etc/sercon-enable romfile

Hi, > Separately, how will sercon get the serial port that it is to use? > > Looking closer at patch 4 I see: > > +u16 addr = PORT_SERIAL1; > +SET_LOW(sercon_port, addr); > > Is the plan to pull this from a romfile so that it can be set on > coreboot?  If so, perhaps that

[SeaBIOS] Time for a seabios 1.11 release?

Hi, Quite a few changes accumulated in master. Time to plan a new release I think, so we can pick up the improvements in qemu 2.11. Comments? Anything pending for qemu which needs firmware support? cheers, Gerd ___ SeaBIOS mailing list

Re: [SeaBIOS] Time for a seabios 1.11 release?

On Wed, 2017-09-27 at 09:51 -0400, Kevin O'Connor wrote: > On Tue, Sep 26, 2017 at 09:33:09AM +0200, Gerd Hoffmann wrote: > >    Hi, > > > > Quite a few changes accumulated in master.  Time to plan a new > > release > > I think, so we can pick up the improvement

Re: [SeaBIOS] [PATCH] boot: Increase description size in boot menu

On Tue, 2017-08-22 at 07:39 +0200, Paul Menzel wrote: > Dear Kevin, > > > Am Dienstag, den 02.05.2017, 20:04 -0400 schrieb Kevin O'Connor: > > On Tue, Apr 25, 2017 at 01:06:53PM -0400, Kevin O'Connor wrote: > > > Increase the boot menu description size so that menu items up to > > > 80 > > >

Re: [SeaBIOS] [PATCH v2 2/2] usb-xhci: use hub portmap

On Fri, 2017-07-28 at 16:01 +0200, Gerd Hoffmann wrote: > xhci controllers have two virtual ports per (usb3 capable) physical > port, one for usb2 and one for usb3 devices.  Add a hub portmap > callback > to map the virtual ports to physical ports. Patches c

Re: [SeaBIOS] [PATCH 0/3] SeaVGABIOS serial console test

Hi, > I was thinking a few instructions to test if calll worked would be > sufficient to catch the x86emu case - something like: > >   pushl $0x >   calll 1f > 1:popl %eax >   cmpl %eax, $1b >   jne running_on_broken_x86emu Ok, finally picked this up again. Rebased the branch, added

Re: [SeaBIOS] GCC 7.1 warning in `tcgbios.c`: `'hleo.eventnumber' may be used uninitialized in this function`

Hi, > Could you please cherry-pick that commit  > 1ef72ab2f89ae61dcdb3f01323bd0a7dc978c2b9 to the stable branch  > *origin/1.10-stable*? Done. I guess time for 1.10.3 (three commits since 1.10.2), which will most likely be the last 1.10.x stable release with 1.11 being just around the corner.

Re: [SeaBIOS] [RFC] paravirt: Only enable sercon in NOGRAPHIC mode if no other console specified

On Fri, Nov 10, 2017 at 12:24:38PM -0500, Kevin O'Connor wrote: > Signed-off-by: Kevin O'Connor > --- > > I wonder if it would be better to only enable sercon with 0x3f8 in the > nographic case if QEMU has neither specified a sercon-port and has not > requested sgabios to be

Re: [SeaBIOS] [Qemu-devel] seabios serial console vs. sgabios

Hi, > > Hmm, why?  The user asked for a serial console.  Whenever that is > > provided by seabios builtin support or the sgabios rom doesn't > > really > > matter, no? > > Surely it has ABI implications for the guest if we stop putting the > sgabios option ROM into memory - changing layout of

[SeaBIOS] [PATCH seabios 0/3] add kvmtool support

to boot a linux guest to the login prompt. cheers, Gerd Gerd Hoffmann (3): kvmtool: initial support kvmtool: allow mmio for legacy bar 0 kvmtool: support larger virtio queues Makefile | 1 + src/fw/paravirt.h| 3 +++ src/hw/virtio-ring.h | 2 +- src/fw/paravirt.c

[SeaBIOS] [PATCH seabios 2/3] kvmtool: allow mmio for legacy bar 0

kvmtool uses MMIO not IO bar for legacy virtio. Doesn't match spec. But easy to handle given we have the code anyway for virtio 1.0 which allows both MMIO and IO. Signed-off-by: Gerd Hoffmann <kra...@redhat.com> --- src/hw/virtio-pci.c | 16 1 file changed, 12 insertions

[SeaBIOS] [PATCH seabios 1/3] kvmtool: initial support

-by: Gerd Hoffmann <kra...@redhat.com> --- Makefile | 1 + src/fw/paravirt.h | 3 +++ src/fw/paravirt.c | 48 src/post.c| 4 +++- src/sercon.c | 2 ++ src/Kconfig | 23 +-- 6 files changed, 78 inse

[SeaBIOS] [PATCH seabios 3/3] kvmtool: support larger virtio queues

kvmtool segfaults. Oops. * Linux kernel doesn't find virtio-blk devices after seabios initialized them. virtio device reset not working properly? Signed-off-by: Gerd Hoffmann <kra...@redhat.com> --- src/hw/virtio-ring.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/

Re: [SeaBIOS] [PATCH] serial console conflicts with serial debugging

On Thu, 2017-11-02 at 11:11 -0400, Kevin O'Connor wrote: > On Thu, Nov 02, 2017 at 10:02:52AM +0100, Gerd Hoffmann wrote: > > Signed-off-by: Gerd Hoffmann <kra...@redhat.com> > > If we defaulted "screen-and-debug" to zero on sercon, would that be > sufficient? I

[SeaBIOS] seabios serial console vs. sgabios

Hi, One problem we have with the serial console support in seabios and sgabios: It can happen that both are activated. We'll go fix that in qemu, but that'll work for new qemu versions only, not for the old already released ones. So I think it would be useful if seabios makes sure sgabios

[SeaBIOS] [PATCH] serial console conflicts with serial debugging

Signed-off-by: Gerd Hoffmann <kra...@redhat.com> --- src/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/src/Kconfig b/src/Kconfig index 4870a3e7b7..985594c51b 100644 --- a/src/Kconfig +++ b/src/Kconfig @@ -553,6 +553,7 @@ menu "Debugging" config DEBUG_SERIAL

Re: [SeaBIOS] [Qemu-devel] seabios serial console vs. sgabios

On Thu, 2017-11-02 at 16:11 +, Daniel P. Berrange wrote: > On Thu, Nov 02, 2017 at 05:04:20PM +0100, Gerd Hoffmann wrote: > >   Hi, > > > > One problem we have with the serial console support in seabios and > > sgabios:  It can happen that both a

[SeaBIOS] [PATCH] Disable ScreenAndDebug in case both serial console and serial debug are active

Signed-off-by: Gerd Hoffmann <kra...@redhat.com> --- src/sercon.c | 4 1 file changed, 4 insertions(+) diff --git a/src/sercon.c b/src/sercon.c index 0b7722ec08..72ebf82452 100644 --- a/src/sercon.c +++ b/src/sercon.c @@ -523,6 +523,10 @@ void sercon_setup(void)

[SeaBIOS] [PATCH] Ignore sgabios rom in case sercon is enabled.

We don't want them both be active. Signed-off-by: Gerd Hoffmann <kra...@redhat.com> --- src/optionroms.c | 5 + 1 file changed, 5 insertions(+) diff --git a/src/optionroms.c b/src/optionroms.c index 092393a56c..a5ecd4cd11 100644 --- a/src/optionroms.c +++ b/src/optionroms.c @@

[SeaBIOS] [PATCH 3/3] qemu: add qemu ramfb support

Add support for qemu ramfb. This is a simple boot framebuffer device, with normal ram being used to back the framebuffer and fw_cfg being used to configure the device. Use case (on x86): boot display for vgpu devices (which neither emulate vga nor have a vgabios). Signed-off-by: Gerd Hoffmann

[SeaBIOS] [PATCH 2/3] paravirt: move some fw_cfg bits to header file.

Also unstatic some qemu_cfg_* functions. This allows ramfb vgabios accessing fw_cfg. Signed-off-by: Gerd Hoffmann --- src/fw/paravirt.h | 27 +++ src/fw/paravirt.c | 30 +++--- 2 files changed, 30 insertions(+), 27 deletions(-) diff --git a/src

[SeaBIOS] [PATCH 1/3] config: reserve more high memory (for ramfb)

qemu ramfb allows to place a boot framebuffer in normal ram. The ramfb vgabios needs a bigger chunk of ram for that, so increase the amout of reserved memory. Obvious drawback is we waste the memory in case ramfb isn't used. Better ideas are welcome. Signed-off-by: Gerd Hoffmann --- src

[SeaBIOS] [PATCH] bochs_display_setup: return error on failure

Signed-off-by: Gerd Hoffmann --- vgasrc/bochsdisplay.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/vgasrc/bochsdisplay.c b/vgasrc/bochsdisplay.c index e1f90f9678..6a75f3787e 100644 --- a/vgasrc/bochsdisplay.c +++ b/vgasrc/bochsdisplay.c @@ -38,7 +38,7

[SeaBIOS] [PATCH v2 3/3] qemu: add qemu ramfb support

with seabios turned out to be difficuilt due to various dependencies the code has on infrastructure which only seabios has. So include a copy of the code here, with those dependencies removed and also stripped down because we don't need a non-dma fallback here. Signed-off-by: Gerd Hoffmann --- Makefile

[SeaBIOS] [PATCH v2 0/3] qemu: add qemu ramfb support

to dependencies on stuff like threads which isn't present in the vgabios builds. So I'm back to the version with the (stripped down) copy of the fw_cfg code ... Gerd Hoffmann (3): pmm: use tmp zone on oom vgasrc: add allocate_pmm() qemu: add qemu ramfb support Makefile | 2 +- vgasrc

[SeaBIOS] [PATCH v2 1/3] pmm: use tmp zone on oom

Signed-off-by: Gerd Hoffmann --- src/pmm.c | 13 + 1 file changed, 13 insertions(+) diff --git a/src/pmm.c b/src/pmm.c index 6403414724..28b253b2d3 100644 --- a/src/pmm.c +++ b/src/pmm.c @@ -8,6 +8,7 @@ #include "config.h" // CONFIG_* #include "malloc.h"

[SeaBIOS] [PATCH v2 2/3] vgasrc: add allocate_pmm()

Factor out pmm allocation function from stack allocator. Signed-off-by: Gerd Hoffmann --- vgasrc/vgautil.h | 1 + vgasrc/vgainit.c | 48 2 files changed, 33 insertions(+), 16 deletions(-) diff --git a/vgasrc/vgautil.h b/vgasrc/vgautil.h index

Re: [SeaBIOS] [PATCH 3/3] qemu: add qemu ramfb support

Hi, > It would be preferable to re-factor allocate_extra_stack() so there is > just one pmm allocation function. I'll try. > > +qemu_cfg_read_entry(, QEMU_CFG_FILE_DIR, sizeof(count)); > > +count = be32_to_cpu(count); > > +u32 select, e, fb; > > +for (select = 0, e = 0; e <

[SeaBIOS] [PATCH 4/6] cbvga_setup_modes: use real mode number instead of 0x140

In case the framebuffer size matches one of the cbvga video modes just use that mode number instead of 0x140. Signed-off-by: Gerd Hoffmann --- vgasrc/cbvga.c | 5 + 1 file changed, 5 insertions(+) diff --git a/vgasrc/cbvga.c b/vgasrc/cbvga.c index 672daa604c..2139a00904 100644 --- a/vgasrc

[SeaBIOS] [PATCH 0/6] qemu: add bochs-display support

Add support for the new bochs-display device in qemu. Gerd Hoffmann (6): pci,optionrom: enable non-vga display devices cbvga: factor out cbvga_setup_modes() qemu: add bochs-display support cbvga_setup_modes: use real mode number instead of 0x140 cbvga_list_modes: don't list current mode

[SeaBIOS] [PATCH 3/6] qemu: add bochs-display support

interface is compatible with the qemu stdvga. Signed-off-by: Gerd Hoffmann --- vgasrc/vgahw.h | 28 +++- vgasrc/vgautil.h | 1 + vgasrc/cbvga.c | 57 vgasrc/Kconfig | 17 + 4 files changed, 90

[SeaBIOS] [PATCH 6/6] [workaround] cbvga_set_mode: disable clearmem

Break windows, memcpy_high call is problematic. Possibly the windows x86 emulator doesn't support int 1587. Signed-off-by: Gerd Hoffmann --- vgasrc/cbvga.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/vgasrc/cbvga.c b/vgasrc/cbvga.c index 13a666b22b..6933fc72aa 100644 --- a/vgasrc

[SeaBIOS] [PATCH 2/6] cbvga: factor out cbvga_setup_modes()

Factor out generic data structure setup code from cbvga_setup(). Signed-off-by: Gerd Hoffmann --- vgasrc/cbvga.c | 57 - 1 file changed, 32 insertions(+), 25 deletions(-) diff --git a/vgasrc/cbvga.c b/vgasrc/cbvga.c index f85989a232

[SeaBIOS] [PATCH 5/6] cbvga_list_modes: don't list current mode twice

In case we've already added the framebuffer video mode to the list do not add number 0x140. Signed-off-by: Gerd Hoffmann --- vgasrc/cbvga.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/vgasrc/cbvga.c b/vgasrc/cbvga.c index 2139a00904..13a666b22b 100644 --- a/vgasrc

[SeaBIOS] [PATCH 1/6] pci, optionrom: enable non-vga display devices

In case no VGA device was found look for other display devices, in both pci initialization and in vgabios rom scan. Signed-off-by: Gerd Hoffmann --- src/fw/pciinit.c | 15 +++ src/optionroms.c | 29 - 2 files changed, 39 insertions(+), 5 deletions

Re: [SeaBIOS] [PATCH 0/6] qemu: add bochs-display support

On Thu, May 31, 2018 at 10:47:05AM +0200, Patrick Rudolph wrote: > Patch 2, 4 and 5 looks good to me. > Patch 6 causes artifacts on mode change, if the new mode is smaller > than the previous. Indeed. But I had no better idea (thats why it is tagged as "workaround"). Suggestions are welcome. >

[SeaBIOS] [PATCH v2 3/6] qemu: add bochs-display support

interface is compatible with the qemu stdvga. Signed-off-by: Gerd Hoffmann --- Makefile | 2 +- vgasrc/vgahw.h| 28 vgasrc/vgautil.h | 3 +++ vgasrc/bochsdisplay.c | 59 +++ vgasrc/Kconfig| 17

[SeaBIOS] [PATCH v2 0/6] qemu: add bochs-display support

Add support for the new bochs-display device in qemu. Gerd Hoffmann (6): optionrom: enable non-vga display devices cbvga: factor out cbvga_setup_modes() qemu: add bochs-display support cbvga_setup_modes: use real mode number instead of 0x140 cbvga_list_modes: don't list current mode

[SeaBIOS] [PATCH v2 1/6] optionrom: enable non-vga display devices

In case no VGA device was found look for other display devices. Signed-off-by: Gerd Hoffmann --- src/optionroms.c | 29 - 1 file changed, 28 insertions(+), 1 deletion(-) diff --git a/src/optionroms.c b/src/optionroms.c index 092393a56c..fc992f649f 100644 --- a/src

[SeaBIOS] [PATCH v2 4/6] cbvga_setup_modes: use real mode number instead of 0x140

In case the framebuffer size matches one of the cbvga video modes just use that mode number instead of 0x140. Signed-off-by: Gerd Hoffmann --- vgasrc/cbvga.c | 5 + 1 file changed, 5 insertions(+) diff --git a/vgasrc/cbvga.c b/vgasrc/cbvga.c index 9ae97d5f51..fb68620067 100644 --- a/vgasrc

[SeaBIOS] [PATCH v2 5/6] cbvga_list_modes: don't list current mode twice

In case we've already added the framebuffer video mode to the list do not add number 0x140. Signed-off-by: Gerd Hoffmann --- vgasrc/cbvga.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/vgasrc/cbvga.c b/vgasrc/cbvga.c index fb68620067..3f16bee10c 100644 --- a/vgasrc

[SeaBIOS] [PATCH v2 6/6] cbvga_set_mode: disable clearmem in windows x86 emulator.

Signed-off-by: Gerd Hoffmann --- vgasrc/cbvga.c | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/vgasrc/cbvga.c b/vgasrc/cbvga.c index 3f16bee10c..f6ebe71242 100644 --- a/vgasrc/cbvga.c +++ b/vgasrc/cbvga.c @@ -192,8 +192,16 @@ int cbvga_set_mode(struct vgamode_s

[SeaBIOS] [PATCH v2 2/6] cbvga: factor out cbvga_setup_modes()

Factor out generic data structure setup code from cbvga_setup(). Signed-off-by: Gerd Hoffmann --- vgasrc/vgautil.h | 1 + vgasrc/cbvga.c | 57 +++- 2 files changed, 33 insertions(+), 25 deletions(-) diff --git a/vgasrc/vgautil.h b/vgasrc

Re: [SeaBIOS] [PATCH 3/6] qemu: add bochs-display support

On Thu, May 31, 2018 at 11:12:14AM -0400, Kevin O'Connor wrote: > On Thu, May 31, 2018 at 08:33:50AM +0200, Gerd Hoffmann wrote: > [...] > > + dprintf(1, "bochs-display: using %dx%d, %d bpp (%d stride)\n" > > +, FRAMEBUFF

Re: [SeaBIOS] [PATCH 3/6] qemu: add bochs-display support

On Thu, May 31, 2018 at 10:44:55AM -0400, Kevin O'Connor wrote: > On Thu, May 31, 2018 at 08:33:50AM +0200, Gerd Hoffmann wrote: > > Use coreboot text mode emulation to also support the qemu bochs-display > > device. This is a new display device supporting simple linear > >

Re: [SeaBIOS] [PATCH 1/6] pci, optionrom: enable non-vga display devices

> > +if (!have_vga) { > > +// no VGA, try fallback to display > > +dprintf(1, "no vga, try display\n"); > > +foreachpci(pci) { > > +if (!is_pci_display_other(pci)) > > +continue; > > +vgahook_setup(pci); > > +

Re: [SeaBIOS] [PATCH 6/6] [workaround] cbvga_set_mode: disable clearmem

On Thu, May 31, 2018 at 10:54:39AM -0400, Kevin O'Connor wrote: > On Thu, May 31, 2018 at 08:33:53AM +0200, Gerd Hoffmann wrote: > > Break windows, memcpy_high call is problematic. > > Possibly the windows x86 emulator doesn't support int 1587. > > Interesting.

Re: [SeaBIOS] [PATCH 6/6] [workaround] cbvga_set_mode: disable clearmem

Hi, > > Perhaps do > > something like the existing BF_EXTRA_STACK check (eg, if we get a vesa > > mode call then we disable 1587 on subsequent calls). > > Can try whenever the BF_EXTRA_STACK check can be used for this too. Yes, works (i.e. clear screen only in case BF_EXTRA_STACK is set).

Re: [SeaBIOS] seabios fails to build with current IASL

On Sun, Jul 01, 2018 at 08:33:28AM +0300, Michael Tokarev wrote: > 01.07.2018 04:25, Kevin O'Connor wrote: > > On Sat, Jun 30, 2018 at 11:28:07AM +0300, Michael Tokarev wrote: > >> Here's the debian bugreport > >> https://bugs.debian.org/901462 > >> with the patch. > > > > I'm a little confused

Re: [SeaBIOS] [PATCH v2 6/6] cbvga_set_mode: disable clearmem in windows x86 emulator.

Hi, > > +if (extra_stack) { > > I'm also not sure on the cause, but I think it should be safe to > change this to: > > if (extra_stack || flags & MF_LEGACY) { > > because if this is a legacy call then it should be safe to write to > highmem even if the last call was a vesa

Re: [SeaBIOS] [PATCH] cbvga_set_mode: refine clear display logic

On Tue, Jun 26, 2018 at 09:27:03AM +0200, Paul Menzel wrote: > Dear Gerd, > > > Am 26.06.2018 um 09:21 schrieb Gerd Hoffmann: > > There is no need to skip text mode clearing. > > Clearing the framebuffer should be safe on legacy calls too. > > How did you test

[SeaBIOS] [PATCH] cbvga_set_mode: refine clear display logic

There is no need to skip text mode clearing. Clearing the framebuffer should be safe on legacy calls too. Signed-off-by: Gerd Hoffmann --- vgasrc/cbvga.c | 18 ++ 1 file changed, 10 insertions(+), 8 deletions(-) diff --git a/vgasrc/cbvga.c b/vgasrc/cbvga.c index f6ebe71242

Re: [SeaBIOS] [PATCH v2 3/3] qemu: add qemu ramfb support

Hi, > Thanks. Series looks good to me. qemu patches have been merged, so I pushed these now. cheers, Gerd ___ SeaBIOS mailing list SeaBIOS@seabios.org https://mail.coreboot.org/mailman/listinfo/seabios

Re: [SeaBIOS] [PATCH] cbvga_set_mode: refine clear display logic

On Tue, Jun 26, 2018 at 09:07:41PM -0400, Kevin O'Connor wrote: > On Tue, Jun 26, 2018 at 09:21:52AM +0200, Gerd Hoffmann wrote: > > There is no need to skip text mode clearing. > > Clearing the framebuffer should be safe on legacy calls too. > > Thanks. Looks good to

Re: [SeaBIOS] [PATCH 0/7] seabios: 1.11.2 update

Hi, > seabios 1.11.2 is not released yet. The plan is to cherry-pick the > changes needed to support the new qemu 3.0 display devices > (bochs-display and ramfb) into the 1.11-stable branch for the 1.11.2 > release. Current state is here: >

Re: [SeaBIOS] [PATCH] paravirt: Allow both Red Hat and Amazon PCI HB subsystem vendor and device ids

> >> @@ -83,8 +83,8 @@ static void qemu_detect(void) > >> -if (sv != 0x1af4 || /* Red Hat, Inc */ > >> -sd != 0x1100) /* Qemu virtual machine */ > >> +if (!(sv == 0x1af4 && sd == 0x1100) && /* Red Hat, Inc. QEMU VM */ > >> +!(sv == 0x1d0f && sd == 0x1237)) /*

Re: [SeaBIOS] Commit d6728f301d7e ("add serial console support") causes double-printing

Hi, > But instead I get the following mess: > > │ BBtt AArrcchh LLiinnuuxx ((xx8866__6644)) Seems both seabios and boot loader print to the serial line. > qemu-system-x86_64 -nodefaults -nographic -serial mon:stdio -cpu kvm64 > -enable-kvm -boot d -no-reboot -cdrom

Re: [SeaBIOS] [PATCH] Don't select SERCON when target is coreboot

On Sun, Dec 24, 2017 at 02:53:27PM +0100, Arthur Heymans wrote: > CONFIG_SERCON=y breaks coreboot S3 (boots into payload instead of OS > reset vector). Any clue why this is happening? I can't see a fundamental incompatibility, and I think sercon can be quite useful on coreboot too. So finding

Re: [SeaBIOS] coreboot: modifying seabios bootenter list dynamically

Hi, > My specific goal is about a dynamic OS bootstrapping or via USB storage > device or via pci netcard automatically without pressing any keyboard > buttons. seabios skips any non-working entries, a blank disk for example. So you can set the bootorder to "disk first, net second" and as

[SeaBIOS] [PATCH 4/7] vgabios: remove submodule and build rules.

. Zap it. Signed-off-by: Gerd Hoffmann --- .gitmodules | 3 --- roms/Makefile | 18 ++ roms/vgabios | 1 - 3 files changed, 2 insertions(+), 20 deletions(-) delete mode 16 roms/vgabios diff --git a/.gitmodules b/.gitmodules index 49e9c2e3f4..d108478e0a 100644

[SeaBIOS] [PATCH 1/7] seabios: update submodule to 1.11.2-testing

https://git.kraxel.org/cgit/seabios/log/?h=1.11-stable-testing For testing, will be replaced with final 1.11.2 of course ... Signed-off-by: Gerd Hoffmann --- roms/seabios | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/roms/seabios b/roms/seabios index 0551a4be2c

[SeaBIOS] [PATCH 2/7] seabios: add vga configs for bochs-display and ramfb

Both bochs-display and ramfb are devices with a simple framebuffer and no vga emulation or text mode. seavgabios has support for text mode emulation (at vgabios call level), we are using that to provide some vga compatibility support for these devices. Signed-off-by: Gerd Hoffmann --- roms

[SeaBIOS] [PATCH 0/7] seabios: 1.11.2 update

?h=seabios-1.11.2 cheers, Gerd Gerd Hoffmann (7): seabios: update submodule to 1.11.2-testing seabios: add vga configs for bochs-display and ramfb seabios: enable ide dma vgabios: remove submodule and build rules. seabios: update binaries bochs-display: enable vgabios ramfb: enab

[SeaBIOS] [PATCH 6/7] bochs-display: enable vgabios

Add vgabios binary to pci rom bar. Signed-off-by: Gerd Hoffmann --- hw/display/bochs-display.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/display/bochs-display.c b/hw/display/bochs-display.c index 1187d77576..12d8a66c6c 100644 --- a/hw/display/bochs-display.c +++ b/hw/display/bochs

[SeaBIOS] [PATCH 7/7] ramfb: enable vgabios

Add vgabios binary to fw_cfg vgaroms. Signed-off-by: Gerd Hoffmann --- hw/display/ramfb.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/display/ramfb.c b/hw/display/ramfb.c index 6867bce8ae..44c572c356 100644 --- a/hw/display/ramfb.c +++ b/hw/display/ramfb.c @@ -88,6 +88,7

[SeaBIOS] [PATCH 3/7] seabios: enable ide dma

-by: Gerd Hoffmann --- roms/config.seabios-128k | 1 + roms/config.seabios-256k | 1 + 2 files changed, 2 insertions(+) diff --git a/roms/config.seabios-128k b/roms/config.seabios-128k index 486ef0e132..35b5a07d8f 100644 --- a/roms/config.seabios-128k +++ b/roms/config.seabios-128k @@ -2,6 +2,7

Re: [SeaBIOS] [PATCH v2 6/6] cbvga_set_mode: disable clearmem in windows x86 emulator.

On Wed, Jun 20, 2018 at 08:00:28PM +0200, Patrick Rudolph wrote: > On Mon, 2018-06-04 at 09:31 -0400, Kevin O'Connor wrote: > > On Mon, Jun 04, 2018 at 09:29:17AM +0200, Gerd Hoffmann wrote: > > > Signed-off-by: Gerd Hoffmann > > > --- > > > vgasrc/cbvga.c |

Re: [SeaBIOS] [PATCH v2 3/3] pci: recognize RH PCI legacy bridge resource reservation capability

Hi, > I think PCI_DEVICE_ID_REDHAT_PCIE_BRIDGE shoud be added too, in case we put > a pcie_pci_bridge at the host bus. Yes, please. thanks, Gerd ___ SeaBIOS mailing list SeaBIOS@seabios.org https://mail.coreboot.org/mailman/listinfo/seabios

Re: [SeaBIOS] [PATCH v2 3/3] pci: recognize RH PCI legacy bridge resource reservation capability

Hi, > +if (pci_config_readw(bdf, PCI_VENDOR_ID) != PCI_VENDOR_ID_REDHAT) { > +dprintf(1, "PCI: QEMU resource reserve cap vendor ID doesn't > match.\n"); I'd suggest to use a higher debug level for this one, 3 would be a good pick I think. level 1 messages are printed by default,

Re: [SeaBIOS] RS232 mouse in Qemu

On Thu, Aug 16, 2018 at 02:52:45PM +0200, Peter Fodrek ml wrote: > Dear Seabios experts, > > I am asking here, because only aswer to my questions to Qemu experts or > Another opensource forums was that this feature is needed be supported by > QEMU or SeaBIOS. seabios doesn't care at all

Re: [SeaBIOS] [PATCH v2 3/3] pci: recognize RH PCI legacy bridge resource reservation capability

On Thu, Aug 16, 2018 at 05:30:45PM +0800, Liu, Jing2 wrote: > Hi Gerd, > > On 8/16/2018 3:19 PM, Gerd Hoffmann wrote: > >Hi, > > > > > I think PCI_DEVICE_ID_REDHAT_PCIE_BRIDGE shoud be added too, in case we > > > put > > > a pcie_pci_bridge

Re: [SeaBIOS] Marvell 88SE9230 passthrough in KVM takes long time to boot

On Sun, Jul 29, 2018 at 01:49:10PM +0200, Konrad Eisele wrote: > I'm passing through a Marvell 88SE9230 card to a KVM guest under > Ubuntu 18.04. The card is a Sata controller with 4 ports. > The option rom of the Marvell 88SE9230 card shows on a normal boot a > bios screen. When pressing CTRL-m

Re: [SeaBIOS] [PATCH v2 3/3] pci: recognize RH PCI legacy bridge resource reservation capability

On Fri, Aug 24, 2018 at 09:12:47AM +0200, Laszlo Ersek wrote: > On 08/24/18 04:23, Liu, Jing2 wrote: > > Hi Laszlo, > > > > On 8/22/2018 5:13 PM, Laszlo Ersek wrote: > >> On 08/16/18 12:43, Liu, Jing2 wrote: > >>> > >>> > >

Re: [SeaBIOS] [PATCH v2 3/3] pci: recognize RH PCI legacy bridge resource reservation capability

> > I imagine you'd post v3 with the update Gerd requested for the debug > > level(s), and then I'd respond with my R-b. (Obviously I'm not a SeaBIOS > > maintainer so that'll not be "decisive" by any means.) > > > Oh, BTW, I am considering, if only dismatch vendor-id stands for > "non-qemu

Re: [SeaBIOS] [RFC v2 0/3] Support multiple pci domains in pci_device

Hi, > > However, QEMU only binds port 0xcf8 and 0xcfc to > > bus pcie.0. To avoid bus confliction, we should use other port pairs for > > busses under new domains. > > I would skip support for IO based configuration and use only MMCONFIG > for extra root buses. > > The question remains: how

Re: [SeaBIOS] [RFC v2 0/3] Support multiple pci domains in pci_device

Hi, > Since we will not use all 256 buses of an extra PCI domain, > I think this space will allow us to support more PCI domains. Depends on the use case I guess. If you just need many pcie devices this probably doesn't help. If you want them for numa support then yes, more domains with less

Re: [SeaBIOS] Backport request for 8c3f57ea12

On Wed, Aug 29, 2018 at 11:51:00AM +0100, Wei Liu wrote: > Hello > > I notice 1.11.2 was only released a few weeks ago so it is probably too > early for another release, but can maintainers at least consider > backporting 8c3f57ea12 to 1.11-stable branch? Done. cheers, Gerd

Re: [SeaBIOS] [PATCH 1/2] nvme: add option to toggle probing only boot devices

> > -run_thread(nvme_controller_setup, pci); > > +if (should_setup_controller(pci)) { > > +run_thread(nvme_controller_setup, pci); > > +} > > } > > } > > Thank you for the patch. Would it be better to make that a > run-time option? I think so. You can

[SeaBIOS] preparing 1.11.1 stable release

Hi, Time to prepare a 1.11-stable release, so we can pick up bugfixes for the upcoming qemu release. Looking at the commits I think these should go in: a3c93bd81d build: Use git describe --always 42812e062a shadow: Don't invoke a shutdown on reboot unless in a reboot loop 14d91c353e pci: fix

Re: [SeaBIOS] preparing 1.11.1 stable release

On Mon, Mar 12, 2018 at 06:05:41PM -0400, Kevin O'Connor wrote: > On Wed, Mar 07, 2018 at 11:49:59AM +0100, Gerd Hoffmann wrote: > > Hi, > > > > Time to prepare a 1.11-stable release, so we can pick up bugfixes for the > > upcoming qemu release. Looking at the comm

Re: [SeaBIOS] [PATCH 2/2] malloc: Fallback to low-zone when alloc from high-zone fails

Hi, > > There is only a tiny amount of ram available in the permanent "low" > > area of ram (typically less that 64K). If the code has exhausted the > > permanent "high" ram (typically 256K) then it is likely to rapidly > > exhaust the low ram and cause a worse failure when code that requires

[SeaBIOS] release planning ...

Hi, I'm wondering whenever it makes sense to switch seabios to time-based releases, like many other projects do meanwhile. For major releases one release per year looks reasonable to me, given the low rate of changes we have. 1.11 was tagged in November 2017. So maybe target 1.12 for November

Re: [SeaBIOS] [PATCH v2] pretty boot menu entry for cdrom drives

On Fri, Sep 28, 2018 at 02:20:35PM -0400, Kevin O'Connor wrote: > On Fri, Sep 28, 2018 at 12:54:05PM +0200, Gerd Hoffmann wrote: > > Show the volume label of bootable cdroms. > > Thanks. Looks fine to me. Pushed. ___ SeaBIOS maili

Re: [SeaBIOS] release planning ...

On Mon, Oct 08, 2018 at 06:37:02PM -0400, Kevin O'Connor wrote: > On Fri, Oct 05, 2018 at 01:46:53PM +0200, Gerd Hoffmann wrote: > > Hi, > > > > I'm wondering whenever it makes sense to switch seabios to time-based > > releases, like many other projects do meanwhile.

Re: [SeaBIOS] [RFC v3] pciinit: setup mcfg for pxb-pcie to support multiple pci domains

Hi, > > I'm curious; what does tape backup have to do with the number of PCI > > slots/busses? > > I'm not very clear about how tape works in qemu, but the problem is pcie > devices under q35. The pcie topology requires one device per bus, therefore > the 256 bus might not be enough if we have

[SeaBIOS] [PATCH] pretty boot menu entry for cdrom drives

Signed-off-by: Gerd Hoffmann --- src/util.h | 1 + src/boot.c | 7 +++ src/cdrom.c | 51 +++ 3 files changed, 59 insertions(+) diff --git a/src/util.h b/src/util.h index 7a23b518fc..6dd080f673 100644 --- a/src/util.h +++ b/src/util.h

Re: [SeaBIOS] [PATCH] pretty boot menu entry for cdrom drives

> Thanks. In general, looks fine to me. > > Some minor comments: > > If there's a read error or non-bootable device, shouldn't it just > revert to the original description? What about "empty" for drives not ready? Drop that too? I think we should be consistent here: Either be verbose and

Re: [SeaBIOS] [RFC v3] pciinit: setup mcfg for pxb-pcie to support multiple pci domains

Hi, > Second, the v5 RFC doesn't actually address the alleged bus number > shortage. IIUC, it supports a low number of ECAM ranges under 4GB, but > those are (individually) limited in the bus number ranges they can > accommodate (due to 32-bit address space shortage). So more or less the >

Re: [SeaBIOS] [RFC v3] pciinit: setup mcfg for pxb-pcie to support multiple pci domains

On Wed, Sep 26, 2018 at 10:47:42AM +0200, Laszlo Ersek wrote: > On 09/26/18 06:44, Gerd Hoffmann wrote: > > Hi, > > > >> Second, the v5 RFC doesn't actually address the alleged bus number > >> shortage. IIUC, it supports a low number of ECAM ranges under 4GB,

[SeaBIOS] [PATCH v2] pretty boot menu entry for cdrom drives

Show the volume label of bootable cdroms. Signed-off-by: Gerd Hoffmann --- src/util.h | 1 + src/boot.c | 10 ++ src/cdrom.c | 46 ++ 3 files changed, 57 insertions(+) diff --git a/src/util.h b/src/util.h index 7a23b518fc..6dd080f673

Re: [SeaBIOS] [PATCH v2] optionrom: disallow int19 redirect for pnp roms.

On Mon, Dec 10, 2018 at 09:53:01PM -0500, Kevin O'Connor wrote: > On Thu, Dec 06, 2018 at 04:07:40PM +0100, Gerd Hoffmann wrote: > > Check whenever pnp roms attempt to redirect int19, and in case it does > > log a message and undo the redirect. > > > > A pnp rom should

<    4   5   6   7   8   9   10   11   12   13   >