Re: [SeaBIOS] seabios: acpi: add _RMV control method for PCI devices

2010-12-08 Thread Gleb Natapov
On Wed, Dec 08, 2010 at 03:08:59PM -0200, Marcelo Tosatti wrote: Use _RMV method to indicate whether device can be removed. But Windows still shows device as removable in the gui and allows to remove it, correct? Data is retrieved from QEMU via I/O port 0xae0c. Signed-off-by: Marcelo

[SeaBIOS] [PATCH] provide full edd info for virtio disk

2010-12-09 Thread Gleb Natapov
Signed-off-by: Gleb Natapov g...@redhat.com diff --git a/src/disk.c b/src/disk.c index 242c742..56c369a 100644 --- a/src/disk.c +++ b/src/disk.c @@ -544,64 +544,78 @@ disk_1348(struct bregs *regs, struct drive_s *drive_g) } SET_INT13DPT(regs, blksize, blksize); -if (size 30

Re: [SeaBIOS] [PATCH RFC] use bootorder file supplied by qemu to order bootable devices

2010-12-13 Thread Gleb Natapov
On Thu, Dec 09, 2010 at 08:27:10PM -0500, Kevin O'Connor wrote: On Wed, Dec 08, 2010 at 02:00:50PM +0200, Gleb Natapov wrote: With patch below (goes on top of bev per CD patch) I can specify boot order from qemu command line between several NICs, CDROMs, floppy and disk. With qemu command

Re: [SeaBIOS] [PATCH RFC] use bootorder file supplied by qemu to order bootable devices

2010-12-13 Thread Gleb Natapov
On Mon, Dec 13, 2010 at 08:55:53AM -0500, Kevin O'Connor wrote: On Mon, Dec 13, 2010 at 08:44:08AM -0500, Kevin O'Connor wrote: On Mon, Dec 13, 2010 at 03:12:51PM +0200, Gleb Natapov wrote: On Thu, Dec 09, 2010 at 08:27:10PM -0500, Kevin O'Connor wrote: On Wed, Dec 08, 2010 at 02:00:50PM

[SeaBIOS] [PATCH 6/9] Add functions for boot device path parsing.

2010-12-23 Thread Gleb Natapov
Add functions that find boot device path for pci/ata/floppy/rom devices. Signed-off-by: Gleb Natapov g...@redhat.com --- src/boot.c | 156 src/boot.h |5 ++ 2 files changed, 161 insertions(+), 0 deletions(-) diff --git a/src

Re: [SeaBIOS] [PATCH 3/9] Add strchr() function.

2010-12-24 Thread Gleb Natapov
On Fri, Dec 24, 2010 at 10:41:45AM -0500, Kevin O'Connor wrote: On Thu, Dec 23, 2010 at 11:29:37AM +0200, Gleb Natapov wrote: Signed-off-by: Gleb Natapov g...@redhat.com --- src/util.c | 11 +++ src/util.h |1 + 2 files changed, 12 insertions(+), 0 deletions(-) How

Re: [SeaBIOS] [PATCH 8/9] Record boot priority for each BAID/BCV/BEV.

2010-12-24 Thread Gleb Natapov
On Fri, Dec 24, 2010 at 02:59:52PM -0500, Kevin O'Connor wrote: On Thu, Dec 23, 2010 at 11:29:42AM +0200, Gleb Natapov wrote: For each BAID/BCV/BEV lookup its boot priority in boot order file. If there is no entry for a device there assign it the lowest boot priority. Signed-off-by: Gleb

Re: [SeaBIOS] [PATCH 0/9] Misc boot related cleanups

2010-12-29 Thread Gleb Natapov
On Wed, Dec 29, 2010 at 02:10:16PM -0500, Kevin O'Connor wrote: On Wed, Dec 29, 2010 at 09:00:36PM +0200, Gleb Natapov wrote: On Wed, Dec 29, 2010 at 12:46:45PM -0500, Kevin O'Connor wrote: Some cleanups I came across while reviewing the boot code. Gleb - patch 7 conflicts with your

Re: [SeaBIOS] [PATCH 0/9] Misc boot related cleanups

2010-12-30 Thread Gleb Natapov
On Thu, Dec 30, 2010 at 01:56:28PM -0500, Kevin O'Connor wrote: On Thu, Dec 30, 2010 at 07:55:27PM +0200, Gleb Natapov wrote: On Thu, Dec 30, 2010 at 12:20:17PM -0500, Kevin O'Connor wrote: On Thu, Dec 30, 2010 at 08:01:15AM +0200, Gleb Natapov wrote: For me it looks more complicated

[SeaBIOS] [PATCH] support T13 EDD3.0 spec

2011-01-05 Thread Gleb Natapov
according to T13 spec otherwise use Phoenix one. Signed-off-by: Gleb Natapov g...@redhat.com diff --git a/src/disk.c b/src/disk.c index f7bfe9c..fb7833a 100644 --- a/src/disk.c +++ b/src/disk.c @@ -503,6 +503,7 @@ static void disk_1348(struct bregs *regs, struct drive_s *drive_g) { u16 size

Re: [SeaBIOS] [PATCH] support T13 EDD3.0 spec

2011-01-05 Thread Gleb Natapov
On Wed, Jan 05, 2011 at 09:32:33PM -0500, Kevin O'Connor wrote: On Wed, Jan 05, 2011 at 05:18:38PM +0200, Gleb Natapov wrote: Some guests (such as Linux) expect BIOS to behave according to T13 EDD3.0 spec. T13 spec is much better then Phoenix since it provides more information about

[SeaBIOS] [PATCHv2] support T13 EDD3.0 spec

2011-01-06 Thread Gleb Natapov
according to T13 spec otherwise use Phoenix one. Signed-off-by: Gleb Natapov g...@redhat.com diff --git a/src/disk.c b/src/disk.c index f7bfe9c..5ac69fd 100644 --- a/src/disk.c +++ b/src/disk.c @@ -503,6 +503,7 @@ static void disk_1348(struct bregs *regs, struct drive_s *drive_g) { u16 size

Re: [SeaBIOS] [PATCH] lest pretend that RTC can be used to wakeup from S4

2011-01-30 Thread Gleb Natapov
On Sun, Jan 30, 2011 at 03:01:43PM +0100, Peter Stuge wrote: Typo in subject. Gleb Natapov wrote: WHQL complains otherwise. Is there something further that should be activated, to actually allow the wakeup to work? Hm, isn't S4 hibernate? Not in a bios. Qemu currently exits on S4

Re: [SeaBIOS] [PATCH] lest pretend that RTC can be used to wakeup from S4

2011-01-30 Thread Gleb Natapov
On Sun, Jan 30, 2011 at 05:25:05PM +0200, Avi Kivity wrote: On 01/30/2011 05:23 PM, Gleb Natapov wrote: On Sun, Jan 30, 2011 at 05:15:49PM +0200, Avi Kivity wrote: On 01/30/2011 05:13 PM, Gleb Natapov wrote: On Sun, Jan 30, 2011 at 05:08:18PM +0200, Avi Kivity wrote: On 01/30/2011 04

Re: [SeaBIOS] [PATCH] lest pretend that RTC can be used to wakeup from S4

2011-02-02 Thread Gleb Natapov
On Wed, Feb 02, 2011 at 09:31:37AM +0100, Paolo Bonzini wrote: On 01/30/2011 04:33 PM, Gleb Natapov wrote: In theory a guest could check whether RTC alarm reboot is supported, if not it keeps awake, if it is it can set the alarm to sleep. So if seabios lies it could break that guest

Re: [SeaBIOS] [PATCH] cpu hotplug issue

2011-08-04 Thread Gleb Natapov
On Wed, Aug 03, 2011 at 06:25:07PM +0200, Vasilis Liaskovitis wrote: On Wed, Aug 03, 2011 at 12:42:11PM +0200, Jan Kiszka wrote: Why can't Seabios read to true number online CPUs from the PIIX4 device? The information is there already, no need for addition PV here. Where is it in

Re: [SeaBIOS] [SeaBIOS PATCH 2/2] hotplug: Add device per func in ACPI DSDT tables

2011-09-19 Thread Gleb Natapov
On Mon, Sep 19, 2011 at 03:27:38AM -0400, Amos Kong wrote: Only func 0 is registered to guest driver (we can only found func 0 in slot-funcs list of driver), the other functions could not be cleaned when hot-removing the whole slot. This patch adds device per function in ACPI DSDT tables.

Re: [SeaBIOS] [SeaBIOS PATCH 2/2] hotplug: Add device per func in ACPI DSDT tables

2011-09-19 Thread Gleb Natapov
On Mon, Sep 19, 2011 at 01:02:59PM +0300, Michael S. Tsirkin wrote: On Mon, Sep 19, 2011 at 12:57:33PM +0300, Gleb Natapov wrote: On Mon, Sep 19, 2011 at 03:27:38AM -0400, Amos Kong wrote: Only func 0 is registered to guest driver (we can only found func 0 in slot-funcs list of driver

Re: [SeaBIOS] Boot ordering problem with qemu-kvm / seabios / gPXE

2011-09-29 Thread Gleb Natapov
of virtio nics). Thanks in advance 2011/9/29 Gleb Natapov g...@redhat.com On Thu, Sep 29, 2011 at 11:30:08AM +0200, Romain Vrignaud wrote: We see the right bootindex option as I want to boot on gPXE from my second NIC (mac=52:54:00:28:ca:e6). The problem is that during my VM

Re: [SeaBIOS] [PATCH] acpi: add Local APIC NMI Structure to MADT.

2011-10-02 Thread Gleb Natapov
On Mon, Sep 26, 2011 at 07:58:56PM +0900, Kenji Kaneshige wrote: (2011/09/23 13:31), Kevin O'Connor wrote: On Thu, Sep 22, 2011 at 09:58:58PM +0900, Kenji Kaneshige wrote: Add Local APIC NMI Structure to ACPI MADT. Thanks. Can you give a brief description of what this is needed by? Also,

Re: [SeaBIOS] [Qemu-devel] insmod virtio-blk is broken in qemu 1.0

2011-12-20 Thread Gleb Natapov
On Mon, Dec 19, 2011 at 10:38:02PM -0500, Kevin O'Connor wrote: On Mon, Dec 19, 2011 at 12:02:59PM -0600, Anthony Liguori wrote: We really need to update SeaBIOS whenever there is a bug that we know requires an update. Things breakdown because of one or more of the following reasons:

Re: [SeaBIOS] [RFC] acpi: Do not advertise S3

2012-01-15 Thread Gleb Natapov
On Fri, Jan 13, 2012 at 05:11:27PM -0200, Luiz Capitulino wrote: S3 is broken in qemu in the following ways: 1. S3 is immediately followed by a resume (or it doesn't even take place) The only real problem. I am not aware of it doesn't even take place part. If there are such cases they

Re: [SeaBIOS] [RFC] acpi: Do not advertise S3

2012-01-15 Thread Gleb Natapov
15, 2012 at 10:00 AM, Gleb Natapov g...@redhat.com wrote: On Fri, Jan 13, 2012 at 05:11:27PM -0200, Luiz Capitulino wrote: S3 is broken in qemu in the following ways:  1. S3 is immediately followed by a resume (or it doesn't even     take place) The only real problem. I am not aware

Re: [SeaBIOS] [RFC] acpi: Do not advertise S3

2012-01-15 Thread Gleb Natapov
On Sun, Jan 15, 2012 at 01:17:50PM +0100, Sebastian Herbszt wrote: Gleb Natapov wrote: On Sun, Jan 15, 2012 at 12:35:07PM +0100, Fred . wrote: SeaBIOS is used in more than just QEMU. The DSDT provided by Seabios is not used by anyone but QEMU (and may be XEN). How about renaming acpi

[SeaBIOS] S3 resume is broken on QEMU

2012-01-18 Thread Gleb Natapov
Hi Kevin, Commit 8b0c509e7cdb broke S3 resume on QEMU. Before this commit QEMU compiled bios with S3_RESUME_VGA_INIT enabled. After it this is no longer an option. -- Gleb. ___ SeaBIOS mailing list SeaBIOS@seabios.org

Re: [SeaBIOS] S3 resume is broken on QEMU

2012-01-18 Thread Gleb Natapov
On Wed, Jan 18, 2012 at 08:27:31AM -0500, Kevin O'Connor wrote: On Wed, Jan 18, 2012 at 11:40:28AM +0200, Gleb Natapov wrote: Hi Kevin, Commit 8b0c509e7cdb broke S3 resume on QEMU. Before this commit QEMU compiled bios with S3_RESUME_VGA_INIT enabled. After it this is no longer

Re: [SeaBIOS] S3 resume is broken on QEMU

2012-01-18 Thread Gleb Natapov
On Wed, Jan 18, 2012 at 09:37:18PM -0500, Kevin O'Connor wrote: On Wed, Jan 18, 2012 at 04:09:45PM +0200, Gleb Natapov wrote: On Wed, Jan 18, 2012 at 08:27:31AM -0500, Kevin O'Connor wrote: On Wed, Jan 18, 2012 at 11:40:28AM +0200, Gleb Natapov wrote: Hi Kevin, Commit

Re: [SeaBIOS] S3 resume is broken on QEMU

2012-01-19 Thread Gleb Natapov
On Thu, Jan 19, 2012 at 05:15:58PM +0100, Peter Stuge wrote: Gleb Natapov wrote: In real life, SeaBIOS does not need to run the VGA BIOS when I resume my ThinkPad with coreboot. So do not run it on a ThinkPad. If it's not needed on my machine, why would it be the right solution

Re: [SeaBIOS] S3 resume is broken on QEMU

2012-01-20 Thread Gleb Natapov
On Thu, Jan 19, 2012 at 08:22:00PM -0500, Kevin O'Connor wrote: On Thu, Jan 19, 2012 at 09:02:09AM +0200, Gleb Natapov wrote: And there I pointed out that many BIOSes has an option to run vga BIOS on resume and even link to a post with description of the same problem we have in QEMU + Linux

Re: [SeaBIOS] S3 resume is broken on QEMU

2012-01-20 Thread Gleb Natapov
On Thu, Jan 19, 2012 at 08:40:45PM -0500, Kevin O'Connor wrote: On Thu, Jan 19, 2012 at 12:16:25PM +0200, Gleb Natapov wrote: There is absolutely nothing that vgabios may attempt to do that is illegal on resume and may cause this kind of hang. The only thing that is illegal on resume

Re: [SeaBIOS] S3 resume is broken on QEMU

2012-01-20 Thread Gleb Natapov
On Fri, Jan 20, 2012 at 12:08:39PM +0100, Gerd Hoffmann wrote: Hi, I do think moving from compile time options to runtime options is important. If you need a quick fix to get your build working, the patch to seabios is below. I do think we should try to figure out how we can get

Re: [SeaBIOS] S3 resume is broken on QEMU

2012-01-20 Thread Gleb Natapov
On Fri, Jan 20, 2012 at 08:48:39AM -0500, Kevin O'Connor wrote: On Fri, Jan 20, 2012 at 01:50:15PM +0200, Gleb Natapov wrote: On Thu, Jan 19, 2012 at 08:40:45PM -0500, Kevin O'Connor wrote: Further, no spec I've seen says an option rom must handle being executed a second time. The option

Re: [SeaBIOS] S3 resume is broken on QEMU

2012-01-22 Thread Gleb Natapov
On Fri, Jan 20, 2012 at 04:23:15PM +0100, Gerd Hoffmann wrote: Hi, I'm 99% sure that wont work. Option roms have to be copied from PCI You 99% sure it wont work on real HW or on QEMU? IIRC QEMU puts vgabios into 0xc directly. That is long history, it went away

[SeaBIOS] [PATCH] mask interrupts on S3 resume

2012-01-24 Thread Gleb Natapov
i8259 clears interrupt mask on reset. Interrupt need to be masked again before enabling interrupts on CPU. Since option roms are called with interrupts enabled, resume should mask interrupts in i8259 before calling vgabios. Signed-off-by: Gleb Natapov g...@redhat.com diff --git a/src/resume.c b

Re: [SeaBIOS] ImageMagick-based SeaBIOS logo generation script

2012-02-07 Thread Gleb Natapov
On Tue, Feb 07, 2012 at 07:59:04PM +0100, Fred . wrote: Please put this file in the repository. I don't know, but somewhere. So it outputs a bootsplash.jpg file to wherever SeaBIOS is looking for that file. #!/bin/sh convert -background black \ -font

Re: [SeaBIOS] ImageMagick-based SeaBIOS logo generation script

2012-02-08 Thread Gleb Natapov
it generate the jpg, and then put the jpg file in the source tree. ImageMagick is shipped by default on Ubuntu. On Wed, Feb 8, 2012 at 8:19 AM, Gleb Natapov g...@redhat.com wrote: On Tue, Feb 07, 2012 at 07:59:04PM +0100, Fred . wrote: Please put this file in the repository. I don't know

Re: [SeaBIOS] Time for a new release?

2012-02-14 Thread Gleb Natapov
On Tue, Feb 14, 2012 at 08:35:12AM -0500, Kevin O'Connor wrote: On Thu, Feb 09, 2012 at 01:22:23PM +0100, Fred . wrote: Lots of stuff have been happening lately (namely VGA and VBE related stuff). Also some fixes. Perhaps it is time for a new release soon? It's a good question. I

Re: [SeaBIOS] [PATCH] seabios: acpi: Add _STA for PCI hotplug slots

2012-03-05 Thread Gleb Natapov
On Mon, Mar 05, 2012 at 08:26:23AM +0200, Michael S. Tsirkin wrote: On Sun, Mar 04, 2012 at 08:30:00PM -0700, Alex Williamson wrote: On Sun, 2012-03-04 at 20:53 +0200, Michael S. Tsirkin wrote: On Fri, Feb 24, 2012 at 04:21:17PM -0700, Alex Williamson wrote: When a Status method is

Re: [SeaBIOS] [PATCH 1/3] Halt if number of started cpus are more then expected

2012-03-11 Thread Gleb Natapov
On Sat, Mar 10, 2012 at 12:47:26PM +0100, Igor Mammedov wrote: Reduce amount of consumed cpu time (i.e. don't spin forever) if number of started cpus are more then expected. And print a bug message into debug port. Signed-off-by: Igor Mammedov imamm...@redhat.com --- src/smp.c |8

Re: [SeaBIOS] [PATCH 3/3] Take in account hot(un)plugged cpus on reboot

2012-03-11 Thread Gleb Natapov
On Sat, Mar 10, 2012 at 12:47:28PM +0100, Igor Mammedov wrote: Initial count of active cpus is communicated to bios from qemu via CMOS_BIOS_SMP_COUNT io port. However if cpus are hotplugged after boot and then guest is rebooted without taking down qemu then bios might be stuck at smp_probe

Re: [SeaBIOS] [coreboot] Linux-ready Firmware Kit

2012-03-11 Thread Gleb Natapov
On Sun, Mar 11, 2012 at 04:28:38PM +0100, Fred . wrote: Linux-ready Firmware Development Kit r3 segfaults under QEMU 0.14.1 (Ubuntu 11.10 Oneiric) during the SUN duplicate test at 30% with the message: Segmentation fault (core dumped) plugins//acpicompile.exe 2. What about more recent

Re: [SeaBIOS] [PATCH 1/3] Halt if number of started cpus are more then expected

2012-03-12 Thread Gleb Natapov
On Mon, Mar 12, 2012 at 10:52:18AM +0100, Igor Mammedov wrote: On 03/11/2012 11:36 AM, Gleb Natapov wrote: On Sat, Mar 10, 2012 at 12:47:26PM +0100, Igor Mammedov wrote: Reduce amount of consumed cpu time (i.e. don't spin forever) if number of started cpus are more then expected. And print

Re: [SeaBIOS] [PATCH 1/3] Halt if number of started cpus are more then expected

2012-03-12 Thread Gleb Natapov
On Mon, Mar 12, 2012 at 02:09:02PM +0100, Igor Mammedov wrote: On 03/12/2012 11:14 AM, Gleb Natapov wrote: On Mon, Mar 12, 2012 at 10:52:18AM +0100, Igor Mammedov wrote: On 03/11/2012 11:36 AM, Gleb Natapov wrote: On Sat, Mar 10, 2012 at 12:47:26PM +0100, Igor Mammedov wrote: Reduce amount

Re: [SeaBIOS] [PATCH 1/3] Halt if number of started cpus are more then expected

2012-03-12 Thread Gleb Natapov
On Mon, Mar 12, 2012 at 05:04:48PM +0100, Igor Mammedov wrote: On 03/12/2012 02:27 PM, Gleb Natapov wrote: On Mon, Mar 12, 2012 at 02:09:02PM +0100, Igor Mammedov wrote: On 03/12/2012 11:14 AM, Gleb Natapov wrote: On Mon, Mar 12, 2012 at 10:52:18AM +0100, Igor Mammedov wrote: On 03/11/2012 11

Re: [SeaBIOS] [PATCH 3/3] Take in account hot(un)plugged cpus on reboot

2012-03-13 Thread Gleb Natapov
On Tue, Mar 13, 2012 at 10:37:54AM +0100, Igor Mammedov wrote: On 03/13/2012 01:09 AM, Kevin O'Connor wrote: On Sat, Mar 10, 2012 at 12:47:28PM +0100, Igor Mammedov wrote: Initial count of active cpus is communicated to bios from qemu via CMOS_BIOS_SMP_COUNT io port. However if cpus are

Re: [SeaBIOS] [PATCH 3/3] Take in account hot(un)plugged cpus on reboot

2012-03-13 Thread Gleb Natapov
On Tue, Mar 13, 2012 at 11:16:51AM +0100, Igor Mammedov wrote: On 03/13/2012 10:51 AM, Gleb Natapov wrote: On Tue, Mar 13, 2012 at 10:37:54AM +0100, Igor Mammedov wrote: On 03/13/2012 01:09 AM, Kevin O'Connor wrote: On Sat, Mar 10, 2012 at 12:47:28PM +0100, Igor Mammedov wrote: Initial count

Re: [SeaBIOS] [PATCH] memory hotplug

2012-03-15 Thread Gleb Natapov
Commenting a little bit late, but since you've said that you are working on a new version of the patch... better late than never. On Thu, Aug 11, 2011 at 04:39:38PM +0200, Vasilis Liaskovitis wrote: Hi, I am testing a set of experimental patches for memory-hotplug on x86_64 host / guest

Re: [SeaBIOS] [PATCH 3/3] Take in account hot(un)plugged cpus on reboot

2012-03-15 Thread Gleb Natapov
On Thu, Mar 15, 2012 at 10:08:17AM -0400, Igor Mammedov wrote: Good point. You mean we need a list of apic ids of available cpus right? Can SeaBIOS build this list by reading apic id in smp_ap_boot_code? I've looked at how tables are build. It seems that it's not hard and sufficient to

Re: [SeaBIOS] [PATCH 3/3] Take in account hot(un)plugged cpus on reboot

2012-03-15 Thread Gleb Natapov
On Thu, Mar 15, 2012 at 10:33:01AM -0400, Igor Mammedov wrote: - Original Message - From: Gleb Natapov g...@redhat.com To: Igor Mammedov imamm...@redhat.com Cc: Kevin O'Connor ke...@koconnor.net, jan kiszka jan.kis...@siemens.com, seabios@seabios.org Sent: Thursday, March

Re: [SeaBIOS] [PATCH] if HPET is not present do not report it in DSDT

2012-03-16 Thread Gleb Natapov
Ping? On Sun, Mar 11, 2012 at 10:08:38AM +0200, Gleb Natapov wrote: Replicate the check that detects if HPET table should be created in AML too. Signed-off-by: Gleb Natapov g...@redhat.com diff --git a/src/acpi-dsdt.dsl b/src/acpi-dsdt.dsl index 7082b65..4e04c48 100644 --- a/src/acpi

[SeaBIOS] [PATCH] Drop FIX_RTC flag from FADT.

2012-03-20 Thread Gleb Natapov
FIX_RTC flag should be set if RTC wake status is _not_ reported in fixed register space, but this is not the case for QEMU. So drop it from FADT. Signed-off-by: Gleb Natapov g...@redhat.com diff --git a/src/acpi.c b/src/acpi.c index 6174e04..30888b9 100644 --- a/src/acpi.c +++ b/src/acpi.c

Re: [SeaBIOS] Version bump?

2012-04-09 Thread Gleb Natapov
On Sun, Apr 08, 2012 at 12:02:16PM -0400, Kevin O'Connor wrote: On Sun, Apr 08, 2012 at 06:10:06PM +0300, Gleb Natapov wrote: On Sun, Apr 08, 2012 at 10:36:07AM -0400, Kevin O'Connor wrote: On Sat, Apr 07, 2012 at 10:09:28PM +0200, Fred . wrote: http://www.seabios.org/Releases

[SeaBIOS] Why drive_s is allocated from f-segment?

2012-04-11 Thread Gleb Natapov
Hi Kevin, Is there a reason why drive_s structures are allocated from f-segment? The space for f-segment allocations are barely sufficient for bios tables. -- Gleb. ___ SeaBIOS mailing list SeaBIOS@seabios.org

Re: [SeaBIOS] Why drive_s is allocated from f-segment?

2012-04-11 Thread Gleb Natapov
On Wed, Apr 11, 2012 at 08:34:13PM -0400, Kevin O'Connor wrote: On Wed, Apr 11, 2012 at 04:27:57PM +0300, Gleb Natapov wrote: Hi Kevin, Is there a reason why drive_s structures are allocated from f-segment? The data is accessed from 16bit mode, so it must be in the first meg. Only

Re: [SeaBIOS] Why drive_s is allocated from f-segment?

2012-04-12 Thread Gleb Natapov
On Thu, Apr 12, 2012 at 08:42:25AM -0400, Kevin O'Connor wrote: On Thu, Apr 12, 2012 at 08:11:13AM +0300, Gleb Natapov wrote: On Wed, Apr 11, 2012 at 08:34:13PM -0400, Kevin O'Connor wrote: On Wed, Apr 11, 2012 at 04:27:57PM +0300, Gleb Natapov wrote: Hi Kevin, Is there a reason

Re: [SeaBIOS] BEV and bootorder

2012-04-15 Thread Gleb Natapov
On Sat, Apr 14, 2012 at 11:19:31PM -0400, Kevin O'Connor wrote: On Thu, Apr 12, 2012 at 01:30:36PM -0600, Steve Goodrich wrote: I'm working towards a goal of having specific devices be bootable, and *only* those devices. For example, if my bootorder file specifies SATA drive 3, I do not

Re: [SeaBIOS] BEV and bootorder

2012-04-15 Thread Gleb Natapov
On Sun, Apr 15, 2012 at 02:24:05PM +0200, Fred . wrote: Why would anyone want to define some devices as unbootable? Because he does not want to boot from them. On Sun, Apr 15, 2012 at 8:57 AM, Gleb Natapov g...@redhat.com wrote: On Sat, Apr 14, 2012 at 11:19:31PM -0400, Kevin O'Connor wrote

Re: [SeaBIOS] BEV and bootorder

2012-04-15 Thread Gleb Natapov
On Sun, Apr 15, 2012 at 02:39:45PM +0200, Fred . wrote: 2012/4/15 Gleb Natapov g...@redhat.com: On Sun, Apr 15, 2012 at 02:24:05PM +0200, Fred . wrote: Why would anyone want to define some devices as unbootable? Because he does not want to boot from them. Then the partition should

Re: [SeaBIOS] [RFC PATCH 0/9] ACPI memory hotplug

2012-04-22 Thread Gleb Natapov
On Thu, Apr 19, 2012 at 04:08:38PM +0200, Vasilis Liaskovitis wrote: This is a prototype for ACPI memory hotplug on x86_64 target. Based on some earlier work and comments from Gleb. Memslot devices are modeled with a new qemu command line -memslot id=name,start=start_addr,size=sz,node=pxm

Re: [SeaBIOS] [RFC PATCH 8/9] pc: adjust e820 map on hot-add and hot-remove

2012-04-22 Thread Gleb Natapov
On Thu, Apr 19, 2012 at 04:08:46PM +0200, Vasilis Liaskovitis wrote: Hotplugged memory is not persistent in the e820 memory maps. After hotplugging a memslot and rebooting the VM, the hotplugged device is not present. A possible solution is to add an e820 for the new memslot in the

Re: [SeaBIOS] [RFC PATCH 8/9] pc: adjust e820 map on hot-add and hot-remove

2012-04-23 Thread Gleb Natapov
On Mon, Apr 23, 2012 at 01:27:40PM +0200, Vasilis Liaskovitis wrote: On Sun, Apr 22, 2012 at 04:58:47PM +0300, Gleb Natapov wrote: On Thu, Apr 19, 2012 at 04:08:46PM +0200, Vasilis Liaskovitis wrote: Hotplugged memory is not persistent in the e820 memory maps. After hotplugging

Re: [SeaBIOS] [RFC PATCH 0/9] ACPI memory hotplug

2012-04-24 Thread Gleb Natapov
On Mon, Apr 23, 2012 at 04:31:04PM +0300, Avi Kivity wrote: On 04/22/2012 05:20 PM, Gleb Natapov wrote: On Sun, Apr 22, 2012 at 05:13:27PM +0300, Avi Kivity wrote: On 04/22/2012 05:09 PM, Gleb Natapov wrote: On Sun, Apr 22, 2012 at 05:06:43PM +0300, Avi Kivity wrote: On 04/22/2012

Re: [SeaBIOS] [RFC PATCH 0/9] ACPI memory hotplug

2012-04-24 Thread Gleb Natapov
On Tue, Apr 24, 2012 at 10:24:51AM +0200, Vasilis Liaskovitis wrote: Hi, On Tue, Apr 24, 2012 at 10:52:24AM +0300, Gleb Natapov wrote: On Mon, Apr 23, 2012 at 02:31:15PM +0200, Vasilis Liaskovitis wrote: The 440fx spec mentions: The address range from the top of main DRAM to 4 Gbytes

Re: [SeaBIOS] synching GPE0_BLK between OVMF and qemu

2012-04-27 Thread Gleb Natapov
On Fri, Apr 27, 2012 at 07:24:48PM +0200, Laszlo Ersek wrote: On 04/27/12 17:12, Jordan Justen wrote: On Fri, Apr 27, 2012 at 07:31, Laszlo Ersek ler...@redhat.com wrote: edk2's OvmfPkg/AcpiTables/Platform.h specifies GPE0_BLK at 0x40C, while qemu's hw/acpi_piix4.c expects the guest to

Re: [SeaBIOS] synching GPE0_BLK between OVMF and qemu

2012-04-27 Thread Gleb Natapov
On Fri, Apr 27, 2012 at 08:47:00PM +0200, Laszlo Ersek wrote: On 04/27/12 20:09, Gleb Natapov wrote: On Fri, Apr 27, 2012 at 07:24:48PM +0200, Laszlo Ersek wrote: From 5.2.9 Fixed ACPI Description Table (FADT) in the ACPI spec (v5.0) it would appear OVMF can freely choose where to put

Re: [SeaBIOS] SeaBIOS vs other BIOS?

2012-05-07 Thread Gleb Natapov
On Sun, May 06, 2012 at 10:26:31PM +0200, Fred . wrote: And in terms of standards compliance? I know proprietary BIOS have advantage when it comes to SMBIOS due to the implementation in SeaBIOS lagging behind several versions. On Sun, May 6, 2012 at 8:00 PM, Peter Stuge pe...@stuge.se

Re: [SeaBIOS] SeaBIOS vs other BIOS?

2012-05-07 Thread Gleb Natapov
On Mon, May 07, 2012 at 10:44:21AM +0200, Fred . wrote: On Mon, May 7, 2012 at 9:40 AM, Gleb Natapov g...@redhat.com wrote: On Sun, May 06, 2012 at 10:26:31PM +0200, Fred . wrote: And in terms of standards compliance? I know proprietary BIOS have advantage when it comes to SMBIOS due

Re: [SeaBIOS] [RESEND PATCH v3] hotplug: add device per func in ACPI DSDT tables

2012-05-11 Thread Gleb Natapov
On Fri, May 11, 2012 at 01:46:17AM +0800, Jiang Liu wrote: On 05/11/2012 01:42 AM, Michael S. Tsirkin wrote: On Fri, May 11, 2012 at 01:17:38AM +0800, Jiang Liu wrote: On 05/09/2012 03:24 PM, Amos Kong wrote: --- src/ssdt-pcihp.dsl | 17 src/ssdt-pcihp.hex | 8869

Re: [SeaBIOS] [RESEND PATCH v3] hotplug: add device per func in ACPI DSDT tables

2012-05-11 Thread Gleb Natapov
On Fri, May 11, 2012 at 11:44:02PM +0800, Jiang Liu wrote: On 05/11/2012 06:14 PM, Gleb Natapov wrote: I'm not familiar with qemu:( On native OS, admin could trigger PCI device hotplug operations through /sys/bus/pci/slot/xx/power. Not sure whether that's needed for guest OS too

Re: [SeaBIOS] [coreboot] seabios feature request : reboot VM or retry boot devices when no valid boot disk is found

2012-05-12 Thread Gleb Natapov
On Sat, May 12, 2012 at 03:04:52AM +0200, Peter Stuge wrote: Kevin O'Connor wrote: +// Unable to find bootable device - warn user and eventually retry. +static void +boot_fail(void) +{ +printf(No bootable device.\n); +// Wait for 60 seconds and then reboot. +u32 end =

Re: [SeaBIOS] [coreboot] seabios feature request : reboot VM or retry boot devices when no valid boot disk is found

2012-05-13 Thread Gleb Natapov
On Sat, May 12, 2012 at 10:01:49AM -0400, Kevin O'Connor wrote: On Sat, May 12, 2012 at 03:04:52AM +0200, Peter Stuge wrote: Kevin O'Connor wrote: +// Unable to find bootable device - warn user and eventually retry. +static void +boot_fail(void) +{ +printf(No bootable

Re: [SeaBIOS] [Qemu-devel] [PATCH 2/2] Get system state configuration from QEMU and patcth DSDT with it.

2012-05-15 Thread Gleb Natapov
On Mon, May 14, 2012 at 09:43:19PM -0400, Kevin O'Connor wrote: On Mon, May 14, 2012 at 03:35:23PM +0300, Gleb Natapov wrote: QEMU may want to disable guest's S3/S4 support and it wants to distinguish between regular powerdown and S4 powerdown. To support that new fw_cfg option was added

Re: [SeaBIOS] [PATCH 2/2] Get system state configuration from QEMU and patcth DSDT with it.

2012-05-16 Thread Gleb Natapov
On Wed, May 16, 2012 at 05:50:31PM +0200, Paolo Bonzini wrote: Il 16/05/2012 15:46, Gleb Natapov ha scritto: I saw that, but I don't get why doing it this way instead of defining the object in AML and patching it? I can define Name(S4VL, 0x2) and path 0x2 to whatever QEMU wants me to use

[SeaBIOS] [PATCH 3/3] Get system state configuration from QEMU and patch DSDT with it.

2012-05-20 Thread Gleb Natapov
represents one system state. If byte at offset X has its MSB set it means that system state X is supported and to enter it guest should use the value from lowest 7 bits. Patch also detects old QEMU and uses values that work in backwards compatible way there. Signed-off-by: Gleb Natapov g

[SeaBIOS] [PATCH 1/3] Fix aml_name_string() to recognize block name modifiers.

2012-05-20 Thread Gleb Natapov
Signed-off-by: Gleb Natapov g...@redhat.com --- tools/acpi_extract.py |6 +- 1 files changed, 5 insertions(+), 1 deletions(-) diff --git a/tools/acpi_extract.py b/tools/acpi_extract.py index 5f613e4..8038269 100755 --- a/tools/acpi_extract.py +++ b/tools/acpi_extract.py @@ -121,7

Re: [SeaBIOS] [Qemu-devel] [PATCH 3/3] Get system state configuration from QEMU and patch DSDT with it.

2012-05-20 Thread Gleb Natapov
On Sun, May 20, 2012 at 03:47:02PM +0300, Avi Kivity wrote: On 05/20/2012 03:36 PM, Gleb Natapov wrote: On Sun, May 20, 2012 at 03:30:50PM +0300, Avi Kivity wrote: On 05/20/2012 03:15 PM, Gleb Natapov wrote: On Sun, May 20, 2012 at 02:44:51PM +0300, Avi Kivity wrote: On 05/20/2012

Re: [SeaBIOS] [Qemu-devel] [PATCH 3/3] Get system state configuration from QEMU and patch DSDT with it.

2012-05-20 Thread Gleb Natapov
On Sun, May 20, 2012 at 05:46:46PM +0300, Avi Kivity wrote: On 05/20/2012 05:43 PM, Gleb Natapov wrote: Or it can be a fixed address in low memory, or a scratch register in hardware. Both will work (fixed addresses are better be avoided and who needs another PV device), but I do

Re: [SeaBIOS] [Qemu-devel] [PATCH 3/3] Get system state configuration from QEMU and patch DSDT with it.

2012-05-20 Thread Gleb Natapov
On Sun, May 20, 2012 at 12:39:13PM -0400, Kevin O'Connor wrote: On Sun, May 20, 2012 at 07:25:40PM +0300, Avi Kivity wrote: On 05/20/2012 07:16 PM, Kevin O'Connor wrote: Here we in agreement, and I was against patching till it was unavoidable, but than pci hotplug started using it,

Re: [SeaBIOS] GPT disks in a BIOS world

2012-06-05 Thread Gleb Natapov
On Tue, Jun 05, 2012 at 10:58:43AM +0200, Fred . wrote: On Tue, Jun 5, 2012 at 5:21 AM, Kevin O'Connor ke...@koconnor.net wrote: On Mon, Jun 04, 2012 at 07:11:30PM -0700, Ralf A. Quint wrote: At 03:36 PM 6/4/2012, Kevin O'Connor wrote: On Mon, Jun 04, 2012 at 03:33:05PM +0200, Fred . wrote:

[SeaBIOS] Problem accessing a small virtio disk

2012-06-13 Thread Gleb Natapov
I noticed that SeaBIOS fails to boot from virtio disk smaller than 512K. The attempt to access a disk fails at basic_access(). (cylinder = nlc || head = nlh || sector nlspt) is true because nlc is zero. The problem seams to be in how SeaBIOS calculates lchs from pchs in get_translation(). Both

Re: [SeaBIOS] [Qemu-devel] [PATCH 1/3] Fix aml_name_string() to recognize block name modifiers.

2012-06-20 Thread Gleb Natapov
On Tue, May 22, 2012 at 09:23:03PM -0400, Kevin O'Connor wrote: On Sun, May 20, 2012 at 12:03:38PM +0300, Gleb Natapov wrote: Signed-off-by: Gleb Natapov g...@redhat.com The patch series looks okay to me. Let me know when the corresponding qemu patches are committed. It is committed

Re: [SeaBIOS] [Qemu-devel] [RFC 0/7+1] QEMU APIC ID + topology bug + CPU hotplug

2012-07-12 Thread Gleb Natapov
On Thu, Jul 12, 2012 at 03:51:48PM +0200, Igor Mammedov wrote: On 07/10/2012 10:22 PM, Eduardo Habkost wrote: The hotplug case is a bit more complex: we need to either: - have a mechanism to let the ACPI SSDT code know what's the APIC ID of hotplugged CPUs; or - make Seabios run some

Re: [SeaBIOS] [Qemu-devel] [QEMU PATCH 2/7] hw/apic.c: rename bit functions to not conflict with bitops.h

2012-07-15 Thread Gleb Natapov
On Sat, Jul 14, 2012 at 09:09:23AM +, Blue Swirl wrote: On Fri, Jul 13, 2012 at 6:07 PM, Eduardo Habkost ehabk...@redhat.com wrote: On Thu, Jul 12, 2012 at 07:24:35PM +, Blue Swirl wrote: On Tue, Jul 10, 2012 at 8:22 PM, Eduardo Habkost ehabk...@redhat.com wrote: Signed-off-by:

Re: [SeaBIOS] Bootorder Failover (Patch)

2012-07-17 Thread Gleb Natapov
On Tue, Jul 17, 2012 at 06:43:01AM -0600, Steve Goodrich wrote: From: Kevin O'Connor [mailto:ke...@koconnor.net] If checking for an MBR is sufficient to determine if the drive is bootable then I'd suggest adding an option to read and validate the MBR in the POST phase prior to assigning a

Re: [SeaBIOS] [RFC seabios PATCH] enumerate APIC IDs directly from CPUs

2012-07-19 Thread Gleb Natapov
On Tue, Jul 17, 2012 at 06:56:30PM -0300, Eduardo Habkost wrote: This patch is an attempt to fix the non-continguous-APIC-ID problem without the FW_CFG_LAPIC_INFO approach I have sent proposed last week. Basically, this changes Seabios to probe for APIC IDs directly from the CPUs on boot,

Re: [SeaBIOS] [seabios PATCH 1/2] acpi: set I/O APIC ID to 0 by default

2012-07-19 Thread Gleb Natapov
On Thu, Jul 19, 2012 at 05:52:41PM -0300, Eduardo Habkost wrote: When resetting an I/O APIC, its ID is set to 0, so set it to 0 on the MADT table too. Actually BIOS needs to configure ioapic id to a uniqe value. This does not really matter for KVM though. Signed-off-by: Eduardo Habkost

Re: [SeaBIOS] [PATCH]: enable USE_PLATFORM_CLOCK bit in FADT flags

2012-07-19 Thread Gleb Natapov
On Thu, Jul 19, 2012 at 08:44:07PM -0400, Kevin O'Connor wrote: On Tue, Jul 17, 2012 at 02:18:00PM -0300, Marcelo Tosatti wrote: Enable bit 15 (USE_PLATFORM_CLOCK) of FADT flags field so that older Windows guests do not make use of the TSC for timestamping. I fixed up and committed

Re: [SeaBIOS] [PATCH]: enable USE_PLATFORM_CLOCK bit in FADT flags

2012-07-20 Thread Gleb Natapov
On Fri, Jul 20, 2012 at 07:24:27AM -0300, Marcelo Tosatti wrote: On Fri, Jul 20, 2012 at 07:49:03AM +0300, Gleb Natapov wrote: On Thu, Jul 19, 2012 at 08:44:07PM -0400, Kevin O'Connor wrote: On Tue, Jul 17, 2012 at 02:18:00PM -0300, Marcelo Tosatti wrote: Enable bit 15

Re: [SeaBIOS] [seabios PATCH 1/2] acpi: set I/O APIC ID to 0 by default

2012-07-23 Thread Gleb Natapov
On Fri, Jul 20, 2012 at 01:22:43PM -0300, Eduardo Habkost wrote: On Fri, Jul 20, 2012 at 12:18:59AM +0300, Gleb Natapov wrote: On Thu, Jul 19, 2012 at 05:52:41PM -0300, Eduardo Habkost wrote: When resetting an I/O APIC, its ID is set to 0, so set it to 0 on the MADT table too

Re: [SeaBIOS] SeaBIOS, FW_CFG_NUMA, and FW_CFG_MAX_CPUS

2012-07-25 Thread Gleb Natapov
On Fri, Jul 20, 2012 at 05:00:25PM -0300, Eduardo Habkost wrote: Hi, While working at the CPU index vs APIC ID changes, I stumbled upon another not-very-well-defined interface between SeaBIOS and QEMU, and I would like to clarify the semantics and constraints of some FW_CFG entries.

Re: [SeaBIOS] [SeaBIOS PATCH 2/2] allow CPUs to have non-contiguous Local APIC IDs (v2)

2012-07-26 Thread Gleb Natapov
On Wed, Jul 25, 2012 at 03:42:21PM -0300, Eduardo Habkost wrote: On Mon, Jul 23, 2012 at 03:20:14PM +0300, Gleb Natapov wrote: On Fri, Jul 20, 2012 at 02:04:50PM -0300, Eduardo Habkost wrote: Extract Local APIC IDs directly from the CPUs, and instead of check for i CountCPUs, check

Re: [SeaBIOS] [PATCH] Add an IPMI SMBIOS entry

2012-07-31 Thread Gleb Natapov
On Mon, Jul 30, 2012 at 09:57:47PM -0500, miny...@acm.org wrote: From: Corey Minyard cminy...@mvista.com An IPMI device is being added to the qemu code, and it has an SMBIOS entry to describe the interface characteristics. So add the SMBIOS entry to the BIOS so it can handle this.

Re: [SeaBIOS] [PATCH] Add an IPMI SMBIOS entry

2012-07-31 Thread Gleb Natapov
On Tue, Jul 31, 2012 at 08:33:53AM -0500, Corey Minyard wrote: On 07/31/2012 02:10 AM, Gleb Natapov wrote: /* This CPUID returns the signature 'KVMKVMKVM' in ebx, ecx, and edx. It * should be used to determine that a VM is running under KVM. @@ -35,6 +36,13 @@ static inline int

Re: [SeaBIOS] [SeaBIOS PATCH 0/2] Allow non-contiguous APIC IDs (v3)

2012-08-01 Thread Gleb Natapov
On Tue, Jul 31, 2012 at 09:14:13PM -0400, Kevin O'Connor wrote: On Wed, Jul 25, 2012 at 03:45:28PM -0300, Eduardo Habkost wrote: Changes v2 - v3: - Report I/O APIC ID = 0 on MP-table, too Changes v1 - v2: - Patch 1/2: cosmetic whitespace change - Patch 2/2: use size suffixes on

Re: [SeaBIOS] [PATCH] acpi: LNKS is not needed

2012-08-07 Thread Gleb Natapov
as ACPI: PCI Interrupt Link [LNKS] (IRQs 9) *0 Instead of that, we can simply use a hardwired interrupt index. Cc: Gleb Natapov gnata...@redhat.com Cc: Laszlo Ersek ler...@redhat.com Signed-off-by: Paolo Bonzini pbonz...@redhat.com Looks good to me. --- src/acpi-dsdt.dsl | 16

Re: [SeaBIOS] Compiling SeaBIOS for coreboot has problems with its ACPI code

2012-08-08 Thread Gleb Natapov
On Tue, Aug 07, 2012 at 07:34:37PM +, Moore, Robert wrote: This is very interesting. If I understand correctly, you are using a utility plus various directives to generate tables of AML offsets -- presumably in order to dynamically change AML values, correct? Yes. I have to say that I

Re: [SeaBIOS] [PATCH] tsc: use kvmclock for calibration

2012-08-10 Thread Gleb Natapov
On Fri, Aug 10, 2012 at 10:18:00AM +0300, Gleb Natapov wrote: can fix the in-kernel PIT issues with GRUB (see Michaels message) while testing. What message exactly? found it. -- Gleb. ___ SeaBIOS mailing list SeaBIOS

Re: [SeaBIOS] [PATCH v2 0/2] Add IPMI SMBIOS/ACPI support

2012-08-13 Thread Gleb Natapov
On Sun, Aug 12, 2012 at 08:22:12PM -0500, Corey Minyard wrote: Patch 2 is complex and I don't fully understand what it is doing. A quick scan leads me to believe it is constructing a dynamic SSDT - though it's not clear why a dynamic SSDT is needed and why the existing mechanism (see

Re: [SeaBIOS] [PATCH] tsc: use kvmclock for calibration

2012-08-13 Thread Gleb Natapov
On Mon, Aug 13, 2012 at 12:37:11PM +0200, Gerd Hoffmann wrote: Hi, Isnt pmtimer ioport usable? 14MHz. Can give it a try. 14 MHz looks wrong though, apci.h says: /* PM Timer ticks per second (HZ) */ #define PM_TIMER_FREQUENCY 3579545 Is this fixed? Or hardware specific?

Re: [SeaBIOS] [PATCH v2 0/2] Add IPMI SMBIOS/ACPI support

2012-08-13 Thread Gleb Natapov
On Mon, Aug 13, 2012 at 09:47:50AM -0500, Corey Minyard wrote: On 08/13/2012 01:25 AM, Gleb Natapov wrote: On Sun, Aug 12, 2012 at 08:22:12PM -0500, Corey Minyard wrote: Patch 2 is complex and I don't fully understand what it is doing. A quick scan leads me to believe it is constructing

  1   2   >