Re: [SeaBIOS] [PATCH v2] serialio: Support for mmap serial ports

2016-12-28 Thread Kevin O'Connor
ba...@gmail.com> > --- > v2: Fix typos > > Suggested by: Kevin O'Connor <ke...@koconnor.net>: > > -Only operate in 32bit mode if !MODESEGMENT > > src/Kconfig | 3 +++ > src/hw/serialio.c | 32 +--- > src/serial.c |

Re: [SeaBIOS] [PATCH] searialio: Support for mmap serial ports

2016-12-20 Thread Kevin O'Connor
On Tue, Dec 20, 2016 at 03:01:52PM +0100, Ricardo Ribalda Delgado wrote: > Some chipsets have memory mapped serial ports. The protocol is the same > as an standard uart, but with memory read/write instead of inb/outb. Thanks. See my comments below. [...] > --- a/src/Kconfig > +++ b/src/Kconfig

Re: [SeaBIOS] [PATCH 0/6] Misc tpm updates

2016-12-02 Thread Kevin O'Connor
On Wed, Nov 23, 2016 at 11:55:40AM -0500, Stefan Berger wrote: > On 08/11/2016 11:17 AM, Kevin O'Connor wrote: > > Hi Stefan, > > > > I dusted off some TPM patches I had worked on earlier in the year. > > Mostly just code movement, but the last p

Re: [SeaBIOS] [PATCH] tpm: Log TPM 2 digest structure in little endian format

2016-12-02 Thread Kevin O'Connor
On Wed, Nov 23, 2016 at 11:19:43AM -0500, Stefan Berger wrote: > The parameters for extending the PCRs of a TPM 2 are written in > big endian format when sent to the TPM. However, the log needs > to be written in little endian format, so we cannot just copy > the structure into the log as-is. To

Re: [SeaBIOS] [PATCH for-1.10-stable] drop "etc/boot-cpus" fw_cfg file and reuse legacy QEMU_CFG_NB_CPUS

2016-11-21 Thread Kevin O'Connor
On Mon, Nov 21, 2016 at 11:56:35AM +0100, Igor Mammedov wrote: > On Tue, 15 Nov 2016 11:36:21 +0100 > Gerd Hoffmann <kra...@redhat.com> wrote: > > > On So, 2016-11-13 at 23:05 -0500, Kevin O'Connor wrote: > > > On Fri, Nov 11, 2016 at 04:35:15PM +0100, Igor M

Re: [SeaBIOS] Starting SEABIOS as Grub payload and NOT loading roms/configuration from CBFS

2016-11-18 Thread Kevin O'Connor
On Fri, Nov 18, 2016 at 10:48:02AM +0100, Dennis Guse wrote: > I know usually Seabios is loaded by Coreboot and then Seabios loads > its modules from CBFS. > I want to do it slightly different: > * Hardware starts coreboot (actually libreboot flashed to a Lenovo X60) > * Coreboot starts Grub2 > *

Re: [SeaBIOS] SeaBIOS doesn't boot from secondary hard drive with OS if primary hard drive is empty

2016-11-17 Thread Kevin O'Connor
On Thu, Nov 17, 2016 at 02:50:51PM +0300, Аладышев Константин wrote: > When I have 2 SATA disks attached to my board, and only second priority > device is with OS, SeaBIOS doesn't boot. > > The "empty" disk doesn't have MBR, so SeaBIOS doesn't stuck on it, it goes > to the end message "No

Re: [SeaBIOS] Seabios build failure with gcc 6.2.0 in Debian Sid

2016-11-04 Thread Kevin O'Connor
On Fri, Nov 04, 2016 at 07:06:07PM +0100, Dario Faggioli wrote: > Hi, > > I'm reporting a build issue that I'm seeing when building Xen's > userspace tools, when the build process clones and build Seabios, on > Debian Sid, with gcc '6.2.0 20161019 (Debian 6.2.0-9)'. > > The error looks like this

[SeaBIOS] [PATCH 3/3] sercon: Support "split output" mode

2016-10-26 Thread Kevin O'Connor
Signed-off-by: Kevin O'Connor <ke...@koconnor.net> --- vgasrc/sercon.c | 65 +++ vgasrc/vgabios.c | 2 +- vgasrc/vgabios.h | 5 + vgasrc/vgaentry.S | 7 ++ vgasrc/vgainit.c | 9 +--- 5 files changed, 84 insertions

[SeaBIOS] [PATCH 2/3] sercon: Add basic keyboard input support

2016-10-26 Thread Kevin O'Connor
Signed-off-by: Kevin O'Connor <ke...@koconnor.net> --- vgasrc/sercon.c | 47 +++ vgasrc/vgainit.c | 3 ++- vgasrc/vgautil.h | 1 + 3 files changed, 50 insertions(+), 1 deletion(-) diff --git a/vgasrc/sercon.c b/vgasrc/sercon.c index 35b60a5..1

[SeaBIOS] [PATCH 0/3] SeaVGABIOS serial console test

2016-10-26 Thread Kevin O'Connor
a SeaBIOS implementation. I suspect it will be easier to handle vga quirks this way. However, handling exotic serial outputs (eg, mmio and usb based) would be better suited in SeaBIOS. Thoughts? -Kevin Kevin O'Connor (3): sercon: Initial support for VGA emulation over serial port sercon: Add basi

[SeaBIOS] [PATCH] usb: Make usb_time_sigatt variable static

2016-10-26 Thread Kevin O'Connor
Signed-off-by: Kevin O'Connor <ke...@koconnor.net> --- src/hw/usb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/hw/usb.c b/src/hw/usb.c index 20731d1..4f9a852 100644 --- a/src/hw/usb.c +++ b/src/hw/usb.c @@ -456,7 +456,7 @@ resetfail: goto done; }

[SeaBIOS] [ANNOUNCE] SeaBIOS 1.10.0

2016-10-26 Thread Kevin O'Connor
usion" scsi controllers on QEMU * Support for virtio devices mapped above 4GB * Several bug fixes and code cleanups For information on obtaining SeaBIOS, please see: http://seabios.org/Download = git shortlog -n rel-1.9.0..rel-1.10.0 ===== Kevin O'Connor (124): usb: Allow con

Re: [SeaBIOS] [PATCH] Makefile: Explicitly pass `no-pic` to compiler

2016-10-25 Thread Kevin O'Connor
On Tue, Oct 25, 2016 at 08:04:34PM +0300, Michael Tokarev wrote: > 25.10.2016 19:14, Kevin O'Connor wrote: > > On Tue, Oct 25, 2016 at 06:08:08PM +0200, Paul Menzel wrote: > > > > Does the patch below work? > > > index 1916ecf..3b94ee0 100644 > > --- a/Make

Re: [SeaBIOS] [PATCH] Makefile: Explicitly pass `no-pic` to compiler

2016-10-25 Thread Kevin O'Connor
On Tue, Oct 25, 2016 at 06:20:46PM +0200, Paul Menzel wrote: > On 10/25/16 18:14, Kevin O'Connor wrote: > > On Tue, Oct 25, 2016 at 06:08:08PM +0200, Paul Menzel wrote: > > > On 10/25/16 17:27, Paul Menzel wrote: > > > > On 10/25/16 17:21, Kevin O'Connor wrote: &

Re: [SeaBIOS] [PATCH] Makefile: Explicitly pass `no-pic` to compiler

2016-10-25 Thread Kevin O'Connor
On Tue, Oct 25, 2016 at 06:08:08PM +0200, Paul Menzel wrote: > On 10/25/16 17:27, Paul Menzel wrote: > > On 10/25/16 17:21, Kevin O'Connor wrote: > > > Does adding '-fno-pie' help? > > > > Isn’t that already used due to `COMMONCFLAGS += $(call > > cc-opt

Re: [SeaBIOS] [PATCH] Makefile: Explicitly pass `no-pic` to compiler

2016-10-25 Thread Kevin O'Connor
On Sun, Oct 23, 2016 at 08:57:28PM +0200, Paul Menzel wrote: > Date: Sun, 23 Oct 2016 18:56:28 +0200 > > Debian enables PIE hardening flags by default since package gcc-6 > 6.2.0-7 [1]. > > With that change, SeaBIOS fails to build with the error below [2][3]. > > ``` > $ make > Build Kconfig

Re: [SeaBIOS] [PATCH] build: Be sure to also include out/*.d in Makefile

2016-10-25 Thread Kevin O'Connor
On Fri, Oct 21, 2016 at 12:06:28PM -0400, Kevin O'Connor wrote: > Signed-off-by: Kevin O'Connor <ke...@koconnor.net> > --- > Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Makefile b/Makefile > index 41bfcf4..1916ecf 100644 > -

Re: [SeaBIOS] [PATCH v5 0/4] support booting more than 255 CPUs with QEMU

2016-10-25 Thread Kevin O'Connor
On Tue, Oct 25, 2016 at 12:44:35PM +0200, Igor Mammedov wrote: > On Tue, 18 Oct 2016 19:13:29 -0400 > "Kevin O'Connor" <ke...@koconnor.net> wrote: > > > On Thu, Oct 13, 2016 at 02:38:24PM +0200, Igor Mammedov wrote: > > [...] > > > Accord

[SeaBIOS] [PATCH] build: Be sure to also include out/*.d in Makefile

2016-10-21 Thread Kevin O'Connor
Signed-off-by: Kevin O'Connor <ke...@koconnor.net> --- Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile b/Makefile index 41bfcf4..1916ecf 100644 --- a/Makefile +++ b/Makefile @@ -281,4 +281,4 @@ clean: distclean: clean $(Q)rm -f .config .conf

Re: [SeaBIOS] [PATCH] vgabios: Reorder video modes to work around a Windows bug

2016-10-19 Thread Kevin O'Connor
On Wed, Oct 19, 2016 at 05:20:08PM +0200, Laszlo Ersek wrote: > On 10/19/16 15:16, Ladi Prosek wrote: > > Another hypothetical alternative would be to try to find an API > > invocation pattern reasonably unique to Windows that would trigger the > > new behavior, to minimize the risk. > > How

Re: [SeaBIOS] [PATCH] vgabios: Reorder video modes to work around a Windows bug

2016-10-19 Thread Kevin O'Connor
On Wed, Oct 19, 2016 at 11:32:41AM +0200, Ladi Prosek wrote: > On Wed, Oct 19, 2016 at 10:06 AM, Ladi Prosek <lpro...@redhat.com> wrote: > > On Wed, Oct 19, 2016 at 1:29 AM, Kevin O'Connor <ke...@koconnor.net> wrote: > >> On Mon, Oct 17, 2016 at 05:53:04PM +0200, La

Re: [SeaBIOS] [PATCH] docs: fix various typos and inconsistency

2016-10-19 Thread Kevin O'Connor
On Wed, Oct 19, 2016 at 01:35:04PM +0200, Piotr Król wrote: > On Tue, Oct 18, 2016 at 07:33:18PM -0400, Kevin O'Connor wrote: > > On Sun, Oct 16, 2016 at 10:31:46PM +0200, Piotr Król wrote: > > > -will instruct SeaBIOS to attempt to boot from the given USB drive > >

Re: [SeaBIOS] [PATCH 0/7] serial console support

2016-10-18 Thread Kevin O'Connor
On Wed, Sep 28, 2016 at 11:07:13AM +0200, Gerd Hoffmann wrote: > Hi, > > After a looong break finally the next round > of the seabios serial console patches. Hi Gerd, Sorry for the delay in responding. I ran some tests on your series and it looks like it causes issues with some systems that

Re: [SeaBIOS] [PATCH] docs: fix various typos and inconsistency

2016-10-18 Thread Kevin O'Connor
On Sun, Oct 16, 2016 at 10:31:46PM +0200, Piotr Król wrote: > Signed-off-by: Piotr Król Thanks. Except for the last part, I committed your patch. [...] > --- a/docs/Runtime_config.md > +++ b/docs/Runtime_config.md > @@ -157,7 +157,7 @@ into bootorder. For example, the

Re: [SeaBIOS] [PATCH] vgabios: Reorder video modes to work around a Windows bug

2016-10-18 Thread Kevin O'Connor
On Mon, Oct 17, 2016 at 05:53:04PM +0200, Ladi Prosek wrote: > Windows Server 2016 and Windows 10 RS1 come with a bug in its blue screen > of death rendering logic which prevents it from generating crash dumps. > > The bug does not manifest if Windows sees a suitable 32 bpp video mode > before a

Re: [SeaBIOS] [PATCH v5 0/4] support booting more than 255 CPUs with QEMU

2016-10-18 Thread Kevin O'Connor
On Thu, Oct 13, 2016 at 02:38:24PM +0200, Igor Mammedov wrote: [...] > According to SDM, if CPUs have APIC ID more than 254 > firmware should pass control to OS in x2APIC mode. > This series adds x2APIC bootstrap initialization. Thanks. Looks good to me - just waiting on QEMU side. -Kevin

Re: [SeaBIOS] next release?

2016-10-12 Thread Kevin O'Connor
On Wed, Oct 12, 2016 at 01:52:42PM +0200, Paolo Bonzini wrote: > Hi, > > is there a plan for SeaBIOS 1.10? It would be nice for one to have the > mpt-scsi driver included in the next QEMU release. :) There is. The plan was to release "mid October". Unfortunately, I'm a little behind, so that

Re: [SeaBIOS] [PATCH 5/5] [wip] sercon: initial split-output implementation

2016-10-03 Thread Kevin O'Connor
On Tue, Sep 27, 2016 at 02:00:08PM +0200, Gerd Hoffmann wrote: > On Fr, 2016-07-15 at 10:35 -0400, Kevin O'Connor wrote: > > On Fri, Jul 15, 2016 at 01:49:49PM +0200, Gerd Hoffmann wrote: > > > > Finally, one high level observation is that we know there are a number > &g

Re: [SeaBIOS] [PATCH v4 3/5] error out if present cpus count changed during SMP bringup

2016-09-16 Thread Kevin O'Connor
On Fri, Sep 16, 2016 at 01:54:16PM +0200, Igor Mammedov wrote: > if during SMP bringup a cpu is hotplugged, Seabios might > silently hung in > > while (cmos_smp_count != CountCPUs) > > loop as cmos_smp_count might be less then CountCPUs if > SIPI were delivered to the hotplugged CPU. > > Warn

Re: [SeaBIOS] [PATCH] boot: Show boot splash until all threads are complete

2016-09-16 Thread Kevin O'Connor
ot splash can > still be seen. The screen only changes, once the Linux kernel boots. > This seems to be a GRUB issue though [1]. > > [1] > http://metadata.ftp-master.debian.org/changelogs//main/g/grub2/grub2_2.02~beta2-36_changelog > > Suggested-by: Kevin O'Connor <

Re: [SeaBIOS] [PATCH] kbd: Move extended and release events out of special key detection switch

2016-09-16 Thread Kevin O'Connor
On Mon, Sep 12, 2016 at 11:30:47AM -0400, Kevin O'Connor wrote: > Move checking for release and extended scancodes to the top of > __process_key(). FYI, I committed this change. -Kevin ___ SeaBIOS mailing list SeaBIOS@seabios.org

Re: [SeaBIOS] [PATCH] fix virtio-pci

2016-09-16 Thread Kevin O'Connor
On Fri, Sep 16, 2016 at 01:14:36PM +0200, Igor Mammedov wrote: > On Fri, 16 Sep 2016 13:01:46 +0200 > Gerd Hoffmann wrote: > > > virtio-pci calls pci_enable_{io,mem}bar with the bar number, > > but the functions expect the bar base register offset. > > > > Reported-by: Igor

[SeaBIOS] [PATCH] kbd: Move extended and release events out of special key detection switch

2016-09-12 Thread Kevin O'Connor
Move checking for release and extended scancodes to the top of __process_key(). Signed-off-by: Kevin O'Connor <ke...@koconnor.net> --- src/kbd.c | 70 +++ 1 file changed, 30 insertions(+), 40 deletions(-) diff --git a/src/kbd.c

[SeaBIOS] Next release

2016-09-12 Thread Kevin O'Connor
On Mon, Sep 12, 2016 at 10:01:18AM +0200, Gerd Hoffmann wrote: > Hi, > > > Virtio 1.0 block devices (virtio-blk/virtio-scsi) use a 64-bit BAR > > unusable by SeaBIOS if mapped over 4G space, preventing the system > > to boot. > > Not needed, works fine in master (see commit >

Re: [SeaBIOS] [PATCH 00/10] Improved keyboard key mappings

2016-09-12 Thread Kevin O'Connor
On Mon, Sep 05, 2016 at 02:36:01PM -0400, Kevin O'Connor wrote: > There were several keys not mapped in the keyboard scancode to > "keycode" mapping functions. This series adds in a number of > additional keyboard mappings. I used the Phoenix "System BIOS for

[SeaBIOS] [PATCH 08/10] usb-hid: Generate Ctrl+Break and Alt+SysReq keys

2016-09-05 Thread Kevin O'Connor
Detect the sequences for generating Ctrl+Break and Alt+SysReq on USB keyboards and produce the appropriate legacy scancodes. Signed-off-by: Kevin O'Connor <ke...@koconnor.net> --- src/hw/usb-hid.c | 50 ++ 1 file changed, 30 insertions(

[SeaBIOS] [PATCH 05/10] kbd: Extract out shift flag setting into new function

2016-09-05 Thread Kevin O'Connor
Signed-off-by: Kevin O'Connor <ke...@koconnor.net> --- src/kbd.c | 105 +- 1 file changed, 43 insertions(+), 62 deletions(-) diff --git a/src/kbd.c b/src/kbd.c index c45e8ea..7ab440e 100644 --- a/src/kbd.c +++ b/src/kbd.c @@ -

[SeaBIOS] [PATCH 09/10] kbd: Generate interrupt events for SysReq, PrtScr, and Break

2016-09-05 Thread Kevin O'Connor
Generate the appropriate interrupt events for the given keys. Signed-off-by: Kevin O'Connor <ke...@koconnor.net> --- src/kbd.c | 55 ++- src/romlayout.S | 2 ++ 2 files changed, 52 insertions(+), 5 deletions(-) diff --git a/src/k

[SeaBIOS] [PATCH 04/10] kbd: Merge bda->kbd_flag0 and bda->kbd_flag1

2016-09-05 Thread Kevin O'Connor
Merge the two consecutive u8 fields into a single u16 field. Signed-off-by: Kevin O'Connor <ke...@koconnor.net> --- src/kbd.c | 87 +-- src/std/bda.h | 26 +++--- 2 files changed, 54 insertions(+), 59 deletions(-)

[SeaBIOS] [PATCH 06/10] kbd: Move checking for special keys in __process_keys() into switch

2016-09-05 Thread Kevin O'Connor
Signed-off-by: Kevin O'Connor <ke...@koconnor.net> --- src/kbd.c | 136 -- 1 file changed, 71 insertions(+), 65 deletions(-) diff --git a/src/kbd.c b/src/kbd.c index 7ab440e..a75adc3 100644 --- a/src/kbd.c +++ b/src/kbd.c @@ -

[SeaBIOS] [PATCH 01/10] kbd: Implement 101-key keyboard keycode mapping

2016-09-05 Thread Kevin O'Connor
The current keyboard code only supports the keycode mappings for 83-key keyboards (plus handling for alt-esc and f11/f12). Add a more complete mapping of keycodes for 101-key keyboards. This adds more alt key and ctrl key mappings. Signed-off-by: Kevin O'Connor <ke...@koconnor.net> --

[SeaBIOS] [PATCH 02/10] kbd: Implement extended keycode mappings for keypad-enter and keypad-/

2016-09-05 Thread Kevin O'Connor
On a 101-key keyboard the keypad enter and keypad '/' keys have unique BIOS keycodes that are distinct from the main keyboard enter and '/' keys. Signed-off-by: Kevin O'Connor <ke...@koconnor.net> --- src/kbd.c | 17 + 1 file changed, 17 insertions(+) diff --git a/src/k

[SeaBIOS] [PATCH 03/10] kbd: Suppress keys without mappings

2016-09-05 Thread Kevin O'Connor
Don't warn if a key without a mapping is pressed - it's known that some keys aren't mapped to keycodes. Suppress these keys instead of sending 0x to the keyboard buffer - as 0x can confuse some programs. Signed-off-by: Kevin O'Connor <ke...@koconnor.net> --- src/kbd.c | 5 ++---

[SeaBIOS] [PATCH 10/10] post: Map int 0x05 to entry point

2016-09-05 Thread Kevin O'Connor
int 0x05 was not assigned in the interrupt table - fix that. Signed-off-by: Kevin O'Connor <ke...@koconnor.net> --- src/post.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/post.c b/src/post.c index 2c4f12b..2a06d44 100644 --- a/src/post.c +++ b/src/post.c @@ -47,6 +47,7 @@ iv

Re: [SeaBIOS] [PATCH] pic: The default hardware interrupt handlers should not take a parameter

2016-08-30 Thread Kevin O'Connor
On Fri, Aug 26, 2016 at 10:54:27AM -0400, Kevin O'Connor wrote: > Hardware interrupt handlers don't take a parameter. Remove the > incorrect (and unused) parameter from handle_hwpic1/2(). FYI, I committed this change. -Kevin ___ SeaBIOS mailin

Re: [SeaBIOS] hw/usb-msc.c: Branch condition evaluates to a garbage value

2016-08-30 Thread Kevin O'Connor
On Mon, Aug 29, 2016 at 07:03:25PM +0200, Paul Menzel wrote: > Dear SeaBIOS developers, > > > Building the attached configuration with GCC 5.3.0 and the static analyzer > scan-build shipped with Clang 3.8, the following error is reported in > `src/hw/usb-msc.c` in line 110. > > The static

[SeaBIOS] [PATCH] pic: The default hardware interrupt handlers should not take a parameter

2016-08-26 Thread Kevin O'Connor
Hardware interrupt handlers don't take a parameter. Remove the incorrect (and unused) parameter from handle_hwpic1/2(). Signed-off-by: Kevin O'Connor <ke...@koconnor.net> --- src/hw/pic.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/hw/pic.c b/src/hw/pic.c

Re: [SeaBIOS] Show bootsplash already during device detection?

2016-08-24 Thread Kevin O'Connor
On Wed, Aug 24, 2016 at 08:53:15AM +0200, Paul Menzel wrote: > Dear SeaBIOS folks, > > Playing with the bootsplash feature, I noticed, that it’s only > displayed when the boot menu is displayed, when no bootsplash is used. The bootsplash image is only displayed while waiting to enter the

Re: [SeaBIOS] [PATCH] ps2: Remove stale check for timeout warning on reset

2016-08-21 Thread Kevin O'Connor
On Sun, Aug 14, 2016 at 10:10:54PM -0400, Kevin O'Connor wrote: > Commit 4ce5d207 removed the code to wait for a possible second byte > from a keyboard reset command, but it did not remove the extra check > when warning in ps2_recvbyte(). Remove the now stale code in > ps2_recvbyt

[SeaBIOS] [PATCH] ps2: Remove stale check for timeout warning on reset

2016-08-14 Thread Kevin O'Connor
Commit 4ce5d207 removed the code to wait for a possible second byte from a keyboard reset command, but it did not remove the extra check when warning in ps2_recvbyte(). Remove the now stale code in ps2_recvbyte(). Signed-off-by: Kevin O'Connor <ke...@koconnor.net> --- src/hw/ps2port

[SeaBIOS] [PATCH 1/6] tpm: Add comment banners to tcg.c separating major parts of spec

2016-08-11 Thread Kevin O'Connor
No code changes; just code movement. Signed-off-by: Kevin O'Connor <ke...@koconnor.net> --- src/std/tcg.h | 192 -- 1 file changed, 91 insertions(+), 101 deletions(-) diff --git a/src/std/tcg.h b/src/std/tcg.h index 3234524..d5bf15a

[SeaBIOS] [PATCH 0/6] Misc tpm updates

2016-08-11 Thread Kevin O'Connor
Hi Stefan, I dusted off some TPM patches I had worked on earlier in the year. Mostly just code movement, but the last patch I think helps simplify tpm_build_and_send_cmd(). Do they look okay to you? -Kevin Kevin O'Connor (6): tpm: Add comment banners to tcg.c separating major parts of spec

[SeaBIOS] [PATCH 6/6] tpm: Rework tpm_build_and_send_cmd() into tpm_simple_cmd()

2016-08-11 Thread Kevin O'Connor
to tpm_simple_cmd(). Signed-off-by: Kevin O'Connor <ke...@koconnor.net> --- src/std/tcg.h | 10 ++-- src/tcgbios.c | 152 ++ 2 files changed, 53 insertions(+), 109 deletions(-) diff --git a/src/std/tcg.h b/src/std/tcg.h index 61a759a..0

[SeaBIOS] [PATCH 3/6] tpm: Move code around in tcgbios.c to keep like code together

2016-08-11 Thread Kevin O'Connor
No code changes; just code movement. Signed-off-by: Kevin O'Connor <ke...@koconnor.net> --- src/tcgbios.c | 417 +- 1 file changed, 210 insertions(+), 207 deletions(-) diff --git a/src/tcgbios.c b/src/tcgbios.c index a3ee37c..5

[SeaBIOS] [PATCH 5/6] tpm: Don't call tpm_build_and_send_cmd() from tpm20_stirrandom()

2016-08-11 Thread Kevin O'Connor
Instead call tpmhw_transmit() directly. Signed-off-by: Kevin O'Connor <ke...@koconnor.net> --- src/std/tcg.h | 3 ++- src/tcgbios.c | 14 ++ 2 files changed, 12 insertions(+), 5 deletions(-) diff --git a/src/std/tcg.h b/src/std/tcg.h index d5bf15a..61a759a 100644 --- a/s

[SeaBIOS] [PATCH 2/6] tpm: Don't call tpm_set_failure() from tpm12_get_capability()

2016-08-11 Thread Kevin O'Connor
In the event of a failure in the low-level tpm12_get_capability() code, just return an error code. The caller can shutdown the TPM if needed - the only place where that is needed is during a failure in tpm12_determine_timeouts(). Signed-off-by: Kevin O'Connor <ke...@koconnor.net> --

[SeaBIOS] [PATCH 4/6] acpi: Generalize find_fadt() and find_tcpa_by_rsdp() into find_acpi_table()

2016-08-11 Thread Kevin O'Connor
The find_fadt() and find_tcpa_by_rsdp() functions are very similar. Create a new find_acpi_table() function and replace the two functions with this new function. Signed-off-by: Kevin O'Connor <ke...@koconnor.net> --- src/fw/biostables.c | 18 +- src/std/acpi.h

[SeaBIOS] [PATCH] checkstack: Handle conditional checks at start of functions

2016-08-10 Thread Kevin O'Connor
Recent versions of gcc will sometimes place conditional checks in the code prior to setting up the function's stack frame. Handle this case correctly. Signed-off-by: Kevin O'Connor <ke...@koconnor.net> --- scripts/checkstack.py | 5 + 1 file changed, 5 insertions(+) diff --git a/s

Re: [SeaBIOS] [PATCH v3 4/7] tpm: Extend tpm20_extend to support extending to multiple PCR banks

2016-08-10 Thread Kevin O'Connor
On Wed, Aug 10, 2016 at 11:17:30AM -0400, Kevin O'Connor wrote: > How about the update below (which I'll squash into the appropriate > patches). > > -Kevin > > > --- a/src/std/tcg.h > +++ b/src/std/tcg.h > @@ -518,6 +518,11 @@ struct tpm2_digest_values { > str

Re: [SeaBIOS] enable hvm in SeaBios

2016-08-10 Thread Kevin O'Connor
On Wed, Aug 10, 2016 at 12:24:25PM +, pieter van puymbroeck wrote: > Hello, > > Currently I'm building a new homelab based on omnios. > > There a kvm enabled zone is created and inside the zone I have 3 kvm-guests > running. These guests are running oracle vm (xen based). All is running

Re: [SeaBIOS] [PATCH v3 2/3] smp: refactor present CPU APIC ID detection and counting

2016-08-10 Thread Kevin O'Connor
On Wed, Aug 10, 2016 at 12:33:22PM +0200, Igor Mammedov wrote: > On Mon, 8 Aug 2016 18:37:13 -0400 > "Kevin O'Connor" <ke...@koconnor.net> wrote: > > > On Fri, Aug 05, 2016 at 12:47:28PM +0200, Igor Mammedov wrote: > > > From: Kevin O'Connor <ke...@kocon

Re: [SeaBIOS] [PATCH v3 3/3] support booting with more than 255 CPUs

2016-08-10 Thread Kevin O'Connor
On Wed, Aug 10, 2016 at 12:59:16PM +0200, Igor Mammedov wrote: > On Mon, 8 Aug 2016 18:42:07 -0400 > "Kevin O'Connor" <ke...@koconnor.net> wrote: > > On Fri, Aug 05, 2016 at 12:47:29PM +0200, Igor Mammedov wrote: > > > @@ -164,6 +178,8 @@ smp_se

Re: [SeaBIOS] [PATCH v3 4/7] tpm: Extend tpm20_extend to support extending to multiple PCR banks

2016-08-10 Thread Kevin O'Connor
On Tue, Aug 09, 2016 at 10:23:36PM -0400, Stefan Berger wrote: > On 08/09/2016 01:36 PM, Kevin O'Connor wrote: > > On Fri, Aug 05, 2016 at 11:07:11AM -0400, Stefan Berger wrote: > > > Extend the tpm20_extend function to support extending a hash to > > > multiple PCR

Re: [SeaBIOS] [PATCH v3 4/7] tpm: Extend tpm20_extend to support extending to multiple PCR banks

2016-08-09 Thread Kevin O'Connor
On Fri, Aug 05, 2016 at 11:07:11AM -0400, Stefan Berger wrote: > Extend the tpm20_extend function to support extending a hash to > multiple PCR banks. The sha1 hash that's being extended into the > sha256 bank for example, will be filled with zero-bytes to the > size of a sha256 hash. [...] > @@

Re: [SeaBIOS] [PATCH 1/2] pvscsi: Fix incorrect arguments order in call to memalign_low

2016-08-09 Thread Kevin O'Connor
On Thu, Aug 04, 2016 at 02:22:30PM +0300, Dana Rubin wrote: > From: Dana Rubin > > First argument should be 'align' and second 'size'. Thanks. I committed these two patches. -Kevin ___ SeaBIOS mailing list

Re: [SeaBIOS] [PATCH] blockcmd: CMD_SCSI op is only used in 32bit mode

2016-08-09 Thread Kevin O'Connor
On Thu, Aug 04, 2016 at 04:06:55PM -0400, Kevin O'Connor wrote: > Reduce the size of the 16bit code slightly by recognizing that > CMD_SCSI is only used in 32bit mode. FYI, I committed this patch. -Kevin ___ SeaBIOS mailing list SeaBIOS@seabi

Re: [SeaBIOS] [PATCH 0/5] Simplify SeaVGABIOS headers

2016-08-09 Thread Kevin O'Connor
On Fri, Aug 05, 2016 at 12:23:15PM -0400, Kevin O'Connor wrote: > This series reorganizes the vgabios headers so that there is just one > header for each C file, except for vgautil.h which is used for C files > that only need simple function and variable extern definitions. FYI, I

Re: [SeaBIOS] [PATCH v3 3/3] support booting with more than 255 CPUs

2016-08-08 Thread Kevin O'Connor
On Fri, Aug 05, 2016 at 12:47:29PM +0200, Igor Mammedov wrote: > SDM[*1] says that if there are CPUs with APIC ID > greater than 254, BIOS is to pass control to OS > in x2APIC mode. Use the fact that QEMU passes in > "etc/max-cpus" max possible "APIC ID + 1" to > detect need for x2APIC mode. Also

Re: [SeaBIOS] [PATCH v3 2/3] smp: refactor present CPU APIC ID detection and counting

2016-08-08 Thread Kevin O'Connor
On Fri, Aug 05, 2016 at 12:47:28PM +0200, Igor Mammedov wrote: > From: Kevin O'Connor <ke...@koconnor.net> > > Signed-off-by: "Kevin O'Connor" <ke...@koconnor.net> > Signed-off-by: Igor Mammedov <imamm...@redhat.com> > --- > v2: > * s/count_

[SeaBIOS] [PATCH 5/5] vgautil: Move definitions from cbvga.h and clext.h to vgautil.h

2016-08-05 Thread Kevin O'Connor
These files only need to export simple function definitions - move them to vgautil.h. Signed-off-by: Kevin O'Connor <ke...@koconnor.net> --- vgasrc/cbvga.c | 1 - vgasrc/cbvga.h | 20 vgasrc/clext.c | 1 - vgasrc/clext.h | 20 vgasrc/vga

[SeaBIOS] [PATCH 2/5] vgainit: Move video param setup to stdvga_build_video_param()

2016-08-05 Thread Kevin O'Connor
Move the full video_param_table[] setup (including the updating of the BDA) to stdvga_build_video_param(). Signed-off-by: Kevin O'Connor <ke...@koconnor.net> --- vgasrc/stdvgamodes.c | 10 ++ vgasrc/vgabios.c | 1 + vgasrc/vgabios.h | 9 +++-- vgasrc/vgainit.c

[SeaBIOS] [PATCH 4/5] vgautil: Move generic definitions from stdvga.h to vgautil.h

2016-08-05 Thread Kevin O'Connor
Don't use stdvga.h for function definitions of code in stdvgamodes.c and stdvgaio.c. Move them to vgautil.h. Signed-off-by: Kevin O'Connor <ke...@koconnor.net> --- vgasrc/bochsvga.c | 2 +- vgasrc/stdvga.c | 1 + vgasrc/stdvga.h | 32 +--- vgasrc/stdv

[SeaBIOS] [PATCH 1/5] vgafb: Move header definitions from vgabios.h to new file vgafb.h

2016-08-05 Thread Kevin O'Connor
Signed-off-by: Kevin O'Connor <ke...@koconnor.net> --- vgasrc/cbvga.c| 1 + vgasrc/swcursor.c | 3 ++- vgasrc/vgabios.c | 1 + vgasrc/vgabios.h | 36 vgasrc/vgafb.c| 1 + vgasrc/vgafb.h| 42 ++ 6

[SeaBIOS] [PATCH 0/5] Simplify SeaVGABIOS headers

2016-08-05 Thread Kevin O'Connor
This series reorganizes the vgabios headers so that there is just one header for each C file, except for vgautil.h which is used for C files that only need simple function and variable extern definitions. -Kevin Kevin O'Connor (5): vgafb: Move header definitions from vgabios.h to new file

[SeaBIOS] [PATCH 1/2] swcursor: Move swcursor code from vgafb.c to new file swcursor.c

2016-08-05 Thread Kevin O'Connor
Signed-off-by: Kevin O'Connor <ke...@koconnor.net> --- Makefile | 2 +- vgasrc/swcursor.c | 65 +++ vgasrc/vgabios.h | 2 ++ vgasrc/vgafb.c| 57 4 files changed, 68 inse

[SeaBIOS] [PATCH 2/2] swcursor: Concentrate swcursor logic in swcursor.c

2016-08-05 Thread Kevin O'Connor
The software cursor code is not frequently used (only the coreboot framebuffer vga code uses it). Move its logic out of the main code and into swcursor.c. Signed-off-by: Kevin O'Connor <ke...@koconnor.net> --- vgasrc/swcursor.c | 37 + vgasrc/vgabios.c

[SeaBIOS] [PATCH] blockcmd: CMD_SCSI op is only used in 32bit mode

2016-08-04 Thread Kevin O'Connor
Reduce the size of the 16bit code slightly by recognizing that CMD_SCSI is only used in 32bit mode. Signed-off-by: Kevin O'Connor <ke...@koconnor.net> --- src/hw/blockcmd.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/hw/blockcmd.c b/src/hw/blockcmd.c

Re: [SeaBIOS] [BUG?] Doesn't retrieve control after coreboot payload return

2016-08-02 Thread Kevin O'Connor
On Tue, Aug 02, 2016 at 04:53:16PM +0200, Antonello Dettori wrote: > On 02/08/16 16:39, Kevin O'Connor wrote: > > On Tue, Aug 02, 2016 at 03:37:44PM +0200, Antonello Dettori wrote: > > > Hi everyone. > > > > > > I'm currently working on coreboot but I stumbled

Re: [SeaBIOS] [QUESTION]stuck in SeaBIOS and vm can not be reset any more

2016-08-02 Thread Kevin O'Connor
On Tue, Aug 02, 2016 at 04:18:30AM +, Xulei (Stone) wrote: > >On Fri, Jul 29, 2016 at 04:04:59AM +, Xulei (Stone) wrote: > >> After one day, the vm is stuck. Looking from the following seabios log, > >> it seems seabios stops at "PCI: Using 00:02.0 for primary VGA", and can > >> not

Re: [SeaBIOS] [BUG?] Doesn't retrieve control after coreboot payload return

2016-08-02 Thread Kevin O'Connor
On Tue, Aug 02, 2016 at 03:37:44PM +0200, Antonello Dettori wrote: > Hi everyone. > > I'm currently working on coreboot but I stumbled on a strange SeaBIOS > behaviour. > After executing a payload and returning control to the caller SeaBIOS > crashes. > > The problem is currently solved by

Re: [SeaBIOS] [QUESTION]stuck in SeaBIOS and vm can not be reset any more

2016-08-01 Thread Kevin O'Connor
On Fri, Jul 29, 2016 at 04:04:59AM +, Xulei (Stone) wrote: > Hi, all: > Recently when i try to reset a vm, I find it may be stuck in SeaBIOS. > I use a shell script to continuously reset a vm to see what may happen. > > #!/bin/bash > while((1)) > do > virsh reset VMNAME > sleep 1 > done > >

Re: [SeaBIOS] [PATCH v2 3/6] tpm: Extend tpm20_extend to support extending to multiple PCR banks

2016-07-28 Thread Kevin O'Connor
On Tue, Jul 26, 2016 at 11:19:50AM -0400, Stefan Berger wrote: > Extend the tpm20_extend function to support extending a hash to > multiple PCR banks. The sha1 hash that's being extended into the > sha256 bank for example, will be filled with zero-bytes to the > size of a sha256 hash. [...] > +/*

Re: [SeaBIOS] [PATCH v2 1/6] tpm: Retrieve the PCR Bank configuration

2016-07-28 Thread Kevin O'Connor
On Tue, Jul 26, 2016 at 11:19:48AM -0400, Stefan Berger wrote: > Implement tpm20_get_capability and retrieve the PCR Bank configuration > from the TPM using this function. [...] > --- a/src/tcgbios.c > +++ b/src/tcgbios.c > @@ -24,6 +24,7 @@ > #include "tcgbios.h"// tpm_*, prototypes > #include

Re: [SeaBIOS] [PATCH] vgabios: Simplify scroll logic

2016-07-28 Thread Kevin O'Connor
On Thu, Jul 21, 2016 at 11:01:10AM -0400, Kevin O'Connor wrote: > Introduce a new function vgafb_scroll() to scroll a window on the > screen and update vgabios.c to use only that function for scrolling. > This makes the low-level vgafb_move_chars() and vgafb_clear_chars() > loca

Re: [SeaBIOS] How CPU executes bios code before copying bios to shadow ram?

2016-07-26 Thread Kevin O'Connor
On Tue, Jul 26, 2016 at 03:02:02PM +0800, Li Wang wrote: > Hi all, > I am reading seaBios code, and I have a question about the shadow memory > copy part. In fw/shadow.c:make_bios_writable_intel() reads pam0 to see if > shadow memory is already readable (if pam0's fourth bit is set), if pam0 >

[SeaBIOS] [PATCH] vgabios: Simplify scroll logic

2016-07-21 Thread Kevin O'Connor
Introduce a new function vgafb_scroll() to scroll a window on the screen and update vgabios.c to use only that function for scrolling. This makes the low-level vgafb_move_chars() and vgafb_clear_chars() local to vgafb.c, and it simplifies the callers. Signed-off-by: Kevin O'Connor <

Re: [SeaBIOS] [PATCH 3/3] tpm: Extend tpm20_extend to support extending to multiple PCR banks

2016-07-19 Thread Kevin O'Connor
On Tue, Jul 19, 2016 at 01:41:56PM -0400, Stefan Berger wrote: > Extend the tpm20_extend function to support extending a hash to > multiple PCR banks. The sha1 hash that's being extended into the > sha256 bank for example, will be filled with zero-bytes to the > size of a sha256 hash. > >

Re: [SeaBIOS] [PATCH 1/3] tpm: Retrieve the PCR Bank configuration

2016-07-19 Thread Kevin O'Connor
On Tue, Jul 19, 2016 at 01:41:54PM -0400, Stefan Berger wrote: > Implement tpm20_get_capability and retrieve the PCR Bank configuration > from the TPM using this function. > > Signed-off-by: Stefan Berger > --- > src/std/tcg.h | 29 + >

Re: [SeaBIOS] [PATCH 5/5] [wip] sercon: initial split-output implementation

2016-07-15 Thread Kevin O'Connor
On Fri, Jul 15, 2016 at 01:49:49PM +0200, Gerd Hoffmann wrote: > > Finally, one high level observation is that we know there are a number > > of quirks in various vgabios emulators. For example, we know some > > emulators don't handle certain 32bit instructions when in 16bit mode > > (hence

Re: [SeaBIOS] [PATCH 1/5] std: add cp437 to unicode map

2016-07-14 Thread Kevin O'Connor
On Thu, Jul 14, 2016 at 10:52:58AM +0200, Gerd Hoffmann wrote: > Signed-off-by: Gerd Hoffmann > --- > Makefile| 5 +- > src/std/cp437.c | 275 > > src/std/cp437.h | 1 + > 3 files changed, 279 insertions(+),

Re: [SeaBIOS] [PATCH 5/5] [wip] sercon: initial split-output implementation

2016-07-14 Thread Kevin O'Connor
On Thu, Jul 14, 2016 at 10:53:02AM +0200, Gerd Hoffmann wrote: > Signed-off-by: Gerd Hoffmann > --- > src/optionroms.c | 2 ++ > src/romlayout.S | 39 ++ > src/sercon.c | 99 > +++- > 3 files

Re: [SeaBIOS] GeodeVGA is not initialized during SeaBIOS execution

2016-07-12 Thread Kevin O'Connor
On Mon, Jul 11, 2016 at 08:25:14PM +0300, Andrey Korolyov wrote: > Awesome suggestion, turns out that the PCI_COMMAND_IO is not set. > Removing the check entirely would lead to an incomplete PCI > initialization but placing VGA ROM to vgaroms/seavgabios.rom could do > the trick. So, out of

Re: [SeaBIOS] GeodeVGA is not initialized during SeaBIOS execution

2016-07-10 Thread Kevin O'Connor
On Mon, Jul 11, 2016 at 02:23:12AM +0300, Andrey Korolyov wrote: > Hi, > > as per Kevin`s suggestion, I am posting initialization log (mixed one) > from initialization of the GeodeLX board. As it could be clearly seen > from the log, VGA option ROM was never called and executed during the >

Re: [SeaBIOS] [PATCH] restore MSRs on S3 resume

2016-07-07 Thread Kevin O'Connor
te_msrs on the BSP followed by smp_scan to initialize the APs. Reported-by: Laszlo Ersek <ler...@redhat.com> Signed-off-by: Paolo Bonzini <pbonz...@redhat.com> Signed-off-by: Kevin O'Connor <ke...@koconnor.net> diff --git a/src/fw/smp.c b/src/fw/smp.c index 6e706e4..719d

Re: [SeaBIOS] [PATCH 1/3] vgabios: Remove special case of dh==0xff in handle_1013()

2016-07-07 Thread Kevin O'Connor
On Mon, Jul 04, 2016 at 12:41:14PM -0400, Kevin O'Connor wrote: > The original "lgpl vgabios" had a special case for dh==0xff in its > int1013 (write string) code. There does not appear to be any VGABIOS > documentation supporting this as an externally available fea

Re: [SeaBIOS] [PATCH 3/3] add serial console support

2016-07-05 Thread Kevin O'Connor
On Tue, Jul 05, 2016 at 05:07:08PM +0200, Gerd Hoffmann wrote: > I also hacked up a patch to send output to both vga + serial: > > https://www.kraxel.org/cgit/seabios/commit/?h=serial=3afd7b8bb96126b00989f3ae09f451bbec4f00f7 > > Not working stable though, seems to corrupt memory, not sure why. >

Re: [SeaBIOS] Issues building SeaBIOS with gcc > 4.8

2016-07-05 Thread Kevin O'Connor
On Tue, Jul 05, 2016 at 03:49:34PM +0200, Roger Pau Monné wrote: > Hello, > > I'm seeing the following issue when building SeaBIOS with gcc > 4.8: > > Compiling whole program out/ccode32flat.o > Compiling whole program out/code32seg.o > Compiling whole program out/ccode16.o >

Re: [SeaBIOS] [PATCH 3/3] add serial console support

2016-07-05 Thread Kevin O'Connor
On Mon, Jul 04, 2016 at 10:39:54PM +0200, Gerd Hoffmann wrote: > Signed-off-by: Gerd Hoffmann Not sure if this is still an RFC. I think it needs to have a Kconfig option. It should probably also have runtime enable option. [...] > --- a/Makefile > +++ b/Makefile > @@ -29,7

Re: [SeaBIOS] [PATCH 1/3] std: add cp437 to unicode map

2016-07-05 Thread Kevin O'Connor
On Mon, Jul 04, 2016 at 10:39:52PM +0200, Gerd Hoffmann wrote: > Signed-off-by: Gerd Hoffmann Nice! [...] > --- /dev/null > +++ b/src/std/cp437.h Instead of making a header file and including it in an array in the C code I think it would be better to instead introduce

<    2   3   4   5   6   7   8   9   10   11   >