[SeaBIOS] [Qemu-devel] [PATCH v5 for-2.3 06/28] acpi: add aml_shiftleft() term

2015-03-10 Thread Marcel Apfelbaum
Add encoding for ACPI DefShiftLeft Opcode. Reviewed-by: Igor Mammedov imamm...@redhat.com Signed-off-by: Marcel Apfelbaum mar...@redhat.com --- hw/acpi/aml-build.c | 10 ++ include/hw/acpi/aml-build.h | 1 + 2 files changed, 11 insertions(+) diff --git a/hw/acpi/aml-build.c b

Re: [SeaBIOS] [Qemu-devel] [PATCH v5 for-2.3 12/28] hw/acpi: add _CRS method for extra root busses

2015-03-10 Thread Marcel Apfelbaum
On 03/10/2015 05:38 PM, Michael S. Tsirkin wrote: Comment from 20150308162743.gc31...@redhat.com not addressed yet I think. I'll try to use g_array, let's see how it will look. Thanks, Marcel On Tue, Mar 10, 2015 at 05:31:58PM +0200, Marcel Apfelbaum wrote: Save the IO/mem/bus numbers

Re: [SeaBIOS] [Qemu-devel] [PATCH v5 for-2.3 27/28] apci: fix PXB behaviour if used with unsupported BIOS

2015-03-10 Thread Marcel Apfelbaum
On 03/10/2015 05:44 PM, Michael S. Tsirkin wrote: On Tue, Mar 10, 2015 at 05:32:13PM +0200, Marcel Apfelbaum wrote: PXB does not work with an unsupported BIOS, but should not interfere with normal OS operation. Fix this by not adding PXB mem/IO chunks to _CRS if they weren't configured by BIOS

[SeaBIOS] [Qemu-devel] [PATCH v5 for-2.3 02/28] acpi: add aml_or() term

2015-03-10 Thread Marcel Apfelbaum
Add encoding for ACPI DefOr Opcode. Reviewed-by: Shannon Zhao zhaoshengl...@huawei.com Reviewed-by: Igor Mammedov imamm...@redhat.com Signed-off-by: Marcel Apfelbaum mar...@redhat.com --- hw/acpi/aml-build.c | 10 ++ include/hw/acpi/aml-build.h | 1 + 2 files changed, 11

Re: [SeaBIOS] [Qemu-devel] [PATCH v4 for-2.3 11/25] hw/apci: add _PRT method for extra PCI root busses

2015-03-10 Thread Marcel Apfelbaum
On 03/10/2015 07:07 PM, Michael S. Tsirkin wrote: On Sun, Mar 08, 2015 at 01:16:13PM +0200, Marcel Apfelbaum wrote: Signed-off-by: Marcel Apfelbaum mar...@redhat.com --- hw/i386/acpi-build.c | 65 1 file changed, 65 insertions(+) diff

[SeaBIOS] [Qemu-devel] [PATCH v5 for-2.3 14/28] hw/pci: move pci bus related code to separate files

2015-03-10 Thread Marcel Apfelbaum
This refactoring moves all the code needed (recursively) to register TYPE_PCI_BUS type to a new file hw/pci/pci_bus.c . This allows to properly add new functionality to the pci bus class. Signed-off-by: Marcel Apfelbaum mar...@redhat.com --- arch_init.c | 1 + hw/alpha/typhoon.c

[SeaBIOS] [Qemu-devel] [PATCH v5 for-2.3 21/28] hw/pci: inform bios if the system has more than one pci bridge

2015-03-10 Thread Marcel Apfelbaum
From: Marcel Apfelbaum marce...@redhat.com The bios looks for 'etc/extra-pci-roots' to decide if is going to scan further buses after bus 0 tree. Signed-off-by: Marcel Apfelbaum mar...@redhat.com --- hw/i386/pc.c | 13 + 1 file changed, 13 insertions(+) diff --git a/hw/i386/pc.c b

[SeaBIOS] [Qemu-devel] [PATCH v5 for-2.3 16/28] hw/pci: made pci_bus_num a PCIBusClass method

2015-03-10 Thread Marcel Apfelbaum
From: Marcel Apfelbaum marce...@redhat.com Refactoring it as a method of PCIBusClass will allow different implementations for subclasses. Signed-off-by: Marcel Apfelbaum mar...@redhat.com --- hw/i386/kvm/pci-assign.c | 1 + hw/pci/pci.c | 7 --- hw/pci/pci_bus.c | 10

[SeaBIOS] [Qemu-devel] [PATCH v5 for-2.3 12/28] hw/acpi: add _CRS method for extra root busses

2015-03-10 Thread Marcel Apfelbaum
Save the IO/mem/bus numbers ranges assigned to the extra root busses to be removed from the root bus 0 range. Signed-off-by: Marcel Apfelbaum mar...@redhat.com --- hw/i386/acpi-build.c | 152 +++ 1 file changed, 152 insertions(+) diff --git a/hw

Re: [SeaBIOS] [Qemu-devel] [PATCH v5 for-2.3 26/28] acpi: restrict the aml emission to PXB host bridges

2015-03-10 Thread Marcel Apfelbaum
On 03/10/2015 05:41 PM, Michael S. Tsirkin wrote: On Tue, Mar 10, 2015 at 05:32:12PM +0200, Marcel Apfelbaum wrote: Initial implementation assumed that the aml used for any extra root buses would be generic, however this is not always true. Restrict aml emission only to i440fx and PXB because

[SeaBIOS] [Qemu-devel] [PATCH v5 for-2.3 05/28] acpi: add aml_index() term

2015-03-10 Thread Marcel Apfelbaum
Add encoding for ACPI DefIndex Opcode. Signed-off-by: Marcel Apfelbaum mar...@redhat.com --- hw/acpi/aml-build.c | 10 ++ include/hw/acpi/aml-build.h | 1 + 2 files changed, 11 insertions(+) diff --git a/hw/acpi/aml-build.c b/hw/acpi/aml-build.c index be73d30..aeaa8f6 100644

[SeaBIOS] [Qemu-devel] [PATCH v5 for-2.3 15/28] hw/pci: made pci_bus_is_root a PCIBusClass method

2015-03-10 Thread Marcel Apfelbaum
From: Marcel Apfelbaum marce...@redhat.com Refactoring it as a method of PCIBusClass will allow different implementations for subclasses. Removed the assumption that the root bus does not have a parent device because is specific only to the default class implementation. Signed-off-by: Marcel

[SeaBIOS] [Qemu-devel] [PATCH v5 for-2.3 00/28] hw/pc: implement multiple primary busses for pc machines

2015-03-10 Thread Marcel Apfelbaum
and i440fx patch 27 Backward compatibility with SeaBIOS patch 28 PXB Documentation Marcel Apfelbaum (28): acpi: fix aml_equal term implementation acpi: add aml_or() term acpi: add aml_add() term acpi: add aml_lless() term acpi: add aml_index() term acpi: add aml_shiftleft() term acpi

[SeaBIOS] [Qemu-devel] [PATCH v5 for-2.3 01/28] acpi: fix aml_equal term implementation

2015-03-10 Thread Marcel Apfelbaum
The DefLEqual op does not have a target operand. Remove it. Reviewed-by: Igor Mammedov imamm...@redhat.com Signed-off-by: Marcel Apfelbaum mar...@redhat.com --- hw/acpi/aml-build.c | 1 - 1 file changed, 1 deletion(-) diff --git a/hw/acpi/aml-build.c b/hw/acpi/aml-build.c index e01b8c2..ace180b

[SeaBIOS] [Qemu-devel] [PATCH v5 for-2.3 22/28] hw/pci: piix - suport multiple host bridges

2015-03-10 Thread Marcel Apfelbaum
From: Marcel Apfelbaum marce...@redhat.com Instead of assuming it has only one bus, it enumerates all the host bridges until it finds the one with bus number corresponding with the config register. Signed-off-by: Marcel Apfelbaum mar...@redhat.com --- hw/pci-host/piix.c | 57

[SeaBIOS] [Qemu-devel] [PATCH v5 for-2.3 26/28] acpi: restrict the aml emission to PXB host bridges

2015-03-10 Thread Marcel Apfelbaum
Initial implementation assumed that the aml used for any extra root buses would be generic, however this is not always true. Restrict aml emission only to i440fx and PXB because is the only supported combination for now. Signed-off-by: Marcel Apfelbaum mar...@redhat.com --- hw/i386/acpi-build.c

[SeaBIOS] [Qemu-devel] [PATCH v5 for-2.3 20/28] hw/pci: introduce PCI Expander Bridge (PXB)

2015-03-10 Thread Marcel Apfelbaum
From: Marcel Apfelbaum marce...@redhat.com PXB is a light-weight host bridge whose purpose is to enable the main host bridge to support multiple PCI root buses. As oposed to PCI-2-PCI bridge's secondary bus, PXB's bus is a primary bus and can be associated with a NUMA node (different from

[SeaBIOS] [Qemu-devel] [PATCH v5 for-2.3 08/28] acpi: add aml_increment() term

2015-03-10 Thread Marcel Apfelbaum
Add encoding for ACPI DefIncrement Opcode. Reviewed-by: Shannon Zhao zhaoshengl...@huawei.com Reviewed-by: Igor Mammedov imamm...@redhat.com Signed-off-by: Marcel Apfelbaum mar...@redhat.com --- hw/acpi/aml-build.c | 8 include/hw/acpi/aml-build.h | 1 + 2 files changed, 9

[SeaBIOS] [Qemu-devel] [PATCH v5 for-2.3 07/28] acpi: add aml_shiftright() term

2015-03-10 Thread Marcel Apfelbaum
Add encoding for ACPI DefShiftRight Opcode. Reviewed-by: Igor Mammedov imamm...@redhat.com Signed-off-by: Marcel Apfelbaum mar...@redhat.com --- hw/acpi/aml-build.c | 10 ++ include/hw/acpi/aml-build.h | 1 + 2 files changed, 11 insertions(+) diff --git a/hw/acpi/aml-build.c b

[SeaBIOS] [Qemu-devel] [PATCH v5 for-2.3 09/28] acpi: add aml_while() term

2015-03-10 Thread Marcel Apfelbaum
Add encoding for ACPI DefWhile Opcode. Reviewed-by: Shannon Zhao zhaoshengl...@huawei.com Reviewed-by: Igor Mammedov imamm...@redhat.com Signed-off-by: Marcel Apfelbaum mar...@redhat.com --- hw/acpi/aml-build.c | 8 include/hw/acpi/aml-build.h | 1 + 2 files changed, 9

[SeaBIOS] [Qemu-devel] [PATCH v5 for-2.3 10/28] hw/acpi: add support for multiple root busses

2015-03-10 Thread Marcel Apfelbaum
If the machine has several root busses, we need to add them to acpi in order to be properly detected by guests. Signed-off-by: Marcel Apfelbaum mar...@redhat.com --- hw/i386/acpi-build.c | 32 1 file changed, 32 insertions(+) diff --git a/hw/i386/acpi-build.c b

[SeaBIOS] [Qemu-devel] [PATCH v5 for-2.3 27/28] apci: fix PXB behaviour if used with unsupported BIOS

2015-03-10 Thread Marcel Apfelbaum
PXB does not work with an unsupported BIOS, but should not interfere with normal OS operation. Fix this by not adding PXB mem/IO chunks to _CRS if they weren't configured by BIOS. Signed-off-by: Marcel Apfelbaum mar...@redhat.com --- hw/i386/acpi-build.c | 71

[SeaBIOS] [Qemu-devel] [PATCH v5 for-2.3 24/28] hw/pci_bus: add support for NUMA nodes

2015-03-10 Thread Marcel Apfelbaum
PCI root buses can be attached to a specific NUMA node. PCI buses are not attached be default to a NUMA node. Signed-off-by: Marcel Apfelbaum mar...@redhat.com --- hw/pci/pci_bus.c | 7 +++ include/hw/pci/pci_bus.h | 6 ++ include/sysemu/sysemu.h | 1 + 3 files changed, 14

[SeaBIOS] [Qemu-devel] [PATCH v5 for-2.3 19/28] hw/pci: implement iteration over multiple host bridges

2015-03-10 Thread Marcel Apfelbaum
From: Marcel Apfelbaum marce...@redhat.com Signed-off-by: Marcel Apfelbaum mar...@redhat.com --- hw/pci/pci.c | 8 include/hw/pci/pci_host.h | 4 2 files changed, 8 insertions(+), 4 deletions(-) diff --git a/hw/pci/pci.c b/hw/pci/pci.c index 53598bd..f0cf752 100644

[SeaBIOS] [Qemu-devel] [PATCH v5 for-2.3 18/28] hw/pci: removed 'rootbus nr is 0' assumption from qmp_pci_query

2015-03-10 Thread Marcel Apfelbaum
From: Marcel Apfelbaum marce...@redhat.com Use the newer pci_bus_num to correctly get the root bus number. Signed-off-by: Marcel Apfelbaum mar...@redhat.com --- hw/pci/pci.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/hw/pci/pci.c b/hw/pci/pci.c index e386f2c..53598bd

[SeaBIOS] [Qemu-devel] [PATCH v5 for-2.3 11/28] hw/apci: add _PRT method for extra PCI root busses

2015-03-10 Thread Marcel Apfelbaum
Signed-off-by: Marcel Apfelbaum mar...@redhat.com --- hw/i386/acpi-build.c | 65 1 file changed, 65 insertions(+) diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c index 3e2701b..513fd6b 100644 --- a/hw/i386/acpi-build.c +++ b/hw/i386

[SeaBIOS] [Qemu-devel] [PATCH v5 for-2.3 13/28] hw/acpi: remove from root bus 0 the crs resources used by other busses.

2015-03-10 Thread Marcel Apfelbaum
If multiple root busses are used, root bus 0 cannot use all the pci holes ranges. Remove the IO/mem ranges used by the other primary busses. Signed-off-by: Marcel Apfelbaum mar...@redhat.com --- hw/i386/acpi-build.c | 84 1 file changed, 72

[SeaBIOS] [Qemu-devel] [PATCH v5 for-2.3 17/28] hw/pci: introduce TYPE_PCI_MAIN_HOST_BRIDGE interface

2015-03-10 Thread Marcel Apfelbaum
From: Marcel Apfelbaum marce...@redhat.com This is a marker interface used to differentiate the default host bridge on a system with multiple host bridges. This differentiation is required only for pc machines for now by the ACPI subsystem. Signed-off-by: Marcel Apfelbaum mar...@redhat.com

[SeaBIOS] [Qemu-devel] [PATCH v5 for-2.3 25/28] hw/pxb: add numa_node parameter

2015-03-10 Thread Marcel Apfelbaum
The pxb can be attach to and existing numa node by specifying numa_node option that equals the desired numa nodeid. Signed-off-by: Marcel Apfelbaum mar...@redhat.com --- hw/i386/acpi-build.c| 12 hw/pci-bridge/pci_expander_bridge.c | 17 + 2 files

[SeaBIOS] [Qemu-devel] [PATCH v5 for-2.3 28/28] docs: Add PXB documentation

2015-03-10 Thread Marcel Apfelbaum
Signed-off-by: Marcel Apfelbaum mar...@redhat.com --- docs/pci_expander_bridge.txt | 52 1 file changed, 52 insertions(+) create mode 100644 docs/pci_expander_bridge.txt diff --git a/docs/pci_expander_bridge.txt b/docs/pci_expander_bridge.txt new

[SeaBIOS] [Qemu-devel] [PATCH v5 for-2.3 23/28] hw/pxb: add map_irq func

2015-03-10 Thread Marcel Apfelbaum
The bios does not index the pxb slot number when it computes the IRQ because it resides on bus 0 and not on the current bus. However Qemu routes the irq through bus 0 and adds the pxb slot to the IRQ computation. Synchronize between bios and Qemu by canceling pxb's effect. Signed-off-by: Marcel

Re: [SeaBIOS] [Qemu-devel] [PATCH v4 for-2.3 05/25] acpi: add aml_index() term

2015-03-09 Thread Marcel Apfelbaum
On 03/09/2015 01:00 PM, Michael S. Tsirkin wrote: On Mon, Mar 09, 2015 at 11:39:57AM +0100, Igor Mammedov wrote: On Sun, 8 Mar 2015 13:16:07 +0200 Marcel Apfelbaum mar...@redhat.com wrote: Add encoding for ACPI DefIndex Opcode. Signed-off-by: Marcel Apfelbaum mar...@redhat.com --- hw/acpi

Re: [SeaBIOS] [Qemu-devel] [PATCH v4 for-2.3 00/25] hw/pc: implement multiple primary busses for pc machines

2015-03-09 Thread Marcel Apfelbaum
On 03/09/2015 04:19 PM, Gerd Hoffmann wrote: Hi, My series is based on commit 09d219a. Try please on top of this commit. Ok, that works. Going to play with that now ;) Good luck! ... and tell me what you think :) If you need any help with the command line of the pxb device, let me

Re: [SeaBIOS] [Qemu-devel] [PATCH v4 for-2.3 00/25] hw/pc: implement multiple primary busses for pc machines

2015-03-09 Thread Marcel Apfelbaum
On 03/09/2015 06:55 PM, Gerd Hoffmann wrote: On Mo, 2015-03-09 at 18:26 +0200, Marcel Apfelbaum wrote: On 03/09/2015 04:19 PM, Gerd Hoffmann wrote: Hi, My series is based on commit 09d219a. Try please on top of this commit. Ok, that works. Going to play with that now ;) Good luck

Re: [SeaBIOS] [Qemu-devel] [PATCH v4 for-2.3 02/25] acpi: add aml_or() term

2015-03-09 Thread Marcel Apfelbaum
On 03/09/2015 09:58 AM, Shannon Zhao wrote: On 2015/3/8 19:16, Marcel Apfelbaum wrote: Add encoding for ACPI DefOr Opcode. Reviewed-by: Igor Mammedov imamm...@redhat.com Signed-off-by: Marcel Apfelbaum mar...@redhat.com --- hw/acpi/aml-build.c | 10 ++ include/hw/acpi/aml

Re: [SeaBIOS] [Qemu-devel] [PATCH v4 for-2.3 00/25] hw/pc: implement multiple primary busses for pc machines

2015-03-09 Thread Marcel Apfelbaum
On 03/09/2015 12:18 PM, Gerd Hoffmann wrote: On Mo, 2015-03-09 at 11:20 +0200, Marcel Apfelbaum wrote: On 03/09/2015 09:43 AM, Gerd Hoffmann wrote: On So, 2015-03-08 at 13:16 +0200, Marcel Apfelbaum wrote: Notes: - Sorry for the late submission, I was waiting for dynamic ACPI series

Re: [SeaBIOS] [Qemu-devel] [PATCH v4 for-2.3 00/25] hw/pc: implement multiple primary busses for pc machines

2015-03-09 Thread Marcel Apfelbaum
On 03/09/2015 09:43 AM, Gerd Hoffmann wrote: On So, 2015-03-08 at 13:16 +0200, Marcel Apfelbaum wrote: Notes: - Sorry for the late submission, I was waiting for dynamic ACPI series to get merged in order to submit - my bad. - The prev version (v2) was wrongfully tagged by me as RFC

Re: [SeaBIOS] [Qemu-devel] [PATCH v4 for-2.3 13/25] hw/acpi: remove from root bus 0 the crs resources used by other busses.

2015-03-08 Thread Marcel Apfelbaum
On 03/08/2015 08:26 PM, Kevin O'Connor wrote: On Sun, Mar 08, 2015 at 07:51:42PM +0200, Marcel Apfelbaum wrote: On 03/08/2015 06:13 PM, Kevin O'Connor wrote: If I read this correctly, it looks like a machine with two root buses and 20 devices, each with one memory range and one io range, would

Re: [SeaBIOS] [Qemu-devel] [PATCH v4 for-2.3 13/25] hw/acpi: remove from root bus 0 the crs resources used by other busses.

2015-03-08 Thread Marcel Apfelbaum
On 03/08/2015 06:13 PM, Kevin O'Connor wrote: On Sun, Mar 08, 2015 at 01:16:15PM +0200, Marcel Apfelbaum wrote: If multiple root busses are used, root bus 0 cannot use all the pci holes ranges. Remove the IO/mem ranges used by the other primary busses. [...] -aml_append(crs

Re: [SeaBIOS] [Qemu-devel] [PATCH v4 for-2.3 12/25] hw/acpi: add _CRS method for extra root busses

2015-03-08 Thread Marcel Apfelbaum
On 03/08/2015 06:27 PM, Michael S. Tsirkin wrote: On Sun, Mar 08, 2015 at 01:16:14PM +0200, Marcel Apfelbaum wrote: Save the IO/mem/bus numbers ranges assigned to the extra root busses to be removed from the root bus 0 range. Signed-off-by: Marcel Apfelbaum mar...@redhat.com --- hw/i386/acpi

[SeaBIOS] [Qemu-devel] [PATCH v4 for-2.3 25/25] hw/pxb: add numa_node parameter

2015-03-08 Thread Marcel Apfelbaum
The pxb can be attach to and existing numa node by specifying numa_node option that equals the desired numa nodeid. Signed-off-by: Marcel Apfelbaum mar...@redhat.com --- hw/i386/acpi-build.c| 12 hw/pci-bridge/pci_expander_bridge.c | 17 + 2 files

[SeaBIOS] [Qemu-devel] [PATCH v4 for-2.3 24/25] hw/pci_bus: add support for NUMA nodes

2015-03-08 Thread Marcel Apfelbaum
PCI root buses can be attached to a specific NUMA node. PCI buses are not attached be default to a NUMA node. Signed-off-by: Marcel Apfelbaum mar...@redhat.com --- hw/pci/pci_bus.c | 7 +++ include/hw/pci/pci_bus.h | 6 ++ include/sysemu/sysemu.h | 1 + 3 files changed, 14

[SeaBIOS] [Qemu-devel] [PATCH v4 for-2.3 06/25] acpi: add aml_shiftleft() term

2015-03-08 Thread Marcel Apfelbaum
Add encoding for ACPI DefShiftLeft Opcode. Reviewed-by: Igor Mammedov imamm...@redhat.com Signed-off-by: Marcel Apfelbaum mar...@redhat.com --- hw/acpi/aml-build.c | 10 ++ include/hw/acpi/aml-build.h | 1 + 2 files changed, 11 insertions(+) diff --git a/hw/acpi/aml-build.c b

[SeaBIOS] [Qemu-devel] [PATCH v4 for-2.3 10/25] hw/acpi: add support for multiple root busses

2015-03-08 Thread Marcel Apfelbaum
If the machine has several root busses, we need to add them to acpi in order to be properly detected by guests. Signed-off-by: Marcel Apfelbaum mar...@redhat.com --- hw/i386/acpi-build.c | 32 1 file changed, 32 insertions(+) diff --git a/hw/i386/acpi-build.c b

[SeaBIOS] [Qemu-devel] [PATCH v4 for-2.3 20/25] hw/pci: introduce PCI Expander Bridge (PXB)

2015-03-08 Thread Marcel Apfelbaum
From: Marcel Apfelbaum marce...@redhat.com PXB is a light-weight host bridge whose purpose is to enable the main host bridge to support multiple PCI root buses. As oposed to PCI-2-PCI bridge's secondary bus, PXB's bus is a primary bus and can be associated with a NUMA node (different from

[SeaBIOS] [Qemu-devel] [PATCH v4 for-2.3 23/25] hw/pxb: add map_irq func

2015-03-08 Thread Marcel Apfelbaum
The bios does not index the pxb slot number when it computes the IRQ because it resides on bus 0 and not on the current bus. However Qemu routes the irq through bus 0 and adds the pxb slot to the IRQ computation. Synchronize between bios and Qemu by canceling pxb's effect. Signed-off-by: Marcel

[SeaBIOS] [Qemu-devel] [PATCH v4 for-2.3 17/25] hw/pci: introduce TYPE_PCI_MAIN_HOST_BRIDGE interface

2015-03-08 Thread Marcel Apfelbaum
From: Marcel Apfelbaum marce...@redhat.com This is a marker interface used to differentiate the default host bridge on a system with multiple host bridges. This differentiation is required only for pc machines for now by the ACPI subsystem. Signed-off-by: Marcel Apfelbaum mar...@redhat.com

[SeaBIOS] [Qemu-devel] [PATCH v4 for-2.3 15/25] hw/pci: made pci_bus_is_root a PCIBusClass method

2015-03-08 Thread Marcel Apfelbaum
From: Marcel Apfelbaum marce...@redhat.com Refactoring it as a method of PCIBusClass will allow different implementations for subclasses. Removed the assumption that the root bus does not have a parent device because is specific only to the default class implementation. Signed-off-by: Marcel

[SeaBIOS] [Qemu-devel] [PATCH v4 for-2.3 09/25] acpi: add aml_while() term

2015-03-08 Thread Marcel Apfelbaum
Add encoding for ACPI DefWhile Opcode. Reviewed-by: Igor Mammedov imamm...@redhat.com Signed-off-by: Marcel Apfelbaum mar...@redhat.com --- hw/acpi/aml-build.c | 8 include/hw/acpi/aml-build.h | 1 + 2 files changed, 9 insertions(+) diff --git a/hw/acpi/aml-build.c b/hw/acpi

[SeaBIOS] [Qemu-devel] [PATCH v4 for-2.3 21/25] hw/pci: inform bios if the system has more than one pci bridge

2015-03-08 Thread Marcel Apfelbaum
From: Marcel Apfelbaum marce...@redhat.com The bios looks for 'etc/extra-pci-roots' to decide if is going to scan further buses after bus 0 tree. Signed-off-by: Marcel Apfelbaum mar...@redhat.com --- hw/i386/pc.c | 13 + 1 file changed, 13 insertions(+) diff --git a/hw/i386/pc.c b

[SeaBIOS] [Qemu-devel] [PATCH v4 for-2.3 00/25] hw/pc: implement multiple primary busses for pc machines

2015-03-08 Thread Marcel Apfelbaum
exist patch 20 handles the actual implementation of the PXB devices patch 21-22 enables the device patch 23 implements PXB map_irq function, (can be squashed into the actual PXB) patch 24-25 adds NUMA support Marcel Apfelbaum (25): acpi: fix aml_equal term implementation acpi: add aml_or() term

[SeaBIOS] [Qemu-devel] [PATCH v4 for-2.3 02/25] acpi: add aml_or() term

2015-03-08 Thread Marcel Apfelbaum
Add encoding for ACPI DefOr Opcode. Reviewed-by: Igor Mammedov imamm...@redhat.com Signed-off-by: Marcel Apfelbaum mar...@redhat.com --- hw/acpi/aml-build.c | 10 ++ include/hw/acpi/aml-build.h | 1 + 2 files changed, 11 insertions(+) diff --git a/hw/acpi/aml-build.c b/hw/acpi

[SeaBIOS] [Qemu-devel] [PATCH v4 for-2.3 07/25] acpi: add aml_shiftright() term

2015-03-08 Thread Marcel Apfelbaum
Add encoding for ACPI DefShiftRight Opcode. Reviewed-by: Igor Mammedov imamm...@redhat.com Signed-off-by: Marcel Apfelbaum mar...@redhat.com --- hw/acpi/aml-build.c | 10 ++ include/hw/acpi/aml-build.h | 1 + 2 files changed, 11 insertions(+) diff --git a/hw/acpi/aml-build.c b

[SeaBIOS] [Qemu-devel] [PATCH v4 for-2.3 05/25] acpi: add aml_index() term

2015-03-08 Thread Marcel Apfelbaum
Add encoding for ACPI DefIndex Opcode. Signed-off-by: Marcel Apfelbaum mar...@redhat.com --- hw/acpi/aml-build.c | 13 + include/hw/acpi/aml-build.h | 1 + 2 files changed, 14 insertions(+) diff --git a/hw/acpi/aml-build.c b/hw/acpi/aml-build.c index 49ba8c1..b3372df 100644

[SeaBIOS] [Qemu-devel] [PATCH v4 for-2.3 01/25] acpi: fix aml_equal term implementation

2015-03-08 Thread Marcel Apfelbaum
The DefLEqual op does not have a target operand. Remove it. Signed-off-by: Marcel Apfelbaum mar...@redhat.com --- hw/acpi/aml-build.c | 1 - 1 file changed, 1 deletion(-) diff --git a/hw/acpi/aml-build.c b/hw/acpi/aml-build.c index 876cada..0d14561 100644 --- a/hw/acpi/aml-build.c +++ b/hw/acpi

[SeaBIOS] [Qemu-devel] [PATCH v4 for-2.3 03/25] acpi: add aml_add() term

2015-03-08 Thread Marcel Apfelbaum
Add encoding for ACPI DefAdd Opcode. Reviewed-by: Igor Mammedov imamm...@redhat.com Signed-off-by: Marcel Apfelbaum mar...@redhat.com --- hw/acpi/aml-build.c | 10 ++ include/hw/acpi/aml-build.h | 1 + 2 files changed, 11 insertions(+) diff --git a/hw/acpi/aml-build.c b/hw/acpi

[SeaBIOS] [Qemu-devel] [PATCH v4 for-2.3 14/25] hw/pci: move pci bus related code to separate files

2015-03-08 Thread Marcel Apfelbaum
This refactoring moves all the code needed (recursively) to register TYPE_PCI_BUS type to a new file hw/pci/pci_bus.c . This allows to properly add new functionality to the pci bus class. Signed-off-by: Marcel Apfelbaum mar...@redhat.com --- arch_init.c | 1 + hw/alpha/typhoon.c

Re: [SeaBIOS] [Qemu-devel] [PATCH v3 for-2.3 10/24] hw/apci: add _PRT method for extra PCI root busses

2015-03-08 Thread Marcel Apfelbaum
On 03/08/2015 12:46 PM, Michael S. Tsirkin wrote: On Thu, Mar 05, 2015 at 04:55:08PM +0200, Marcel Apfelbaum wrote: Signed-off-by: Marcel Apfelbaum mar...@redhat.com some ideas for cleaning this up. there's more here btw. --- hw/i386/acpi-build.c | 78

[SeaBIOS] [Qemu-devel] [PATCH v4 for-2.3 22/25] hw/pci: piix - suport multiple host bridges

2015-03-08 Thread Marcel Apfelbaum
From: Marcel Apfelbaum marce...@redhat.com Instead of assuming it has only one bus, it enumerates all the host bridges until it finds the one with bus number corresponding with the config register. Signed-off-by: Marcel Apfelbaum mar...@redhat.com --- hw/pci-host/piix.c | 57

[SeaBIOS] [Qemu-devel] [PATCH v4 for-2.3 12/25] hw/acpi: add _CRS method for extra root busses

2015-03-08 Thread Marcel Apfelbaum
Save the IO/mem/bus numbers ranges assigned to the extra root busses to be removed from the root bus 0 range. Signed-off-by: Marcel Apfelbaum mar...@redhat.com --- hw/i386/acpi-build.c | 149 +++ 1 file changed, 149 insertions(+) diff --git a/hw

[SeaBIOS] [Qemu-devel] [PATCH v4 for-2.3 16/25] hw/pci: made pci_bus_num a PCIBusClass method

2015-03-08 Thread Marcel Apfelbaum
From: Marcel Apfelbaum marce...@redhat.com Refactoring it as a method of PCIBusClass will allow different implementations for subclasses. Signed-off-by: Marcel Apfelbaum mar...@redhat.com --- hw/i386/kvm/pci-assign.c | 1 + hw/pci/pci.c | 7 --- hw/pci/pci_bus.c | 10

[SeaBIOS] [Qemu-devel] [PATCH v4 for-2.3 19/25] hw/pci: implement iteration over multiple host bridges

2015-03-08 Thread Marcel Apfelbaum
From: Marcel Apfelbaum marce...@redhat.com Signed-off-by: Marcel Apfelbaum mar...@redhat.com --- hw/pci/pci.c | 8 include/hw/pci/pci_host.h | 4 2 files changed, 8 insertions(+), 4 deletions(-) diff --git a/hw/pci/pci.c b/hw/pci/pci.c index 53598bd..f0cf752 100644

[SeaBIOS] [Qemu-devel] [PATCH v4 for-2.3 04/25] acpi: add aml_lless() term

2015-03-08 Thread Marcel Apfelbaum
Add encoding for ACPI DefLLess Opcode. Reviewed-by: Igor Mammedov imamm...@redhat.com Signed-off-by: Marcel Apfelbaum mar...@redhat.com --- hw/acpi/aml-build.c | 9 + include/hw/acpi/aml-build.h | 1 + 2 files changed, 10 insertions(+) diff --git a/hw/acpi/aml-build.c b/hw/acpi

[SeaBIOS] [Qemu-devel] [PATCH v4 for-2.3 18/25] hw/pci: removed 'rootbus nr is 0' assumption from qmp_pci_query

2015-03-08 Thread Marcel Apfelbaum
From: Marcel Apfelbaum marce...@redhat.com Use the newer pci_bus_num to correctly get the root bus number. Signed-off-by: Marcel Apfelbaum mar...@redhat.com --- hw/pci/pci.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/hw/pci/pci.c b/hw/pci/pci.c index e386f2c..53598bd

Re: [SeaBIOS] [Qemu-devel] [PATCH v3 for-2.3 10/24] hw/apci: add _PRT method for extra PCI root busses

2015-03-08 Thread Marcel Apfelbaum
On 03/08/2015 04:47 PM, Michael S. Tsirkin wrote: On Sun, Mar 08, 2015 at 01:04:07PM +0200, Marcel Apfelbaum wrote: On 03/08/2015 12:46 PM, Michael S. Tsirkin wrote: On Thu, Mar 05, 2015 at 04:55:08PM +0200, Marcel Apfelbaum wrote: Signed-off-by: Marcel Apfelbaum mar...@redhat.com some

Re: [SeaBIOS] [Qemu-devel] [PATCH v3 for-2.3 10/24] hw/apci: add _PRT method for extra PCI root busses

2015-03-08 Thread Marcel Apfelbaum
On 03/08/2015 05:27 PM, Michael S. Tsirkin wrote: On Sun, Mar 08, 2015 at 05:22:43PM +0200, Marcel Apfelbaum wrote: On 03/08/2015 04:47 PM, Michael S. Tsirkin wrote: On Sun, Mar 08, 2015 at 01:04:07PM +0200, Marcel Apfelbaum wrote: On 03/08/2015 12:46 PM, Michael S. Tsirkin wrote: On Thu

Re: [SeaBIOS] [Qemu-devel] [PATCH v3 for-2.3 04/24] acpi: add aml_index() term

2015-03-06 Thread Marcel Apfelbaum
On 03/06/2015 12:40 PM, Igor Mammedov wrote: On Thu, 5 Mar 2015 16:55:02 +0200 Marcel Apfelbaum mar...@redhat.com wrote: Add encoding for ACPI DefIndex Opcode. Signed-off-by: Marcel Apfelbaum mar...@redhat.com --- hw/acpi/aml-build.c | 10 ++ include/hw/acpi/aml-build.h

Re: [SeaBIOS] [Qemu-devel] [PATCH v3 for-2.3 10/24] hw/apci: add _PRT method for extra PCI root busses

2015-03-05 Thread Marcel Apfelbaum
On 03/05/2015 09:52 PM, Michael S. Tsirkin wrote: On Thu, Mar 05, 2015 at 04:55:08PM +0200, Marcel Apfelbaum wrote: Signed-off-by: Marcel Apfelbaum mar...@redhat.com --- hw/i386/acpi-build.c | 78 1 file changed, 78 insertions(+) diff

[SeaBIOS] [Qemu-devel] [PATCH v3 for-2.3 15/24] hw/pci: made pci_bus_num a PCIBusClass method

2015-03-05 Thread Marcel Apfelbaum
From: Marcel Apfelbaum marce...@redhat.com Refactoring it as a method of PCIBusClass will allow different implementations for subclasses. Signed-off-by: Marcel Apfelbaum mar...@redhat.com --- hw/i386/kvm/pci-assign.c | 1 + hw/pci/pci.c | 7 --- hw/pci/pci_bus.c | 10

[SeaBIOS] [Qemu-devel] [PATCH v3 for-2.3 16/24] hw/pci: introduce TYPE_PCI_MAIN_HOST_BRIDGE interface

2015-03-05 Thread Marcel Apfelbaum
From: Marcel Apfelbaum marce...@redhat.com This is a marker interface used to differentiate the default host bridge on a system with multiple host bridges. This differentiation is required only for pc machines for now by the ACPI subsystem. Signed-off-by: Marcel Apfelbaum mar...@redhat.com

[SeaBIOS] [Qemu-devel] [PATCH v3 for-2.3 19/24] hw/pci: introduce PCI Expander Bridge (PXB)

2015-03-05 Thread Marcel Apfelbaum
From: Marcel Apfelbaum marce...@redhat.com PXB is a light-weight host bridge whose purpose is to enable the main host bridge to support multiple PCI root buses. As oposed to PCI-2-PCI bridge's secondary bus, PXB's bus is a primary bus and can be associated with a NUMA node (different from

[SeaBIOS] [Qemu-devel] [PATCH v3 for-2.3 12/24] hw/acpi: remove from root bus 0 the crs resources used by other busses.

2015-03-05 Thread Marcel Apfelbaum
If multiple root busses are used, root bus 0 cannot use all the pci holes ranges. Remove the IO/mem ranges used by the other primary busses. Signed-off-by: Marcel Apfelbaum mar...@redhat.com --- hw/i386/acpi-build.c | 84 1 file changed, 72

[SeaBIOS] [Qemu-devel] [PATCH v3 for-2.3 24/24] hw/pxb: add numa_node parameter

2015-03-05 Thread Marcel Apfelbaum
The pxb can be attach to and existing numa node by specifying numa_node option that equals the desired numa nodeid. Signed-off-by: Marcel Apfelbaum mar...@redhat.com --- hw/i386/acpi-build.c| 12 hw/pci-bridge/pci_expander_bridge.c | 17 + 2 files

[SeaBIOS] [Qemu-devel] [PATCH v3 for-2.3 14/24] hw/pci: made pci_bus_is_root a PCIBusClass method

2015-03-05 Thread Marcel Apfelbaum
From: Marcel Apfelbaum marce...@redhat.com Refactoring it as a method of PCIBusClass will allow different implementations for subclasses. Removed the assumption that the root bus does not have a parent device because is specific only to the default class implementation. Signed-off-by: Marcel

[SeaBIOS] [Qemu-devel] [PATCH v3 for-2.3 13/24] hw/pci: move pci bus related code to separate files

2015-03-05 Thread Marcel Apfelbaum
This refactoring moves all the code needed (recursively) to register TYPE_PCI_BUS type to a new file hw/pci/pci_bus.c . This allows to properly add new functionality to the pci bus class. Signed-off-by: Marcel Apfelbaum mar...@redhat.com --- arch_init.c | 1 + hw/alpha/typhoon.c

[SeaBIOS] [Qemu-devel] [PATCH v3 for-2.3 11/24] hw/acpi: add _CRS method for extra root busses

2015-03-05 Thread Marcel Apfelbaum
Save the IO/mem/bus numbers ranges assigned to the extra root busses to be removed from the root bus 0 range. Signed-off-by: Marcel Apfelbaum mar...@redhat.com --- hw/i386/acpi-build.c | 149 +++ 1 file changed, 149 insertions(+) diff --git a/hw

[SeaBIOS] [Qemu-devel] [PATCH v3 for-2.3 18/24] hw/pci: implement iteration over multiple host bridges

2015-03-05 Thread Marcel Apfelbaum
From: Marcel Apfelbaum marce...@redhat.com Signed-off-by: Marcel Apfelbaum mar...@redhat.com --- hw/pci/pci.c | 8 include/hw/pci/pci_host.h | 4 2 files changed, 8 insertions(+), 4 deletions(-) diff --git a/hw/pci/pci.c b/hw/pci/pci.c index 53598bd..f0cf752 100644

[SeaBIOS] [Qemu-devel] [PATCH v3 for-2.3 10/24] hw/apci: add _PRT method for extra PCI root busses

2015-03-05 Thread Marcel Apfelbaum
Signed-off-by: Marcel Apfelbaum mar...@redhat.com --- hw/i386/acpi-build.c | 78 1 file changed, 78 insertions(+) diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c index e5709e8..f0401d2 100644 --- a/hw/i386/acpi-build.c +++ b/hw/i386

[SeaBIOS] [Qemu-devel] [PATCH v3 for-2.3 17/24] hw/pci: removed 'rootbus nr is 0' assumption from qmp_pci_query

2015-03-05 Thread Marcel Apfelbaum
From: Marcel Apfelbaum marce...@redhat.com Use the newer pci_bus_num to correctly get the root bus number. Signed-off-by: Marcel Apfelbaum mar...@redhat.com --- hw/pci/pci.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/hw/pci/pci.c b/hw/pci/pci.c index e386f2c..53598bd

[SeaBIOS] [Qemu-devel] [PATCH v3 for-2.3 08/24] acpi: add aml_while() term

2015-03-05 Thread Marcel Apfelbaum
Add encoding for ACPI DefWhile Opcode. Signed-off-by: Marcel Apfelbaum mar...@redhat.com --- hw/acpi/aml-build.c | 8 include/hw/acpi/aml-build.h | 1 + 2 files changed, 9 insertions(+) diff --git a/hw/acpi/aml-build.c b/hw/acpi/aml-build.c index 86b2ddc..eb53d90 100644

[SeaBIOS] [Qemu-devel] [PATCH v3 for-2.3 20/24] hw/pci: inform bios if the system has more than one pci bridge

2015-03-05 Thread Marcel Apfelbaum
From: Marcel Apfelbaum marce...@redhat.com The bios looks for 'etc/extra-pci-roots' to decide if is going to scan further buses after bus 0 tree. Signed-off-by: Marcel Apfelbaum mar...@redhat.com --- hw/i386/pc.c | 13 + 1 file changed, 13 insertions(+) diff --git a/hw/i386/pc.c b

[SeaBIOS] [Qemu-devel] [PATCH v3 for-2.3 07/24] acpi: add aml_increment() term

2015-03-05 Thread Marcel Apfelbaum
Add encoding for ACPI DefIncrement Opcode. Signed-off-by: Marcel Apfelbaum mar...@redhat.com --- hw/acpi/aml-build.c | 8 include/hw/acpi/aml-build.h | 1 + 2 files changed, 9 insertions(+) diff --git a/hw/acpi/aml-build.c b/hw/acpi/aml-build.c index 45c1eb1..86b2ddc 100644

[SeaBIOS] [Qemu-devel] [PATCH v3 for-2.3 22/24] hw/pxb: add map_irq func

2015-03-05 Thread Marcel Apfelbaum
The bios does not index the pxb slot number when it computes the IRQ because it resides on bus 0 and not on the current bus. However Qemu routes the irq through bus 0 and adds the pxb slot to the IRQ computation. Synchronize between bios and Qemu by canceling pxb's effect. Signed-off-by: Marcel

[SeaBIOS] [Qemu-devel] [PATCH v3 for-2.3 01/24] acpi: add aml_or() term

2015-03-05 Thread Marcel Apfelbaum
Add encoding for ACPI DefOr Opcode. Signed-off-by: Marcel Apfelbaum mar...@redhat.com --- hw/acpi/aml-build.c | 10 ++ include/hw/acpi/aml-build.h | 1 + 2 files changed, 11 insertions(+) diff --git a/hw/acpi/aml-build.c b/hw/acpi/aml-build.c index 876cada..a31f88e 100644

[SeaBIOS] [Qemu-devel] [PATCH v3 for-2.3 00/24] hw/pc: implement multiple primary busses for pc machines

2015-03-05 Thread Marcel Apfelbaum
one primary bus can exist patch 19 handles the actual implementation of the PXB devices patch 20-21 enables the device patch 22 implements PXB map_irq function, (can be squashed into the actual PXB) patch 23-24 adds NUMA support Marcel Apfelbaum (24): acpi: add aml_or() term acpi: add aml_add

[SeaBIOS] [Qemu-devel] [PATCH v3 for-2.3 05/24] acpi: add aml_shiftleft() term

2015-03-05 Thread Marcel Apfelbaum
Add encoding for ACPI DefShiftLeft Opcode. Signed-off-by: Marcel Apfelbaum mar...@redhat.com --- hw/acpi/aml-build.c | 10 ++ include/hw/acpi/aml-build.h | 1 + 2 files changed, 11 insertions(+) diff --git a/hw/acpi/aml-build.c b/hw/acpi/aml-build.c index 0b3fcda..ac27b40

[SeaBIOS] [Qemu-devel] [PATCH v3 for-2.3 04/24] acpi: add aml_index() term

2015-03-05 Thread Marcel Apfelbaum
Add encoding for ACPI DefIndex Opcode. Signed-off-by: Marcel Apfelbaum mar...@redhat.com --- hw/acpi/aml-build.c | 10 ++ include/hw/acpi/aml-build.h | 1 + 2 files changed, 11 insertions(+) diff --git a/hw/acpi/aml-build.c b/hw/acpi/aml-build.c index 611c949..0b3fcda 100644

[SeaBIOS] [Qemu-devel] [PATCH v3 for-2.3 02/24] acpi: add aml_add() term

2015-03-05 Thread Marcel Apfelbaum
Add encoding for ACPI DefAdd Opcode. Signed-off-by: Marcel Apfelbaum mar...@redhat.com --- hw/acpi/aml-build.c | 10 ++ include/hw/acpi/aml-build.h | 1 + 2 files changed, 11 insertions(+) diff --git a/hw/acpi/aml-build.c b/hw/acpi/aml-build.c index a31f88e..38b82a4 100644

[SeaBIOS] [Qemu-devel] [PATCH v3 for-2.3 03/24] acpi: add aml_lless() term

2015-03-05 Thread Marcel Apfelbaum
Add encoding for ACPI DefLLess Opcode. Signed-off-by: Marcel Apfelbaum mar...@redhat.com --- hw/acpi/aml-build.c | 9 + include/hw/acpi/aml-build.h | 1 + 2 files changed, 10 insertions(+) diff --git a/hw/acpi/aml-build.c b/hw/acpi/aml-build.c index 38b82a4..611c949 100644

[SeaBIOS] [Qemu-devel] [PATCH v3 for-2.3 06/24] acpi: add aml_shiftright() term

2015-03-05 Thread Marcel Apfelbaum
Add encoding for ACPI DefShiftRight Opcode. Signed-off-by: Marcel Apfelbaum mar...@redhat.com --- hw/acpi/aml-build.c | 10 ++ include/hw/acpi/aml-build.h | 1 + 2 files changed, 11 insertions(+) diff --git a/hw/acpi/aml-build.c b/hw/acpi/aml-build.c index ac27b40..45c1eb1

[SeaBIOS] [Qemu-devel] [PATCH v3 for-2.3 09/24] hw/acpi: add support for multiple root busses

2015-03-05 Thread Marcel Apfelbaum
If the machine has several root busses, we need to add them to acpi in order to be properly detected by guests. Signed-off-by: Marcel Apfelbaum mar...@redhat.com --- hw/i386/acpi-build.c | 32 1 file changed, 32 insertions(+) diff --git a/hw/i386/acpi-build.c b

Re: [SeaBIOS] [PATCH V3 0/2] fw/pci: better support for multiple host bridges

2015-02-25 Thread Marcel Apfelbaum
On 02/24/2015 07:34 PM, Kevin O'Connor wrote: On Mon, Feb 16, 2015 at 07:29:18PM +0200, Marcel Apfelbaum wrote: The series is developed together with QEMU's: [Qemu-devel] [PATCH RFC 00/17] implement multiple primary busses for pc machines http://lists.gnu.org/archive/html/qemu-ppc

[SeaBIOS] [PATCH V3 2/2] fw/pci: map memory and IO regions for multiple pci root buses

2015-02-16 Thread Marcel Apfelbaum
For resource sizing and mapping purposes treat devices on extra root buses as if they are on the default root bus (bus 0). Signed-off-by: Kevin O'Connor ke...@koconnor.net Signed-off-by: Marcel Apfelbaum mar...@redhat.com --- src/fw/pciinit.c | 10 ++ 1 file changed, 10 insertions

[SeaBIOS] [PATCH V3 0/2] fw/pci: better support for multiple host bridges

2015-02-16 Thread Marcel Apfelbaum
scans all the bus range to find the extra root buses. Second patch extends memory and IO mapping for found buses. Marcel Apfelbaum (2): fw/pci: scan all buses if extraroots romfile is present fw/pci: map memory and IO regions for multiple pci root buses src/fw/pciinit.c | 19

[SeaBIOS] [PATCH V3 1/2] fw/pci: scan all buses if extraroots romfile is present

2015-02-16 Thread Marcel Apfelbaum
From: Marcel Apfelbaum marce...@redhat.com If there are extra primary root buses, scanning the bus's 0 subtree is not enough. Scan all the range. Signed-off-by: Marcel Apfelbaum mar...@redhat.com --- src/fw/pciinit.c | 9 + 1 file changed, 9 insertions(+) diff --git a/src/fw/pciinit.c

Re: [SeaBIOS] [PATCH V2 2/2] fw/pci: map memory and IO regions for multiple pci root buses

2015-02-16 Thread Marcel Apfelbaum
On 02/16/2015 04:55 PM, Kevin O'Connor wrote: On Mon, Feb 16, 2015 at 11:31:03AM +0200, Marcel Apfelbaum wrote: For resource sizing and mapping purposes treat devices on extra root buses as if they are on the default root bus (bus 0). Hi Kevin, Thank you for the review. Remind me - did you

Re: [SeaBIOS] [PATCH V2 2/2] fw/pci: map memory and IO regions for multiple pci root buses

2015-02-16 Thread Marcel Apfelbaum
On 02/16/2015 06:36 PM, Kevin O'Connor wrote: On Mon, Feb 16, 2015 at 06:14:57PM +0200, Marcel Apfelbaum wrote: On 02/16/2015 06:07 PM, Kevin O'Connor wrote: On Mon, Feb 16, 2015 at 05:43:31PM +0200, Marcel Apfelbaum wrote: On 02/16/2015 04:55 PM, Kevin O'Connor wrote: On Mon, Feb 16, 2015

Re: [SeaBIOS] [PATCH V2 2/2] fw/pci: map memory and IO regions for multiple pci root buses

2015-02-16 Thread Marcel Apfelbaum
On 02/16/2015 06:07 PM, Kevin O'Connor wrote: On Mon, Feb 16, 2015 at 05:43:31PM +0200, Marcel Apfelbaum wrote: On 02/16/2015 04:55 PM, Kevin O'Connor wrote: On Mon, Feb 16, 2015 at 11:31:03AM +0200, Marcel Apfelbaum wrote: For resource sizing and mapping purposes treat devices on extra root

Re: [SeaBIOS] [Qemu-devel] [PATCH RFC V2 12/17] hw/pci: introduce PCI Expander Bridge (PXB)

2015-02-16 Thread Marcel Apfelbaum
On 02/16/2015 02:58 PM, Alexander Graf wrote: On 16.02.15 10:54, Marcel Apfelbaum wrote: From: Marcel Apfelbaum marce...@redhat.com PXB is a light-weight host bridge whose purpose is to enable the main host bridge to support multiple PCI root buses. As oposed to PCI-2-PCI bridge's secondary

Re: [SeaBIOS] [Qemu-devel] [PATCH RFC V2 14/17] hw/pci: piix - suport multiple host bridges

2015-02-16 Thread Marcel Apfelbaum
On 02/16/2015 03:00 PM, Alexander Graf wrote: On 16.02.15 10:54, Marcel Apfelbaum wrote: From: Marcel Apfelbaum marce...@redhat.com Instead of assuming it has only one bus, it enumerates all the host bridges until it finds the one with bus number corresponding with the config register

<    1   2   3   >