Re: [SeaBIOS] [PATCH] block: add NVMe boot support

Kevin, On Jan 21, 2017 09:32, Kevin O'Connor wrote: The copyright would need to say the file is licensed under the LGPLv3. Preference would be to use what the other files have: // This file may be distributed under the terms of the GNU LGPLv3 license. I'll post an updated

Re: [SeaBIOS] [PATCH] block: add NVMe boot support

On Tue, 2017-01-24 at 12:26 -0500, Kevin O'Connor wrote: > Thanks.  See my comments below.  Mostly minor things I noticed. Thanks for looking into this. It'll take me a couple of days to post a new patch, because I'm currently traveling. Expect a new patch next week. Btw, some of the issues you

Re: [SeaBIOS] [PATCH 1/5] nvme: support NVMe 1.0 controllers

Hey Daniel, thanks for the bugfixes! Much appreciated. They all look good to me. On Thu, 2017-02-23 at 23:27 -0700, Daniel Verkamp wrote: > Rather than using the Identify command with CNS 01b (GET_NS_LIST), > which > was added in NVMe 1.1, we can just enumerate all of the possible > namespace

Re: [SeaBIOS] [PATCH 1/2] nvme: add option to toggle probing only boot devices

On Fri, 2018-07-06 at 11:37 +0200, Paul Menzel wrote: > Thank you for the patch. Would it be better to make that a > run-time option? Can you elaborate? As long as there is a mechanism to limit the number of NVMe controllers probed, I'm happy to take any feedback here. Regards, Julian Amazon