[SeaBIOS] Re: [PATCH] timer: Configure timer1 to a standard settings

2022-08-05 Thread Kevin O'Connor
On Wed, Jul 13, 2022 at 03:25:17AM +0200, Petr Cvek wrote: > ASPI2DOS.SYS and KEYB.COM from Win 98 SE installation CD (and most likely > other DOS versions too) depend on I/O port 0x61 bit 4 to be toggled. This > requires timer 1 (I/O 0x41, legacy DRAM refresh) to be correctly set. > Also Intel

[SeaBIOS] Re: [PATCH] floppy: Support CMOS setting outside QEMU

2022-08-05 Thread Kevin O'Connor
On Wed, Jul 13, 2022 at 03:24:49AM +0200, Petr Cvek wrote: > SeaBIOS can be used for booting legacy OS and also Linux is still using > CMOS address 0x10 to configure floppy controller. Under these assumptions > it makes sense to allow boot from CMOS defined floppy drives. There was never really a

[SeaBIOS] Re: [PATCH] virtio-blk: use larger default request size

2022-07-07 Thread Kevin O'Connor
On Thu, Jul 07, 2022 at 12:06:16PM +0200, Gerd Hoffmann wrote: > Bump default from 8 to 64 blocks. Using 8 by default leads > to requests being splitted on qemu, which slows down boot. > > Some (temporary) debug logging added showed that almost all > requests on a standard fedora install are

[SeaBIOS] Re: [PATCH 3/3] handle_13: Only terminate El Torito disk emulation when active

2022-06-02 Thread Kevin O'Connor
On Fri, May 20, 2022 at 03:19:03PM +, Lev Kujawski wrote: > In accord with the El Torito specification[1], SeaBIOS now signals > failure (AH=1 and CF) whenever attempts are made to terminate disk > emulation (0x4B) for non-emulated drives. The prior behavior of always > returning success

[SeaBIOS] Re: [PATCH 1/3] handle_1591: [INT15/AH=91h] Always set AH=0 and clear CF

2022-06-02 Thread Kevin O'Connor
On Fri, May 20, 2022 at 03:19:01PM +, Lev Kujawski wrote: > References: > R. Brown, "INT 15 - OS HOOK - DEVICE POST (AT,PS)", in > The x86 Interrupt List. https://www.cs.cmu.edu/~ralf/files.html > [Updated: 2018-02-28]. > > F. v. Gilluwe, The Undocumented PC. Boston, MA:

[SeaBIOS] Re: [PATCH v4 0/2] use large ZoneHigh when there is enough memory

2022-04-27 Thread Kevin O'Connor
On Wed, Apr 27, 2022 at 09:22:02AM +0200, Gerd Hoffmann wrote: > v4: > - make calculations more robust. > > v3: > - check size instead of end address. The series looks good to me. -Kevin ___ SeaBIOS mailing list -- seabios@seabios.org To unsubscribe

[SeaBIOS] Re: [PATCH v3 2/2] malloc: use large ZoneHigh when there is enough memory

2022-04-27 Thread Kevin O'Connor
On Wed, Apr 27, 2022 at 08:26:35AM +0200, Gerd Hoffmann wrote: > > > if (!highram_start) { > > > +if (e - s > BUILD_MAX_HIGHTABLE * 16) > > > +highram_size = BUILD_MAX_HIGHTABLE; > > > u32 newe = ALIGN_DOWN(e - highram_size, MALLOC_MIN_ALIGN); > >

[SeaBIOS] Re: [PATCH v3 2/2] malloc: use large ZoneHigh when there is enough memory

2022-04-26 Thread Kevin O'Connor
On Tue, Apr 26, 2022 at 10:56:42AM +0200, Gerd Hoffmann wrote: > In case there is enough memory installed use a large ZoneHigh. > > Signed-off-by: Gerd Hoffmann > --- > src/config.h | 3 ++- > src/malloc.c | 4 +++- > 2 files changed, 5 insertions(+), 2 deletions(-) > > diff --git

[SeaBIOS] Re: [PATCH v2 2/2] malloc: use large ZoneHigh when there is enough memory

2022-04-25 Thread Kevin O'Connor
On Mon, Apr 25, 2022 at 09:41:45AM +0200, Gerd Hoffmann wrote: > In case there is enough memory installed use a large ZoneHigh. > > Signed-off-by: Gerd Hoffmann > --- > src/config.h | 3 ++- > src/malloc.c | 4 +++- > 2 files changed, 5 insertions(+), 2 deletions(-) > > diff --git

[SeaBIOS] Re: Floppy setup

2022-04-25 Thread Kevin O'Connor
On Sun, Apr 24, 2022 at 07:29:56PM -0400, Keith Hui wrote: > (Looping in the SeaBIOS mailing list again.) > > See this: https://www.seabios.org/Runtime_config > > It appears CMOS locations are a legacy artifact and files within the > cbfs image (eg. etc/floppy0) is the preferred way of passing

[SeaBIOS] Re: [PATCH] memory: reserve more space for ZoneHigh

2022-04-22 Thread Kevin O'Connor
On Fri, Apr 22, 2022 at 01:55:56PM +0200, Gerd Hoffmann wrote: > Bump BUILD_MAX_HIGHTABLE from 256k to 1M to avoid running > out of memory with very large smbios tables. > > Signed-off-by: Gerd Hoffmann > --- > src/config.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git

[SeaBIOS] Re: [PATCH 0/2] improve ZoneHigh memory management

2022-04-21 Thread Kevin O'Connor
On Thu, Apr 21, 2022 at 11:33:24AM +0200, Gerd Hoffmann wrote: > When running out of memory get a chunk of memory from ZoneTmpHigh to > expand ZoneHigh. Drop simliar logic fro pmm code because it's not > needed ay more. > > This fixes some scalability problems, for example with lots of vcpus, >

[SeaBIOS] Re: [PATCH] MP: fix mptable interrupt source generation for pci devices

2022-04-19 Thread Kevin O'Connor
On Tue, Apr 19, 2022 at 11:46:59AM +0200, Gerd Hoffmann wrote: > > > diff --git a/src/fw/mptable.c b/src/fw/mptable.c > > > index 47385cc..3a7b02f 100644 > > > --- a/src/fw/mptable.c > > > +++ b/src/fw/mptable.c > > > > If you look at the top of that file you'll see the notice: > > > > // DO NOT

[SeaBIOS] Re: [PATCH] MP: fix mptable interrupt source generation for pci devices

2022-04-15 Thread Kevin O'Connor
On Fri, Apr 15, 2022 at 04:33:34PM +0530, Jay Khandkar wrote: > Set the correct IOAPIC INTIN pin number for pci bus interrupt > sources during MP spec table generation (on emulators). Currently, > the pin number is set to the interrupt line field in the device's > configuration space, which is set

[SeaBIOS] Re: [PATCH v3 0/2] Fix reset issue with QEMU -machine q35

2022-04-04 Thread Kevin O'Connor
On Sat, Apr 02, 2022 at 08:24:41PM +0200, Volker Rümelin wrote: > This reset issue was reported on the QEMU issue tracker at > https://gitlab.com/qemu-project/qemu/-/issues/766 > > A reset with QEMU -machine q35 -accel tcg leads to a reset loop > and with -machine q35 -accel kvm the reset only

[SeaBIOS] Re: [PATCH v2 2/2] reset: force standard PCI configuration access

2022-03-30 Thread Kevin O'Connor
On Sat, Mar 26, 2022 at 10:33:19AM +0100, Volker Rümelin wrote: > After a reset of a QEMU -machine q35 guest, the PCI Express > Enhanced Configuration Mechanism is disabled and the variable > mmconfig no longer matches the configuration register PCIEXBAR > of the Q35 chipset. Until the variable

[SeaBIOS] Re: [ANNOUNCE] SeaBIOS 1.16.0

2022-03-15 Thread Kevin O'Connor
On Tue, Mar 15, 2022 at 10:28:12AM +0300, Michael Tokarev wrote: > 02.03.2022 05:19, Kevin O'Connor rote: > > The 1.16.0 version of SeaBIOS has now been released. For more > > information on the release, please see: > > Hi Kevin! > This release seems to be missing at

[SeaBIOS] [ANNOUNCE] SeaBIOS 1.16.0

2022-03-01 Thread Kevin O'Connor
smbios_build_tables() arguments optional smbios: Make smbios_build_tables() ready for 64-bit tables smbios: copy_smbios_30() function smbios: Support SMBIOS 3.0 entry point at copy_table() smbios: Support SMBIOS 3.0 entry point at smbios_romfile_setup() Kevin O'Connor (13

[SeaBIOS] Next release

2022-02-23 Thread Kevin O'Connor
I'm currently planning to make a release early next week. This will be a v1.16.0 release. If anyone knows of any critical bugs or deficiencies with the current code, please let me know. -Kevin ___ SeaBIOS mailing list -- seabios@seabios.org To

[SeaBIOS] Re: [PATCH] nvme: fix LBA format data structure

2022-02-03 Thread Kevin O'Connor
On Sun, Jan 23, 2022 at 05:43:57PM +0100, Florian Larysch wrote: > The LBA Format Data structure is dword-sized, but struct nvme_lba_format > erroneously contains an additional member, misaligning all LBAF > descriptors after the first and causing them to be misinterpreted. > Remove it. Thanks.

[SeaBIOS] Re: [PATCH] nvme: fix LBA format data structure

2022-02-02 Thread Kevin O'Connor
On Wed, Feb 02, 2022 at 11:50:50AM +0100, Alexander Graf wrote: > > On 02.02.22 02:52, Kevin O'Connor wrote: > > On Tue, Feb 01, 2022 at 08:39:10PM +0100, Florian Larysch wrote: > > > On Thu, Jan 27, 2022 at 11:37:52AM -0500, Kevin O'Connor wrote: > > > > Thanks

[SeaBIOS] Re: [PATCH] nvme: fix LBA format data structure

2022-02-01 Thread Kevin O'Connor
On Tue, Feb 01, 2022 at 08:39:10PM +0100, Florian Larysch wrote: > On Thu, Jan 27, 2022 at 11:37:52AM -0500, Kevin O'Connor wrote: > > Thanks. I don't know enough about NVMe to review this patch though. > > Maybe Julian or Alex could comment? > > Happy to hear their comment

[SeaBIOS] Re: Cut 1.15.1 release?

2022-01-28 Thread Kevin O'Connor
On Fri, Jan 28, 2022 at 01:03:23PM +0100, Gerd Hoffmann wrote: > On Thu, Jan 27, 2022 at 05:43:32PM +0100, Paul Menzel wrote: > > Dear SeaBIOS folks, > > > > > > with the latest NVMe fixes, would it make sense to tag a 1.15.1 release? > > > > The 1.16.0 release is planned for end of February,

[SeaBIOS] Re: [PATCH] nvme: fix LBA format data structure

2022-01-27 Thread Kevin O'Connor
On Sun, Jan 23, 2022 at 05:43:57PM +0100, Florian Larysch wrote: > The LBA Format Data structure is dword-sized, but struct nvme_lba_format > erroneously contains an additional member, misaligning all LBAF > descriptors after the first and causing them to be misinterpreted. > Remove it. Thanks.

[SeaBIOS] Re: [PATCH] nvme: avoid use-after-free in nvme_controller_enable()

2022-01-27 Thread Kevin O'Connor
On Mon, Jan 24, 2022 at 10:20:53AM +0100, Jan Beulich via SeaBIOS wrote: > Commit b68f313c9139 ("nvme: Record maximum allowed request size") > introduced a use of "identify" past it being passed to free(). Latch the > value of interest into a local variable. > > Reported-by: Coverity (ID 1497613)

[SeaBIOS] Re: [PATCH] sercon: Fix missing GET_LOW() to access rx_bytes

2022-01-27 Thread Kevin O'Connor
On Fri, Jan 21, 2022 at 11:12:35AM -0500, Kevin O'Connor wrote: > The variable rx_bytes is marked VARLOW, but there was a missing > GET_LOW() to access rx_bytes. Fix by copying rx_bytes to a local > variable and avoid the repetitive segment memory accesses. > > Reported-by: Gabe

[SeaBIOS] Re: [PATCHv2 0/6] Rework NVME page transfers and avoid fsegment allocation

2022-01-27 Thread Kevin O'Connor
On Fri, Jan 21, 2022 at 11:48:42AM -0500, Kevin O'Connor wrote: > This is a resend of the previous series. Changes since last time: > > * Patch 1: Fix function comment on nvme_io_xfer() > * Patch 3-5: Added "goto bounce" to nvme_io_xfer() as suggested by Alex > * Patch

[SeaBIOS] Re: [PATCH 5/5] nvme: Build the page list in the existing dma buffer

2022-01-22 Thread Kevin O'Connor
On Fri, Jan 21, 2022 at 09:44:46PM +0100, Alexander Graf wrote: > On 21.01.22 17:54, Kevin O'Connor wrote: > > On Fri, Jan 21, 2022 at 05:41:17PM +0100, Alexander Graf wrote: > > > On 21.01.22 17:02, Kevin O'Connor wrote: > > > > On Fri, Jan 21, 2022 at 03:28:33

[SeaBIOS] Re: [PATCHv2 3/6] nvme: Convert nvme_build_prpl() to nvme_prpl_xfer()

2022-01-21 Thread Kevin O'Connor
On Fri, Jan 21, 2022 at 11:48:45AM -0500, Kevin O'Connor wrote: > Rename nvme_build_prpl() to nvme_prpl_xfer() and directly invoke > nvme_io_xfer() or nvme_bounce_xfer() from that function. > > Signed-off-by: Kevin O'Connor > --- > src/hw/nvme-int.h | 1 - > s

[SeaBIOS] Re: [PATCH 5/5] nvme: Build the page list in the existing dma buffer

2022-01-21 Thread Kevin O'Connor
On Fri, Jan 21, 2022 at 05:41:17PM +0100, Alexander Graf wrote: > On 21.01.22 17:02, Kevin O'Connor wrote: > > On Fri, Jan 21, 2022 at 03:28:33PM +0100, Alexander Graf wrote: > > > On 19.01.22 19:45, Kevin O'Connor wrote: > > > >if ((ns->block_si

[SeaBIOS] [PATCHv2 6/6] nvme: Only allocate one dma bounce buffer for all nvme drives

2022-01-21 Thread Kevin O'Connor
There is no need to create multiple dma bounce buffers as the BIOS disk code isn't reentrant capable. Also, verify that the allocation succeeds. Signed-off-by: Kevin O'Connor Reviewed-by: Alexander Graf --- src/hw/nvme-int.h | 3 --- src/hw/nvme.c | 21 +++-- 2 files

[SeaBIOS] [PATCHv2 5/6] nvme: Build the page list in the existing dma buffer

2022-01-21 Thread Kevin O'Connor
. This patch builds the PRP maintenance data in the existing "dma bounce buffer" and only builds it when needed. Fixes: 01f2736cc905d ("nvme: Pass large I/O requests as PRP lists") Reported-by: Matt DeVillier Signed-off-by: Alexander Graf Signed-off-by: Kevin O'Connor --- src

[SeaBIOS] [PATCHv2 4/6] nvme: Pass prp1 and prp2 directly to nvme_io_xfer()

2022-01-21 Thread Kevin O'Connor
When using a prp2 parameter, build it in nvme_prpl_xfer() and pass it directly to nvme_io_xfer(). Signed-off-by: Kevin O'Connor Reviewed-by: Alexander Graf --- src/hw/nvme.c | 39 ++- 1 file changed, 18 insertions(+), 21 deletions(-) diff --git a/src/hw

[SeaBIOS] [PATCHv2 3/6] nvme: Convert nvme_build_prpl() to nvme_prpl_xfer()

2022-01-21 Thread Kevin O'Connor
Rename nvme_build_prpl() to nvme_prpl_xfer() and directly invoke nvme_io_xfer() or nvme_bounce_xfer() from that function. Signed-off-by: Kevin O'Connor --- src/hw/nvme-int.h | 1 - src/hw/nvme.c | 46 -- 2 files changed, 20 insertions(+), 27

[SeaBIOS] [PATCHv2 2/6] nvme: Add nvme_bounce_xfer() helper function

2022-01-21 Thread Kevin O'Connor
Move bounce buffer processing to a new helper function. Signed-off-by: Kevin O'Connor Reviewed-by: Alexander Graf --- src/hw/nvme.c | 35 +-- 1 file changed, 21 insertions(+), 14 deletions(-) diff --git a/src/hw/nvme.c b/src/hw/nvme.c index 608651a..d656e9b

[SeaBIOS] [PATCHv2 1/6] nvme: Rework nvme_io_readwrite() to return -1 on error

2022-01-21 Thread Kevin O'Connor
Rename nvme_io_readwrite() to nvme_io_xfer() and change it so it implements the debugging dprintf() and it returns -1 on an error. Signed-off-by: Kevin O'Connor Reviewed-by: Alexander Graf --- src/hw/nvme.c | 37 ++--- 1 file changed, 18 insertions(+), 19

[SeaBIOS] [PATCHv2 0/6] Rework NVME page transfers and avoid fsegment allocation

2022-01-21 Thread Kevin O'Connor
checking for malloc failure -Kevin Kevin O'Connor (6): nvme: Rework nvme_io_readwrite() to return -1 on error nvme: Add nvme_bounce_xfer() helper function nvme: Convert nvme_build_prpl() to nvme_prpl_xfer() nvme: Pass prp1 and prp2 directly to nvme_io_xfer() nvme: Build the page list

[SeaBIOS] [PATCH] sercon: Fix missing GET_LOW() to access rx_bytes

2022-01-21 Thread Kevin O'Connor
The variable rx_bytes is marked VARLOW, but there was a missing GET_LOW() to access rx_bytes. Fix by copying rx_bytes to a local variable and avoid the repetitive segment memory accesses. Reported-by: Gabe Black Signed-off-by: Volker Rümelin Signed-off-by: Kevin O'Connor --- src/sercon.c

[SeaBIOS] Re: [PATCH] smm: Suppress gcc array-bounds warnings

2022-01-21 Thread Kevin O'Connor
On Thu, Jan 13, 2022 at 05:27:11PM +0100, Paul Menzel wrote: > Dear Kevin, > > > Am 13.01.22 um 17:19 schrieb Kevin O'Connor: > > Add a hack to suppress spurious gcc array-bounds warning. > > Wow, thank you for fixing it. Maybe elaborate a little, what version it >

[SeaBIOS] Re: [PATCH 5/5] nvme: Build the page list in the existing dma buffer

2022-01-21 Thread Kevin O'Connor
On Fri, Jan 21, 2022 at 03:28:33PM +0100, Alexander Graf wrote: > > On 19.01.22 19:45, Kevin O'Connor wrote: > > Commit 01f2736cc905d ("nvme: Pass large I/O requests as PRP lists") > > introduced multi-page requests using the NVMe PRP mechanism. To store the >

[SeaBIOS] Re: [PATCH] sercon: add missing GET_LOW() to access rx_bytes

2022-01-19 Thread Kevin O'Connor
On Wed, Jan 19, 2022 at 10:08:49PM +0100, Volker Rümelin wrote: > The variable rx_bytes is marked VARLOW. Add a missing GET_LOW() > to access rx_bytes. > > Reported-by: Gabe Black > Signed-off-by: Volker Rümelin Thanks. Good catch! I think we should fix this by copying the contents into a

[SeaBIOS] [PATCH] nvme: Only allocate one dma bounce buffer for all nvme drives

2022-01-19 Thread Kevin O'Connor
There is no need to create multiple dma bounce buffers as the BIOS disk code isn't reentrant capable. Signed-off-by: Kevin O'Connor --- This is a minor cleanup on top of the previous nvme code series. -Kevin --- src/hw/nvme-int.h | 3 --- src/hw/nvme.c | 14 +- 2 files

[SeaBIOS] [PATCH 5/5] nvme: Build the page list in the existing dma buffer

2022-01-19 Thread Kevin O'Connor
. This patch builds the PRP maintenance data in the existing "dma bounce buffer" and only builds it when needed. Fixes: 01f2736cc905d ("nvme: Pass large I/O requests as PRP lists") Reported-by: Matt DeVillier Signed-off-by: Alexander Graf Signed-off-by: Kevin O'Connor --

[SeaBIOS] [PATCH 4/5] nvme: Pass prp1 and prp2 directly to nvme_io_xfer()

2022-01-19 Thread Kevin O'Connor
When using a prp2 parameter, build it in nvme_prpl_xfer() and pass it directly to nvme_io_xfer(). Signed-off-by: Kevin O'Connor --- src/hw/nvme.c | 39 ++- 1 file changed, 18 insertions(+), 21 deletions(-) diff --git a/src/hw/nvme.c b/src/hw/nvme.c index

[SeaBIOS] [PATCH 3/5] nvme: Convert nvme_build_prpl() to nvme_prpl_xfer()

2022-01-19 Thread Kevin O'Connor
Rename nvme_build_prpl() to nvme_prpl_xfer() and directly invoke nvme_io_xfer() or nvme_bounce_xfer() from that function. Signed-off-by: Kevin O'Connor --- src/hw/nvme-int.h | 1 - src/hw/nvme.c | 42 -- 2 files changed, 16 insertions(+), 27

[SeaBIOS] [PATCH 2/5] nvme: Add nvme_bounce_xfer() helper function

2022-01-19 Thread Kevin O'Connor
Move bounce buffer processing to a new helper function. Signed-off-by: Kevin O'Connor --- src/hw/nvme.c | 35 +-- 1 file changed, 21 insertions(+), 14 deletions(-) diff --git a/src/hw/nvme.c b/src/hw/nvme.c index a97501b..fd7c1d0 100644 --- a/src/hw/nvme.c +++ b

[SeaBIOS] [PATCH 1/5] nvme: Rework nvme_io_readwrite() to return -1 on error

2022-01-19 Thread Kevin O'Connor
Rename nvme_io_readwrite() to nvme_io_xfer() and change it so it implements the debugging dprintf() and it returns -1 on an error. Signed-off-by: Kevin O'Connor --- src/hw/nvme.c | 34 +- 1 file changed, 17 insertions(+), 17 deletions(-) diff --git a/src/hw

[SeaBIOS] [PATCH 0/5] Rework NVME page transfers and avoid fsegment allocation

2022-01-19 Thread Kevin O'Connor
us -snapshot -L test -chardev stdio,id=seabios -device isa-debugcon,iobase=0x402,chardev=seabios -m 512 -drive file=dos-drivec,if=none,id=drive0 -device nvme,drive=drive0,serial=nvme-1 -boot menu=on Thanks, -Kevin Kevin O'Connor (5): nvme: Rework nvme_io_readwrite() to return -1 on error nvme:

[SeaBIOS] Re: new november release?

2022-01-13 Thread Kevin O'Connor
On Thu, Jan 13, 2022 at 11:56:35AM +0100, Gerd Hoffmann wrote: > Hi, > > > 2. Commit the smbios 3 changes (and pcie-pci-bridge changes) and > >release v1.15.0 in early January. > > I think all pending patches have been applied meanwhile. > So time to enter 1.15 freeze and release in ~2

[SeaBIOS] [PATCH] smm: Suppress gcc array-bounds warnings

2022-01-13 Thread Kevin O'Connor
Add a hack to suppress spurious gcc array-bounds warning. Signed-off-by: Kevin O'Connor --- src/fw/smm.c | 21 +++-- 1 file changed, 15 insertions(+), 6 deletions(-) diff --git a/src/fw/smm.c b/src/fw/smm.c index d90e43a..a0b50b2 100644 --- a/src/fw/smm.c +++ b/src/fw/smm.c

[SeaBIOS] Re: [PATCH 1/2] readserial: Improve Python3 compatibility

2021-12-27 Thread Kevin O'Connor
On Sun, Dec 19, 2021 at 09:45:59AM -0500, Kevin O'Connor wrote: > Signed-off-by: Kevin O'Connor > --- > scripts/readserial.py | 28 +++- > 1 file changed, 11 insertions(+), 17 deletions(-) > FYI, I committed this series (along with the two gcc warni

[SeaBIOS] [PATCH 2/2] scripts: Remove python23compat.py

2021-12-19 Thread Kevin O'Connor
It's simpler to use b"" designations around binary strings than to use the as_bytes() function. Signed-off-by: Kevin O'Connor --- scripts/buildrom.py | 6 ++ scripts/checkrom.py | 4 +--- scripts/python23compat.py | 14 -- 3 files changed, 3 inserti

[SeaBIOS] [PATCH 1/2] readserial: Improve Python3 compatibility

2021-12-19 Thread Kevin O'Connor
Signed-off-by: Kevin O'Connor --- scripts/readserial.py | 28 +++- 1 file changed, 11 insertions(+), 17 deletions(-) diff --git a/scripts/readserial.py b/scripts/readserial.py index a7383e8..e3f56e5 100755 --- a/scripts/readserial.py +++ b/scripts/readserial.py @@ -10,8

[SeaBIOS] Re: [PATCH] memmap: Fix gcc out-of-bounds warning

2021-12-18 Thread Kevin O'Connor
On Sat, Dec 18, 2021 at 09:13:57PM +0100, Paul Menzel wrote: > Dear Kevin, > > > Am 18.12.21 um 19:10 schrieb Kevin O'Connor: > > Use a different definition for the linker script symbol to avoid a gcc > > warning. > > What GCC version did you use, and which

[SeaBIOS] [PATCH] memmap: Fix gcc out-of-bounds warning

2021-12-18 Thread Kevin O'Connor
Use a different definition for the linker script symbol to avoid a gcc warning. Signed-off-by: Kevin O'Connor --- src/memmap.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/memmap.h b/src/memmap.h index 22bd4bc..32ca265 100644 --- a/src/memmap.h +++ b/src/memmap.h

[SeaBIOS] [PATCH] vgasrc: Don't use VAR16 in header files to fix gcc warning

2021-12-18 Thread Kevin O'Connor
Some versions of gcc complain when VAR16 is used in both the header and C files - use only in the C file to fix the warning. Signed-off-by: Kevin O'Connor --- vgasrc/svgamodes.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/vgasrc/svgamodes.h b/vgasrc/svgamodes.h index

[SeaBIOS] Re: [PATCH] svgamodes: add standard 4k modes

2021-12-18 Thread Kevin O'Connor
On Thu, Dec 16, 2021 at 08:20:58AM +0100, Gerd Hoffmann wrote: > Add all three 4k modes. Computer monitors typically use > the first one (3840x2160). > > Add 16 and 32 bpp variants. 24bpp is dead these days, and > software which is so old that still uses those modes most > likely doesn't even

[SeaBIOS] Re: [PATCH v4 0/3] virtio-blk: add feature VIRTIO_BLK_F_SIZE_MAX

2021-12-18 Thread Kevin O'Connor
On Tue, Dec 07, 2021 at 09:31:05AM +0800, Andy Pei wrote: > if driver reads data larger than VIRTIO_BLK_F_SIZE_MAX, it will cause > some issue to the DMA engine. > So add VIRTIO_BLK_F_SIZE_MAX feature support, when upper software > wants to read data larger than VIRTIO_BLK_F_SIZE_MAX, virtio-blk >

[SeaBIOS] Re: [PATCH v3 0/2] pci: reserve resources for pcie-pci-bridge to fix regressed hotplug on q35 with ACPI hotplug enabled

2021-12-18 Thread Kevin O'Connor
On Mon, Nov 29, 2021 at 06:48:10AM -0500, Igor Mammedov wrote: > Since QEMU-6.1, Q35 machine is using ACPI PCI hotplug by default. > However SeaBIOS did not take in account pcie-pci-bridge and treated it > as any other PCIe device which is not correct in the case of the bridge. > > Patch [1/2]

[SeaBIOS] Re: [PATCH 00/19] Support SMBIOS 3.0 entry points

2021-12-18 Thread Kevin O'Connor
On Thu, Dec 10, 2020 at 04:26:21PM -0500, Eduardo Habkost wrote: > This series implements support for SMBIOS 3.0 entry points in > > SeaBIOS. > > The main advantage of SMBIOS 3.0 entry points is the higher limit > for total table size. The SMBIOS 2.1 64435 bytes limit can be > easily hit in

[SeaBIOS] Re: [coreboot] [ANNOUNCE] SeaBIOS 1.15.0

2021-12-03 Thread Kevin O'Connor
On Fri, Dec 03, 2021 at 09:35:24AM +0100, Paul Menzel wrote: > Dear Kevin, > > > Am 03.12.21 um 03:40 schrieb Kevin O'Connor: > > The 1.15.0 version of SeaBIOS has now been released. For more > > information on the release, please see: > > Thank you for cu

[SeaBIOS] Re: new november release?

2021-12-02 Thread Kevin O'Connor
On Wed, Dec 01, 2021 at 12:21:34PM +0100, Gerd Hoffmann wrote: > Hi, > > > I'm not sure what you'd prefer to do with the SeaBIOS release though. > > We have a couple of high-level options: > > > > 1. Release v1.15.0 this week without these changes (tag 64f37cc5). > > > > 2. Commit the smbios

[SeaBIOS] [ANNOUNCE] SeaBIOS 1.15.0

2021-12-02 Thread Kevin O'Connor
vme: Clean up nvme_cmd_readwrite() Kevin O'Connor (1): docs: Note v1.15.0 release Matt DeVillier (1): usb.c: Fix devices using non-primary interface descriptor Mike Banon (1): Support booting USB drives with a write protect switch enabled Sergei Trofimovich (1): vgas

[SeaBIOS] Re: new november release?

2021-11-30 Thread Kevin O'Connor
On Tue, Nov 23, 2021 at 09:50:44AM +0100, Gerd Hoffmann wrote: > Hi, > > > > Damn. Support for smbiod 3.0 fall completely through the cracks: > > > > > > https://www.mail-archive.com/seabios@seabios.org/msg12438.html > > > > > > The qemu-side changes have long been merged (except for

[SeaBIOS] Re: [PATCH v3 0/2] pci: reserve resources for pcie-pci-bridge to fix regressed hotplug on q35 with ACPI hotplug enabled

2021-11-30 Thread Kevin O'Connor
On Mon, Nov 29, 2021 at 06:48:10AM -0500, Igor Mammedov wrote: > Since QEMU-6.1, Q35 machine is using ACPI PCI hotplug by default. > However SeaBIOS did not take in account pcie-pci-bridge and treated it > as any other PCIe device which is not correct in the case of the bridge. Thanks. It looks

[SeaBIOS] Re: new november release?

2021-11-22 Thread Kevin O'Connor
On Mon, Nov 22, 2021 at 10:15:49AM +0100, Gerd Hoffmann wrote: > On Thu, Oct 21, 2021 at 09:43:39PM -0400, Kevin O'Connor wrote: > > On Thu, Oct 21, 2021 at 03:01:23PM +0200, Gerd Hoffmann wrote: > > > Hi, > > > > > > It's been a while since

[SeaBIOS] Re: new november release?

2021-10-21 Thread Kevin O'Connor
On Thu, Oct 21, 2021 at 03:01:23PM +0200, Gerd Hoffmann wrote: > Hi, > > It's been a while since the last release, we have some nice but > unreleased bits in the master branch (tpm and nvme improvements > for example), time for a new release I think. > > How about freeze in a week, release by

[SeaBIOS] Re: [PATCH v3 0/5] Make seabios linkable with lld

2021-10-21 Thread Kevin O'Connor
On Tue, Oct 19, 2021 at 07:50:40PM -0400, Brad Smith via SeaBIOS wrote: > On 8/14/2021 1:02 AM, Brad Smith wrote: > > > As an OpenBSD developer I'm very interested in these patches. SeaBIOS is > > the only package > > left in our ports tree still using lld to link and one of very few ports > >

[SeaBIOS] Re: [PATCH] tcgbios: Disable platform hierarchy in case of failure

2021-09-23 Thread Kevin O'Connor
On Tue, Sep 07, 2021 at 05:05:52PM -0400, Stefan Berger wrote: > In the rare case of a TPM 2 failure, disable the platform hierarchy after > disabling the endorsement and owner hierarchies. Thanks. I committed this change. -Kevin ___ SeaBIOS mailing

[SeaBIOS] Re: [PATCH] nvme: fix missing newline on sq full print

2021-06-30 Thread Kevin O'Connor
On Sat, Jun 26, 2021 at 10:13:40PM +, Alex Martens via SeaBIOS wrote: > Signed-off-by: Alex Martens Thanks. I committed this change. -Kevin ___ SeaBIOS mailing list -- seabios@seabios.org To unsubscribe send an email to seabios-le...@seabios.org

[SeaBIOS] Re: [PATCH] tcgbios: Fix details in log entries

2021-06-30 Thread Kevin O'Connor
On Wed, Jun 09, 2021 at 01:31:59PM -0400, Stefan Berger wrote: > Fix two details of the logs: > > - Set the field 'SpecErrata' to 2 as required by specs. > - Write the separator into the log entry's event field. > > Signed-off-by: Stefan Berger Thanks. I committed this change. -Kevin

[SeaBIOS] Re: [PATCH 0/2] tcgbios: Use the proper hashes for the TPM 2 PCR banks

2021-06-30 Thread Kevin O'Connor
On Mon, Jun 14, 2021 at 01:35:47PM -0400, Stefan Berger wrote: > This PR adds the implementations for sha{256, 384, 512} and makes use > of the hash implementation when extending the PCRs of the respective > banks rather than always using the sha1 and zero-padding it for the PCR > banks of a TPM

[SeaBIOS] Re: [PATCH 0/2] tcgbios: Use the proper hashes for the TPM 2 PCR banks

2021-06-14 Thread Kevin O'Connor
On Mon, Jun 14, 2021 at 01:35:47PM -0400, Stefan Berger wrote: > This PR adds the implementations for sha{256, 384, 512} and makes use > of the hash implementation when extending the PCRs of the respective > banks rather than always using the sha1 and zero-padding it for the PCR > banks of a TPM

[SeaBIOS] Re: [PATCH v4 0/2] fix PS/2 keyboard initialization failures

2021-06-09 Thread Kevin O'Connor
On Fri, Jun 04, 2021 at 07:59:27PM +0200, Volker Rümelin wrote: > Hi, > > I wrote a few patches for qemu [1] and patch 10/11 exposes a bug > in seabios. > > Sometimes the PS/2 keyboard initialization fails and seabios > doesn't detect the keyboard. This patch fixes the PS/2 keyboard >

[SeaBIOS] Re: [PATCH v4 0/2] fix PS/2 keyboard initialization failures

2021-06-04 Thread Kevin O'Connor
On Fri, Jun 04, 2021 at 07:59:27PM +0200, Volker Rümelin wrote: > Hi, > > I wrote a few patches for qemu [1] and patch 10/11 exposes a bug > in seabios. > > Sometimes the PS/2 keyboard initialization fails and seabios > doesn't detect the keyboard. This patch fixes the PS/2 keyboard >

[SeaBIOS] Re: [PATCH v3 1/3] stacks: fix asm constraints in run_thread()

2021-06-02 Thread Kevin O'Connor
On Wed, Jun 02, 2021 at 09:25:54PM +0200, Volker Rümelin wrote: > > On Tue, Jun 01, 2021 at 09:06:54PM +0200, Volker Rümelin wrote: > > > The variables data, func, thread and cur are input operands for > > > the asm statement in run_thread(). The assembly code clobbers > > > these inputs. > > > >

[SeaBIOS] Re: [PATCH v3 1/3] stacks: fix asm constraints in run_thread()

2021-06-02 Thread Kevin O'Connor
On Tue, Jun 01, 2021 at 09:06:54PM +0200, Volker Rümelin wrote: > The variables data, func, thread and cur are input operands for > the asm statement in run_thread(). The assembly code clobbers > these inputs. > > From the gcc documentation chapter Extended-Asm, Input Operands: > "It is not

[SeaBIOS] Re: [PATCH v3] Increate BUILD_MIN_BIOSTABLE for large roms

2021-06-02 Thread Kevin O'Connor
On Mon, May 31, 2021 at 07:55:28AM +0200, Gerd Hoffmann wrote: > BUILD_MIN_BIOSTABLE reserves space in the f-segment. Some data > structures -- for example disk drives known to seabios -- must be > stored there, so the space available here limits the number of > devices seabios is able to manage.

[SeaBIOS] Re: [PATCH 1/1] stacks: fix missing NMI_DISABLE_BIT on call32_post()

2021-05-27 Thread Kevin O'Connor
On Thu, May 27, 2021 at 03:43:51PM -0300, Heitor Alves de Siqueira wrote: > On Thu, May 27, 2021 at 11:44 AM Kevin O'Connor wrote: > > > > The purpose of this code is to restore the NMI_DISABLE_BIT to what it > > was prior to call32_prep(). If something c

[SeaBIOS] Re: [PATCH v2] make BUILD_MIN_BIOSTABLE configurable

2021-05-27 Thread Kevin O'Connor
On Thu, May 27, 2021 at 10:52:27AM +0200, Gerd Hoffmann wrote: > BUILD_MIN_BIOSTABLE reserves space in the f-segment. Some data > structures -- for example disk drives known to seabios -- must be > stored there, so the space available here limits the number of > devices seabios is able to manage.

[SeaBIOS] Re: [PATCH 1/1] stacks: fix missing NMI_DISABLE_BIT on call32_post()

2021-05-27 Thread Kevin O'Connor
On Thu, May 27, 2021 at 09:25:01AM -0300, Heitor Alves de Siqueira wrote: > We should disable NMIs when accessing CMOS ports during state restore, > like it's done during state backup in call32_prep(). > > Signed-off-by: Heitor Alves de Siqueira > --- > src/stacks.c | 2 +- > 1 file changed, 1

[SeaBIOS] Re: [PATCH 0/2] nvme fixes

2021-05-26 Thread Kevin O'Connor
On Wed, May 26, 2021 at 09:49:55AM +0200, Gerd Hoffmann wrote: > Gerd Hoffmann (2): > > nvme: improve namespace allocation > > nvme: drive desc should not include the newline > Thanks. It looks fine to me. -Kevin ___ SeaBIOS mailing list --

[SeaBIOS] Re: [PATCH v2] vgasrc/vgalayout.lds.S: ignore .node.gnu.property (binutils-2.36 support)

2021-05-26 Thread Kevin O'Connor
On Thu, May 20, 2021 at 11:18:48PM +0100, Sergei Trofimovich wrote: > From: Sergei Trofimovich > > Modern binutils unconditionally tracks x86_64 ISA levels in intermediate > files in .note.gnu.property. Custom liker script does not handle the > section and complains about it: > > ld

[SeaBIOS] Re: [PATCH] stacks: call check_irqs() in run_thread()

2021-05-26 Thread Kevin O'Connor
# test reply is still on wire. > | > yield(); > # After a few yield()s the keyboard interrupt fires > # and clears the I8042_STR_OBF status bit. If the > # keyboard self test reply arrives before the > # i

[SeaBIOS] Re: [PATCH] fw/coreboot.c: Use coreboot table to find cbfs

2021-05-26 Thread Kevin O'Connor
On Thu, May 20, 2021 at 06:09:55PM +, Peter Stuge wrote: > Arthur Heymans wrote: > > This breaks compatibility with very old coreboot build (build before > > fb5d5b16 "2015-07-14, cbtable: describe boot media"). > > Is that really acceptable in SeaBIOS master at some random time? > > At the

[SeaBIOS] Re: [PATCH v2 0/3] Add support for all HD and QXGA resolutions

2021-05-21 Thread Kevin O'Connor
On Fri, May 21, 2021 at 11:03:00AM +0200, Gerd Hoffmann wrote: > On Thu, May 20, 2021 at 01:55:12PM -0400, Kevin O'Connor wrote: > > On Tue, May 04, 2021 at 07:43:35PM -0400, Elliot Killick via SeaBIOS wrote: > > > Hi, > > > > > > This patch series adds sup

[SeaBIOS] Re: [PATCH] stacks: always call check_irqs() in yield()

2021-05-20 Thread Kevin O'Connor
On Thu, May 20, 2021 at 08:53:34PM +0200, Volker Rümelin wrote: > > On Fri, May 14, 2021 at 08:03:20PM +0200, Volker Rümelin wrote: > > > The comment above the yield() function suggests that yield() > > > allows interrupts for a short time. Currently this is only true > > > if seabios was built

[SeaBIOS] Re: patch: add run-time option to load but not execute option roms

2021-05-20 Thread Kevin O'Connor
On Sun, May 16, 2021 at 12:25:27AM +0100, Leah Rowe via SeaBIOS wrote: > From anecdotal reports, sometimes it is useful; I've heard of instances where > certain Nvidia graphics cards can, if using the nouveau driver on a GNU+Linux > system, be used without running any option ROM, but where the

[SeaBIOS] Re: [PATCH] stacks: always call check_irqs() in yield()

2021-05-20 Thread Kevin O'Connor
On Fri, May 14, 2021 at 08:03:20PM +0200, Volker Rümelin wrote: > The comment above the yield() function suggests that yield() > allows interrupts for a short time. Currently this is only true > if seabios was built without CONFIG_THREADS or if yield() is > called from the main thread. Change the

[SeaBIOS] Re: [PATCH v2 0/3] Add support for all HD and QXGA resolutions

2021-05-20 Thread Kevin O'Connor
On Tue, May 04, 2021 at 07:43:35PM -0400, Elliot Killick via SeaBIOS wrote: > Hi, > > This patch series adds support for all HD and QXGA resolutions. > > I've taken Gerd's advice on the v1 patch and split the formatting > improvments into a separate patch. > > I also tried to take Gerd's advice

[SeaBIOS] Re: [PATCH] fw/coreboot.c: Use coreboot table to find cbfs

2021-05-20 Thread Kevin O'Connor
On Fri, Apr 30, 2021 at 10:28:26AM +0200, Arthur Heymans wrote: > The "cbfs master header" cbfs file is considered a legacy feature in > coreboot and is planned for removal in the master branch. Since 2015 > the coreboot tables have exported info about the active cbfs. > > This change uses the

[SeaBIOS] Re: [PATCH] vgasrc/vgalayout.lds.S: ignore .node.gnu.property (binutils-2.36 support)

2021-05-20 Thread Kevin O'Connor
On Fri, Apr 30, 2021 at 11:30:33PM +0100, Sergei Trofimovich wrote: > From: Sergei Trofimovich > > Modern binutils unconditionally tracks x86_64 ISA levels in intermediate > files in .note.gnu.property. Custom liker script does not handle the > section and complains about it: > > ld

[SeaBIOS] Re: SeaBIOS fails to boot from NVMe controller with lots of namespaces

2021-04-14 Thread Kevin O'Connor
On Thu, Apr 08, 2021 at 01:32:47PM +0200, Gerd Hoffmann wrote: > > > > I changed the number of namespaces my controller reports to 1 and it > > > > worked fine. Is there an easy way to get around this or do I have to > > > > fix the code? I haven't looked at the code in detail, but I think we > >

[SeaBIOS] Re: [PATCH] boot: add config option for fast device init

2021-04-14 Thread Kevin O'Connor
On Thu, Apr 08, 2021 at 12:02:23PM +0200, Gerd Hoffmann wrote: > Hi, > > > > > > Add a config option for fast device init (i.e. skip non-bootable > > > > > devices). This optimization breaks boot in some rare configurations, > > > > > specifically in case the boot loader needs access to

[SeaBIOS] Re: [PATCH] malloc: Add check to avoid dereference NULL pointer.

2021-04-02 Thread Kevin O'Connor
On Tue, Mar 23, 2021 at 03:03:37AM +, likejun (A) wrote: > From: Kejun Li mailto:likej...@huawei.com>> > > Date: Mon, 22 Mar 2021 14:03:10 +0800 > > Subject: [PATCH] malloc: Add check to avoid dereference NULL pointer. > > > > info = alloc_find_lowest() may return NULL, should check

[SeaBIOS] Re: [PATCH] vgasrc/svgamodes: added 4k resolution

2021-04-02 Thread Kevin O'Connor
On Sun, Mar 14, 2021 at 01:48:07PM +0100, vit...@cyberhaven.com wrote: > From: Vitaly Chipounov > > This requires at least 32MB of video memory. > > Tested with Windows 10's default display driver and virtio-vga. > > Signed-off-by: Vitaly Chipounov > --- > vgasrc/bochsvga.h | 4 ++-- >

[SeaBIOS] Re: Bump max MPTABLE and SMBIOS sizes from 600 to 768

2021-04-02 Thread Kevin O'Connor
really justified in the first place: 768 decimal is > > 0x300, while 600 is a weird 0x258. > > > > On Tue, Mar 9, 2021 at 2:28 AM Kevin O'Connor wrote: > > > > > > On Tue, Mar 02, 2021 at 11:21:27PM +0300, Mike Banon wrote: > > > > There are plenty of cor

[SeaBIOS] Re: [PATCH] boot: add config option for fast device init

2021-04-02 Thread Kevin O'Connor
On Fri, Mar 26, 2021 at 09:52:49AM +0100, Gerd Hoffmann wrote: > On Tue, Mar 23, 2021 at 04:31:41PM +0100, Paul Menzel wrote: > > Dear Gerd, > > > > > > On 2021-03-23 15:18, Gerd Hoffmann wrote: > > > Add a config option for fast device init (i.e. skip non-bootable > > > devices). This

[SeaBIOS] Re: [PATCH 1/1] usb-hid: Increase MAX_KBD_EVENT

2021-03-11 Thread Kevin O'Connor
On Tue, Mar 09, 2021 at 03:14:05AM +0100, Stefan Ott via SeaBIOS wrote: > Some USB keyboards use max packet sizes beyond the current maximum > supported by SeaBIOS. > > This increases the available size to support keyboards such as the > Matias Ergo Pro. Thanks - I committed this change. -Kevin

[SeaBIOS] Re: [PATCH 00/31] Add support for PA-RISC CPU target

2021-03-08 Thread Kevin O'Connor
On Wed, Mar 03, 2021 at 05:26:23PM +0100, Helge Deller wrote: > On 2/24/21 2:23 AM, Kevin O'Connor wrote: > > Similarly, there are many cases where parisc has different > > implementations of similar functionality that isn't architecture > > I assume you meant "...tha

  1   2   3   4   5   6   7   8   9   10   >