Re: [SeaBIOS] [PATCH v2 0/2] Add IPMI SMBIOS/ACPI support

2012-08-14 Thread Kevin O'Connor
On Mon, Aug 13, 2012 at 07:07:06PM -0500, Corey Minyard wrote: On 08/13/2012 05:49 PM, Kevin O'Connor wrote: How different are they. Can you give human readable example? Here are the examples from the IPMI spec. I lied a little bit, there are actually four standard interfaces (one can be on

Re: [SeaBIOS] [PATCH v2 0/2] Add IPMI SMBIOS/ACPI support

2012-08-14 Thread Corey Minyard
On 08/13/2012 07:25 PM, Kevin O'Connor wrote: On Mon, Aug 13, 2012 at 07:07:06PM -0500, Corey Minyard wrote: On 08/13/2012 05:49 PM, Kevin O'Connor wrote: How different are they. Can you give human readable example? Here are the examples from the IPMI spec. I lied a little bit, there are

Re: [SeaBIOS] [PATCH v2 0/2] Add IPMI SMBIOS/ACPI support

2012-08-14 Thread Corey Minyard
On 08/13/2012 05:49 PM, Kevin O'Connor wrote: On How different are they. Can you give human readable example? Here are the examples from the IPMI spec. I lied a little bit, there are actually four standard interfaces (one can be on an SMBus), but it's a different thing to manage, I think.

Re: [SeaBIOS] [PATCH v2 0/2] Add IPMI SMBIOS/ACPI support

2012-08-13 Thread Gleb Natapov
On Sun, Aug 12, 2012 at 08:22:12PM -0500, Corey Minyard wrote: Patch 2 is complex and I don't fully understand what it is doing. A quick scan leads me to believe it is constructing a dynamic SSDT - though it's not clear why a dynamic SSDT is needed and why the existing mechanism (see

Re: [SeaBIOS] [PATCH v2 0/2] Add IPMI SMBIOS/ACPI support

2012-08-13 Thread Gleb Natapov
On Mon, Aug 13, 2012 at 09:47:50AM -0500, Corey Minyard wrote: On 08/13/2012 01:25 AM, Gleb Natapov wrote: On Sun, Aug 12, 2012 at 08:22:12PM -0500, Corey Minyard wrote: Patch 2 is complex and I don't fully understand what it is doing. A quick scan leads me to believe it is constructing a

Re: [SeaBIOS] [PATCH v2 0/2] Add IPMI SMBIOS/ACPI support

2012-08-13 Thread Corey Minyard
On 08/13/2012 01:25 AM, Gleb Natapov wrote: On Sun, Aug 12, 2012 at 08:22:12PM -0500, Corey Minyard wrote: Patch 2 is complex and I don't fully understand what it is doing. A quick scan leads me to believe it is constructing a dynamic SSDT - though it's not clear why a dynamic SSDT is needed

Re: [SeaBIOS] [PATCH v2 0/2] Add IPMI SMBIOS/ACPI support

2012-08-12 Thread Kevin O'Connor
On Fri, Aug 10, 2012 at 08:48:58AM -0500, Corey Minyard wrote: On 08/08/2012 11:11 AM, miny...@acm.org wrote: I went ahead and kept the structure passing because I've added ACPI support. After thinking about it a while, I think if you have to pass anything to SMBIOS (like IPMI is present) you

Re: [SeaBIOS] [PATCH v2 0/2] Add IPMI SMBIOS/ACPI support

2012-08-12 Thread Corey Minyard
On 08/12/2012 07:49 PM, Kevin O'Connor wrote: On Fri, Aug 10, 2012 at 08:48:58AM -0500, Corey Minyard wrote: On 08/08/2012 11:11 AM, miny...@acm.org wrote: I went ahead and kept the structure passing because I've added ACPI support. After thinking about it a while, I think if you have to pass

Re: [SeaBIOS] [PATCH v2 0/2] Add IPMI SMBIOS/ACPI support

2012-08-10 Thread Corey Minyard
On 08/08/2012 11:11 AM, miny...@acm.org wrote: I went ahead and kept the structure passing because I've added ACPI support. After thinking about it a while, I think if you have to pass anything to SMBIOS (like IPMI is present) you might as well pass the whole structure, and making things fixed

[SeaBIOS] [PATCH v2 0/2] Add IPMI SMBIOS/ACPI support

2012-08-08 Thread minyard
I went ahead and kept the structure passing because I've added ACPI support. After thinking about it a while, I think if you have to pass anything to SMBIOS (like IPMI is present) you might as well pass the whole structure, and making things fixed in the BIOS that can change in the hardware