Re: [SeaBIOS] [RfC PATCH 1/2] pci: move to two-pass pci initialization

2011-06-01 Thread Gerd Hoffmann
On 05/30/11 17:29, Kevin O'Connor wrote: On Tue, May 24, 2011 at 11:05:32AM +0200, Gerd Hoffmann wrote: This patch adds a second device scan to the pci initialization, which counts the memory bars of the various sizes and types. Then it calculates the sizes and the packing of the prefetchable a

Re: [SeaBIOS] [RfC PATCH 1/2] pci: move to two-pass pci initialization

2011-05-30 Thread Kevin O'Connor
On Tue, May 24, 2011 at 11:05:32AM +0200, Gerd Hoffmann wrote: > This patch adds a second device scan to the pci initialization, which > counts the memory bars of the various sizes and types. Then it > calculates the sizes and the packing of the prefetchable and > non-prefetchable pci memory windo

Re: [SeaBIOS] [RfC PATCH 1/2] pci: move to two-pass pci initialization

2011-05-25 Thread Alon Levy
On Thu, May 26, 2011 at 06:43:57AM +0200, André Weidemann wrote: > Hi Gerd, > > On 25.05.2011 14:45, Gerd Hoffmann wrote: > >PS: full patch collection @ > >http://www.kraxel.org/cgit/seabios/log/?h=kraxel.q35 > > I checked out your branch under Ubuntu Natty and ran "make". But > unfortunately lin

Re: [SeaBIOS] [RfC PATCH 1/2] pci: move to two-pass pci initialization

2011-05-25 Thread Gerd Hoffmann
Hi, out/romlayout16.lds:699 cannot move location counter backwards (from ca0f to c9f4) I've seen this on the list already, IIRC this is some binutils bug, check the archive. cheers, Gerd ___ SeaBIOS mailing list SeaBI

Re: [SeaBIOS] [RfC PATCH 1/2] pci: move to two-pass pci initialization

2011-05-25 Thread André Weidemann
Hi Gerd, On 25.05.2011 14:45, Gerd Hoffmann wrote: PS: full patch collection @ http://www.kraxel.org/cgit/seabios/log/?h=kraxel.q35 I checked out your branch under Ubuntu Natty and ran "make". But unfortunately linking failed with the following error(see below). root@test:/tmp/seabios-pci-t

Re: [SeaBIOS] [RfC PATCH 1/2] pci: move to two-pass pci initialization

2011-05-25 Thread Gerd Hoffmann
Hi, (1) Figure which devices are needed to boot. That list should include VGA, storage devices, NICs (with ROM), maybe all devices with a ROM. Anything else? (2) For devices which are not needed to boot we can: (b) Skip device altogether. Something like this ... cheers, Gerd PS: full pa

Re: [SeaBIOS] [RfC PATCH 1/2] pci: move to two-pass pci initialization

2011-05-25 Thread Gerd Hoffmann
On 05/25/11 06:33, Isaku Yamahata wrote: The patch doesn't check any overflows. And it assumes that BAR assignment is always possible. However it isn't true. Some people complained about it before, so I added overflow check. Indeed, there is no error handling at all yet. Some devices have ver

Re: [SeaBIOS] [RfC PATCH 1/2] pci: move to two-pass pci initialization

2011-05-24 Thread Isaku Yamahata
The patch doesn't check any overflows. And it assumes that BAR assignment is always possible. However it isn't true. Some people complained about it before, so I added overflow check. Some devices have very huge BAR like 1G, 2G... For example, qemu ivshmem or device-assignment of home-made device.

Re: [SeaBIOS] [RfC PATCH 1/2] pci: move to two-pass pci initialization

2011-05-24 Thread Isaku Yamahata
Basically it looks good. Great work. I've wanted to see this kind of patch. Some comments below. On Tue, May 24, 2011 at 11:05:32AM +0200, Gerd Hoffmann wrote: > This patch adds a second device scan to the pci initialization, which > counts the memory bars of the various sizes and types. Then it

Re: [SeaBIOS] [RfC PATCH 1/2] pci: move to two-pass pci initialization

2011-05-24 Thread Alon Levy
On Tue, May 24, 2011 at 11:05:32AM +0200, Gerd Hoffmann wrote: > This patch adds a second device scan to the pci initialization, which > counts the memory bars of the various sizes and types. Then it > calculates the sizes and the packing of the prefetchable and > non-prefetchable pci memory windo

[SeaBIOS] [RfC PATCH 1/2] pci: move to two-pass pci initialization

2011-05-24 Thread Gerd Hoffmann
This patch adds a second device scan to the pci initialization, which counts the memory bars of the various sizes and types. Then it calculates the sizes and the packing of the prefetchable and non-prefetchable pci memory windows and prints the results. TODO: actually use the calculated stuff. S