Looks great
Sam
On Fri, Nov 15, 2019 at 1:35 PM Gerd Hoffmann wrote:
>
> Hi,
>
> > > I am afraid it will be slightly unreadable when looking at file histories.
> > > The only commit that didn't change was:
> > > [SeaBIOS] [PATCH v4 2/5] boot: Reorder functions in boot.c
> >
> > Hmm, looks
Hi,
> > I am afraid it will be slightly unreadable when looking at file histories.
> > The only commit that didn't change was:
> > [SeaBIOS] [PATCH v4 2/5] boot: Reorder functions in boot.c
>
> Hmm, looks like there have been more changes than I remember.
Yep, v3..v4 diff is pretty big, so
On Thu, Nov 14, 2019 at 11:08:59AM +0200, Sam Eiderman wrote:
> Do you want a single commit with the changes?
That is the idea, unless it is too messy. I don't have v4 any more,
looks like I've deleted v4 instead of v3 while cleaning up my mail
folders, so I can't easily check. Do you have v3
Do you want a single commit with the changes?
I am afraid it will be slightly unreadable when looking at file histories.
The only commit that didn't change was:
[SeaBIOS] [PATCH v4 2/5] boot: Reorder functions in boot.c
Sam
On Thu, Nov 14, 2019 at 9:20 AM Gerd Hoffmann wrote:
>
> On Wed, Nov
On Wed, Nov 13, 2019 at 05:03:58PM +0200, Sam Eiderman wrote:
> Hi,
>
> Does this fix a bug that actually happened?
Yes, "make check-qtest" may fail. It's kind of random though.
> I just noticed that in my lchs patches I assumed that lchs struct is
> zeroed out in all devices (not only ahci):
Links to latest commits from archive.
You can see all changes in the cover letter.
[SeaBIOS] [PATCH v4 0/5] Add Qemu to SeaBIOS LCHS interface
https://mail.coreboot.org/hyperkitty/list/seabios@seabios.org/message/VLNFBEERTWLEUO6LM5BYLBNVIFCTP46M/
[SeaBIOS] [PATCH v4 1/5] geometry: Read LCHS from
Sure,
There are two issues here.
The first issue is that my commits which applied to seabios master:
* 9caa19b - geometry: Apply LCHS values for boot devices
* cb56f61 - config: Add toggle for bootdevice information
* ad29109 - geometry: Add boot_lchs_find_*() utility functions
* b3d2120 -
Hi Sam,
On 11/13/19 4:03 PM, Sam Eiderman wrote:
Hi,
Does this fix a bug that actually happened?
I just noticed that in my lchs patches I assumed that lchs struct is
zeroed out in all devices (not only ahci):
9caa19be0e53 (geometry: Apply LCHS values for boot devices)
Seems like this is not
Sorry the correct list (which includes ahci) is:
git grep "drive_s * drive"
src/hw/ahci.h:struct drive_s drive;
src/hw/ata.h:struct drive_s drive;
src/hw/esp-scsi.c:struct drive_s drive;
src/hw/lsi-scsi.c:struct drive_s drive;
src/hw/megasas.c:struct drive_s drive;
We should make sure drive.lchs is zeroed out for the following devices:
git grep "drive_s drive"
src/hw/ata.h:struct drive_s drive;
src/hw/esp-scsi.c:struct drive_s drive;
src/hw/lsi-scsi.c:struct drive_s drive;
src/hw/megasas.c:struct drive_s drive;
src/hw/mpt-scsi.c:struct
Hi,
Does this fix a bug that actually happened?
I just noticed that in my lchs patches I assumed that lchs struct is
zeroed out in all devices (not only ahci):
9caa19be0e53 (geometry: Apply LCHS values for boot devices)
Seems like this is not the case but why only ahci is affected?
The list
On Wed, Nov 13, 2019 at 10:35:03AM +0100, Laszlo Ersek wrote:
> On 11/13/19 10:18, Gerd Hoffmann wrote:
> > Specifically port->driver.lchs needs clearing, otherwise seabios will
>
> s/driver/drive/
> Reviewed-by: Laszlo Ersek
Typo fixed & pushed.
thanks,
Gerd
On 11/13/19 10:18, Gerd Hoffmann wrote:
> Specifically port->driver.lchs needs clearing, otherwise seabios will
s/driver/drive/
> try interpret whatever random crap happens to be there as disk geometry,
> which may or may not break boot depending on how lucky you are.
>
> Signed-off-by: Gerd
13 matches
Mail list logo
