[SeaBIOS] Re: [PATCH es] bootmenu: Gerd Hoffman version - feedback

2019-04-12 Thread Mike Banon
Good day, > Also note that not all keyboards layouts have querty ordering. Mine > (german) has quertz, and dvorak looks completely different. Thank you, I forgot about this. Hope their scancodes are the same... By the way: if we are extending the boot menu, at ./src/config.h we need to increase

[SeaBIOS] Re: [PATCH es] bootmenu: Gerd Hoffman version - feedback

2019-04-12 Thread Gerd Hoffmann
Hi, > I see that you decided to continue it with "abcdef" instead of > suggested "qwerty". Interesting, what approach would be more > convenient for the end user... I find lexical ordering more intuitive. The char array allows easy reordering though. Also note that not all keyboards layouts h

[SeaBIOS] Re: [PATCH es] bootmenu: Gerd Hoffman version - feedback

2019-04-12 Thread Mike Banon
On Thu, Apr 11, 2019 at 11:34 PM Gerd Hoffmann wrote: > > Too many changes in a single patch. Needs splitting up into > one patch per change. Good idea, thank you. I could try to split the numpad support/console interface into a second patch. Although I provided a coreboot.rom QEMU image with lo

[SeaBIOS] Re: [PATCH es] bootmenu: Gerd Hoffman version - feedback

2019-04-11 Thread Gerd Hoffmann
On Thu, Apr 11, 2019 at 05:11:29PM +0300, Mike Banon wrote: > Dear Gerd Hoffman, > > If my advanced_bootmenu new patch ( [*] link below ) is not > upstream-able ( for what reasons? ), Too many changes in a single patch. Needs splitting up into one patch per change. > what's currently in SeaBIOS