On Mon, Dec 28, 2015 at 04:09:22PM -0800, Alex G. wrote:
> > Are you suggesting that an (unsigned) cast should be added? I doubt
> > it would matter.
>
> I'm suggesting to not rely on (0 - 4) to produce 0xfffc. The
> (unsigned) cast does not solve the C issue of writing a negative value
>
On Thu, Dec 24, 2015 at 03:45:03PM -0800, Alex Gagniuc wrote:
> When SeaBIOS is run on an FMAP-based CBFS (AKA, without a CBFS master
> header, it crashes). The problem is in coreboot_cbfs_init. A
> disassembly with -Mintel shows the following:
>
> :
>...
>7: 8b 35 fc ff ff ff
When SeaBIOS is run on an FMAP-based CBFS (AKA, without a CBFS master
header, it crashes). The problem is in coreboot_cbfs_init. A
disassembly with -Mintel shows the following:
:
...
7: 8b 35 fc ff ff ff movesi,DWORD PTR ds:0xfffc
d: 81 3e 4f 52 42 43 cmp
