Re: [SeaBIOS] (PAM stuff) reset doesn't work on OVMF + SeaBIOS CSM

2013-02-18 Thread David Woodhouse
On Sat, 2013-02-16 at 02:37 +0100, Laszlo Ersek wrote: I give up. Thanks for the help sorry about spamming three lists. I've managed to reproduce this on a clean F18 system. This is the stock qemu 1.2.2-6.fc18 on kernel 3.7.6-201.fc18.x86_64 with a newly-installed Fedora 18 VM in the guest.

Re: [SeaBIOS] [edk2] (PAM stuff) reset doesn't work on OVMF + SeaBIOS CSM

2013-02-18 Thread David Woodhouse
On Mon, 2013-02-18 at 10:40 +, David Woodhouse wrote: On Sat, 2013-02-16 at 02:37 +0100, Laszlo Ersek wrote: I give up. Thanks for the help sorry about spamming three lists. I've managed to reproduce this on a clean F18 system. This is the stock qemu 1.2.2-6.fc18 on kernel

Re: [SeaBIOS] [edk2] (PAM stuff) reset doesn't work on OVMF + SeaBIOS CSM

2013-02-18 Thread David Woodhouse
On Mon, 2013-02-18 at 15:46 +0100, Paolo Bonzini wrote: If you want to submit this patch for upstream QEMU (I agree it is a good idea), please set dc-reset instead in i440fx_class_init. Thanks. I just copied the way that PIIX3 does it... is that something that piix3_class_init() should be

[SeaBIOS] [PATCH] Rename rom_get_top() to rom_get_max().

2013-02-18 Thread Kevin O'Connor
Rename rom_get_top and try to make the difference between it and rom_get_last more clear. Signed-off-by: Kevin O'Connor ke...@koconnor.net --- src/optionroms.c | 4 ++-- src/pmm.c| 8 src/shadow.c | 2 +- src/util.h | 2 +- 4 files changed, 8 insertions(+), 8

[SeaBIOS] [PATCH] Report on f-segment UMB ram also.

2013-02-18 Thread Kevin O'Connor
Some old DOS programs can also use f-segment space as Upper Memory Blocks (UMB), so also report on what space is available in debug messages. Signed-off-by: Kevin O'Connor ke...@koconnor.net --- src/pmm.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/pmm.c b/src/pmm.c

[SeaBIOS] [PATCH] Clarify build generated zone low values.

2013-02-18 Thread Kevin O'Connor
Rename datalow_base (and similar) to zonelow_base, and datalow_start (and similar) to varlow_start. This helps distinguish between the bounds for the runtime dynamic memory pool and the compile time global variables. Signed-off-by: Kevin O'Connor ke...@koconnor.net --- src/biosvar.h | 6

[SeaBIOS] [PATCH] Verify CC is valid during build tests.

2013-02-18 Thread Kevin O'Connor
Update test-build.sh to report if it can't run the c compiler at all. Without this test, a totally non-working build environment will yield an invalid LD message which can be confusing. Signed-off-by: Kevin O'Connor ke...@koconnor.net --- tools/test-build.sh | 9 - 1 file changed, 8

Re: [SeaBIOS] [edk2] (PAM stuff) reset doesn't work on OVMF + SeaBIOS CSM

2013-02-18 Thread Paolo Bonzini
Il 18/02/2013 16:00, David Woodhouse ha scritto: On Mon, 2013-02-18 at 15:46 +0100, Paolo Bonzini wrote: If you want to submit this patch for upstream QEMU (I agree it is a good idea), please set dc-reset instead in i440fx_class_init. Thanks. I just copied the way that PIIX3 does it... is

[SeaBIOS] [PATCH] Disable handle_post() on CSM builds.

2013-02-18 Thread Kevin O'Connor
This reduces the size of the CSM binary by a few bytes. Signed-off-by: Kevin O'Connor ke...@koconnor.net --- src/post.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/post.c b/src/post.c index cf0d9b4..7f096de 100644 --- a/src/post.c +++ b/src/post.c @@ -313,6 +313,9 @@ dopost(void)

Re: [SeaBIOS] [edk2] (PAM stuff) reset doesn't work on OVMF + SeaBIOS CSM

2013-02-18 Thread David Woodhouse
On Mon, 2013-02-18 at 19:16 +0100, Laszlo Ersek wrote: On 02/18/13 18:45, Gleb Natapov wrote: On Mon, Feb 18, 2013 at 06:12:55PM +0100, Laszlo Ersek wrote: CS =f000 000f f300 ^^^^ |base limitflags selector This is

Re: [SeaBIOS] [edk2] (PAM stuff) reset doesn't work on OVMF + SeaBIOS CSM

2013-02-18 Thread Gleb Natapov
On Mon, Feb 18, 2013 at 07:16:25PM +0100, Laszlo Ersek wrote: On 02/18/13 18:45, Gleb Natapov wrote: On Mon, Feb 18, 2013 at 06:12:55PM +0100, Laszlo Ersek wrote: CS =f000 000f f300 ^^^^ |base limitflags selector This is

Re: [SeaBIOS] [edk2] (PAM stuff) reset doesn't work on OVMF + SeaBIOS CSM

2013-02-18 Thread Gleb Natapov
On Mon, Feb 18, 2013 at 06:12:55PM +0100, Laszlo Ersek wrote: On 02/18/13 13:53, David Woodhouse wrote: Nevertheless, on my workstation as on yours, we do seem to end up executing from the CSM in RAM when we reset. But on my laptop, it executes the *ROM* as it should. This patch

Re: [SeaBIOS] [Qemu-devel] [edk2] (PAM stuff) reset doesn't work on OVMF + SeaBIOS CSM

2013-02-18 Thread Kevin O'Connor
On Mon, Feb 18, 2013 at 08:31:01PM +0200, Gleb Natapov wrote: Laszlo explained to me that the problem is that after reset we end up in SeaBIOS reset code instead of OVMF one. This is because kvm starts to execute from 0 instead of fff0 after reset and this memory location is modifying

Re: [SeaBIOS] [Qemu-devel] [edk2] (PAM stuff) reset doesn't work on OVMF + SeaBIOS CSM

2013-02-18 Thread David Woodhouse
On Mon, 2013-02-18 at 14:00 -0500, Kevin O'Connor wrote: On Mon, Feb 18, 2013 at 08:31:01PM +0200, Gleb Natapov wrote: Laszlo explained to me that the problem is that after reset we end up in SeaBIOS reset code instead of OVMF one. This is because kvm starts to execute from 0 instead of

Re: [SeaBIOS] [Qemu-devel] [edk2] (PAM stuff) reset doesn't work on OVMF + SeaBIOS CSM

2013-02-18 Thread Laszlo Ersek
On 02/18/13 20:00, Kevin O'Connor wrote: On Mon, Feb 18, 2013 at 08:31:01PM +0200, Gleb Natapov wrote: Laszlo explained to me that the problem is that after reset we end up in SeaBIOS reset code instead of OVMF one. This is because kvm starts to execute from 0 instead of fff0 after

Re: [SeaBIOS] [Qemu-devel] [edk2] (PAM stuff) reset doesn't work on OVMF + SeaBIOS CSM

2013-02-18 Thread Gleb Natapov
On Mon, Feb 18, 2013 at 02:00:52PM -0500, Kevin O'Connor wrote: On Mon, Feb 18, 2013 at 08:31:01PM +0200, Gleb Natapov wrote: Laszlo explained to me that the problem is that after reset we end up in SeaBIOS reset code instead of OVMF one. This is because kvm starts to execute from 0

Re: [SeaBIOS] [Qemu-devel] [edk2] (PAM stuff) reset doesn't work on OVMF + SeaBIOS CSM

2013-02-18 Thread Kevin O'Connor
On Mon, Feb 18, 2013 at 09:17:05PM +0200, Gleb Natapov wrote: On Mon, Feb 18, 2013 at 02:00:52PM -0500, Kevin O'Connor wrote: Why not fix KVM so that it runs at fff0 after reset? Because KVM uses VMX extension and VMX on CPU without unrestricted guest is not capable of doing so. Recent

Re: [SeaBIOS] [Qemu-devel] [edk2] (PAM stuff) reset doesn't work on OVMF + SeaBIOS CSM

2013-02-18 Thread Laszlo Ersek
On 02/18/13 20:09, Laszlo Ersek wrote: On 02/18/13 20:00, Kevin O'Connor wrote: On Mon, Feb 18, 2013 at 08:31:01PM +0200, Gleb Natapov wrote: Laszlo explained to me that the problem is that after reset we end up in SeaBIOS reset code instead of OVMF one. This is because kvm starts to execute

Re: [SeaBIOS] [Qemu-devel] [edk2] (PAM stuff) reset doesn't work on OVMF + SeaBIOS CSM

2013-02-18 Thread Kevin O'Connor
On Mon, Feb 18, 2013 at 07:04:08PM +, David Woodhouse wrote: Well, what SeaBIOS already *does* is bash on the keyboard controller to cause a reset. Which *ought* to work too; I have a patch to at least fix *that*, by resetting the PAM setup in the i440. The thing to be aware of here is

Re: [SeaBIOS] [edk2] (PAM stuff) reset doesn't work on OVMF + SeaBIOS CSM

2013-02-18 Thread Paolo Bonzini
Il 18/02/2013 13:53, David Woodhouse ha scritto: diff --git a/hw/piix_pci.c b/hw/piix_pci.c index 6c77e49..6dcf1c5 100644 --- a/hw/piix_pci.c +++ b/hw/piix_pci.c @@ -171,6 +171,23 @@ static int i440fx_load_old(QEMUFile* f, void *opaque, int version_id) return 0; } +static void

Re: [SeaBIOS] [Qemu-devel] [edk2] (PAM stuff) reset doesn't work on OVMF + SeaBIOS CSM

2013-02-18 Thread David Woodhouse
On Mon, 2013-02-18 at 14:11 -0500, Kevin O'Connor wrote: On Mon, Feb 18, 2013 at 07:04:08PM +, David Woodhouse wrote: Well, what SeaBIOS already *does* is bash on the keyboard controller to cause a reset. Which *ought* to work too; I have a patch to at least fix *that*, by resetting the

Re: [SeaBIOS] [PATCH] Enable VGA output when setting Cirrus-specific mode

2013-02-18 Thread Laszlo Ersek
Hi, could someone please review this one-liner? Thanks! Laszlo (PS: sorry for top posting) On 02/14/13 05:43, Laszlo Ersek wrote: This patch does the same for Cirrus as David's following patch for bochs, originally posted under

Re: [SeaBIOS] [PATCH] Enable VGA output when setting Cirrus-specific mode

2013-02-18 Thread David Woodhouse
On Mon, 2013-02-18 at 21:27 +0100, Laszlo Ersek wrote: could someone please review this one-liner? Kevin already merged it. -- dwmw2 smime.p7s Description: S/MIME cryptographic signature ___ SeaBIOS mailing list SeaBIOS@seabios.org

Re: [SeaBIOS] [PATCH] Enable VGA output when setting Cirrus-specific mode

2013-02-18 Thread Laszlo Ersek
On 02/18/13 22:25, David Woodhouse wrote: On Mon, 2013-02-18 at 21:27 +0100, Laszlo Ersek wrote: could someone please review this one-liner? Kevin already merged it. Thanks. Sorry for the noise. L. ___ SeaBIOS mailing list SeaBIOS@seabios.org

Re: [SeaBIOS] [Qemu-devel] [edk2] (PAM stuff) reset doesn't work on OVMF + SeaBIOS CSM

2013-02-18 Thread Kevin O'Connor
On Mon, Feb 18, 2013 at 09:12:46PM +, David Woodhouse wrote: The i440fx data sheet (§3.0) appears to say that the default values are loaded on a *hard* reset, not a soft reset. And a reset invoked by the keyboard controller (as SeaBIOS does) is a *soft* reset. The only way to do a *hard*

Re: [SeaBIOS] [Qemu-devel] [edk2] (PAM stuff) reset doesn't work on OVMF + SeaBIOS CSM

2013-02-18 Thread David Woodhouse
On Mon, 2013-02-18 at 17:37 -0500, Kevin O'Connor wrote: On Mon, Feb 18, 2013 at 09:12:46PM +, David Woodhouse wrote: The i440fx data sheet (§3.0) appears to say that the default values are loaded on a *hard* reset, not a soft reset. And a reset invoked by the keyboard controller (as

[SeaBIOS] [PATCH] Minor assembler enhancements to __csm_return.

2013-02-18 Thread Kevin O'Connor
Signed-off-by: Kevin O'Connor ke...@koconnor.net --- src/romlayout.S | 17 - 1 file changed, 8 insertions(+), 9 deletions(-) diff --git a/src/romlayout.S b/src/romlayout.S index 42f8761..b1628ef 100644 --- a/src/romlayout.S +++ b/src/romlayout.S @@ -384,6 +384,7 @@ entry_elf:

[SeaBIOS] [PATCH 2/2] Convert VAR16VISIBLE, VAR16EXPORT, and VAR32VISIBLE to VARFSEG.

2013-02-18 Thread Kevin O'Connor
Convert all users of the alternative variable exports to VARFSEG. There isn't a significant distinction between the existing types of exports, so it's simpler to just use one type going forward. The new VARFSEG declaration is only emitting when in 32bit mode, so update and move some variables as

[SeaBIOS] [PATCH 1/2] Introduce VARFSEG for variables that will reside in the f-segment.

2013-02-18 Thread Kevin O'Connor
Introduce a variable declaration that will force variables (that are compiled in 32bit mode) to be emitted into the f-segment. Signed-off-by: Kevin O'Connor ke...@koconnor.net --- src/types.h| 4 tools/layoutrom.py | 29 ++--- 2 files changed, 26

[SeaBIOS] [PATCH] Don't relocate varlow variable references at runtime.

2013-02-18 Thread Kevin O'Connor
Since the final location of the varlow variables are known at build time, link the final locations into the binary during the build. The 16bit code was already done at link time - update the build so the 32bit code is also done at link time. Signed-off-by: Kevin O'Connor ke...@koconnor.net ---

[SeaBIOS] [PATCH] Move malloc's ZoneFSeg and ZoneLow setup to malloc_init.

2013-02-18 Thread Kevin O'Connor
This reduces some duplicate code between malloc_preinit() and csm_malloc_preinit(). Signed-off-by: Kevin O'Connor ke...@koconnor.net --- src/pmm.c | 15 +-- 1 file changed, 5 insertions(+), 10 deletions(-) diff --git a/src/pmm.c b/src/pmm.c index 0bd30b2..c717884 100644 ---