Re: [SeaBIOS] seabios: acpi: add _RMV control method for PCI devices

2010-12-12 Thread Kevin O'Connor
On Wed, Dec 08, 2010 at 03:08:59PM -0200, Marcelo Tosatti wrote: Use _RMV method to indicate whether device can be removed. Data is retrieved from QEMU via I/O port 0xae0c. Signed-off-by: Marcelo Tosatti mtosa...@redhat.com Thanks Marcelo, Can you add acked-bys from the qemu/kvm

Re: [SeaBIOS] [PATCHv2] Create separate IPL entry for each CD/DVD

2010-12-12 Thread Kevin O'Connor
On Tue, Dec 07, 2010 at 01:50:54PM +0200, Gleb Natapov wrote: Current code creates only one IPL entry of type IPL_TYPE_CDROM even if there are more then one CDROM drive present. If CDROM that the entry refers to is not bootable there is no way to retry boot from another CDROM. Fix this by

Re: [SeaBIOS] [PATCH RFC] use bootorder file supplied by qemu to order bootable devices

2010-12-13 Thread Kevin O'Connor
On Mon, Dec 13, 2010 at 08:44:08AM -0500, Kevin O'Connor wrote: On Mon, Dec 13, 2010 at 03:12:51PM +0200, Gleb Natapov wrote: On Thu, Dec 09, 2010 at 08:27:10PM -0500, Kevin O'Connor wrote: On Wed, Dec 08, 2010 at 02:00:50PM +0200, Gleb Natapov wrote: With patch below (goes on top of bev

Re: [SeaBIOS] [PATCH] provide full edd info for virtio disk

2010-12-14 Thread Kevin O'Connor
On Thu, Dec 09, 2010 at 03:10:39PM +0200, Gleb Natapov wrote: Signed-off-by: Gleb Natapov g...@redhat.com Looks okay to me. Why SCSI though? -Kevin ___ SeaBIOS mailing list SeaBIOS@seabios.org http://www.seabios.org/mailman/listinfo/seabios

Re: [SeaBIOS] [PATCH 1/9] Provide full EDD 3.0 info for virtio disk

2010-12-24 Thread Kevin O'Connor
On Thu, Dec 23, 2010 at 11:29:35AM +0200, Gleb Natapov wrote: Fill out entire EDD 3.0 structure for virtio disk. Currently only EDD 1.0 part is filled which is missing such important info as device path. Use SCSI device type since virtio is not defined by EDD spec and virtio disk pci device

Re: [SeaBIOS] [PATCH 5/9] Add romfile_name() function.

2010-12-24 Thread Kevin O'Connor
On Thu, Dec 23, 2010 at 11:29:39AM +0200, Gleb Natapov wrote: romfile_name() return file name given file handler. Works for qemu and coreboot. Signed-off-by: Gleb Natapov g...@redhat.com Thanks - I applied this. -Kevin ___ SeaBIOS mailing list

Re: [SeaBIOS] [PATCH 4/9] Read bootorder file into memory.

2010-12-24 Thread Kevin O'Connor
that the bootorder file doesn't need to be null-terminated (seabios will tack on a trailing null itself). -Kevin commit f9b0930ab9efe5f340edbb61f3a5269dbff8c663 Author: Kevin O'Connor ke...@koconnor.net Date: Fri Dec 24 11:15:26 2010 -0500 Add romfile_loadfile() helper function. Add

Re: [SeaBIOS] [PATCH 8/9] Record boot priority for each BAID/BCV/BEV.

2010-12-24 Thread Kevin O'Connor
On Thu, Dec 23, 2010 at 11:29:42AM +0200, Gleb Natapov wrote: For each BAID/BCV/BEV lookup its boot priority in boot order file. If there is no entry for a device there assign it the lowest boot priority. Signed-off-by: Gleb Natapov g...@redhat.com It's not clear what the floppy part of this

Re: [SeaBIOS] [PATCH 1/9] Provide full EDD 3.0 info for virtio disk

2010-12-26 Thread Kevin O'Connor
On Sun, Dec 26, 2010 at 04:12:21PM +0200, Gleb Natapov wrote: On Fri, Dec 24, 2010 at 10:42:50AM -0500, Kevin O'Connor wrote: On Thu, Dec 23, 2010 at 11:29:35AM +0200, Gleb Natapov wrote: Fill out entire EDD 3.0 structure for virtio disk. Currently only EDD 1.0 part is filled which

Re: [SeaBIOS] your mail

2010-12-26 Thread Kevin O'Connor
I applied this change. -Kevin On Tue, Dec 21, 2010 at 10:29:27PM +0100, Stefan Reinauer wrote: Hi, I made these two tiny changes to SeaBIOS when I was playing with the HEAD version. The Makefile change prevents the test command from failing if CC contains a space. The coreboot

Re: [SeaBIOS] [PATCH] pciinit: fix off-by-one

2010-12-26 Thread Kevin O'Connor
On Fri, Dec 24, 2010 at 10:51:08AM +0900, Isaku Yamahata wrote: IO port ends at 64K - 1. not 64K. Thanks - I applied this. -Kevin ___ SeaBIOS mailing list SeaBIOS@seabios.org http://www.seabios.org/mailman/listinfo/seabios

[SeaBIOS] [PATCH 0/2] Simplify boot ordering mechanisms

2010-12-26 Thread Kevin O'Connor
bootorder file reading code. -Kevin Kevin O'Connor (2): Populate drive_g-desc prior to calling add_bcv_internal(). Simplify boot ordering by building an inclusive boot list. src/ahci.c | 11 +- src/ata.c| 13 +- src/block.c | 20 +--- src/boot.c | 425

[SeaBIOS] [PATCH 1/2] Populate drive_g-desc prior to calling add_bcv_internal().

2010-12-26 Thread Kevin O'Connor
Make sure the description is populated before registering a drive. --- src/usb-msc.c|5 ++--- src/virtio-blk.c |8 +++- 2 files changed, 5 insertions(+), 8 deletions(-) diff --git a/src/usb-msc.c b/src/usb-msc.c index 080efdc..48635d9 100644 --- a/src/usb-msc.c +++

[SeaBIOS] [PATCH 7/9] Move IPL.fw_bootorder to static variables in boot.c.

2010-12-29 Thread Kevin O'Connor
--- src/boot.c | 17 + src/boot.h | 10 -- 2 files changed, 9 insertions(+), 18 deletions(-) diff --git a/src/boot.c b/src/boot.c index 5ae418c..9a395c6 100644 --- a/src/boot.c +++ b/src/boot.c @@ -14,13 +14,14 @@ #include cmos.h // inb_cmos #include paravirt.h

Re: [SeaBIOS] [PATCH 0/9] Misc boot related cleanups

2010-12-29 Thread Kevin O'Connor
On Wed, Dec 29, 2010 at 10:29:57PM +0200, Gleb Natapov wrote: On Wed, Dec 29, 2010 at 02:10:16PM -0500, Kevin O'Connor wrote: BTW, I was thinking of ways to try and simplify this code. What if we tried doing an exact string match for the device, but if that fails and a BDF is known

[SeaBIOS] [PATCH] USB boot priority

2010-12-30 Thread Kevin O'Connor
This adds tracking of USB port paths, and enables searching the bootorder file based on it. It's on top of the other patches I've sent. Gleb - I tried adding: -usb -drive file=dos-drivec,if=none,id=d1 -device usb-storage,drive=d1,bootindex=1 But qemu didn't add anything to the bootorder

Re: [SeaBIOS] Question about linker building seabios

2011-01-15 Thread Kevin O'Connor
On Sat, Jan 15, 2011 at 09:29:07PM +0100, Marc Bertens wrote: Keven, here is the patch, i hope yoiu can see what i'm doing wrong :-) Marc The patch had no problem linking on my machine. Can you re-clone, apply the patch, and verify you still have the failure? If so, please tar up the

Re: [SeaBIOS] Question about linker building seabios

2011-01-17 Thread Kevin O'Connor
On Mon, Jan 17, 2011 at 07:35:25PM +0100, Marc Bertens wrote: Hmmm, not completely true i'm afraid. When booting a cold systen it will not come up. When i switch to my fallback rom it boots, now i switch back to the image that was not booting and now it boots just fine. So i was a little

Re: [SeaBIOS] Kconfig for SeaBIOS finally

2011-01-23 Thread Kevin O'Connor
On Sun, Jan 23, 2011 at 09:01:41PM +0100, Marc Bertens wrote: Kevin, I'm currently underway of fixing the Kconfig errors, already fixed coreboot Y/N issue. But i notice that this takes some work due to the way its currently coded. i did already boot.c, coreboot.c and ramdisk.c and there

[SeaBIOS] [PATCH 0/4] Minimal import of Kconfig

2011-01-26 Thread Kevin O'Connor
This patch series adds Kconfig to SeaBIOS. The goal is to do this with a minimal impact to the current SeaBIOS build and config system. Further build and config changes can be done in subsequent patches. This imports the latest Kconfig from the Linux 2.6 tree. -Kevin Kevin O'Connor (4

[SeaBIOS] [PATCH 4/4] Start using Kconfig to configure SeaBIOS settings.

2011-01-26 Thread Kevin O'Connor
Create autoconf.h during the build. Move a couple of config settings from config.h to Kconfig. --- .gitignore|2 ++ Makefile | 12 +--- src/Kconfig | 15 +++ src/config.h | 11 ++- src/defconfig |6 ++ 5 files changed, 34 insertions(+),

Re: [SeaBIOS] [PATCH 4/4] Start using Kconfig to configure SeaBIOS settings.

2011-01-27 Thread Kevin O'Connor
On Fri, Jan 28, 2011 at 03:45:09AM +0100, Stefan Reinauer wrote: * Kevin O'Connor ke...@koconnor.net [110127 03:38]: Create autoconf.h during the build. Move a couple of config settings from config.h to Kconfig. [...] -$(OUT)ccode32flat.o: ; $(call whole-compile, $(CFLAGS32FLAT

[SeaBIOS] [PATCHv2 0/4] Minimal import of Kconfig

2011-01-27 Thread Kevin O'Connor
src/defconfig - have Kconfig build it automatically Some Makefile fixes Kevin O'Connor (4): Initial commit of Kconfig build tool. Build changes for Linux kconfig code to work in seabios dir structure. Change kconfig to emit disabled symbols in autoconf.h. Start using Kconfig

[SeaBIOS] [PATCH 1/4] Initial commit of Kconfig build tool.

2011-01-27 Thread Kevin O'Connor
This is a pure copy of the tool from the Linux v2.6.38-rc2 scripts/kconfig/ directory. --- tools/kconfig/.gitignore | 23 + tools/kconfig/Makefile | 354 + tools/kconfig/POTFILES.in| 12 + tools/kconfig/check.sh | 14 +

[SeaBIOS] [PATCHv2 3/4] Change kconfig to emit disabled symbols in autoconf.h.

2011-01-27 Thread Kevin O'Connor
Always emit CONFIG_X definitions in autoconf.h - set them to 0 when they are disabled. --- tools/kconfig/confdata.c | 11 ++- 1 files changed, 10 insertions(+), 1 deletions(-) diff --git a/tools/kconfig/confdata.c b/tools/kconfig/confdata.c index 61c35bf..f110bf5 100644 ---

[SeaBIOS] [PATCHv2 4/4] Start using Kconfig to configure SeaBIOS settings.

2011-01-27 Thread Kevin O'Connor
Create autoconf.h during the build. Move a couple of config settings from config.h to Kconfig. --- .gitignore |2 ++ Makefile | 16 src/Kconfig | 15 +++ src/config.h | 11 ++- 4 files changed, 31 insertions(+), 13 deletions(-) create mode

[SeaBIOS] [PATCH] Support non-local build directory - allow make OUT=abc/ to work.

2011-01-29 Thread Kevin O'Connor
Don't require the build directory to be the out/ directory of the SeaBIOS source. --- Makefile |3 ++- src/config.h |2 +- src/romlayout.S |4 ++-- vgasrc/vgaentry.S |2 +- 4 files changed, 6 insertions(+), 5 deletions(-) diff --git a/Makefile b/Makefile index

Re: [SeaBIOS] [PATCH] lest pretend that RTC can be used to wakeup from S4

2011-01-30 Thread Kevin O'Connor
On Sun, Jan 30, 2011 at 03:30:43PM +0100, Peter Stuge wrote: Gleb Natapov wrote: WHQL complains otherwise. Is there something further that should be activated, to actually allow the wakeup to work? Hm, isn't S4 hibernate? Not in a bios. Qemu currently exits on S4 (hibernate to

Re: [SeaBIOS] A question on SeaBIOS PCI Enumeration

2011-02-10 Thread Kevin O'Connor
On Mon, Feb 07, 2011 at 07:17:52PM +, Prasad Joshi wrote: Hello, I am working on QEMU to pass-through a graphics device. I noticed few problems with PCI enumeration hence I compiled SeaBIOS with more debug information. The PCI enumeration problem seems to be related to

Re: [SeaBIOS] [PATCH] Updated version of OXPCIe serial port support

2011-02-12 Thread Kevin O'Connor
On Fri, Feb 11, 2011 at 01:18:03PM -0800, Stefan Reinauer wrote: add support for OXPCIe 952 card and clean up debug abstraction layer Signed-off-by: Stefan Reinauer reina...@google.com Thanks. See comments below. [...] +#define OXPCIE_COM1 (oxpcie_bar + 0x1000) +u32 oxpcie_bar

Re: [SeaBIOS] [PATCH] Allow to run option roms with bad checksums

2011-02-12 Thread Kevin O'Connor
On Fri, Feb 11, 2011 at 01:26:43PM -0800, Stefan Reinauer wrote: See patch -- Stefan Reinauer Google Inc. Allow running option roms with a wrong checksum. Signed-off-by: Stefan Reinauer reina...@google.com This is an area where SeaBIOS could really use a mechanism to load config

Re: [SeaBIOS] Problem with DOS application and 286 DOS Extender application

2011-02-14 Thread Kevin O'Connor
On Sun, Feb 13, 2011 at 03:06:44PM +0100, Gerhard Wiesinger wrote: Hello, After some fortune I found out that also Turbo Debugger 286 doesn't work under plain DOS 6.22 (without any memory mananger just pressing F5) or with some memory mananagers (HIMEM.SYS, EMM386, QEMM386). Error message

Re: [SeaBIOS] [PATCH] Updated version of OXPCIe serial port support

2011-02-15 Thread Kevin O'Connor
On Sun, Feb 13, 2011 at 06:26:32PM -0800, Stefan Reinauer wrote: On Sat, Feb 12, 2011 at 2:30 PM, Kevin O'Connor ke...@koconnor.net wrote: +    while ((readb((void *)OXPCIE_COM1+SEROFF_LSR) 0x60) != 0x60) I'm not sure how this will work.  The bar is likely to be in high memory, yet

[SeaBIOS] Git repo moving

2011-02-15 Thread Kevin O'Connor
The SeaBIOS git repo can now be accessed via: git clone git://git.seabios.org/seabios.git This is a separate repo from the one located on the linuxtogo.org site. I will maintain the two repos for the next couple of months, but will eventually stop updating the linuxtogo one. The new repo

[SeaBIOS] [ANNOUNCE] SeaBIOS 0.6.2

2011-02-28 Thread Kevin O'Connor
I've tagged a new release of SeaBIOS. For more information on the release, please see: http://seabios.org/Releases New in this release: * Setup code can relocate to high-memory to save space in c-f segments * Build now configured via Kconfig * Experimental support for AHCI

Re: [SeaBIOS] Some questions

2011-02-28 Thread Kevin O'Connor
On Fri, Feb 25, 2011 at 10:35:04AM -0500, Stefan Berger wrote: On 11/25/2010 08:35 AM, Kevin O'Connor wrote: This is due to the hierarchical nature of the functions. Also, while for example B calls A, B fills a data structure (on the stack) that it passes to A. A of course can get the same

Re: [SeaBIOS] [ANNOUNCE] SeaBIOS 0.6.2

2011-03-04 Thread Kevin O'Connor
On Fri, Mar 04, 2011 at 03:50:41PM -0800, H. Peter Anvin wrote: On 02/28/2011 06:37 PM, Kevin O'Connor wrote: * Support T13 EDD3.0 spec EDD 4.0? I'm not sure if you're asking if that is a typo or if you're asking if EDD4 can be added. As near as I can tell, we added T13 EDD3.0. I'm

[SeaBIOS] [PATCH] Add config option to disable MTRR initialization.

2011-03-06 Thread Kevin O'Connor
Some versions of Bochs don't like the MTRR initialization, so add CONFIG_MTRR_INIT to control whether SeaBIOS will touch the MTRRs. --- src/Kconfig |6 ++ src/mtrr.c |2 +- 2 files changed, 7 insertions(+), 1 deletions(-) diff --git a/src/Kconfig b/src/Kconfig index fca73e4..f064b27

Re: [SeaBIOS] [PATCH] Allow to run option roms with bad checksums

2011-03-06 Thread Kevin O'Connor
. -Kevin From cc975646af69f279396d4d5e1379ac6af80ee637 Mon Sep 17 00:00:00 2001 Message-Id: cc975646af69f279396d4d5e1379ac6af80ee637.1299457605.git.ke...@koconnor.net From: Kevin O'Connor ke...@koconnor.net Date: Sun, 6 Mar 2011 19:22:46 -0500 Subject: [PATCH] Add config option to permit running option

Re: [SeaBIOS] [PATCH] Add config option to disable MTRR initialization.

2011-03-08 Thread Kevin O'Connor
On Mon, Mar 07, 2011 at 09:37:59PM +0100, Sebastian Herbszt wrote: Kevin O'Connor wrote: Some versions of Bochs don't like the MTRR initialization, so add Which versions don't? I ran into it with the version fc14 has - Bochs v2.4.5. I get: 00034041578i[CPU0 ] 0x01fe28e9 wrmsr : 0F30

Re: [SeaBIOS] Reset bug in SeaBIOS / qemu?

2011-03-10 Thread Kevin O'Connor
Hi Matthew. I'm forwarding your mail to the seabios list. I'll also take a look at this later on. On Wed, Mar 09, 2011 at 06:29:20PM +, Matthew Bloch wrote: Hi Kevin - I'm not sure whether this is a qemu bug or SeaBIOS' but your commit 244caf86f11f5f65d166d91704f64cb673167abc seems to

Re: [SeaBIOS] Reset bug in SeaBIOS / qemu?

2011-03-13 Thread Kevin O'Connor
On Thu, Mar 10, 2011 at 08:42:00AM -0500, Kevin O'Connor wrote: Hi Matthew. I'm forwarding your mail to the seabios list. I'll also take a look at this later on. On Wed, Mar 09, 2011 at 06:29:20PM +, Matthew Bloch wrote: Hi Kevin - I'm not sure whether this is a qemu bug

Re: [SeaBIOS] [PATCH] Add config option to disable MTRRinitialization.

2011-03-16 Thread Kevin O'Connor
On Tue, Mar 15, 2011 at 11:29:21PM +0100, Sebastian Herbszt wrote: I was now able to reproduce it: [...] It happens because your Bochs 2.4.5 version was compiled without x86-64 support and --enable-long-phy-address and only supports 32-bit phys_bits. You can recompile it or upgrade to 2.4.6 to

Re: [SeaBIOS] Some questions

2011-03-31 Thread Kevin O'Connor
On Wed, Mar 30, 2011 at 07:31:23PM -0400, Stefan Berger wrote: I mailed them today to seabios@seabios.org but didn't see them coming back or showing up on the webpage. I cc'ed the Qemu mailing list and there they are. Stefan The mailing list had a blip yesterday - but it should be okay

Re: [SeaBIOS] [Qemu-devel] [PATCH V1 3/8] Implementation of the TCG BIOS extensions

2011-04-03 Thread Kevin O'Connor
Hi Stefan, I haven't had a chance to fully review, but I do have some comments. On Wed, Mar 30, 2011 at 01:55:37PM -0400, Stefan Berger wrote: [...] - a utility function called mssleep is added. It waits for a number of milliseconds before it returns. I had tried to build a function like

Re: [SeaBIOS] [Qemu-devel] [PATCH V1 2/8] Provide ACPI SSDT table for TPM device + S3 resume support

2011-04-03 Thread Kevin O'Connor
On Wed, Mar 30, 2011 at 01:55:36PM -0400, Stefan Berger wrote: This patch provides ACPI support for the TPM device. It probes for the TPM device and only if a TPM device is found then the TPM's SSDT and TCPA table are created. This patch also connects them to the RSDT. [...] // Space to

Re: [SeaBIOS] [Qemu-devel] [PATCH V1 6/8] Add measurement code to the BIOS

2011-04-03 Thread Kevin O'Connor
On Wed, Mar 30, 2011 at 01:55:40PM -0400, Stefan Berger wrote: This patch adds invocactions of functions that measure various parts of the code and data through various parts of the BIOS code. It follows TCG specifications on what needs to be measured. It also adds the implementation of the

Re: [SeaBIOS] my bios.bin.elf is too big

2011-04-06 Thread Kevin O'Connor
On Wed, Apr 06, 2011 at 06:42:09PM +0800, Rock Cui wrote: hello, everyone, I'm a seabios newer. I want to build a coreboot image with seabios as its payload. I need the seabios(bios.bin.elf) to be smaller then 1M, but I got a 1.3M one after building . I did not change anything in my seabios

Re: [SeaBIOS] non-emulated AHCI hardware

2011-04-28 Thread Kevin O'Connor
On Tue, Apr 26, 2011 at 09:15:04PM -0500, Scott Duplichan wrote: Kevin O'Connor wrote: ]Out of curiosity, can you see what happens if you return ]DISK_RET_EBOUNDARY in the unaligned case? DOS tries the same request 10 times then ignores the error and continues. Thanks for testing. ]It's

Re: [SeaBIOS] [PATCH v2] Make pci memory window configurable.

2011-04-28 Thread Kevin O'Connor
On Thu, Apr 28, 2011 at 08:28:40PM -0400, Kevin O'Connor wrote: [...] I think it would be better to define the kconfig variables needed (eg, PCIMEM_START, PCIMEM_SIZE, PCIMEM_PREFMEM_SIZE) [...] Hrmm - on second thought, we know the PCI range should end at 0xfec0, so I think kconfig only

Re: [SeaBIOS] [PATCH v2] Make pci memory window configurable.

2011-04-28 Thread Kevin O'Connor
On Thu, Apr 28, 2011 at 04:49:52PM +0200, Gerd Hoffmann wrote: This patch makes the memory window for PCI memory bars configurable via Kconfig. These BUILD_PCI* variables are only used by four lines of code in pciinit.c. The code only uses BUILD_PCIMEM_START, BUILD_PCIMEM_END,

Re: [SeaBIOS] [PATCH] skip interactive boot menu if only one boot device present

2011-04-30 Thread Kevin O'Connor
On Sat, Apr 30, 2011 at 10:19:25AM +0200, Sven Schnelle wrote: There's no point in presenting a menu to the user if there's only one option to choose from. In that case skip this menu to save some waiting time during boot. [...] +/* If we have only one bootdevice, + skip interactive

Re: [SeaBIOS] [PATCH v2] Make pci memory window configurable.

2011-04-30 Thread Kevin O'Connor
On Fri, Apr 29, 2011 at 09:37:05AM +0200, Gerd Hoffmann wrote: On 04/29/11 02:41, Kevin O'Connor wrote: On Thu, Apr 28, 2011 at 08:28:40PM -0400, Kevin O'Connor wrote: [...] I think it would be better to define the kconfig variables needed (eg, PCIMEM_START, PCIMEM_SIZE, PCIMEM_PREFMEM_SIZE

Re: [SeaBIOS] [PATCH] Support more than one vga card

2011-05-03 Thread Kevin O'Connor
On Tue, May 03, 2011 at 01:49:57PM -0300, Glauber Costa wrote: It is theorectically possible for a system to have more than one pci vga card. In particular, I am interested in the use of SGAbios as a pci device, alongside of a normal vga bios in QEMU. This patch makes seabios continue

Re: [SeaBIOS] Xen Hypervisor and Disk Drive Layer

2011-05-03 Thread Kevin O'Connor
On Tue, May 03, 2011 at 09:32:45AM +0200, Gerd Hoffmann wrote: Hi, I am going to write new code to allow SeaBios to use the split-driver model of Xen to write directly to the back-end device of Xen using shared memory, but was wondering if I could leverage the drive abstraction layer that

Re: [SeaBIOS] [PATCH] Support more than one vga card

2011-05-03 Thread Kevin O'Connor
On Tue, May 03, 2011 at 09:41:48PM -0300, Glauber Costa wrote: On Tue, 2011-05-03 at 19:58 -0400, Kevin O'Connor wrote: My understanding is that in a machine with multiple VGA devices only one vga device is setup to forward the legacy VGA IO ranges over PCI, and only that device should have

Re: [SeaBIOS] [PATCH v2] Make pci memory window configurable.

2011-05-03 Thread Kevin O'Connor
On Tue, May 03, 2011 at 12:34:42PM +0200, Gerd Hoffmann wrote: Is there any reason why there is a fixed split, other than making the code simpler (i.e. need only one instead of two passes over all pci devices)? I think the only reason is that a two pass PCI scan is more work than anyone

Re: [SeaBIOS] [PATCH] Support more than one vga card

2011-05-05 Thread Kevin O'Connor
On Thu, May 05, 2011 at 12:44:04PM +, Mark Marshall wrote: Not having access to the very beginning of the boot really limited sgabios' capabilities, so the vgaroms/ trick was added to SeaBIOS. (In particular, one couldn't change the boot order on a real machine.) It's ~3 lines of code

Re: [SeaBIOS] [coreboot] Keyboard not working on Thinkpad X60/T60

2011-05-07 Thread Kevin O'Connor
On Wed, May 04, 2011 at 10:16:17AM +0200, Sven Schnelle wrote: Will do. But right now i have the problem that the Keyboard isn't working on cold boot - seabios is probably started so early that some hardware parts are not finished with reset or similar things. [...] I've just modified

Re: [SeaBIOS] [coreboot] Keyboard not working on Thinkpad X60/T60

2011-05-07 Thread Kevin O'Connor
On Sat, May 07, 2011 at 08:48:45PM +0200, Sven Schnelle wrote: Kevin O'Connor ke...@koconnor.net writes: Some ps2 ports send NAK (0xfe) when there is no keyboard plugged in. The detection for NAK was added so that it doesn't take a full second to recognize that no keyboard is present

Re: [SeaBIOS] Is the SeaBIOS ELF 32 bit entry point a supported interface?

2011-05-10 Thread Kevin O'Connor
On Tue, May 10, 2011 at 01:47:34PM +0100, Ian Campbell wrote: Hi, It looks like it is but I just thought I should check, is starting SeaBIOS via the ELF entry point (post32 in romlayout.S) rather than via the 16 bit reset vector valid from the SeaBIOS point of view? It is valid - all

Re: [SeaBIOS] [RFC] [PATCH 0/2] Basic SeaBIOS support for Xen HVM

2011-05-14 Thread Kevin O'Connor
On Fri, May 13, 2011 at 04:59:03PM +0100, Ian Campbell wrote: As you may know we (the Xen project) are hoping to transition to SeaBIOS at the same time as we transition to the recently upstreamed qemu support for Xen. The following patches add very basic support for running SeaBIOS as the

Re: [SeaBIOS] [PATCH 2/2] Basic support for booting directly as Xen HVM firmware.

2011-05-14 Thread Kevin O'Connor
On Fri, May 13, 2011 at 04:59:24PM +0100, Ian Campbell wrote: This allows a guest to be booted using SeaBIOS directly as its firmware rather than being loaded indirectly via hvmloader. This is presented as a proof of concept since it's not obvious yet which the best approach will be from

Re: [SeaBIOS] [RFC] [PATCH 0/2] Basic SeaBIOS support for Xen HVM

2011-05-16 Thread Kevin O'Connor
On Mon, May 16, 2011 at 09:44:28AM +0100, Ian Campbell wrote: On Sat, 2011-05-14 at 14:36 +0100, Kevin O'Connor wrote: On Fri, May 13, 2011 at 04:59:03PM +0100, Ian Campbell wrote: As you may know we (the Xen project) are hoping to transition to SeaBIOS at the same time as we transition

Re: [SeaBIOS] [PATCH V4 2/8] Provide ACPI SSDT table for TPM device + S3 resume support

2011-05-18 Thread Kevin O'Connor
On Wed, May 18, 2011 at 03:49:25PM -0400, Stefan Berger wrote: On 04/12/2011 09:32 AM, Stefan Berger wrote: + +static u32 add_tpm_device(void **tpm_addr, void **tcpa_addr) +{ +struct tcpa_descriptor_rev2 *tcpa; + +*tpm_addr = NULL; +*tcpa_addr = NULL; + +if

Re: [SeaBIOS] [Xen-devel] Re: [RFC] [PATCH 0/2] Basic SeaBIOS support for Xen HVM

2011-05-26 Thread Kevin O'Connor
On Thu, May 26, 2011 at 04:13:37PM +0100, Ian Campbell wrote: On Tue, 2011-05-24 at 22:44 -0400, Kevin O'Connor wrote: On Tue, May 24, 2011 at 12:02:07PM +0100, Ian Campbell wrote: Would that involve pulling a bunch of mainboard specific stuff from coreboot into SeaBIOS? The idea

Re: [SeaBIOS] Issues with ASRock E350M1

2011-05-28 Thread Kevin O'Connor
On Thu, May 26, 2011 at 11:39:51PM -0500, Marshall Buschman wrote: Hello: I was instructed to send mail to you by Carebear from #coreboot. I have some issues to report based on the Golden Image I received from him, which was created for the ASRock E350M1. The first is with hard drive

Re: [SeaBIOS] Issues with ASRock E350M1

2011-05-28 Thread Kevin O'Connor
On Fri, May 27, 2011 at 02:11:14AM -0500, Scott Duplichan wrote: I also have USB keyboard problems, but my problem is different. For each key I press, it repeats a couple dozen times. I solve the problem by adding a 'break' to usb-hid.c: for (;;) { struct keyevent data;

Re: [SeaBIOS] Issues with ASRock E350M1

2011-05-29 Thread Kevin O'Connor
On Sun, May 29, 2011 at 03:17:40AM -0500, Scott Duplichan wrote: I decided to try and debug this myself. The attached patch is what I came up with. Within the limitations of typing abilities, it is now perfect. No sluggishness and no dropped keys. The head == next check was failing when it

Re: [SeaBIOS] [RfC PATCH 1/2] pci: move to two-pass pci initialization

2011-05-30 Thread Kevin O'Connor
On Tue, May 24, 2011 at 11:05:32AM +0200, Gerd Hoffmann wrote: This patch adds a second device scan to the pci initialization, which counts the memory bars of the various sizes and types. Then it calculates the sizes and the packing of the prefetchable and non-prefetchable pci memory windows

Re: [SeaBIOS] Graphics card pass-through working with two pass pci-initialization

2011-06-01 Thread Kevin O'Connor
On Wed, Jun 01, 2011 at 04:40:15PM +0200, Rudolf Marek wrote: Having a brief look at the coreboot code it seems static stuff (compiled by iasl) and dynamic bits are combined into the final dsdt table, is that correct? Yes the dsdt is static, it has just external references to ssdt which is

Re: [SeaBIOS] Graphics card pass-through working with two pass pci-initialization

2011-06-01 Thread Kevin O'Connor
On Wed, Jun 01, 2011 at 11:20:29PM +0900, Isaku Yamahata wrote: On Wed, Jun 01, 2011 at 09:30:12AM +0200, Gerd Hoffmann wrote: Hi, 0xE000 is hard-coded in the DSDT for both piix and q35 as below. If the range is determined dynamically, the area also needs to be updated somehow

Re: [SeaBIOS] Xen HVM Support

2011-06-05 Thread Kevin O'Connor
On Wed, Jun 01, 2011 at 10:59:10AM +0100, Ian Campbell wrote: The following enables support for running SeaBIOS as the virtual BIOS in a Xen HVM (fully-virtualised) guest. In this series SeaBIOS is loaded by hvmloader (the Xen early firmware) rather than directly as was previously tried.

Re: [SeaBIOS] [PATCH] Correct fseg allocation for SMBIOS tables.

2011-06-14 Thread Kevin O'Connor
On Tue, Jun 14, 2011 at 03:22:09PM +0100, Ian Campbell wrote: Anthony Perard noticed that grub was unhappy because it sees no low memory and that his e820 table was missing the first entry. He then pointed out this rather glaring error in the allocation of space for the SMBIOS tables. I've

Re: [SeaBIOS] introduce a patch to enhance seabios splash picture showing ability

2011-06-18 Thread Kevin O'Connor
Hi. Thanks for submitting your patch. On Fri, Jun 17, 2011 at 05:20:23PM +0800, Wayne Xia wrote: Patch description: ** There is suggestion to let KVM be able to show a logo when it start up. Although the sea-bios already included a

Re: [SeaBIOS] [PATCH] Enhance seabios splash picture showing ability

2011-06-18 Thread Kevin O'Connor
On Fri, Jun 17, 2011 at 05:35:13PM +0800, Wayne Xia wrote: Signed-off-by: Wayne Xia xiaw...@linux.vnet.ibm.com Thanks - see my comments below. [...] --- /dev/null +++ b/src/bmp.c @@ -0,0 +1,71 @@ +/* +* Basic BMP data process functions. +* Could used to adjust pixel data format, get

[SeaBIOS] [PATCH] Remove dev-i440fx.c/h - move code closer to its callers.

2011-06-19 Thread Kevin O'Connor
@@ -// initialization function which are specific to i440fx chipset -// -// Copyright (C) 2008 Kevin O'Connor ke...@koconnor.net -// Copyright (C) 2006 Fabrice Bellard -// -// Copyright (C) 2010 Isaku Yamahata yamahata at valinux co jp -// Split out from pciinit.c -// -// This file may be distributed

[SeaBIOS] [PATCH 0/2] Support white-listing of AHCI controllers in legacy ATA mode

2011-06-19 Thread Kevin O'Connor
This patch series enables the ATA code to support using select AHCI controllers in legacy ATA mode when SeaBIOS isn't compiled with the AHCI driver. I've only registered the device id of the controller on my e350m1 board, but it's easy to add more device ids. Kevin O'Connor (2): Convert ATA

[SeaBIOS] [PATCH 2/2] Add support for white-listing AHCI controllers as ATA compatible.

2011-06-19 Thread Kevin O'Connor
To start, register the AMD ATA controller on the A50M chipset as compatible with ATA mode even if it comes up in AHCI mode. --- src/ata.c | 22 +++--- 1 files changed, 19 insertions(+), 3 deletions(-) diff --git a/src/ata.c b/src/ata.c index 1540565..95e1352 100644 ---

[SeaBIOS] [PATCH 00/10] Add PCI device cache

2011-06-20 Thread Kevin O'Connor
/ pcipath), and it's likely PCI init on emulators could take advantage of this structure during PCI setup. This is the start of conversion to the 'struct pci_device' system - other users could also be converted. In particular, the pci_setup() code has not been converted. -Kevin Kevin O'Connor (10

[SeaBIOS] [PATCH 01/10] Rename foreachpci macro to foreachbdf.

2011-06-20 Thread Kevin O'Connor
--- src/ahci.c |4 ++-- src/ata.c|4 ++-- src/mptable.c|4 ++-- src/optionroms.c |4 ++-- src/pci.c| 10 +- src/pci.h|4 ++-- src/pcibios.c|6 +++--- src/pciinit.c|8 src/usb.c|4 ++--

[SeaBIOS] [PATCH 04/10] Convert option rom scan to use struct pci_device.

2011-06-20 Thread Kevin O'Connor
--- src/optionroms.c | 86 ++--- src/pci.c| 55 -- src/pci.h| 11 --- 3 files changed, 55 insertions(+), 97 deletions(-) diff --git a/src/optionroms.c b/src/optionroms.c index

[SeaBIOS] [PATCH 09/10] Convert USB detection code to use struct pci_device.

2011-06-20 Thread Kevin O'Connor
--- src/pci.h |3 +++ src/usb.c | 41 ++--- 2 files changed, 21 insertions(+), 23 deletions(-) diff --git a/src/pci.h b/src/pci.h index a214bb1..7aa2dfe 100644 --- a/src/pci.h +++ b/src/pci.h @@ -52,6 +52,9 @@ struct pci_device { extern struct

[SeaBIOS] [PATCH 02/10] Find all pci devices at startup and cache them for future use.

2011-06-20 Thread Kevin O'Connor
This adds 'struct pci_device' and pci_probe() which will locate and store all found PCI devices in the system at startup. --- src/pci.c | 60 src/pci.h | 20 src/post.c |1 + 3 files changed, 81

[SeaBIOS] [PATCH 10/10] Replace PCIPaths code with struct pci_device.

2011-06-20 Thread Kevin O'Connor
--- src/boot.c | 39 --- src/pci.c | 30 -- src/pci.h |5 - src/post.c |1 - 4 files changed, 24 insertions(+), 51 deletions(-) diff --git a/src/boot.c b/src/boot.c index 9a67916..f3c165c 100644 --- a/src/boot.c

[SeaBIOS] [PATCH 08/10] Convert AHCI detection code to use struct pci_device.

2011-06-20 Thread Kevin O'Connor
--- src/ahci.c | 12 ++-- 1 files changed, 6 insertions(+), 6 deletions(-) diff --git a/src/ahci.c b/src/ahci.c index b28597a..fb4b70c 100644 --- a/src/ahci.c +++ b/src/ahci.c @@ -8,7 +8,7 @@ #include ioport.h // inb #include util.h // dprintf #include biosvar.h // GET_EBDA

[SeaBIOS] [PATCH 0/4] Use 'struct pci_device' to limit option rom execution.

2011-06-21 Thread Kevin O'Connor
a device that isn't identified as a PCI_CLASS_STORAGE_IDE uses the native ATA driver. So, a bit in the 'struct pci_device' now notes when a native driver is in use and the option rom code checks for it. Gerd - this patch series (and the previous one) may conflict with your work. Kevin O'Connor (4

[SeaBIOS] [PATCH 1/4] Use manual PCI search when making bios ram writable.

2011-06-21 Thread Kevin O'Connor
During the ram unlock phase static variables can't be written, so don't rely on the higher level PCI searching functions. This will allow for future simplification of those high level search functions. This also limits the scan for the memory locking device to the first bus - the device should

[SeaBIOS] [PATCH 3/4] Convert pci_init_device to use 'struct pci_device'.

2011-06-21 Thread Kevin O'Connor
--- src/acpi.c| 16 +++--- src/ata.c | 13 ++- src/pci.c | 33 +- src/pci.h |8 -- src/pciinit.c | 61 src/shadow.c | 10 src/smm.c |6 ++-- 7

Re: [SeaBIOS] [PATCH 1/2] Boot up with a splash picture configurable,

2011-06-23 Thread Kevin O'Connor
On Wed, Jun 22, 2011 at 08:24:16PM +0800, Wayne Xia wrote: Signed-off-by: Wayne Xia xiaw...@linux.vnet.ibm.com Thanks. See my comments below. [...] +void raw_data_format_adjust_24bpp(u8 *src, u8 *dest, int width, int height, +int bytes_per_line_src, int bytes_per_line_dest, u8

Re: [SeaBIOS] [PATCH v2 0/2] Boot up with a splash picture configurable, testing about it

2011-07-02 Thread Kevin O'Connor
On Mon, Jun 27, 2011 at 10:21:18PM -0700, H. Peter Anvin wrote: On 06/27/2011 08:40 PM, Wayne Xia wrote: Yeah, BMP have a big size, but it would not lose quality of the image. So I'd like to make BMP decoder an option for seabios. If the user want to pass an image with compression, I

Re: [SeaBIOS] [PATCH v2 1/2] Boot up with a splash picture configurable

2011-07-02 Thread Kevin O'Connor
On Mon, Jun 27, 2011 at 03:10:38PM +0800, Wayne Xia wrote: added a bmp decoder, changed jpeg decoder to fix some problem in 24 bpp mode Thanks. In general it looks good to me. I have a few minor comments. [...] --- /dev/null +++ b/src/bmp.c @@ -0,0 +1,90 @@ +/* +* Basic BMP data process

Re: [SeaBIOS] [PATCH 1/4] pci: add two-pass pci initialization code

2011-07-02 Thread Kevin O'Connor
On Fri, Jun 24, 2011 at 05:24:35PM +0200, Gerd Hoffmann wrote: This patch adds a second device scan to the pci initialization, which counts the memory bars of the various sizes and types. Then it calculates the sizes and the packing of the prefetchable and non-prefetchable pci memory windows

[SeaBIOS] [PATCH 0/4] More 'struct pci' enhancements

2011-07-02 Thread Kevin O'Connor
More cleanups and enhancements. This series simplifies pci_next() so that it no longer needs to check for pci bridges. The vgahook changes in the first patch were compile tested only. -Kevin Kevin O'Connor (4): Calculate vgahook responses during setup instead of in 16bit code. Convert

[SeaBIOS] [PATCH 1/4] Calculate vgahook responses during setup instead of in 16bit code.

2011-07-02 Thread Kevin O'Connor
Do vga type and parameter detection during setup and store the necessary info in global variables for the 16bit code. This simplifies the vgahook 16bit code. --- src/coreboot.c |9 +- src/optionroms.c |3 +- src/util.h |5 +- src/vgahooks.c | 250

[SeaBIOS] [PATCH 4/4] Rename foreachbdf_in_bus to foreachbdf and simplify it.

2011-07-02 Thread Kevin O'Connor
Now that all callers of foreachbdf have been converted to foreachbdf_in_bus, simplify the pci_next() code - it no longer needs to track PCI bridges. Also, rename the remaining users of foreachbdf_in_bus to foreachbdf. --- src/pci.c | 40 +++- src/pci.h

Re: [SeaBIOS] [PATCH v2 1/4] pci: add two-pass pci initialization code

2011-07-04 Thread Kevin O'Connor
On Mon, Jul 04, 2011 at 12:59:09PM +0200, Gerd Hoffmann wrote: This patch adds a second device scan to the pci initialization, which counts the memory bars of the various sizes and types. Then it calculates the sizes and the packing of the prefetchable and non-prefetchable pci memory windows

[SeaBIOS] [PATCH 0/8] SeaBIOS code to extract config parameters

2011-07-05 Thread Kevin O'Connor
settings that are converted. -Kevin Kevin O'Connor (8): Add romfile code to assist with extract integer config settings. Replace CONFIG_BOOTMENU_WAIT with dynamic etc/boot-menu-wait file. Replace CONFIG_EXTRA_PCI_ROOTS with dynamic etc/extra-pci-roots file. Replace

[SeaBIOS] [PATCH 1/8] Add romfile code to assist with extract integer config settings.

2011-07-05 Thread Kevin O'Connor
Add romfile_loadint() function which can be used to extract a little-endian binary encoded integer from rom. --- src/paravirt.c | 19 +++ src/paravirt.h |1 + 2 files changed, 20 insertions(+), 0 deletions(-) diff --git a/src/paravirt.c b/src/paravirt.c index

[SeaBIOS] [PATCH 3/8] Replace CONFIG_EXTRA_PCI_ROOTS with dynamic etc/extra-pci-roots file.

2011-07-05 Thread Kevin O'Connor
--- src/Kconfig| 11 --- src/paravirt.h |1 + src/pci.c |8 3 files changed, 5 insertions(+), 15 deletions(-) diff --git a/src/Kconfig b/src/Kconfig index 0ffc49e..e732528 100644 --- a/src/Kconfig +++ b/src/Kconfig @@ -194,17 +194,6 @@ menu Hardware support

  1   2   3   4   5   6   7   8   9   10   >