Re: [SeaBIOS] [PATCH] serial console conflicts with serial debugging

2017-11-03 Thread Stephen Douthit
ebugging information to serial port. > Could we instead add a config option to set the default to SERCON UART address like we do for the debug UART address? Some boards have different UARTs for debug and user console, so I don't think we want these to be mutually exclusive. How about something

Re: [SeaBIOS] Long delay: WARNING - Timeout at wait_reg8:81!

2018-03-07 Thread Stephen Douthit
On 03/07/2018 12:41 PM, Kevin O'Connor wrote: On Wed, Mar 07, 2018 at 12:33:36PM -0500, Stephen Douthit wrote: On 03/07/2018 10:33 AM, Paul Menzel wrote: Dear Stephen, Thank you for your quick response. Am Dienstag, den 06.03.2018, 11:57 -0500 schrieb Stephen Douthit: On 03/06/2018 11:04

Re: [SeaBIOS] Long delay: WARNING - Timeout at wait_reg8:81!

2018-03-12 Thread Stephen Douthit
On 03/09/2018 09:49 AM, Stephen Douthit wrote: [This sender failed our fraud detection checks and may not be who they appear to be. Learn about spoofing at http://aka.ms/LearnAboutSpoofing] On 03/09/2018 06:05 AM, Paul Menzel wrote: Dear Stephen, On 03/07/2018 07:24 PM, Stephen Douthit

Re: [SeaBIOS] Long delay: WARNING - Timeout at wait_reg8:81!

2018-03-13 Thread Stephen Douthit
When tis_probe() returns '1', it means the interface was detected. If all registers return 0x in the no-TPM case we should return a '0' from tis_probe since rc was set to 0 from tis_wait_access() and we will not get into the ifaceid test case. If they return 0 then we shouldn't get past

Re: [SeaBIOS] Long delay: WARNING - Timeout at wait_reg8:81!

2018-03-13 Thread Stephen Douthit
On 03/13/2018 10:40 AM, Stefan Berger wrote: On 03/13/2018 10:15 AM, Stephen Douthit wrote: When tis_probe() returns '1', it means the interface was detected. If all registers return 0x in the no-TPM case we should return a '0' from tis_probe since rc was set to 0 from tis_wait_access

Re: [SeaBIOS] Long delay: WARNING - Timeout at wait_reg8:81!

2018-03-07 Thread Stephen Douthit
On 03/07/2018 10:33 AM, Paul Menzel wrote: Dear Stephen, Thank you for your quick response. Am Dienstag, den 06.03.2018, 11:57 -0500 schrieb Stephen Douthit: On 03/06/2018 11:04 AM, Paul Menzel wrote: On 03/02/18 17:31, Kevin O'Connor wrote: On Tue, Feb 27, 2018 at 02:17:08PM -0500

Re: [SeaBIOS] Long delay: WARNING - Timeout at wait_reg8:81!

2018-03-09 Thread Stephen Douthit
On 03/09/2018 06:05 AM, Paul Menzel wrote: Dear Stephen, On 03/07/2018 07:24 PM, Stephen Douthit wrote: On 03/07/2018 12:41 PM, Kevin O'Connor wrote: On Wed, Mar 07, 2018 at 12:33:36PM -0500, Stephen Douthit wrote: On 03/07/2018 10:33 AM, Paul Menzel wrote: Am Dienstag, den 06.03.2018

Re: [SeaBIOS] [PATCH v1 0/3] tpm: Support 2.0 TPM devices connected to a TIS host

2018-03-06 Thread Stephen Douthit
On 03/06/2018 11:04 AM, Paul Menzel wrote: Dear Stephen, dear Kevin, On 03/02/18 17:31, Kevin O'Connor wrote: On Tue, Feb 27, 2018 at 02:17:08PM -0500, Stephen Douthit wrote: […] Thanks.  I committed this series. The second commit introduced a regression with coreboot on the ASRock

Re: [SeaBIOS] [PATCH 0/3] Fix CRB probing to work with real hardware

2018-03-14 Thread Stephen Douthit
On 03/14/2018 01:42 PM, Stefan Berger wrote: This series of patches attempts to fix the probing of the CRB interface for real hardware. Stephen Douthit should test this on real hardware. Thanks for putting this together. The modded unit is tied up in other development work that I need

Re: [SeaBIOS] [PATCH 1/3] tpm: Wait for tpmRegValidSts flags on CRQ interface before probing

2018-03-19 Thread Stephen Douthit
On 03/19/2018 08:55 AM, Stefan Berger wrote: On 03/14/2018 03:42 PM, Kevin O'Connor wrote: On Wed, Mar 14, 2018 at 01:42:41PM -0400, Stefan Berger wrote: Wait for the tpmRegValidSts flag on the TPM_LOC_STATE_x register. Since it's not quite clear when this flag may become valid, we request

Re: [SeaBIOS] [PATCH v2 1/3] tpm: Wait for tpmRegValidSts flag on CRQ interface before probing

2018-03-19 Thread Stephen Douthit
On 03/19/2018 12:36 PM, Paul Menzel wrote: Dear Stephen, On 03/19/18 17:23, Stephen Douthit wrote: On 03/19/2018 12:00 PM, Stefan Berger wrote: Wait for the tpmRegValidSts flag on the TPM_LOC_STATE_x register to be set; we espect the locAssigned flag to not be set. s/espect/expect

Re: [SeaBIOS] [PATCH v2 1/3] tpm: Wait for tpmRegValidSts flag on CRQ interface before probing

2018-03-19 Thread Stephen Douthit
On 03/19/2018 12:00 PM, Stefan Berger wrote: Wait for the tpmRegValidSts flag on the TPM_LOC_STATE_x register to be set; we espect the locAssigned flag to not be set. s/espect/expect/ and in the subject line s/CRQ/CRB Just retested the v2 series on my board so: Tested-by: Stephen Douthit

Re: [SeaBIOS] [PATCH v1 2/3] tpm: Wait for interface startup when probing

2018-03-02 Thread Stephen Douthit
On 03/02/2018 11:05 AM, Kevin O'Connor wrote: On Tue, Feb 27, 2018 at 02:17:10PM -0500, Stephen Douthit wrote: This is based on wait_startup() from the Linux tpm_tis driver. Signed-off-by: Stephen Douthit <steph...@silicom-usa.com> Tested-by: Stephen Douthit <steph...@silico

[SeaBIOS] [PATCH 0/3] Support TPM2.0 devices on TIS host

2018-02-26 Thread Stephen Douthit
f an Intel C3758, but have not regression tested with TPM 1.2 devices. Regards, Steve Stephen Douthit (3): tpm: Refactor duplicated wait code in tis_wait_sts() & crb_wait_reg() tpm: Wait for interface startup when probing tpm: Support 2.0 TPM devices connected to a TIS host src/hw/tpm_d

Re: [SeaBIOS] [PATCH 3/3] tpm: Support 2.0 TPM devices connected to a TIS host

2018-02-26 Thread Stephen Douthit
On 02/26/2018 05:09 PM, Stefan Berger wrote: On 02/26/2018 03:37 PM, Stephen Douthit wrote: tis_get_tpm_version() was returning the interface version, which is always 1.2 since tis_probe() would have failed if the interface wasn't TIS. New version check is based on the tpm2_probe() function

[SeaBIOS] [PATCH 3/3] tpm: Support 2.0 TPM devices connected to a TIS host

2018-02-26 Thread Stephen Douthit
tis_get_tpm_version() was returning the interface version, which is always 1.2 since tis_probe() would have failed if the interface wasn't TIS. New version check is based on the tpm2_probe() function from the Linux tpm_tis driver. Signed-off-by: Stephen Douthit <steph...@silicom-usa.com>

[SeaBIOS] [PATCH 1/3] tpm: Refactor duplicated wait code in tis_wait_sts() & crb_wait_reg()

2018-02-26 Thread Stephen Douthit
Signed-off-by: Stephen Douthit <steph...@silicom-usa.com> Tested-by: Stephen Douthit <steph...@silicom-usa.com> --- src/hw/tpm_drivers.c | 80 ++-- 1 file changed, 33 insertions(+), 47 deletions(-) diff --git a/src/hw/tpm_driver

Re: [SeaBIOS] [PATCH 1/3] tpm: Refactor duplicated wait code in tis_wait_sts() & crb_wait_reg()

2018-02-26 Thread Stephen Douthit
On 02/26/2018 05:35 PM, Stefan Berger wrote: On 02/26/2018 03:37 PM, Stephen Douthit wrote: Signed-off-by: Stephen Douthit <steph...@silicom-usa.com> Tested-by: Stephen Douthit <steph...@silicom-usa.com> ---   src/hw/tpm_drivers.c | 80 ++--

[SeaBIOS] [PATCH 2/3] tpm: Wait for interface startup when probing

2018-02-26 Thread Stephen Douthit
This is based on wait_startup() from the Linux tpm_tis driver. Signed-off-by: Stephen Douthit <steph...@silicom-usa.com> Tested-by: Stephen Douthit <steph...@silicom-usa.com> --- src/hw/tpm_drivers.c | 13 - 1 file changed, 12 insertions(+), 1 deletion(-) diff --

Re: [SeaBIOS] [PATCH 3/3] tpm: Support 2.0 TPM devices connected to a TIS host

2018-02-27 Thread Stephen Douthit
On 02/26/2018 06:02 PM, Stefan Berger wrote: On 02/26/2018 05:44 PM, Stephen Douthit wrote: On 02/26/2018 05:09 PM, Stefan Berger wrote: On 02/26/2018 03:37 PM, Stephen Douthit wrote: tis_get_tpm_version() was returning the interface version, which is always 1.2 since tis_probe() would have