[SeaBIOS] Re: [PATCH v2] build: use -fcf-protection=none when available

2020-05-14 Thread Kevin O'Connor 
On Tue, May 12, 2020 at 12:58:31PM +0200, Christian Ehrhardt wrote:
> On Fri, Mar 20, 2020 at 9:38 AM Christian Ehrhardt
>  wrote:
> >
> > Some hardened gcc v9 compilers (such as the one in Ubuntu)
> > default this option which for seabios leads to emulation errors
> > when running in KVM (does not trigger in TCG) on older intel
> > chips of the Penryn generation (~2006-2008).
> 
> Hi,
> other than the request to add "endbr32/endbr64 interpretation
> failures" to the commit message there was no other feedback.
> This was done in v2 and since then nothing happened, therefore I
> wanted to ping if this can be accepted into master?

Thanks.  It's committed now.

-Kevin
___
SeaBIOS mailing list -- seabios@seabios.org
To unsubscribe send an email to seabios-le...@seabios.org

[SeaBIOS] Re: [PATCH v2] build: use -fcf-protection=none when available

2020-05-12 Thread Christian Ehrhardt 
On Fri, Mar 20, 2020 at 9:38 AM Christian Ehrhardt
 wrote:
>
> Some hardened gcc v9 compilers (such as the one in Ubuntu)
> default this option which for seabios leads to emulation errors
> when running in KVM (does not trigger in TCG) on older intel
> chips of the Penryn generation (~2006-2008).

Hi,
other than the request to add "endbr32/endbr64 interpretation
failures" to the commit message there was no other feedback.
This was done in v2 and since then nothing happened, therefore I
wanted to ping if this can be accepted into master?

> The symptom appears as endbr32/endbr64 interpretation failures
> and in KVM it looks like:
>   KVM internal error. Suberror: 1
>   emulation failure
>   EAX= EBX= ECX=86d4 EDX=
>   ESI= EDI= EBP=86d4 ESP=6d7c
>   EIP=7acf EFL=0002 [---] CPL=0 II=0 A20=1 SMM=0 HLT=0
>   ES =   00809300
>   CS =f000 000f  00809b00
>   SS =   00809300
>   DS =   00809300
>   FS =   00809300
>   GS =   00809300
>   LDT=   8200
>   TR =   8b00
>   GDT= 000f6200 0037
>   IDT=  03ff
>   CR0=0010 CR2= CR3= CR4=
>   DR0= DR1=
>   DR2= DR3=
>   DR6=0ff0 DR7=0400
>   EFER=
>   Code=b8 90 d9 00 00 66 e8 6b f7 ff ff 66 b8 0a 00 00
>00 e9 61 f2  0f 1e fb 66 57 66 56 66 53 66 53
>66 89 c7 67 66 89 14 24 66 89 ce 66 e8 15 f8 ff ff 88
>
> URL: https://bugs.launchpad.net/ubuntu/+source/qemu/+bug/1866870
> Signed-off-by: Christian Ehrhardt 
> ---
>  Makefile | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/Makefile b/Makefile
> index 5f7d5370..9e8188e5 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -69,6 +69,7 @@ COMMONCFLAGS += $(call 
> cc-option,$(CC),-fno-stack-protector,)
>  COMMONCFLAGS += $(call cc-option,$(CC),-fno-stack-protector-all,)
>  COMMONCFLAGS += $(call cc-option,$(CC),-fstack-check=no,)
>  COMMONCFLAGS += $(call cc-option,$(CC),-Wno-address-of-packed-member,)
> +COMMONCFLAGS += $(call cc-option,$(CC),-fcf-protection=none,)
>  COMMA := ,
>
>  CFLAGS32FLAT := $(COMMONCFLAGS) -DMODE16=0 -DMODESEGMENT=0
> --
> 2.25.1
>


-- 
Christian Ehrhardt
Staff Engineer, Ubuntu Server
Canonical Ltd
___
SeaBIOS mailing list -- seabios@seabios.org
To unsubscribe send an email to seabios-le...@seabios.org