RE: [PATCH] selinux: print leading 0x on ioctlcmd audits

2016-07-15 Thread Roberts, William C
seandroid-list@tycho.nsa.gov; > seli...@tycho.nsa.gov; linux-au...@redhat.com > Subject: Re: [PATCH] selinux: print leading 0x on ioctlcmd audits > > On Friday, July 15, 2016 7:33:09 PM EDT Roberts, William C wrote: > > > > > > > > This is important so that people d

Re: [PATCH] selinux: print leading 0x on ioctlcmd audits

2016-07-15 Thread Paul Moore
On Fri, Jul 15, 2016 at 3:31 PM, Roberts, William C wrote: > Does this mean then the patch will be applied? As I mentioned earlier, I added it to the SELinux next queue, as soon as the merge window closes (approx two weeks from this weekend) I will rotate the patch

RE: [PATCH] selinux: print leading 0x on ioctlcmd audits

2016-07-15 Thread Roberts, William C
> > This is important so that people don't make up new ones that do the > > same thing. The ioctlcmd field name should be recorded. Are there more > > that need documenting? > > Steve/William, one of you want to send a patch/PR for the field dictionary? I'll send it over.

Re: [PATCH] selinux: print leading 0x on ioctlcmd audits

2016-07-15 Thread Paul Moore
On Fri, Jul 15, 2016 at 2:54 PM, Steve Grubb <sgr...@redhat.com> wrote: > On Thursday, July 14, 2016 6:17:32 PM EDT Paul Moore wrote: >> Re: [PATCH] selinux: print leading 0x on ioctlcmd audits >> From: Paul Moore <p...@paul-moore.com> >> To: william.

Re: [PATCH] selinux: print leading 0x on ioctlcmd audits

2016-07-15 Thread Steve Grubb
On Thursday, July 14, 2016 6:17:32 PM EDT Paul Moore wrote: > Re: [PATCH] selinux: print leading 0x on ioctlcmd audits > From: Paul Moore <p...@paul-moore.com> > To: william.c.robe...@intel.com > CC: seli...@tycho.nsa.gov, seandroid-list@tycho.nsa.gov, Stephen Smalley >

Re: [PATCH] selinux: print leading 0x on ioctlcmd audits

2016-07-15 Thread Paul Moore
On Thu, Jul 14, 2016 at 7:33 PM, William Roberts wrote: > On Thu, Jul 14, 2016 at 4:18 PM, William Roberts wrote: >> On Thu, Jul 14, 2016 at 3:17 PM, Paul Moore wrote: >>> On Thu, Jul 14, 2016 at 3:29 PM, wrote: >>> >

Re: [PATCH] selinux: print leading 0x on ioctlcmd audits

2016-07-15 Thread Paul Moore
On Thu, Jul 14, 2016 at 3:29 PM, wrote: > From: William Roberts > > ioctlcmd is currently printing hex numbers, but their is no leading > 0x. Thus things like ioctlcmd=1234 are misleading, as the base is > not evident. > > Correct this