[PATCH] libselinux: add support for pcre2

2016-09-15 Thread Janis Danisevskis
From: Janis Danisevskis This patch moves all pcre1/2 dependencies into the new files regex.h and regex.c implementing the common denominator of features needed by libselinux. The compiler flag -DUSE_PCRE2 toggles between the used implementations. As of this patch libselinux

Re: [PATCH] libselinux: add support for pcre2

2016-09-15 Thread Stephen Smalley
On 09/15/2016 10:04 AM, Janis Danisevskis wrote: > From: Janis Danisevskis > > This patch moves all pcre1/2 dependencies into the new files regex.h > and regex.c implementing the common denominator of features needed > by libselinux. The compiler flag -DUSE_PCRE2 toggles

Re: [PATCH v3] libselinux: clean up process file

2016-09-15 Thread Stephen Smalley
On 09/09/2016 02:27 PM, Stephen Smalley wrote: > On 09/09/2016 01:44 PM, william.c.robe...@intel.com wrote: >> From: William Roberts >> >> The current process_file() code will open the file >> twice on the case of a binary file, correct this. >> >> The general flow

Re: [PATCH v3] libselinux: clean up process file

2016-09-15 Thread William Roberts
Ill send that right up! On Thu, Sep 15, 2016 at 7:42 AM, Stephen Smalley wrote: > On 09/09/2016 02:27 PM, Stephen Smalley wrote: >> On 09/09/2016 01:44 PM, william.c.robe...@intel.com wrote: >>> From: William Roberts >>> >>> The current

Re: [PATCH] libselinux: add support for pcre2

2016-09-15 Thread Stephen Smalley
On 09/15/2016 12:14 PM, Janis Danisevskis wrote: > From: Janis Danisevskis > > This patch moves all pcre1/2 dependencies into the new files regex.h > and regex.c implementing the common denominator of features needed > by libselinux. The compiler flag -DUSE_PCRE2 toggles

[PATCH] libselinux: correct error path to always try text

2016-09-15 Thread william . c . roberts
From: William Roberts patch 5e15a52aaa cleans up the process_file() but introduced a bug. If the binary file cannot be opened, always attempt to fall back to the textual file, this was not occurring. The logic should be: 1. Open the newest file based on base path +

Re: [PATCH] libselinux: add support for pcre2

2016-09-15 Thread William Roberts
On Thu, Sep 15, 2016 at 7:57 AM, Stephen Smalley wrote: > On 09/15/2016 10:04 AM, Janis Danisevskis wrote: >> From: Janis Danisevskis >> >> This patch moves all pcre1/2 dependencies into the new files regex.h >> and regex.c implementing the common

[PATCH v3] libselinux: correct error path to always try text

2016-09-15 Thread william . c . roberts
From: William Roberts patch 5e15a52aaa cleans up the process_file() but introduced a bug. If the binary file cannot be opened, always attempt to fall back to the textual file, this was not occurring. The logic should be: 1. Open the newest file based on base path +

Re: [PATCH v2] libselinux: correct error path to always try text

2016-09-15 Thread William Roberts
> + if (!rc) { > + rc = digest_add_specfile(digest, fp, NULL, > sb.st_size, found_path); > + } One more time... ___ Seandroid-list mailing list Seandroid-list@tycho.nsa.gov To unsubscribe, send email

[PATCH v2] libselinux: correct error path to always try text

2016-09-15 Thread william . c . roberts
From: William Roberts patch 5e15a52aaa cleans up the process_file() but introduced a bug. If the binary file cannot be opened, always attempt to fall back to the textual file, this was not occurring. The logic should be: 1. Open the newest file based on base path +