hg: jdk7/tl/jdk: 6935997: Please add a nested throwable constructor to AssertionError

2010-06-08 Thread joe . darcy
Changeset: a21e3a29ca9d Author:darcy Date: 2010-06-08 18:52 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/a21e3a29ca9d 6935997: Please add a nested throwable constructor to AssertionError Reviewed-by: martin, forax, wetmore ! src/share/classes/java/lang/AssertionError.java

Re: Code review request for 6935997 "Please add a nested throwable constructor to AssertionError"

2010-06-08 Thread Brad Wetmore
As we discussed here, this looks fine. Brad On 6/8/2010 8:31 AM, Joe Darcy wrote: Thanks Martin and Rémi for the quick reviews! Upon further consideration, before doing the push I decided to look for instances in the jdk repo where this new constructor could be used and I found one in java.se

Re: Code review request for 6935997 "Please add a nested throwable constructor to AssertionError"

2010-06-08 Thread Joe Darcy
Thanks Martin and Rémi for the quick reviews! Upon further consideration, before doing the push I decided to look for instances in the jdk repo where this new constructor could be used and I found one in java.security.Security: --- old/src/share/classes/java/security/Security.java2010-06-

hg: jdk7/tl/jdk: 6957375: java/net/ResponseCache getResponseCode and ResponseCacheTest fail after rebranding

2010-06-08 Thread chris . hegarty
Changeset: 489c1720757b Author:chegar Date: 2010-06-08 10:46 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/489c1720757b 6957375: java/net/ResponseCache getResponseCode and ResponseCacheTest fail after rebranding Reviewed-by: ohair, wetmore, alanb ! test/java/net/ResponseCa