Re: code review request: 6960894: Better AS-REQ creation and processing

Hi, Max, KrbAsRep.java => 1) the javadoc of its decrypt method only documents the first two arguments which seems incomplete. You meant to emphasize that there two are user-provided? Maybe you can just enhance the method description. In addition, only one of the keys and password arguments is

hg: jdk7/tl/jdk: 6510892: com/sun/net/httpserver/bugs/B6361557.java fails

Changeset: 4d72d0ec83f5 Author:michaelm Date: 2010-07-30 18:16 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/4d72d0ec83f5 6510892: com/sun/net/httpserver/bugs/B6361557.java fails Reviewed-by: chegar ! test/com/sun/net/httpserver/bugs/B6361557.java

Re: code review request: 6973371: X509Factory should recognize PEM headers

Hi Max, I'm not sure about this change. There's a definitely a change in behavior. Before generateCertificate would only read one PEM block from the stream, and throw an exception if it wasn't a certificate. But the current fix ignores non certificate blocks until it finds a certificate or end

hg: jdk7/tl/langtools: 8 new changesets

Changeset: 4cca8d7ce6c1 Author:lana Date: 2010-06-21 22:09 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/4cca8d7ce6c1 Merge Changeset: d1d7595fa824 Author:lana Date: 2010-06-29 22:43 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/d1d7595fa

hg: jdk7/tl/jdk: 58 new changesets

Changeset: 4d55419ce99e Author:andrew Date: 2010-06-08 17:52 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/4d55419ce99e 6959123: Remove use of obsolete png_check_sig function in splashscreen_png.c Summary: Avoid use of deprecated libpng macro (removed in some 1.4.x releases)

code review request: 6973371: X509Factory should recognize PEM headers

Hi Sean 6973371: X509Factory should recognize PEM headers Please review the webrev: http://cr.openjdk.java.net/~weijun/6973371/webrev.00/ There is one place I haven't touched, generateCertPath. PKCS #7 PEM block should begin with -BEGIN PKCS7-, or as described in [1], with -BEG

hg: jdk7/tl/jaxws: 7 new changesets

Changeset: db63f482182d Author:lana Date: 2010-06-21 22:07 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jaxws/rev/db63f482182d Merge Changeset: bd26d0ce0c3c Author:lana Date: 2010-06-29 22:31 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jaxws/rev/bd26d0ce0c3c Mer

hg: jdk7/tl/jaxp: 7 new changesets

Changeset: 478835e100cd Author:lana Date: 2010-06-21 22:07 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jaxp/rev/478835e100cd Merge Changeset: d524be5ef62e Author:lana Date: 2010-06-29 22:31 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jaxp/rev/d524be5ef62e Merge