6653372 code review request

2010-08-02 Thread Sean Mullan
Hi Max, Can you review this simple fix? http://cr.openjdk.java.net/~mullan/6653372/webrev.00/ Thanks, Sean

hg: jdk7/tl/langtools: 6973626: test/tools/javac/processing/* tests fail with assertions enabled

2010-08-02 Thread jonathan . gibbons
Changeset: 6318230cdb82 Author:jjg Date: 2010-08-02 16:29 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/6318230cdb82 6973626: test/tools/javac/processing/* tests fail with assertions enabled Reviewed-by: darcy !

Re: code review request: 6973371: X509Factory should recognize PEM headers

2010-08-02 Thread Weijun Wang
On 08/03/2010 05:10 AM, Sean Mullan wrote: On 7/31/10 9:46 AM, Weijun Wang wrote: Yes, you're correct. I regard not-working - working a fix, not a regression. I think I would regard it as underspecified. There's nothing in CertificateFactory.generateCertificate that says it skips