Re: review request for 7008728: diamond conversion of basic security, permission, authentication code

2010-12-28 Thread Stuart Marks
On 12/27/10 12:15 PM, Sean Mullan wrote: On 12/22/10 8:39 PM, Stuart Marks wrote: http://cr.openjdk.java.net/~smarks/reviews/7008728/webrev.0/ src/share/classes/com/sun/security/auth/SubjectCodeSource.java [96] Looks like the converter also missed another one. I think this line should be: ne

Re: review request for 7008713: diamond conversion of kerberos5 and security tools

2010-12-28 Thread Stuart Marks
On 12/27/10 11:58 AM, Sean Mullan wrote: One instance where I think it is debatable as to whether it improves code readability is if the variable is declared somewhere else in the code. In these cases I find myself scrolling upwards or searching to find the declaration to see what type the parame

Re: Please Review: required security algorithms for Java SE 7 implementations

2010-12-28 Thread Sean Mullan
I have posted the 3rd revision of the required algorithms list at: http://cr.openjdk.java.net/~mullan/5001004/review.02/StandardNames.html#impl Changes since the initial (00) version are: - added MD5 and HmacMD5 to the required algorithms - added the CertPath Encodings PKCS7 and PkiPath to the