Re: Code review request for 7036252: sunpkcs11-solaris.cfg needs a review

2011-04-29 Thread Sean Mullan
This looks fine. However, the bug report never mentions why it is ok to remove the CKM_SSL3_KEY_AND_MAC_DERIVE and CKM_TLS_KEY_AND_MAC_DERIVE mechanisms. I think it should be updated. Also, isn't this the kind of thing we should periodically review each release? If so, maybe we should create

hg: jdk7/tl/jdk: 7040150: Indexing Error in CachedRowSetImpl.removeCurrentRow

2011-04-29 Thread lance . andersen
Changeset: 0b1354ecf5a3 Author:lancea Date: 2011-04-29 09:04 -0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/0b1354ecf5a3 7040150: Indexing Error in CachedRowSetImpl.removeCurrentRow Reviewed-by: smarks ! src/share/classes/com/sun/rowset/CachedRowSetImpl.java

hg: jdk7/tl/jdk: 7039809: Remove @ConstructorProperties annotation from java.io.File class

2011-04-29 Thread mandy . chung
Changeset: 24ad188dc46c Author:mchung Date: 2011-04-29 08:51 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/24ad188dc46c 7039809: Remove @ConstructorProperties annotation from java.io.File class Reviewed-by: alanb, malenkov ! src/share/classes/java/io/File.java -

hg: jdk7/tl/langtools: 4 new changesets

2011-04-29 Thread maurizio . cimadamore
Changeset: 4c03383f6529 Author:mcimadamore Date: 2011-04-29 16:05 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/4c03383f6529 7040104: javac NPE on Object a[]; Object o = (a=null)[0]; Summary: When a null literal is found on top of stack, if expected type is

hg: jdk7/tl/jaxp: 7040147: jaxp 1.4.5 jdk7 integration

2011-04-29 Thread kelly . ohair
Changeset: 30129a58aacc Author:ohair Date: 2011-04-29 10:58 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jaxp/rev/30129a58aacc 7040147: jaxp 1.4.5 jdk7 integration Reviewed-by: joehw ! jaxp.properties

Re: Code review request for 7036252: sunpkcs11-solaris.cfg needs a review

2011-04-29 Thread Frances Ho
So what were the results from your run on the T4? performance wise. On 4/29/2011 11:14 AM, Valerie (Yu-Ching) Peng wrote: Right, good point. I'll update the bugster w/ evaluation on CKM_SSL3_KEY_AND_MAC_DERIVE and CKM_TLS_KEY_AND_MAC_DERIVE. True, conceptually this should be done for every

Re: Code review request for 7036252: sunpkcs11-solaris.cfg needs a review

2011-04-29 Thread Valerie (Yu-Ching) Peng
In general, T4 runs much faster, this goes not just for PKCS11 provider, but for pure java provider as well. My run is focused on the settings of disabled mechanism section. Based on the run results, message digests excluded, performance numbers are similar between the default one and the

hg: jdk7/tl/jdk: 7040572: Fix broken java/nio/charset/StandardCharset/Standard.java and add more tests.

2011-04-29 Thread mike . duigou
Changeset: 36dd30b5f85d Author:mduigou Date: 2011-04-29 14:09 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/36dd30b5f85d 7040572: Fix broken java/nio/charset/StandardCharset/Standard.java and add more tests. Reviewed-by: alanb !