Re: Code review request: 7059709, java/jsse, close the IO in a final block

2011-06-28 Thread Brad Wetmore
While I was thinking the same thing as Sean/Stuart, it's not clear how much risk you would be refactoring a lot of code just to use this language feature. It's pretty clear (to me anyway) what you were intending here. Brad On 6/28/2011 1:31 PM, Stuart Marks wrote: On 6/28/11 11:46 AM, Sea

Re: Code review request: 7059709, java/jsse, close the IO in a final block

2011-06-28 Thread Stuart Marks
On 6/28/11 11:46 AM, Sean Mullan wrote: On 6/27/11 9:29 PM, Xuelei Fan wrote: webrev: http://cr.openjdk.java.net/~xuelei/7059709/webrev.00/ It seems you could restructure this code by moving the instantiation of the FileInputStream down just before the KeyStore.load and use a try-with-resource

Re: Code review request: 7059709, java/jsse, close the IO in a final block

2011-06-28 Thread Sean Mullan
On 6/27/11 9:29 PM, Xuelei Fan wrote: webrev: http://cr.openjdk.java.net/~xuelei/7059709/webrev.00/ It seems you could restructure this code by moving the instantiation of the FileInputStream down just before the KeyStore.load and use a try-with-resources block instead. --Sean

Re: sun.security.provider.certpath.DistributionPointFetcher

2011-06-28 Thread Sean Mullan
On 6/28/11 1:01 PM, David Pomeroy wrote: Hi Sean, I am using Open JDK 6. Are the indirect CRL bugs in JDK 6 documented anywhere? Are there any workarounds? See: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6509162 http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6542169 No known wor

Re: sun.security.provider.certpath.DistributionPointFetcher

2011-06-28 Thread David Pomeroy
Hi Sean, I am using Open JDK 6. Are the indirect CRL bugs in JDK 6 documented anywhere? Are there any workarounds? I am setting enableCRLDP. Thanks, Dave On Tue, Jun 28, 2011 at 5:46 AM, Sean Mullan wrote: > Are you using JDK 7? There were some bugs fixed with indirect CRLs in JDK > 7. > >

Re: sun.security.provider.certpath.DistributionPointFetcher

2011-06-28 Thread Xuelei Fan
Thanks for the feedback, I will look into the log If I can get some time tomorrow. Thanks, Xuelei On 6/29/2011 12:57 AM, David Pomeroy wrote: > Hi Xuelei, > > Attached is the certpath debug output. > > Here is some more info about my test setup. > > Dev Root CA issued Dev Sub CA > Dev Sub CA

Re: sun.security.provider.certpath.DistributionPointFetcher

2011-06-28 Thread David Pomeroy
Hi Xuelei, Attached is the certpath debug output. Here is some more info about my test setup. Dev Root CA issued Dev Sub CA Dev Sub CA issued client cert Dev Root CA issued Dev Crl Server cert Crl is issued by Dev Crl Server, URL is http://localhost/crl.crl Dev Root CA, Dev Sub CA, and Dev Crl S

Re: sun.security.provider.certpath.DistributionPointFetcher

2011-06-28 Thread Sean Mullan
Are you using JDK 7? There were some bugs fixed with indirect CRLs in JDK 7. Also, make sure you set the system property com.sun.security.enableCRLDP to the value true when running, ex: java -Dcom.sun.security.enableCRLDP=true ... --Sean On 6/28/11 1:05 AM, [email protected] wrote: Can you

hg: jdk8/tl/jdk: 2 new changesets

2011-06-28 Thread michael . x . mcmahon
Changeset: 7b5a0a141b8b Author:michaelm Date: 2011-06-28 10:07 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/7b5a0a141b8b 7058832: com/sun/net/httpserver/bugs/B6373555.java failing intermittently Reviewed-by: alanb ! test/com/sun/net/httpserver/bugs/B6373555.java Changeset

hg: jdk8/tl/jdk: 7039182: PPC: NIO: java.io.IOException: Invalid argument in sun.nio.ch.FileDispatcherImpl.read0

2011-06-28 Thread david . holmes
Changeset: 3abc52f0a4dc Author:dholmes Date: 2011-06-27 20:13 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3abc52f0a4dc 7039182: PPC: NIO: java.io.IOException: Invalid argument in sun.nio.ch.FileDispatcherImpl.read0 Summary: Allow platform specific files to be located at b