On 7/7/11 10:05 PM, Bradford Wetmore wrote:
My only comment is in the diff section. I realize it's a FileInputStream and
all the bytes should be obtained on a read, but I think you might want to
consider the case of a short read for whatever reason. FileInputStream doesn't
guarantee that all byte
Hi Max,
> Ping
Pong. :)
My only comment is in the diff section. I realize it's a
FileInputStream and all the bytes should be obtained on a read, but I
think you might want to consider the case of a short read for whatever
reason. FileInputStream doesn't guarantee that all bytes will be
r
Ping again. Or, someone else can take a look?
On 06/23/2011 08:48 AM, Weijun Wang wrote:
http://cr.openjdk.java.net/~weijun/6330275/webrev.00/
Thanks
Max
On 06/23/2011 08:03 AM, Brad Wetmore wrote:
No, feel free to take it.
Brad
On 6/21/2011 2:24 AM, Weijun Wang wrote:
Hi Brad
# Timed
Changeset: 7337295434b6
Author:jjg
Date: 2011-07-07 13:29 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/7337295434b6
7061125: Proposed javac argument processing performance improvement
Reviewed-by: jjg, dlsmith, mcimadamore, forax
Contributed-by: [email protected]
!
I have a blog to talk about the trap.
http://sim.ivi.co/2011/07/trap-of-case-insensitive-string.html
Xuelei
On 7/7/2011 4:53 PM, Xuelei Fan wrote:
> On 7/7/2011 4:42 PM, [email protected] wrote:
>> I did not check all directories. I think we may need to evaluate them in the
>> same CR or ac
On 7/7/2011 4:42 PM, [email protected] wrote:
> I did not check all directories. I think we may need to evaluate them in the
> same CR or according to modules.
Too quick to reply the e-mail. I refer "them" to toUpperCase() and
toLowerCase() methods, rather than the equalsIgnoreCase() methood.
On Jul 7, 2011, at 4:30 PM, Weijun Wang wrote:
> Hi Xuelei
>
> There are some other places using equalsIgnoreCase(). Is this method safe for
> all locales?
>
equalsIgnoreCase() is safe. Looking into the code of this method, you will find
that the implementation is a little different from ju
I did not check all directories. I think we may need to evaluate them in the
same CR or according to modules.
Andrew
On Jul 7, 2011, at 4:30 PM, Weijun Wang wrote:
> Hi Xuelei
>
> There are some other places using equalsIgnoreCase(). Is this method safe for
> all locales?
>
> Thanks
> Max
Hi Xuelei
There are some other places using equalsIgnoreCase(). Is this method
safe for all locales?
Thanks
Max
