On Jul 21, 2011, at 1:25 AM, Alexandre Boulgakov
wrote:
> This is a Netbeans warning, not generated by the compiler. The reason is that
> List.isEmpty() can be more efficient for some implementations.
> ArrayList.size() == 0 and ArrayList.isEmpty() should take the same time, so
> it doesn't
Changeset: 9505edecc8b5
Author:jjg
Date: 2011-07-20 12:19 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/9505edecc8b5
7068617: Core libraries don't build with javac -Xlint:all -Werror
Reviewed-by: darcy
Contributed-by: [email protected]
! make/java/java/Makefile
"JAVAC_MAX_WARNINGS = true" is the same as "JAVAC_LINT_OPTIONS =
-Xlint:all", so the only warnings being ignored are deprecation warnings.
-Sasha
On 7/19/2011 8:10 PM, Xuelei Fan wrote:
About the makefile. In some makefiles, you added:
JAVAC_MAX_WARNINGS = false
JAVAC_LINT_OPTIONS = -
This is a Netbeans warning, not generated by the compiler. The reason is
that List.isEmpty() can be more efficient for some implementations.
ArrayList.size() == 0 and ArrayList.isEmpty() should take the same time,
so it doesn't matter for allResults, but keyTypeList is a List argument,
so any i
Hi Sasha,
The updates look fine to me.
--Sean
On 7/18/11 9:21 PM, Alexandre Boulgakov wrote:
> Hello,
>
> Here's an updated webrev:
> http://cr.openjdk.java.net/~smarks/aboulgak/7064075.2/
>
> I've reexamined the @SuppressWarnings("unchecked") annotations, and
> added comments to all of the o
