Re: Enhance toString() to return structured info, for certificate and probably more

2011-08-25 Thread Weijun Wang
Well, I mentioned toString() there just to make it look absurd so that I can promote my alternative method. :) As for the toDescription() method, do you know if there are other cases it can be useful? Thanks Max On 08/26/2011 10:03 AM, Mike Duigou wrote: On Aug 25 2011, at 14:01 , Dr Andr

Re: Enhance toString() to return structured info, for certificate and probably more

2011-08-25 Thread Mike Duigou
On Aug 25 2011, at 14:01 , Dr Andrew John Hughes wrote: > On 10:41 Thu 25 Aug , Weijun Wang wrote: >> Hi All >> >> I was talking with Xuelei on how to better display certificate info. >> There are 3 cases we can currently think of: >> >> 1. debug output >> 2. keytool/jarsigner output >> 3.

code review request: 7083576 (was Re: no javax/xml/crypto jprt test targets in jdk/test/Makefile)

2011-08-25 Thread Weijun Wang
[ Add [email protected] to CC] I think so. javax/xml/crypto is public API and it should go to jdk_security2 (along with javax/crypto). Of course, that is still not included in the default run. I've filed a bug: 7083576: add javax/xml/crypto into jdk_security2 test rule and he

Request for review Remove "private" cause in jdk exceptions

2011-08-25 Thread Sebastian Sickelmann
Am 26.08.2011 00:24, schrieb Sebastian Sickelmann: Am 26.08.2011 00:03, schrieb Sebastian Sickelmann: I have found more places in jdk source where an Exception has a private cause field. share/classes/javax/management/remote/JMXProviderException.java: private Throwable cause = null; share/

Re: 7081804: Remove cause field from javax.xml.crypto.NoSuchMechnismException

2011-08-25 Thread Sebastian Sickelmann
Am 26.08.2011 00:03, schrieb Sebastian Sickelmann: I have found more places in jdk source where an Exception has a private cause field. share/classes/javax/management/remote/JMXProviderException.java: private Throwable cause = null; share/classes/javax/xml/crypto/KeySelectorException.java:

Re: 7081804: Remove cause field from javax.xml.crypto.NoSuchMechnismException

2011-08-25 Thread Sebastian Sickelmann
I have found more places in jdk source where an Exception has a private cause field. share/classes/javax/management/remote/JMXProviderException.java: private Throwable cause = null; share/classes/javax/xml/crypto/KeySelectorException.java:private Throwable cause; share/classes/javax/xml

Re: Enhance toString() to return structured info, for certificate and probably more

2011-08-25 Thread Dr Andrew John Hughes
On 10:41 Thu 25 Aug , Weijun Wang wrote: > Hi All > > I was talking with Xuelei on how to better display certificate info. > There are 3 cases we can currently think of: > > 1. debug output > 2. keytool/jarsigner output > 3. Java plugin display > > The 1st one is the most primitive one and

Re: Code review request for 7024697

2011-08-25 Thread Valerie (Yu-Ching) Peng
Looks fine. Thanks, Valerie On 08/25/11 06:45, Seán Coffey wrote: This is a forward port of http://bugs.sun.com/view_bug.do?bug_id=7024697 to jdk 7 & 8 releases. Code change is identical to that made in jdk6. http://cr.openjdk.java.net/~coffeys/webrev.7024697/ regards, Sean.

hg: jdk8/tl/jdk: 7082727: VirtualMachineError should declare its serialVersionUID

2011-08-25 Thread joe . darcy
Changeset: 624cc18a6cf9 Author:darcy Date: 2011-08-25 09:42 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/624cc18a6cf9 7082727: VirtualMachineError should declare its serialVersionUID Reviewed-by: alanb ! src/share/classes/java/lang/VirtualMachineError.java

hg: jdk8/tl/jdk: 7044870: java/nio/channels/DatagramChannel/SelectWhenRefused.java failed on SUSE Linux 10

2011-08-25 Thread chris . hegarty
Changeset: c9e78769c0da Author:chegar Date: 2011-08-25 16:08 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c9e78769c0da 7044870: java/nio/channels/DatagramChannel/SelectWhenRefused.java failed on SUSE Linux 10 Reviewed-by: alanb, chegar Contributed-by: kurchi.subhra.ha...@o

Code review request for 7024697

2011-08-25 Thread Seán Coffey
This is a forward port of http://bugs.sun.com/view_bug.do?bug_id=7024697 to jdk 7 & 8 releases. Code change is identical to that made in jdk6. http://cr.openjdk.java.net/~coffeys/webrev.7024697/ regards, Sean.