Re: Request for review Remove private cause in jdk exceptions

2011-08-26 Thread Alan Bateman
Sebastian Sickelmann wrote: OK. Webrev is there: http://oss-patches.24.eu/openjdk8/NoSuchMechanismException/REBASED_ON_8018d541a7b2_2/ Can someone review this? I think this one will require careful review and I'm not even sure that it's worth it. Using serialPersistentFields and

Re: code review request: 7083576 (was Re: no javax/xml/crypto jprt test targets in jdk/test/Makefile)

2011-08-26 Thread Sean Mullan
Looks fine though you missed updating the copyright date on the test. --Sean On 8/25/11 9:44 PM, Weijun Wang wrote: [ Add security-dev@openjdk.java.net to CC] I think so. javax/xml/crypto is public API and it should go to jdk_security2 (along with javax/crypto). Of course, that is still

Re: code review request: 7083576 (was Re: no javax/xml/crypto jprt test targets in jdk/test/Makefile)

2011-08-26 Thread Weijun Wang
On 08/26/2011 09:15 PM, Sean Mullan wrote: Looks fine though you missed updating the copyright date on the test. Recently I form a new habit of not touching copyright years at all, so that a changeset can be ported to another version with no change at all. -Max --Sean On 8/25/11 9:44

Re: code review request: 7083576 (was Re: no javax/xml/crypto jprt test targets in jdk/test/Makefile)

2011-08-26 Thread Sean Mullan
On 8/26/11 9:42 AM, Weijun Wang wrote: On 08/26/2011 09:15 PM, Sean Mullan wrote: Looks fine though you missed updating the copyright date on the test. Recently I form a new habit of not touching copyright years at all, so that a changeset can be ported to another version with no change

hg: jdk8/tl/jdk: 7060243: (dc) Multicasting tests fail on Windows XP if IPv6 is enabled

2011-08-26 Thread alan . bateman
Changeset: 6d2f09eed4e3 Author:alanb Date: 2011-08-26 22:24 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/6d2f09eed4e3 7060243: (dc) Multicasting tests fail on Windows XP if IPv6 is enabled Reviewed-by: alanb Contributed-by: kurchi.subhra.ha...@oracle.com !

Re: 7081804: Remove cause field from javax.xml.crypto.NoSuchMechnismException

2011-08-26 Thread Sebastian Sickelmann
Am 22.08.2011 17:28, schrieb Sean Mullan: (dropping core-libs-dev) On 8/22/11 9:03 AM, Sebastian Sickelmann wrote: Hi, while making some change for using exception-chaining on RuntimeException in more cases, i found that javax.xml.crypto.NoSuchMechnismException had a private cause field that

Re: Request-Review: Remove two simple warnings in HttpsURLConnection.java

2011-08-26 Thread Xuelei Fan
Hi Sebastian, Thank you for your contribution on OpenJDK. The update looks fine to me. Do you have a CR (Change Request) for this update? BTW, have you signed the Oracle Contribution Agreement [1]? I did not find you name in the OpenJDK people list. Thanks, Xuelei [1]