Changeset: a5a28b040714
Author:chegar
Date: 2011-09-01 06:45 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/a5a28b040714
7014860: Socket.getInputStream().available() not clear for shutdown input
Reviewed-by: alanb, michaelm
! src/share/classes/java/net/AbstractPlainSocketImp
On 9/1/2011 12:31 PM, Weijun Wang wrote:
>
> On 08/31/2011 09:17 PM, Xuelei Fan wrote:
>> I understand the code, fine to me. But the loadKeyStore() method looks
>> really ugly and lazy. :-)
>
> It's ugly, but not very lazy.
>
Lazy code is not a bad coding style. ;-)
> Anyway, I'm going to putba
On 08/31/2011 09:17 PM, Xuelei Fan wrote:
I understand the code, fine to me. But the loadKeyStore() method looks
really ugly and lazy. :-)
It's ugly, but not very lazy.
Anyway, I'm going to putback this version since you already said fine.
Just for your reference in the inline comments.
Changeset: f85d980faaf8
Author:jjg
Date: 2011-08-31 15:39 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/f85d980faaf8
7074416: Regression: JSR199: javac doesn't unwrap clientcodewrapper objects
Reviewed-by: mcimadamore
! src/share/classes/com/sun/tools/javac/api/Client
I agree that we should not remove all tests for DSA keypair generation - this
could also hide any new regressions in that area.
It's my understanding that there are still some tests that test DSA keypair
generation, just not as many, so the likelihood of encountering the Solaris bug
is smaller. Is
Changeset: b86277584776
Author:mcimadamore
Date: 2011-08-31 16:11 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/b86277584776
7085024: internal error; cannot instantiate Foo
Summary: Types.isConvertible does not handle erroneous types correctly
Reviewed-by: jjg
! src/s
I understand the code, fine to me. But the loadKeyStore() method looks
really ugly and lazy. :-)
Just for your reference in the inline comments.
On 8/31/2011 4:00 PM, Weijun Wang wrote:
>
>
> On 08/30/2011 09:52 PM, Xuelei Fan wrote:
>> 1. Do you want to add more debug info? line 1509-1511:
>>
I may argue more in a different viewpoint from you. ;-)
1. I don't think the failure is noise, it is valuable information to
tell us that there is problem in our implementation or underlying
platform. If it happens again and again, it means that we don't solve
the problem from build to build. If w
More:
You can see that I simply added "-keyalg rsa". Most of these tests are
not designed to test on any algorithm, instead, they test various
functions/commands of the tool. Maybe this change will reveal some RSA
problems. Who knows? :)
(I admit if it really finds out any, I don't know what
My personal view was not faraway from yours -- I am not so frightened by
test failures.
However, zero tolerance of any test failure is becoming a common sense
of the team and the whole JPG [1]. Evaluating test failures is consuming
too much time for both release engineers, SQE and us. Especial
On 08/30/2011 09:52 PM, Xuelei Fan wrote:
1. Do you want to add more debug info? line 1509-1511:
+if (debug) {
+e.printStackTrace();
+}
Yes. The -debug option is used to show exception full stack when an
error occurs. I want the exception printed for w
11 matches
Mail list logo
