Re: 7054637 closed/lib/security/cacerts/VerifyCACerts.java failed on solaris 11

2011-09-23 Thread Michael StJohns
At 04:13 PM 9/23/2011, Vincent Ryan wrote: >On 09/23/11 05:41 PM, Michael StJohns wrote: >> Heh - I thought this looked familiar. >> >> Please take a look at my comments in bug 6763530, especially the fix for >> P11Key around line 1017. >> > >I didn't see any comments from you in bug 6763530

Re: code review request: 7077646: gssapi wrap for CFX per-message tokens always set FLAG_ACCEPTOR_SUBKEY

2011-09-23 Thread Valerie (Yu-Ching) Peng
The changes look good to me. Thanks, Valerie On 09/22/11 08:05, Weijun Wang wrote: Webrev at http://cr.openjdk.java.net/~weijun/7077646/webrev.00/ According to RFC 4121 [1]: 2. Key Derivation for Per-Message Tokens ... During the context initiation and acceptance sequence, the acce

Re: 7054637 closed/lib/security/cacerts/VerifyCACerts.java failed on solaris 11

2011-09-23 Thread Vincent Ryan
On 09/23/11 05:41 PM, Michael StJohns wrote: > Heh - I thought this looked familiar. > > Please take a look at my comments in bug 6763530, especially the fix for > P11Key around line 1017. > I didn't see any comments from you in bug 6763530? > Would it make sense to back out the fix that

Re: 7081804: Remove cause field from javax.xml.crypto.NoSuchMechnismException

2011-09-23 Thread Sean Mullan
On 9/17/11 3:09 PM, Sebastian Sickelmann wrote: >> i have updated the webrev [0]. >> But i think that L69 and L72 of the test should be changed to >> checkMutable and the implementation of the exceptions accordantly. That's an interesting question. The current implementation in your code is cons

Re: 7054637 closed/lib/security/cacerts/VerifyCACerts.java failed on solaris 11

2011-09-23 Thread Michael StJohns
Heh - I thought this looked familiar. Please take a look at my comments in bug 6763530, especially the fix for P11Key around line 1017. Would it make sense to back out the fix that was put into P11Key to fix that bug in favor of a provider based solution (e.g. same boolean check)? Other

Re: 7054637 closed/lib/security/cacerts/VerifyCACerts.java failed on solaris 11

2011-09-23 Thread Vincent Ryan
Thanks for your feedback Michael. I agree that your provider-based solution is preferable. Here's a revised webrev: http://cr.openjdk.java.net/~vinnie/7054637/webrev.01/ On 09/22/11 11:18 PM, Michael StJohns wrote: > Hi Vincent - > > Sorry - it took me a few days to look at this. I can't supp

hg: jdk8/tl/jdk: 7091003: ScheduledExecutorService never executes Runnable with corePoolSize of zero

2011-09-23 Thread chris . hegarty
Changeset: 8dab38c07b6b Author:dl Date: 2011-09-23 14:24 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/8dab38c07b6b 7091003: ScheduledExecutorService never executes Runnable with corePoolSize of zero Reviewed-by: dholmes, chegar ! src/share/classes/java/util/concurrent/Sch

Re: Code review request: 7092375 Security libraries don't build with javac -Werror

2011-09-23 Thread Xuelei Fan
I only reviewed my commented changes. If you updated other files, please let me know. Just one minor comment, read inlines, please. On Sep 23, 2011, at 2:36 PM, Kurchi Hazra wrote: > Hi Xuelei, > > Thanks a lot for your comments. Please find an updated webrev at : > http://cr.openjdk.java.