Re: updated code review request: 7099399: cannot deal with CRL file larger than 16MB

2011-10-13 Thread Weijun Wang
On 10/13/2011 2:10 AM, Florian Weimer wrote: * Seán Coffey: Should this test be set to run manually ? 5 mins is far too long for a jtreg unit test IMO. Sorry, I was talking about the whole time for the job. I just go into each log to take a look at the exact time for the test itself. Most

hg: jdk8/tl/jdk: 2 new changesets

2011-10-13 Thread sean . mullan
Changeset: 01615d3e74ed Author:mullan Date: 2011-10-13 13:50 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/01615d3e74ed 6953295: Move few sun.security.{util, x509, pkcs} classes used by keytool/jarsigner to another package Reviewed-by: mchung ! make/sun/security/other/Make

hg: jdk8/tl/jdk: 7099228: Use a PKCS11 config attribute to control encoding of an EC point

2011-10-13 Thread vincent . x . ryan
Changeset: 2b27e14a4c82 Author:vinnie Date: 2011-10-13 12:00 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/2b27e14a4c82 7099228: Use a PKCS11 config attribute to control encoding of an EC point Reviewed-by: valeriep, mullan ! src/share/classes/sun/security/pkcs11/Config.jav

Re: updated code review request: 7099399: cannot deal with CRL file larger than 16MB

2011-10-13 Thread Florian Weimer
* Seán Coffey: > Should this test be set to run manually ? > > 5 mins is far too long for a jtreg unit test IMO. If the visibility of the internal helper method is changed, you could test with a custom InputStream and ByteArrayOutputStream, which would cut down memory requirements. -- Florian W

Re: updated code review request: 7099399: cannot deal with CRL file larger than 16MB

2011-10-13 Thread Seán Coffey
Should this test be set to run manually ? 5 mins is far too long for a jtreg unit test IMO. regards, Sean. On 13/10/2011 02:52, Xuelei Fan wrote: Looks fine to me. Xuelei On 10/13/2011 3:12 AM, Weijun Wang wrote: Sorry, a new updated webrev http://cr.openjdk.java.net/~weijun/7099399/web