Re: Code Review Needed: 7031830: bad_record_mac failure on TLSv1.2 enabled connection with SSLEngine

2011-10-14 Thread Xuelei Fan
The change of SSLEngineImpl looks fine to me. In the new regression test: A. class name 28 * @run main/othervm SSLEngineTemplate 29 * 30 * SunJSSE does not support dynamic system properties, no way to re-use 31 * system properties in samevm/agentvm mode. I think the class name shoul

Re: Kerberos codes in Apple's Java

2011-10-14 Thread Weijun Wang
On Oct 14, 2011, at 5:50 PM, Bino George wrote: > Hi Max, > >> 1. Looking for krb5.conf at /Library/Preferences/edu.mit.Kerberos > > I filed http://java.net/jira/browse/MACOSX_PORT-566 which tracks this > feature. This should be fairly straight forward to port it from JDK6. We > fixed JDK6 in

Re: Code Review Needed: 7031830: bad_record_mac failure on TLSv1.2 enabled connection with SSLEngine

2011-10-14 Thread Brad Wetmore
I'll need a second codereviewer for the 7u2 change. Valerie/Sean/Max? Brad On 10/14/2011 5:52 PM, Brad Wetmore wrote: Hi Xuelei, I need code reviews for the bug I mentioned to you earlier. 7031830: bad_record_mac failure on TLSv1.2 enabled connection with SSLEngine The MAC calculation was

Code Review Needed: 7031830: bad_record_mac failure on TLSv1.2 enabled connection with SSLEngine

2011-10-14 Thread Brad Wetmore
Hi Xuelei, I need code reviews for the bug I mentioned to you earlier. 7031830: bad_record_mac failure on TLSv1.2 enabled connection with SSLEngine The MAC calculation was summing the wrong data range when using non-direct byte buffers and TLS1.1/1.2. The new regression test will now interop

Re: Kerberos codes in Apple's Java

2011-10-14 Thread Bino George
Hi Max, > 1. Looking for krb5.conf at /Library/Preferences/edu.mit.Kerberos I filed http://java.net/jira/browse/MACOSX_PORT-566 which tracks this feature. This should be fairly straight forward to port it from JDK6. We fixed JDK6 in Lion to also read the Kerberos config from SCDynamicStore as

Kerberos codes in Apple's Java

2011-10-14 Thread Weijun Wang
Hi Mike I'm working in the Java SE Security Team in Oracle. Apple's JRE (at least in the JDK 6 releases) supports some extra Kerberos features for OS X. As I know, at least there are: 1. Looking for krb5.conf at /Library/Preferences/edu.mit.Kerberos 2. Reading native memory-based credentials