I only have a few very minor suggestions.
in sun/security/util/Cache.java:
-> 264 this.queue = soft ? new ReferenceQueue() : null;
^
I would like to remove the generic "V" in the right side of the assignment:
264 this.queue = soft ? new ReferenceQueue<
Thanks Max/Andrew!
On 10/17/2011 6:57 PM, Weijun Wang wrote:
src looks fine.
Not sure of test. So whenever you use socket on one side and engine on
another, this bug will jump out?
If you use a SSLsocket on side, and an SSLEngine on the other, and the
engine is using target ByteBuffers that
src looks fine.
Not sure of test. So whenever you use socket on one side and engine on
another, this bug will jump out?
-Max
On 10/15/2011 08:59 AM, Brad Wetmore wrote:
I'll need a second codereviewer for the 7u2 change. Valerie/Sean/Max?
Brad
On 10/14/2011 5:52 PM, Brad Wetmore wrote:
Both (JDK 7u2 and JDK 8) look fine to me. Thanks for the update.
Xuelei
On 10/18/2011 8:41 AM, Brad Wetmore wrote:
> (Max/Valerie/Sean, I am hoping to get this into 7u2, thus need a second
> codereview. The code itself is pretty straightforward.)
>
> Xuelei wrote:
>> The change of SSLEngineImpl
(Max/Valerie/Sean, I am hoping to get this into 7u2, thus need a second
codereview. The code itself is pretty straightforward.)
Xuelei wrote:
> The change of SSLEngineImpl looks fine to me.
>
> In the new regression test:
Changes made. Thanks for the feedback, Xuelei. I tweaked things a bit
Hi Xuelei,
Would you be able to review this fix?
http://cr.openjdk.java.net/~mullan/webrevs/7092897/webrev.00/
Thanks,
Sean
Changeset: b5d0b8effc85
Author:mcimadamore
Date: 2011-10-17 12:54 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/b5d0b8effc85
7097436: Project Coin: duplicate varargs warnings on method annotated with
@SafeVarargs
Summary: Duplicate aliasing check during subtyping lead
Changeset: 6cb07b35acf5
Author:weijun
Date: 2011-10-17 17:11 +0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/6cb07b35acf5
7099399: cannot deal with CRL file larger than 16MB
Reviewed-by: xuelei, mullan
! src/share/classes/sun/security/provider/X509Factory.java
+ test/sun/secu
