Re: 7094155 Code Review Request

2011-10-26 Thread Xuelei Fan
Looks fine to me. I also look at some other places that use the Node.getLocalName(). As this method may return null, I was wondering it would be nice if we also make changes to com/sun/org/apache/xml/internal/security/utils/ElementCheckerImpl.java, line 10: 9 if ((el == null) || 10 ns!=el.getN

hg: jdk8/tl/jdk: 29 new changesets

2011-10-26 Thread lana . steuck
Changeset: 19f0a3db863c Author:katleman Date: 2011-09-22 16:02 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/19f0a3db863c Added tag jdk8-b06 for changeset bdb870cc269e ! .hgtags Changeset: ac9349be6821 Author:katleman Date: 2011-09-29 18:53 -0700 URL: http:/

hg: jdk8/tl/langtools: 11 new changesets

2011-10-26 Thread lana . steuck
Changeset: 116980ecec5c Author:katleman Date: 2011-09-22 16:02 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/116980ecec5c Added tag jdk8-b06 for changeset d2422276f9da ! .hgtags Changeset: 9268bd271c6f Author:katleman Date: 2011-09-29 18:54 -0700 URL:

hg: jdk8/tl/jaxws: 5 new changesets

2011-10-26 Thread lana . steuck
Changeset: 134b0debf7b0 Author:katleman Date: 2011-09-22 16:02 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxws/rev/134b0debf7b0 Added tag jdk8-b06 for changeset ac22a946 ! .hgtags Changeset: 1c9d4f59acf8 Author:katleman Date: 2011-09-29 18:53 -0700 URL: http

hg: jdk8/tl/corba: 5 new changesets

2011-10-26 Thread lana . steuck
Changeset: 3d61f0856f34 Author:katleman Date: 2011-09-22 16:01 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/3d61f0856f34 Added tag jdk8-b06 for changeset 45c43dde7ba7 ! .hgtags Changeset: 0d52b1c87aa8 Author:katleman Date: 2011-09-29 18:53 -0700 URL: http

hg: jdk8/tl: 7 new changesets

2011-10-26 Thread lana . steuck
Changeset: 0db7ae9f2b10 Author:katleman Date: 2011-09-22 16:01 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/rev/0db7ae9f2b10 Added tag jdk8-b06 for changeset 28cf2aec4dd7 ! .hgtags Changeset: cf76aa4189e4 Author:katleman Date: 2011-09-29 18:53 -0700 URL: http://hg.

hg: jdk8/tl/jaxp: 5 new changesets

2011-10-26 Thread lana . steuck
Changeset: c114306576dc Author:katleman Date: 2011-09-22 16:02 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/c114306576dc Added tag jdk8-b06 for changeset d7b8192e7277 ! .hgtags Changeset: de4794dd69c4 Author:katleman Date: 2011-09-29 18:53 -0700 URL: http:

hg: jdk8/tl/jdk: 7090046: Lots of invalid link in java.text.BreakIterator comments

2011-10-26 Thread yuka . kamiya
Changeset: 0d371f2911a1 Author:peytoia Date: 2011-10-26 22:16 +0900 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/0d371f2911a1 7090046: Lots of invalid link in java.text.BreakIterator comments Reviewed-by: okutsu ! src/share/classes/java/text/BreakIterator.java

hg: jdk8/tl/jdk: 7104650: rawtype warnings in several net, nio and security source files

2011-10-26 Thread chris . hegarty
Changeset: 88a260444e4d Author:chegar Date: 2011-10-26 13:58 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/88a260444e4d 7104650: rawtype warnings in several net, nio and security source files Summary: Also reviewed by [email protected] Reviewed-by: mcimadamore, alanb, dholmes

7094155 Code Review Request

2011-10-26 Thread Sean Mullan
Hi Xuelei, Could you please review my fix for 7094155 (JSR105 code throws javax.xml.crypto.URIReference when running into Java 7 VM)? webrev: http://cr.openjdk.java.net/~mullan/webrevs/7094155/webrev.00/ Thanks, Sean