Re: Code review request: 7113275, compatibility issue with MD2 trust anchor and old X509TrustManager

2011-11-21 Thread Xuelei Fan
updated webrev: http://cr.openjdk.java.net/~xuelei/7113275/webrev.01/ On 11/22/2011 5:59 AM, Sean Mullan wrote: > On 11/20/2011 10:06 PM, Xuelei Fan wrote: >> webrev: http://cr.openjdk.java.net/~xuelei/7113275/webrev.00/ >> Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7113275 >> >> Test

Re: Code review request, 7106773: 512 bits RSA key cannot work with SHA384 and SHA512

2011-11-21 Thread Weijun Wang
I really like this one. Thanks Max On 11/21/2011 08:05 PM, Xuelei Fan wrote: > How about this approach? This looks very safe. > I also prefer this approach, although it need more updates in PKCS11 and MSCPI source code. If you vote for this approach, I will try to implement it.

Re: Code review request: 7113275, compatibility issue with MD2 trust anchor and old X509TrustManager

2011-11-21 Thread Sean Mullan
On 11/20/2011 10:06 PM, Xuelei Fan wrote: webrev: http://cr.openjdk.java.net/~xuelei/7113275/webrev.00/ Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7113275 Test MD2InTrustAnchor.java is used to test that MD2 in trust anchor is able to work with the default trust manager (X509Extended

Re: JDK 8 Code Review Request: 7093090 Reduce synchronization in java.security.Policy.getPolicyNoCheck

2011-11-21 Thread Valerie (Yu-Ching) Peng
Sean, Your changes look good to me. Thanks, Valerie On 11/17/11 08:58, Sean Mullan wrote: Hi Valerie, Could you review this one for me? http://cr.openjdk.java.net/~mullan/webrevs/7093090/webrev.00/ This one was tricky to fix, but I have confirmed that it does indeed fix the thread contentio

Re: Unable to wrap key using SunPKCS11 Provider

2011-11-21 Thread Valerie (Yu-Ching) Peng
The support for key wrapping and unwrapping is tracked under 4898471 "Support for key wrapping and unwrapping" I assume that the 3DES key is unextractable? If yes, I am afraid that this would require that 4898471 be fixed. I'll fix this in jdk7 update and later releases. Thanks, Valerie On

Re: Review 7053252: New regression test does not compile on windows-amd64

2011-11-21 Thread Frances Ho
Hi Tomas, New proposed features for JDK 8 will be posted on java.net (http://openjdk.java.net/jeps), please check there periodically for new additions. Thanks! _Frances On 11/2/2011 2:37 AM, Tomas Gustavsson wrote: Will there ever be a pkcs11 for windows-x64? Cheers, Tomas On 10/31/2011

Unable to wrap key using SunPKCS11 Provider

2011-11-21 Thread Paulo Ricardo Ribeiro
Hello I'm trying to wrap a 3DES key, that is stored in a HSM, using the SunPKCS11 provider: Cipher wrapper = Cipher.getInstance("DESede/CBC/NOPADDING", getProviderName()); wrapper.init(Cipher.WRAP_MODE, wrappingKey, new IvParameterSpec(iv)); cText = wrapper.wrap(

Re: Review 7053252: New regression test does not compile on windows-amd64

2011-11-21 Thread Tomas Gustavsson
Will there ever be a pkcs11 for windows-x64? Cheers, Tomas On 10/31/2011 11:33 PM, Valerie (Yu-Ching) Peng wrote: > Looks good to me. > Valerie > > On 10/31/11 14:19, Brad Wetmore wrote: >> >> Hi Valerie, >> >> http://cr.openjdk.java.net/~wetmore/7053252/ >> >> Review 7053252: New regression t

Re: Code review request: 7113275, compatibility issue with MD2 trust anchor and old X509TrustManager - approved

2011-11-21 Thread Dennis Gu
Xuelei Fan wrote: webrev: http://cr.openjdk.java.net/~xuelei/7113275/webrev.00/ Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7113275 Test MD2InTrustAnchor.java is used to test that MD2 in trust anchor is able to work with the default trust manager (X509ExtendedTrustManager). Test Tr

hg: jdk8/tl/jdk: 7114125: TEST_BUG: java/util/Timer/KillThread.java should use volatile cross thread variable declaration

2011-11-21 Thread alan . bateman
Changeset: 2db942c7eb9c Author:alanb Date: 2011-11-21 12:57 + URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/2db942c7eb9c 7114125: TEST_BUG: java/util/Timer/KillThread.java should use volatile cross thread variable declaration Reviewed-by: dholmes, alanb Contributed-by: gary.a

hg: jdk8/tl/jdk: 7084033: TEST_BUG: test/java/lang/ThreadGroup/Stop.java fails intermittently

2011-11-21 Thread alan . bateman
Changeset: 184578f3e8b9 Author:alanb Date: 2011-11-21 12:51 + URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/184578f3e8b9 7084033: TEST_BUG: test/java/lang/ThreadGroup/Stop.java fails intermittently Reviewed-by: forax, chegar, dholmes Contributed-by: [email protected] ! te

Re: Code review request, 7106773: 512 bits RSA key cannot work with SHA384 and SHA512

2011-11-21 Thread Xuelei Fan
webrev: http://cr.openjdk.java.net/~xuelei/7106773/webrev.03/ On 11/21/2011 4:34 PM, Weijun Wang wrote: > I removed most of the thread and keep some sections below: > > On 11/21/2011 03:30 PM, Xuelei Fan wrote: >> new webrev: http://cr.openjdk.java.net/~xuelei/7106773/webrev.02/ > > What is sync

Re: Code review request, 7106773: 512 bits RSA key cannot work with SHA384 and SHA512

2011-11-21 Thread Weijun Wang
I removed most of the thread and keep some sections below: On 11/21/2011 03:30 PM, Xuelei Fan wrote: new webrev: http://cr.openjdk.java.net/~xuelei/7106773/webrev.02/ What is synchronized for? Why only on the for block? This won't prevent map iteration and insertion at the same time. An