On 02/29/2012 11:32 PM, Xuelei Fan wrote:
So far, I only have a very minor comment:
The block from line 875 to 880 is a little overlapped with lines 884 to
889. Is it possible to improve the code?
A flag added:
http://cr.openjdk.java.net/~weijun/7149012/webrev.01/
I'm not sure whether
Please review the fix for:
6988842 jce/ECC test fails for SunPKCS11 provider using nss library
It is the long overdue refresh of the NSS libraries that we include in
the JDK regression test suite. One significant change is that the
NSS libraries are now obtained from the OS on Solaris and
Looks good to me.
--Sean
On 3/2/12 7:23 AM, Vincent Ryan wrote:
On 03/ 2/12 12:22 PM, Vincent Ryan wrote:
Please review the fix for:
6988842 jce/ECC test fails for SunPKCS11 provider using nss library
It is the long overdue refresh of the NSS libraries that we include in
the JDK
Looks fine to me.
Thanks for the update.
Xuelei
On Mar 2, 2012, at 2:29 AM, Weijun Wang weijun.w...@oracle.com wrote:
On 02/29/2012 11:32 PM, Xuelei Fan wrote:
So far, I only have a very minor comment:
The block from line 875 to 880 is a little overlapped with lines 884 to
889. Is it
Changeset: 3664ca46bc91
Author:vinnie
Date: 2012-03-02 17:24 +
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3664ca46bc91
6988842: jce/ECC test fails for SunPKCS11 provider using nss library
Reviewed-by: mullan
! make/sun/security/Makefile
!
Vinnie,
Would it clearer to name the new configuration option
minLibraryVersion instead of libraryVersionCheck?
Would it help to include the required minimum value in the exception
message in SunPKCS11.java?
Also, do you know what's the nss version that's commonly available on
our Solaris
On 02/03/2012 19:40, Valerie (Yu-Ching) Peng wrote:
Vinnie,
Would it clearer to name the new configuration option
minLibraryVersion instead of libraryVersionCheck?
I based the name of the option on the common NSS method called
NSS_VersionCheck()
Would it help to include the required
DHKeyAGreement.java
===
Mainly just a request for some additional commenting so the reader
doesn't have to have a good understanding of the BigInteger logic to
understand the assumptions being made here:
For example, if the expected bits of the modulus is
1024 bits
