Re: Code Review Request for 7146728 and 7130959

2012-03-06 Thread Valerie (Yu-Ching) Peng
BTW, have you looked at the fixes of 7130959? * 7130959: Tweak 7058133 fix for JDK 8 (javah makefile changes) o http://cr.openjdk.java.net/~valeriep/7130959/webrev.00/ Instead of using the -Xbootclasspath, switching over to use -boothclasspath for consistency with the backported changes in the

Re: Code Review Request for 7146728 and 7130959

2012-03-06 Thread Valerie (Yu-Ching) Peng
Brad, Thanks for the review. Please find the update webrev at: http://cr.openjdk.java.net/~valeriep/7146728/webrev.01/ On 03/02/12 17:31, Brad Wetmore wrote: DHKeyAGreement.java === Mainly just a request for some additional commenting so the reader doesn't have to have a good u

hg: jdk8/tl/jdk: 6961765: Double byte characters corrupted in DN for LDAP referrals

2012-03-06 Thread weijun . wang
Changeset: e8438dc196bb Author:weijun Date: 2012-03-07 10:15 +0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e8438dc196bb 6961765: Double byte characters corrupted in DN for LDAP referrals Reviewed-by: vinnie ! src/share/classes/com/sun/jndi/toolkit/url/UrlUtil.java + test/co

hg: jdk8/tl/jdk: 7113349: Initial changeset for Macosx port to jdk

2012-03-06 Thread michael . x . mcmahon
Changeset: d45bc4307996 Author:michaelm Date: 2012-03-06 20:34 + URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/d45bc4307996 7113349: Initial changeset for Macosx port to jdk Reviewed-by: jjh, alanb, dholmes, anthony, ohrstrom, ksrini, jrose, weijun, smarks Contributed-by: Ala

hg: jdk8/tl/langtools: 7113349: Initial changeset for Macosx port to jdk

2012-03-06 Thread michael . x . mcmahon
Changeset: f3743b82945e Author:michaelm Date: 2012-03-06 20:27 + URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/f3743b82945e 7113349: Initial changeset for Macosx port to jdk Reviewed-by: jjh, alanb, dholmes, anthony, ohrstrom, ksrini, jrose, weijun, smarks Contributed-b

hg: jdk8/tl/jaxws: 7113349: Initial changeset for Macosx port to jdk

2012-03-06 Thread michael . x . mcmahon
Changeset: 5600254058a1 Author:michaelm Date: 2012-03-06 20:26 + URL: http://hg.openjdk.java.net/jdk8/tl/jaxws/rev/5600254058a1 7113349: Initial changeset for Macosx port to jdk Reviewed-by: jjh, alanb, dholmes, anthony, ohrstrom, ksrini, jrose, weijun, smarks Contributed-by: A

hg: jdk8/tl/corba: 7113349: Initial changeset for Macosx port to jdk

2012-03-06 Thread michael . x . mcmahon
Changeset: f7718662741d Author:michaelm Date: 2012-03-06 20:25 + URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/f7718662741d 7113349: Initial changeset for Macosx port to jdk Reviewed-by: jjh, alanb, dholmes, anthony, ohrstrom, ksrini, jrose, weijun, smarks Contributed-by: A

hg: jdk8/tl: 7113349: Initial changeset for Macosx port to jdk

2012-03-06 Thread michael . x . mcmahon
Changeset: 84ece503953e Author:michaelm Date: 2012-03-06 20:25 + URL: http://hg.openjdk.java.net/jdk8/tl/rev/84ece503953e 7113349: Initial changeset for Macosx port to jdk Reviewed-by: jjh, alanb, dholmes, anthony, ohrstrom, ksrini, jrose, weijun, smarks Contributed-by: Alan Ba

Re: Code Review Request: 7146431 java.security files out-of-sync

2012-03-06 Thread Brad Wetmore
Looks fine to me too. Brad On 3/6/2012 6:28 AM, Sean Mullan wrote: Please review the following fix to correct an issue in 7u4 with the system-specific java.security files being out-of-sync. webrev: http://cr.openjdk.java.net/~mullan/webrevs/7146431/webrev.00/ Thanks, Sean

Re: Code Review Request: 7146431 java.security files out-of-sync

2012-03-06 Thread Xuelei Fan
Looks fine to me, too. Xuelei On 3/6/2012 6:34 AM, Vincent Ryan wrote: You fix looks fine. On 03/ 6/12 02:28 PM, Sean Mullan wrote: Please review the following fix to correct an issue in 7u4 with the system-specific java.security files being out-of-sync. webrev: http://cr.openjdk.java.net/~m

hg: jdk8/tl/langtools: 2 new changesets

2012-03-06 Thread maurizio . cimadamore
Changeset: c2234816495f Author:mcimadamore Date: 2012-03-06 16:48 + URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/c2234816495f 7151070: NullPointerException in Resolve.isAccessible Summary: Spurious accessibility check in TransTypes Reviewed-by: jjg ! src/share/classes/

Re: Code Review Request: 7146431 java.security files out-of-sync

2012-03-06 Thread Vincent Ryan
You fix looks fine. On 03/ 6/12 02:28 PM, Sean Mullan wrote: Please review the following fix to correct an issue in 7u4 with the system-specific java.security files being out-of-sync. webrev: http://cr.openjdk.java.net/~mullan/webrevs/7146431/webrev.00/ Thanks, Sean

Code Review Request: 7146431 java.security files out-of-sync

2012-03-06 Thread Sean Mullan
Please review the following fix to correct an issue in 7u4 with the system-specific java.security files being out-of-sync. webrev: http://cr.openjdk.java.net/~mullan/webrevs/7146431/webrev.00/ Thanks, Sean

hg: jdk8/tl/langtools: 3 new changesets

2012-03-06 Thread maurizio . cimadamore
Changeset: dda6a5b15580 Author:mcimadamore Date: 2012-03-06 13:26 + URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/dda6a5b15580 7148622: Some diagnostic methods do not go through Log.report Summary: Deferred lint diagnostics ignore Log settings such as deferred diagnosti