Re: 7142172: Custom TrustManagers that return null for getAcceptedIssuers will NPE

2012-03-29 Thread Brad Wetmore
Thanks, I won't regenerate the webrev unless someone really wants to see it. Brad On 3/29/2012 7:30 PM, Xuelei Fan wrote: Forgot one thing about the regression test. JSSE test should run in othervm. Would you please add the following lines to the test: * SunJSSE does not support dynamic

Re: 7142172: Custom TrustManagers that return null for getAcceptedIssuers will NPE

2012-03-29 Thread Xuelei Fan
Forgot one thing about the regression test. JSSE test should run in othervm. Would you please add the following lines to the test: * SunJSSE does not support dynamic system properties, no way to * re-use system properties in samevm/agentvm mode. * @run main/othervm NullGetAcceptedIssuer

Re: 7142172: Custom TrustManagers that return null for getAcceptedIssuers will NPE

2012-03-29 Thread Xuelei Fan
Looks fine to me. Thanks, Xuelei On 3/30/2012 10:20 AM, Brad Wetmore wrote: > Hi Xuelei, > > Can you please rereview this bug, the 7u4 and 8 changes are here: > > http://cr.openjdk.java.net/~wetmore/7142172/ > > Thanks, > > Brad >

7142172: Custom TrustManagers that return null for getAcceptedIssuers will NPE

2012-03-29 Thread Brad Wetmore
Hi Xuelei, Can you please rereview this bug, the 7u4 and 8 changes are here: http://cr.openjdk.java.net/~wetmore/7142172/ Thanks, Brad

Re: Code Review Request: Generalise com.oracle.security.ucrypto tests

2012-03-29 Thread Valerie (Yu-Ching) Peng
Well, I have not looked at the complete webrev. But it looks to me that if the tests are generalized to cover more providers, then they should be moved to somewhere else instead of "com/oracle/security/ucrypto" directory which implies the regression tests for OracleUcrypto provider. Maybe somew

Code Review Request: Generalise com.oracle.security.ucrypto tests

2012-03-29 Thread Andrew Hughes
Hi all, As discussed in: http://mail.openjdk.java.net/pipermail/security-dev/2012-March/004615.html this webrev: http://cr.openjdk.java.net/~andrew/enc_tests/webrev.01/ updates the tests as follows: 1. Tests all available providers, not just ucrypto which is unavailable on OpenJDK. 2. No l

hg: jdk8/tl/jdk: 7070436: Support Unicode 6.1.0 in JDK 8

2012-03-29 Thread yuka . kamiya
Changeset: b2687ac9cffb Author:peytoia Date: 2012-03-29 18:02 +0900 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/b2687ac9cffb 7070436: Support Unicode 6.1.0 in JDK 8 Reviewed-by: okutsu ! make/tools/GenerateCharacter/CharacterData00.java.template ! make/tools/UnicodeData/PropLis