The source changes look good except the minor nit that the copyright
year should be updated to 2012.
As for the test, shouldn't it use the "file" variable instead of the
"tmpcc" values?
Also, it may be better to name the "file" variable more specifically,
like "ccache" or "emptyCCache".
Thanks,
I am out of the office until 04/09/2012.
I will respond to your message when I return.
Please contact Lisbeth Arriaza or Guillermo Mejia for L2 support requests.
Please contact Audrey Timkovich for urgent support requests of the Java
Security team or JCE specific issues.
Please contact Ralph
Changeset: 55ae94116e89
Author:jjg
Date: 2012-04-06 10:10 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/55ae94116e89
7157626: Create a new test to check major version for a class file
Reviewed-by: jjg
Contributed-by: [email protected]
+ test/tools/javac/classfile
On 06/04/12 15:16, Sean Mullan wrote:
On 4/6/12 10:13 AM, Sean Mullan wrote:
On 4/6/12 9:59 AM, Seán Coffey wrote:
Looks good Sean. Thanks for taking care of jdk 8 changes.
Hopefully someone else can also review since I'm not an official jdk 8
reviewer.
Ok. Copying Chris to see if he could a
On 4/6/12 10:13 AM, Sean Mullan wrote:
> On 4/6/12 9:59 AM, Seán Coffey wrote:
>> Looks good Sean. Thanks for taking care of jdk 8 changes.
>>
>> Hopefully someone else can also review since I'm not an official jdk 8
>> reviewer.
>
> Ok. Copying Chris to see if he could also review.
Oops, missed
On 4/6/12 9:59 AM, Seán Coffey wrote:
> Looks good Sean. Thanks for taking care of jdk 8 changes.
>
> Hopefully someone else can also review since I'm not an official jdk 8
> reviewer.
Ok. Copying Chris to see if he could also review.
Thanks,
Sean
>
> regards,
> Sean.
>
> On 06/04/12 14:40,
Looks good Sean. Thanks for taking care of jdk 8 changes.
Hopefully someone else can also review since I'm not an official jdk 8
reviewer.
regards,
Sean.
On 06/04/12 14:40, Sean Mullan wrote:
Hi Sean,
Can you please review the code changes for the following bugs:
7152564: Improve CodeSourc
Hi Sean,
Can you please review the code changes for the following bugs:
7152564: Improve CodeSource.matchLocation(CodeSource) performance
7155693: CodeSource.matchLocation getPort test can be improved
webrev: http://cr.openjdk.java.net/~mullan/webrevs/7152564_7155693/webrev.00/
I will finalize
