hg: jdk8/tl/jdk: 7160242: (prefs) Preferences.remove(null) does not throw NPE [macosx]

2012-04-25 Thread kurchi . subhra . hazra
Changeset: 3e398b549cea Author:khazra Date: 2012-04-25 12:31 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3e398b549cea 7160242: (prefs) Preferences.remove(null) does not throw NPE [macosx] Summary: Insert null check of argument in remove()'s implementation Reviewed-by: fora

Re: Code review request: 7163483 JarSigner -verify -verbose does not format date string according to locale

2012-04-25 Thread Weijun Wang
Hi Jonathan I'm using English. In your test all the files have a similar modified time so you cannot see the difference. However, in my example, you can see that the widths for date and hour are not zero-padded so the width can be either 1 or 2. French is even worse smk 76 10 nov. 200

Re: Code review request: 7163483 JarSigner -verify -verbose does not format date string according to locale

2012-04-25 Thread Jonathan Lu
Hello Max, Terribly sorry for my misunderstanding! On 04/25/2012 05:39 PM, Weijun Wang wrote: On 04/25/2012 05:23 PM, Jonathan Lu wrote: Hi Max, On 04/25/2012 05:12 PM, Weijun Wang wrote: On 04/25/2012 03:28 PM, Jonathan Lu wrote: Hi Weijun, Thanks for your time, I've updated the webre

Re: Code review request: 7163483 JarSigner -verify -verbose does not format date string according to locale

2012-04-25 Thread Weijun Wang
On 04/25/2012 05:23 PM, Jonathan Lu wrote: Hi Max, On 04/25/2012 05:12 PM, Weijun Wang wrote: On 04/25/2012 03:28 PM, Jonathan Lu wrote: Hi Weijun, Thanks for your time, I've updated the webrev, could you please take a look? http://cr.openjdk.java.net/~luchsh/7163483_2/ On 04/24/2012 03:

Re: Code review request: 7163483 JarSigner -verify -verbose does not format date string according to locale

2012-04-25 Thread Jonathan Lu
Hi Max, On 04/25/2012 05:12 PM, Weijun Wang wrote: On 04/25/2012 03:28 PM, Jonathan Lu wrote: Hi Weijun, Thanks for your time, I've updated the webrev, could you please take a look? http://cr.openjdk.java.net/~luchsh/7163483_2/ On 04/24/2012 03:06 PM, Weijun Wang wrote: Hi Jonathan Some c

Re: Code review request: 7163483 JarSigner -verify -verbose does not format date string according to locale

2012-04-25 Thread Weijun Wang
On 04/25/2012 03:28 PM, Jonathan Lu wrote: Hi Weijun, Thanks for your time, I've updated the webrev, could you please take a look? http://cr.openjdk.java.net/~luchsh/7163483_2/ On 04/24/2012 03:06 PM, Weijun Wang wrote: Hi Jonathan Some comments: 1. Can you be sure that the new format alwa

Re: Code review request: 7163483 JarSigner -verify -verbose does not format date string according to locale

2012-04-25 Thread Jonathan Lu
Hi Weijun, Thanks for your time, I've updated the webrev, could you please take a look? http://cr.openjdk.java.net/~luchsh/7163483_2/ On 04/24/2012 03:06 PM, Weijun Wang wrote: Hi Jonathan Some comments: 1. Can you be sure that the new format always has the same length? jarsigner tries to ou