Re: Code review request for 7172149 ArrayIndexOutOfBoundsException from Signature.verify

2012-05-29 Thread Brad Wetmore
I think it is worth exploring what other parts of the code do in this case. It seems to me this is going to be a lot more involved than just Signatures. (InputStreams, etc) Brad On 5/29/2012 4:26 PM, Xuelei Fan wrote: On 5/29/2012 3:11 PM, Jonathan Lu wrote: Hi Xuelei, Thanks for review

Re: Code review request for 7172149 ArrayIndexOutOfBoundsException from Signature.verify

2012-05-29 Thread Xuelei Fan
On 5/29/2012 3:11 PM, Jonathan Lu wrote: > Hi Xuelei, > > Thanks for review! > > On 05/29/2012 02:45 PM, Xuelei Fan wrote: >> That's an interesting topic. From my understand, the length of an array >> is of type "int". So normally, the (offset + length) should not be >> great than integer.max_v

Re: JDK 8 Review Request for 6854712 (JEP 124), 6637288 and 7126011

2012-05-29 Thread Xuelei Fan
>> # SunCertPathBuilder.java >> >> public CertPathBuilderResult engineBuild(CertPathParameters params) >> private PKIXCertPathBuilderResult build() >> -result = buildCertPath(buildForward, true, adjList); >> +result = buildCertPath(true, adjList); >> >> This update disables reverse buildin

hg: jdk8/tl/jdk: 7171591: getDefaultScopeID() in src/solaris/native/java/net/net_util_md.c should return a value

2012-05-29 Thread kurchi . subhra . hazra
Changeset: eb441933f6fe Author:khazra Date: 2012-05-29 13:16 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/eb441933f6fe 7171591: getDefaultScopeID() in src/solaris/native/java/net/net_util_md.c should return a value Summary: Use CHECK_NULL_RETURN instead of CHECK_NULL Revie

Re: JDK 8 Review Request for 6854712 (JEP 124), 6637288 and 7126011

2012-05-29 Thread Sean Mullan
On 5/29/12 2:02 AM, Xuelei Fan wrote: > On 5/26/2012 1:11 AM, Sean Mullan wrote: >>> That's my comment on specification. I may look into the implementation >>> update next Monday. > > # KeyChecker.java, ConstraintsChecker.java > # PolicyChecker.java, ConstraintsChecker.java, minor comment: > > p

JSSE TlsPrfGenerator ArrayIndexOutOfBoundsException

2012-05-29 Thread Christopher Meyer
Hi, during some research we noticed an interesting implementation bug inside the com.sun.crypto.provider.TlsPrfGenerator.expand(..) function. The problem is that an internal for loop das some XOR magic on passed arrays: for (int i = 0; i < secLen; i++) { pad1[i] ^= secret[i + secOff];

Re: Code review request for 7172149 ArrayIndexOutOfBoundsException from Signature.verify

2012-05-29 Thread Jonathan Lu
Hi Xuelei, Thanks for review! On 05/29/2012 02:45 PM, Xuelei Fan wrote: That's an interesting topic. From my understand, the length of an array is of type "int". So normally, the (offset + length) should not be great than integer.max_value. Of course, Hostile or improper code are not of the