Re: Avoid PrincipalName with realm == null

2012-06-08 Thread Valerie (Yu-Ching) Peng
Max, Yes, I think the current model that you described sounds error prone. I don't know the history of the current design. But I do also prefer the described changes that you have. I'd expect the refactoring would make the code clearer and more robust. Valerie On 06/06/12 17:55, Weijun Wang w

Code Review Request for 7044060 "Need to support NSA Suite B Cryptography algorithms"

2012-06-08 Thread Valerie (Yu-Ching) Peng
Vinnie, Could you please review the changes for 7044060 "Need to support NSA Suite B Cryptography algorithms"? The webrev is at: http://cr.openjdk.java.net/~valeriep/7044060/webrev.00/ The changes are as follows: 1) add support for larger DSA key sizes (up to 2048-bit): this also means adding

Re: Avoid PrincipalName with realm == null

2012-06-08 Thread Henry B. Hotz
Always just used the API, which takes care of it. Anyway, this looks like as authoritative a description as any. In particular, it says the first string is the realm, which matches my intuition of what should be there, since it's the same ordering as in the DER representation. http://www.gnu.

hg: jdk8/tl/jdk: 7161881: (dc) DatagramChannel.bind(null) fails if IPv4 socket and running with preferIPv6Addresses=true

2012-06-08 Thread rob . mckenna
Changeset: a7895dc61088 Author:robm Date: 2012-06-08 18:23 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/a7895dc61088 7161881: (dc) DatagramChannel.bind(null) fails if IPv4 socket and running with preferIPv6Addresses=true Reviewed-by: alanb, chegar ! src/share/classes/sun/

Re: Code review request, CR 7174244, NPE in Krb5ProxyImpl.getServerKeys()

2012-06-08 Thread Xuelei Fan
On 6/8/2012 8:31 PM, Steven Read wrote: > Xuelei Fan writes: > >> >> On 6/6/2012 9:11 PM, Weijun Wang wrote: >>> Hi Xuelei >>> >>> I don't quite understand the bug report. Certainly it's good to prevent >>> that NPE, but why must the cipher suites be ordered? It seems it's not >>> ordered before

Re: Code review request, CR 7174244, NPE in Krb5ProxyImpl.getServerKeys()

2012-06-08 Thread Steven Read
Xuelei Fan writes: > > On 6/6/2012 9:11 PM, Weijun Wang wrote: > > Hi Xuelei > > > > I don't quite understand the bug report. Certainly it's good to prevent > > that NPE, but why must the cipher suites be ordered? It seems it's not > > ordered before the new HashMap. > No, it was not ordered be

hg: jdk8/tl/jdk: 2 new changesets

2012-06-08 Thread lance . andersen
Changeset: 8305ddc88a5a Author:lancea Date: 2012-06-07 20:11 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/8305ddc88a5a 7172551: Remove Native calls from DriverManager for jigsaw Reviewed-by: alanb, chegar, darcy, mchung ! make/java/java/FILES_c.gmk ! make/java/java/mapfile

hg: jdk8/tl/jdk: 7175413: Typo in comments of JVM_SupportsCX8 in jvm.h

2012-06-08 Thread chris . hegarty
Changeset: abe465d6a9b8 Author:chegar Date: 2012-06-08 09:55 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/abe465d6a9b8 7175413: Typo in comments of JVM_SupportsCX8 in jvm.h Reviewed-by: chegar Contributed-by: Krystal Mok ! src/share/javavm/export/jvm.h