Code review request: 7198507: [TEST_BUG] sun/security/tools/keytool/console.sh should be rewritten

First, I'm very glad to see that we are running manual tests. Then, please take a look at http://cr.openjdk.java.net/~weijun/7198507/webrev.00 Nothing is changed in the real keytool command calls, only some small changes: 1. Better prompt 2. Keystore file now /tmp/kkk.$$, clean and no

hg: jdk8/tl/jdk: 7198871: cleanup security tests in problem lists with no CR attached

Changeset: 53ca38f76eaa Author:weijun Date: 2012-09-18 17:38 +0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/53ca38f76eaa 7198871: cleanup security tests in problem lists with no CR attached Reviewed-by: alanb ! test/ProblemList.txt

7190273: Deprecate com.sun.security.auth.callback.DialogCallbackHandler

Sean - do you mind reviewing the attached? As background, the Oracle specific API to JAAS has two sample CallbackHandlers, one of which is highly problematic for our modularization efforts as it has an API dependency on java.awt.Component. It doesn't appear to be used by many but to

hg: jdk8/tl/jdk: 7198901: correct the field size check when decoding a point on ECC curve

Changeset: 95a93f039e5c Author:vinnie Date: 2012-09-18 11:08 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/95a93f039e5c 7198901: correct the field size check when decoding a point on ECC curve Reviewed-by: xuelei ! src/share/classes/sun/security/ec/ECParameters.java

hg: jdk8/tl/jdk: 7142919: TEST_BUG: java/nio/channels/AsyncCloseAndInterrupt.java failing intermittently [sol11]

Changeset: bc5e7ec12717 Author:dxu Date: 2012-09-18 13:14 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/bc5e7ec12717 7142919: TEST_BUG: java/nio/channels/AsyncCloseAndInterrupt.java failing intermittently [sol11] Reviewed-by: alanb ! test/ProblemList.txt !

Re: 7190273: Deprecate com.sun.security.auth.callback.DialogCallbackHandler

Sure, this change looks fine to me. --Sean On 9/18/12 6:01 AM, Alan Bateman wrote: Sean - do you mind reviewing the attached? As background, the Oracle specific API to JAAS has two sample CallbackHandlers, one of which is highly problematic for our modularization efforts as it has an API

Re: Code review request, 7199066 Typo in method name

Looks good to me. Don't forget to add the noreg-trivial keyword to the CR before pushing. --Sean On 9/17/12 9:38 PM, Xuelei Fan wrote: Hi, Please review the trivial fix of a typo in internal method name. The bug has not been shown in bug database. The method name,

[PATCH FOR REVIEW] Allow OpenJDK to be built with the unlimited crypto policy

This is an issue that has been with us for a while. See: https://bugs.openjdk.java.net/show_bug.cgi?id=100062 http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7188845 for some background. The original proposed patch goes to far in removing most of the infrastructure for restricting crypto

hg: jdk8/tl/jdk: 7198984: Add java/text/Bidi/Bug6665028.java to ProblemList.txt

Changeset: 0136fca60652 Author:naoto Date: 2012-09-18 10:34 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/0136fca60652 7198984: Add java/text/Bidi/Bug6665028.java to ProblemList.txt Reviewed-by: alanb Contributed-by: yiming.w...@oracle.com ! test/ProblemList.txt

hg: jdk8/tl/jdk: 7199249: TEST_BUG : Add /othervm to Collisions.java @run main with -D definitions

Changeset: e7add6d98729 Author:mduigou Date: 2012-09-18 11:04 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e7add6d98729 7199249: TEST_BUG : Add /othervm to Collisions.java @run main with -D definitions Reviewed-by: alanb ! test/java/util/Map/Collisions.java

hg: jdk8/tl/jdk: 7195933: There is incorrect link to Info-ZIP Application Note 970311 in doc page of Package java.util.zip

Changeset: e143d8f8e477 Author:dxu Date: 2012-09-18 14:45 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e143d8f8e477 7195933: There is incorrect link to Info-ZIP Application Note 970311 in doc page of Package java.util.zip Summary: Correct a java doc link in java.util.zip