Hi Valerie
Test4512704.java:
Why not test AES/CBC/PKCS5Padding anymore?
TestKATForGCM.java:
Is there a URL for the test data?
GaloisCounterMode, GCTR, and GHASH are good.
Thanks
Max
On 11/06/2012 04:48 PM, Weijun Wang wrote:
CipherCore.java:
79 * update() must buffer this
That's correct. I'll make that change to PBEParameters.java.
Thanks.
On 7 Nov 2012, at 02:51, Valerie (Yu-Ching) Peng wrote:
Vinnie,
I noticed the following after you putback, if you agree w/ my comments,
please include them in the follow up TBD bug fixes for JEP-121.
Changeset: 9e013ce42dd7
Author:dfuchs
Date: 2012-11-07 13:24 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/9e013ce42dd7
6720349: (ch) Channels tests depending on hosts inside Sun
Summary: This changeset make the nio tests start small TCP or UDP servers from
within the
hi everyone - we submitted this code change [1] for review back in July. There
was some discussion off list but it sort of petered out.
Any chance someone can pick it up again please and review the change?
Thanks
Steve
[1]
Hi, Max,
Thanks for the prompt review!
On 11/07/12 02:41, Weijun Wang wrote:
Hi Valerie
Test4512704.java:
Why not test AES/CBC/PKCS5Padding anymore?
This particular test is not really padding-relevant, so I just switching
to test AES/CBC/NoPadding instead, since GCM mode requires
Hi, Max,
Please find comments in line:
On 11/06/12 00:48, Weijun Wang wrote:
380 AlgorithmParameters getParameters(String algName)
The updated code does not return null anymore. Is there some other
reason out of this patch? The init() method below seems to support
null for all modes.
Changeset: cc325832469c
Author:naoto
Date: 2012-11-07 15:08 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/cc325832469c
8001205: Calendar.getDisplayName(...): Returns null when provider is SPI but
there is no SPI implementation
8001562: Collator.getAvailableLocales()
Changeset: 19d6ba779759
Author:vromero
Date: 2012-11-05 16:26 +
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/19d6ba779759
8000484: Bad error recovery when 'catch' without 'try' is found
Reviewed-by: jjg, mcimadamore
!
I have a concern about the performance. Not a big problem, but may be
nice to consider it.
Unlike CBC ciphers, GCM based ciphers need to update the IV for every
encryption/decryption operation. As means that the Cipher.init() is
required to call in every operation:
Key key = // the key used
Changeset: a516debe2cee
Author:amurillo
Date: 2012-10-26 14:18 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/a516debe2cee
8001663: new hotspot build - hs25-b08
Reviewed-by: jcoomes
! make/hotspot_version
Changeset: 5ec0c42da025
Author:coleenp
Date: 2012-10-25
Changeset: 2986e7052952
Author:jjg
Date: 2012-11-07 17:01 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/2986e7052952
8002157: Write combo compiler tests for repeating annotations for JDK8
Reviewed-by: darcy, jjg
Contributed-by: sonali.g...@oracle.com
+
Changeset: a1dc543483fc
Author:jjg
Date: 2012-11-07 17:20 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/a1dc543483fc
8003134: CheckResourceKeys issues
Reviewed-by: jjh, bpatel
!
src/share/classes/com/sun/tools/doclets/formats/html/resources/standard.properties
!
Changeset: 599f231cba97
Author:jfranck
Date: 2012-11-07 17:39 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/599f231cba97
8001598: Augment ElementType enum for JSR 308
Reviewed-by: darcy
! src/share/classes/java/lang/annotation/ElementType.java
Changeset: cdf02b372956
Author:sherman
Date: 2012-11-07 20:50 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/cdf02b372956
6282196: There should be Math.mod(number, modulo) methods
Summary: added the requested methods
Reviewed-by: darcy, emcmanus, alanb
Contributed-by:
Max,
Update: I removed the block (starting line 580 in CipherCore.java) for
handling RC2 since it's never used.
It turns out that the current impl in RC2Cipher always convert the
AlgorithmParameters object to RC2ParameterSpec and only uses
CipherCore.init(..., AlgorithmParameterSpec,...)
15 matches
Mail list logo