hg: jdk8/tl/jdk: 7178922: (props) re-visit how os.name is determined on Mac

2012-11-16 Thread mandy . chung
Changeset: 6f20caa6e1e9 Author:bchristi Date: 2012-11-16 17:01 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/6f20caa6e1e9 7178922: (props) re-visit how os.name is determined on Mac Reviewed-by: alanb, mchung, skovatch, serb ! src/solaris/native/java/lang/java_props_macosx.c

hg: jdk8/tl/jdk: 8003518: (prefs) Tests in jdk/test/java/util/prefs should not be run concurrently

2012-11-16 Thread kurchi . subhra . hazra
Changeset: 0ee09f17361e Author:khazra Date: 2012-11-16 12:28 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/0ee09f17361e 8003518: (prefs) Tests in jdk/test/java/util/prefs should not be run concurrently Summary: Add java/util/prefs to exclusiveAccess.dirs in TEST.ROOT Review

hg: jdk8/tl/langtools: 8003357: Add support for jtreg -concurrency to langtools/test/Makefile

2012-11-16 Thread james . holmlund
Changeset: 843d3b191773 Author:jjh Date: 2012-11-16 18:27 + URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/843d3b191773 8003357: Add support for jtreg -concurrency to langtools/test/Makefile Reviewed-by: jjg ! test/Makefile

Re: Warning cleanup in package javax.net.ssl

2012-11-16 Thread Florian Weimer
On 11/16/2012 04:40 PM, Xuelei Fan wrote: The patch looks fine to me. Personally, I prefer a consistent style to have the "Override" tag in a full line, for example: + @Override public String run() { That's my preference as well, but the existing style is mixed, so I wasn't sure what t

Re: [8] Code Review Request for CR 7167056 - Clarify that BasicPermission names that contain non-wildcard asterisks are not invalid

2012-11-16 Thread Xuelei Fan
Looks fine to me. Xuelei On 11/16/2012 10:54 PM, Sean Mullan wrote: > This change affects components in the security and core libs areas. > > This is a minor specification clarification to avoid the use of the terms > "valid" and "invalid" when describing the syntax for wildcard names in > java.

Re: Warning cleanup in package javax.net.ssl

2012-11-16 Thread Xuelei Fan
The patch looks fine to me. Personally, I prefer a consistent style to have the "Override" tag in a full line, for example: + @Override public String run() { Please let me know if you want a sponsor to push the patch. Thanks for the contribution. Xuelei On 11/16/2012 10:32 PM, Florian Wei

[8] Code Review Request for CR 7167056 - Clarify that BasicPermission names that contain non-wildcard asterisks are not invalid

2012-11-16 Thread Sean Mullan
This change affects components in the security and core libs areas. This is a minor specification clarification to avoid the use of the terms "valid" and "invalid" when describing the syntax for wildcard names in java.security.BasicPermission and various subclasses. This could be implied that thes

Warning cleanup in package javax.net.ssl

2012-11-16 Thread Florian Weimer
The attached patch fixes a few warnings in javax.net.ssl.*. All the overrides appear to be intentional. -- Florian Weimer / Red Hat Product Security Team # HG changeset patch # User Florian Weimer # Date 1353076204 -3600 # Node ID 1978e4b72308472c5b70f31d2bf2b927b73e08a0 # Parent 64a42798ea5e