Re: Code Review Request for 6996769: support AEAD ciphers

2012-12-12 Thread Weijun Wang
Hi Valerie The code changes work. However, I'm only not quite comfortable with the passKeyAndIvCheck flag. It sounds like it should be only required for GCM/encoding but now it's used everywhere. I especially find this line in doFinal() confusing: passKeyAndIvCheck = (cipherMode != GCM_MO

hg: jdk8/tl/jdk: 8004357: Implement various methods in SerialBlob/Clob/Array and specify Thread Safety

2012-12-12 Thread lance . andersen
Changeset: 7a8978a5bb6e Author:lancea Date: 2012-12-12 20:57 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/7a8978a5bb6e 8004357: Implement various methods in SerialBlob/Clob/Array and specify Thread Safety Reviewed-by: naoto ! src/share/classes/javax/sql/rowset/serial/Seri

hg: jdk8/tl/jdk: 8004235: Disable native JGSS provider on Mac

2012-12-12 Thread weijun . wang
Changeset: 5a2ab2c3f106 Author:weijun Date: 2012-12-13 08:11 +0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/5a2ab2c3f106 8004235: Disable native JGSS provider on Mac Reviewed-by: erikj, valeriep ! make/sun/security/Makefile ! makefiles/CompileNativeLibraries.gmk ! src/share/

hg: jdk8/tl/jdk: 8004651: TEST: java/util/logging/CheckLockLocationTest.java failed to delete file (win)

2012-12-12 Thread stuart . marks
Changeset: 56fd5479a98f Author:jgish Date: 2012-12-12 15:37 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/56fd5479a98f 8004651: TEST: java/util/logging/CheckLockLocationTest.java failed to delete file (win) Summary: Failure to delete test log file should be a warning instea

hg: jdk8/tl/langtools: 8004504: ListBuffer could reuse List.nil() as the sentinel element

2012-12-12 Thread jonathan . gibbons
Changeset: 170e486632d9 Author:jlahoda Date: 2012-12-12 20:26 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/170e486632d9 8004504: ListBuffer could reuse List.nil() as the sentinel element Summary: ListBuffer.last now points to the last elements with client data, or nu

[8] Code Review Request for 8004234: Downgrade normative references to ${java.home}/lib/security/krb5.conf

2012-12-12 Thread Sean Mullan
The rationale for this fix is the same as the previous review request [1] to downgrade normative references to ${java.home}/lib/security/java.security. This change is much smaller and only affects the javax.security.auth.kerberos package description. webrev: http://cr.openjdk.java.net/~mulla

hg: jdk8/tl/jdk: 8004337: java/sql tests aren't run in test/Makefile

2012-12-12 Thread rob . mckenna
Changeset: 68374c6e65c1 Author:robm Date: 2012-12-12 15:57 + URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/68374c6e65c1 8004337: java/sql tests aren't run in test/Makefile Reviewed-by: lancea, alanb ! test/Makefile

hg: jdk8/tl/jdk: 8004874: Reduce dependency on java.beans to only add/removePropertyChangeListener

2012-12-12 Thread alan . bateman
Changeset: 81640e75c7a7 Author:alanb Date: 2012-12-12 13:03 + URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/81640e75c7a7 8004874: Reduce dependency on java.beans to only add/removePropertyChangeListener Reviewed-by: ksrini, mchung, dholmes ! src/share/classes/com/sun/java/ut

hg: jdk8/tl/jdk: 8004921: Trivial javadoc warnings in Base64

2012-12-12 Thread chris . hegarty
Changeset: 806cf26e5063 Author:chegar Date: 2012-12-12 11:35 + URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/806cf26e5063 8004921: Trivial javadoc warnings in Base64 Reviewed-by: darcy ! src/share/classes/java/util/Base64.java

hg: jdk8/tl/jdk: 8004904: Makefile for ntlm

2012-12-12 Thread weijun . wang
Changeset: 12fba0974a9d Author:weijun Date: 2012-12-12 18:39 +0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/12fba0974a9d 8004904: Makefile for ntlm Reviewed-by: erikj, chegar ! make/com/sun/security/Makefile + make/com/sun/security/ntlm/Makefile

Re: Code review: 8004904: Makefile for ntlm (was Re: com/sun/security/ntlm)

2012-12-12 Thread Chris Hegarty
Thank you Max, looks fine to me. -Chris. On 12/12/2012 03:32, Weijun Wang wrote: Hi Chris/Mark I've added a makefile, please take a look http://cr.openjdk.java.net/~weijun/8004904/webrev.00/ *build-dev* guys, I guess this won't affect the new build style. Thanks Max On 12/12/2012 09:28 AM

Re: Code review: 8004904: Makefile for ntlm (was Re: com/sun/security/ntlm)

2012-12-12 Thread Erik Joelsson
That is correct, the new build will already handle incremental building of any changed java file, so this won't make a difference. Thanks for the heads up anyway! /Erik On 2012-12-12 04:32, Weijun Wang wrote: Hi Chris/Mark I've added a makefile, please take a look http://cr.openjdk.java.