Re: Code Review Request for 6996769: support AEAD ciphers

2013-01-03 Thread Michael StJohns
At 09:17 PM 1/3/2013, Valerie (Yu-Ching) Peng wrote: >Michael, > >I thought this some more. I think a cleaner way to do what you wanted may be >achieved by adding an AlgorithmParameterGenerator impl for GCM. *sigh* I forgot to answer this. I think this would probably work too. But I agree that

Re: Code Review Request for 6996769: support AEAD ciphers

2013-01-03 Thread Michael StJohns
Hi Valerie - Comments in line. At 09:17 PM 1/3/2013, Valerie (Yu-Ching) Peng wrote: >Michael, > >I thought this some more. I think a cleaner way to do what you wanted may be >achieved by adding an AlgorithmParameterGenerator impl for GCM. >I've read through your email multiple times but yet I can

Re: Code Review Request for 6996769: support AEAD ciphers

2013-01-03 Thread Valerie (Yu-Ching) Peng
Max, Forgot to mention that the latest webrev has been updated: http://cr.openjdk.java.net/~valeriep/6996769/webrev.05/ I shall proceed with putbacks if you have no further comments tomorrow. Thanks, Valerie On 01/03/13 18:17, Valerie (Yu-Ching) Peng wrote: Michael, I thought this some more.

Re: Code Review Request for 6996769: support AEAD ciphers

2013-01-03 Thread Valerie (Yu-Ching) Peng
Michael, I thought this some more. I think a cleaner way to do what you wanted may be achieved by adding an AlgorithmParameterGenerator impl for GCM. I've read through your email multiple times but yet I can't think of a good way to fit all the functionality that you wanted into the GCMParamet

hg: jdk8/tl/jdk: 8005634: tools/launcher/VersionCheck.java fails version check on jdeps

2013-01-03 Thread chris . hegarty
Changeset: 21708d15553b Author:chegar Date: 2013-01-03 10:00 + URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/21708d15553b 8005634: tools/launcher/VersionCheck.java fails version check on jdeps Summary: add jdeps to the list of tools that do not support '-version' Reviewed-by: