Draft API for JEP-166: Overhaul JKS-JCEKS-PKCS12 Keystores

2013-01-14 Thread Vincent Ryan
Hello all, I am seeking feedback on a draft of the public APIs that I believe are needed to address the features described in JEP-166 [1]. JEP-166 is targeted to JDK 8 Milestone 6 so I am keen to get the bulk of these API changes integrated into the last remaining build of M6: Build 75. Note

hg: jdk8/tl/jdk: 7162007: Clean up i18n related caches

2013-01-14 Thread naoto . sato
Changeset: 1d7a6adf499f Author:naoto Date: 2013-01-14 11:09 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/1d7a6adf499f 7162007: Clean up i18n related caches Reviewed-by: okutsu, ohair ! make/java/java/FILES_java.gmk ! src/share/classes/java/text/DateFormatSymbols.java !

[8] Request for review: 8005414: Removing fix for JDK-6500133

2013-01-14 Thread Jason Uh
This change removes the fix for 6500133, as it has been determined to be not compliant with the PKIX standard. Webrev: http://cr.openjdk.java.net/~juh/8005414/webrev.00/ Original bug: http://bugs.sun.com/view_bug.do?bug_id=6500133 Thanks, Jason

Re: [8] Request for review: 8005414: Removing fix for JDK-6500133

2013-01-14 Thread Sean Mullan
Looks good to me. --Sean On 01/14/2013 04:38 PM, Jason Uh wrote: This change removes the fix for 6500133, as it has been determined to be not compliant with the PKIX standard. Webrev: http://cr.openjdk.java.net/~juh/8005414/webrev.00/ Original bug:

hg: jdk8/tl/langtools: 8006119: update javac to follow latest spec for repeatable annotations

2013-01-14 Thread jonathan . gibbons
Changeset: df694c775e8a Author:jjg Date: 2013-01-14 13:50 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/df694c775e8a 8006119: update javac to follow latest spec for repeatable annotations Reviewed-by: darcy !

Re: [8] Request for review: 8005414: Removing fix for JDK-6500133

2013-01-14 Thread Bernd Eckenfels
Am 14.01.2013, 22:52 Uhr, schrieb Sean Mullan sean.mul...@oracle.com: Looks good to me. The patch removes all unit tests for this class it seems. There should be one parseable URL and if you intent to reject illegal content you can use the test vectors to test for the expected exception.

Re: [8] Request for review: 8005414: Removing fix for JDK-6500133

2013-01-14 Thread Sean Mullan
On 01/14/2013 05:00 PM, Bernd Eckenfels wrote: Am 14.01.2013, 22:52 Uhr, schrieb Sean Mullan sean.mul...@oracle.com: Looks good to me. The patch removes all unit tests for this class it seems. There should be one parseable URL and if you intent to reject illegal content you can use the test

hg: jdk8/tl/langtools: 8006241: Test DocRootSlash.java fails

2013-01-14 Thread jonathan . gibbons
Changeset: d54b4a091450 Author:jjg Date: 2013-01-14 14:17 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/d54b4a091450 8006241: Test DocRootSlash.java fails Reviewed-by: darcy ! test/com/sun/javadoc/DocRootSlash/DocRootSlash.java

Re: [8] Request for review: 8005414: Removing fix for JDK-6500133

2013-01-14 Thread Jason Uh
There used to be a unit test in the closed workspace for this case that was removed when the fix for 6500133 was introduced. That test and its certificate will be restored. Thanks, Jason On 01/14/2013 02:18 PM, Sean Mullan wrote: On 01/14/2013 05:00 PM, Bernd Eckenfels wrote: Am 14.01.2013,

hg: jdk8/tl/langtools: 7193719: Support repeating annotations in javax.lang.model

2013-01-14 Thread joel . franck
Changeset: 9f42a06a49c0 Author:jfranck Date: 2013-01-14 19:52 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/9f42a06a49c0 7193719: Support repeating annotations in javax.lang.model Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/code/Symbol.java !

Re: [8] Request for review: 8005414: Removing fix for JDK-6500133

2013-01-14 Thread Jason Uh
Sorry, please refer to the following webrev instead: http://cr.openjdk.java.net/~juh/8005414/webrev.02/ (Removed @bug tag as this is no longer fixing 6500133). On 01/14/2013 03:41 PM, Jason Uh wrote: Thanks for your suggestions. I suppose there's no reason to restore the old test, so here's

hg: jdk8/tl/jdk: 8005252: pack200 should support MethodParameters

2013-01-14 Thread kumar . x . srinivasan
Changeset: dcb64d498d5b Author:ksrini Date: 2013-01-14 15:46 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/dcb64d498d5b 8005252: pack200 should support MethodParameters Reviewed-by: jrose ! src/share/classes/com/sun/java/util/jar/pack/Attribute.java !

[8] Request for review: 8005939: sun/security/x509/{X509CRLImpl, X509CertImpl}/Verify.java fail in confusing way when some providers not present

2013-01-14 Thread Jason Uh
(Resending with bug ID in the Subject.) This change allows the tests sun/security/x509/{X509CRLImpl,X509CertImpl}/Verify.java to fail with a more meaningful message when a provider is not found. Webrev: http://cr.openjdk.java.net/~juh/8005939/webrev.00/ Bug:

Code review request 8006265, Add test SSLEngineDeadlock.java to ProblemList

2013-01-14 Thread Xuelei Fan
webrev: http://cr.openjdk.java.net./~xuelei/8006265/webrev.00/ Occasionally, test case SSLEngineDeadlock.java timeout because of performance issue of testing itself, see [JDK-7144048]. Need to add this test to ProblemList. Xuelei [JDK-7144048]:

Re: Code review request 8006265, Add test SSLEngineDeadlock.java to ProblemList

2013-01-14 Thread Weijun Wang
Good. Hopefully the test can be liberated soon. :) Thanks Max On 01/15/2013 10:13 AM, Xuelei Fan wrote: webrev: http://cr.openjdk.java.net./~xuelei/8006265/webrev.00/ Occasionally, test case SSLEngineDeadlock.java timeout because of performance issue of testing itself, see [JDK-7144048].

Re: [8] Request for review: 8005939: sun/security/x509/{X509CRLImpl, X509CertImpl}/Verify.java fail in confusing way when some providers not present

2013-01-14 Thread Weijun Wang
Hi Jason The code change looks good. I suppose you mean smaller profiles in the first line of the bug description? Thanks Max On 01/15/2013 10:05 AM, Jason Uh wrote: (Resending with bug ID in the Subject.) This change allows the tests

hg: jdk8/tl/jdk: 8006265: Add test SSLEngineDeadlock.java to ProblemList

2013-01-14 Thread xuelei . fan
Changeset: edb7e34a0531 Author:xuelei Date: 2013-01-14 18:31 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/edb7e34a0531 8006265: Add test SSLEngineDeadlock.java to ProblemList Reviewed-by: weijun ! test/ProblemList.txt