hg: jdk8/tl/jdk: 3 new changesets

Changeset: 4209b3936a7f Author:mduigou Date: 2013-01-25 16:13 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/4209b3936a7f 8005632: Extend java.util.Logger to use Supplier for messages Reviewed-by: briangoetz, mduigou Contributed-by: henry@oracle.com ! src/share/classes/j

hg: jdk8/tl/jdk: 7017962: Obsolete link is used in URL class level spec

Changeset: 77bde15bc6a9 Author:khazra Date: 2013-01-25 11:52 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/77bde15bc6a9 7017962: Obsolete link is used in URL class level spec Summary: Change the link to an archived document Reviewed-by: chegar, mduigou ! src/share/classes/j

Re: [8] code review for 8006946: PKCS12 test failure due to incorrect alias name

Thanks Mike. A 'contains' feature on arrays would certainly be useful since arrays are quite convenient to statically initialize. Yes I could have defined separate OID strings. They are already defined in integer array form. I will have to re-visit this code following M6. On 25/01/2013 17:42,

Re: [8] code review for 8006951: Avoid storing duplicate PKCS12 attributes

On 25/01/2013 17:20, Sean Mullan wrote: On 01/25/2013 12:05 PM, Vincent Ryan wrote: Sure. Three safeBag attributes require special handling by the PKCS12 keystore: friendlyName, localKeyId and trustedKeyUsage. The friendlyName is used as the keystore entry alias, localKeyId is used to match priv

hg: jdk8/tl/jdk: 8006951: Avoid storing duplicate PKCS12 attributes

Changeset: 117491dd58c2 Author:vinnie Date: 2013-01-25 17:47 + URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/117491dd58c2 8006951: Avoid storing duplicate PKCS12 attributes Reviewed-by: mullan ! src/share/classes/sun/security/pkcs12/PKCS12KeyStore.java

Re: [8] code review for 8006946: PKCS12 test failure due to incorrect alias name

At 08:47 AM 1/25/2013, Vincent Ryan wrote: >Please review this fix to correct a failing PKCS12 test: > >Webrev: >http://cr.openjdk.java.net/~vinnie/8006946/webrev.00/ > >Thanks. This first is not a comment on the change - but a "why can't ja

Re: [8] code review for 8006951: Avoid storing duplicate PKCS12 attributes

On 01/25/2013 12:05 PM, Vincent Ryan wrote: Sure. Three safeBag attributes require special handling by the PKCS12 keystore: friendlyName, localKeyId and trustedKeyUsage. The friendlyName is used as the keystore entry alias, localKeyId is used to match private keys to their associated certificat

Re: [8] code review for 8006951: Avoid storing duplicate PKCS12 attributes

Sure. Three safeBag attributes require special handling by the PKCS12 keystore: friendlyName, localKeyId and trustedKeyUsage. The friendlyName is used as the keystore entry alias, localKeyId is used to match private keys to their associated certificates, and trustedKeyUsage, to identify trusted

Re: [8] code review for 8006951: Avoid storing duplicate PKCS12 attributes

Can you explain a bit more what use-case is causing this failure? I don't quite understand why you are ignoring the attributes that are already in the KeyStore.Entry. --Sean On 01/25/2013 10:37 AM, Vincent Ryan wrote: Please review this fix to correct a failing PKCS12 test: Webrev: http://cr

hg: jdk8/tl/jdk: 8006946: PKCS12 test failure due to incorrect alias name

Changeset: c6ea84a629db Author:vinnie Date: 2013-01-25 16:19 + URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c6ea84a629db 8006946: PKCS12 test failure due to incorrect alias name Reviewed-by: mullan ! src/share/classes/sun/security/pkcs12/PKCS12KeyStore.java

Re: [8] code review for 8006946: PKCS12 test failure due to incorrect alias name

Thanks. On 25 Jan 2013, at 15:21, Sean Mullan wrote: > Looks fine. Don't forget to add the appropriate noreg label to the bug and > add what specific test is failing. > > --Sean > > On 01/25/2013 08:47 AM, Vincent Ryan wrote: >> Please review this fix to correct a failing PKCS12 test: >> >> W

[8] code review for 8006951: Avoid storing duplicate PKCS12 attributes

Please review this fix to correct a failing PKCS12 test: Webrev: http://cr.openjdk.java.net/~vinnie/8006951/webrev.00/ Thanks.

Re: [8] code review for 8006946: PKCS12 test failure due to incorrect alias name

Looks fine. Don't forget to add the appropriate noreg label to the bug and add what specific test is failing. --Sean On 01/25/2013 08:47 AM, Vincent Ryan wrote: Please review this fix to correct a failing PKCS12 test: Webrev: http://cr.openjdk.java.net/~vinnie/8006946/webrev.00/ Thanks.

[8] code review for 8006946: PKCS12 test failure due to incorrect alias name

Please review this fix to correct a failing PKCS12 test: Webrev: http://cr.openjdk.java.net/~vinnie/8006946/webrev.00/ Thanks.

hg: jdk8/tl/jdk: 8006565: java.lang.instrument specification should make it clear that -javaagent is optional

Changeset: 4a4b97f7f83b Author:alanb Date: 2013-01-25 13:09 + URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/4a4b97f7f83b 8006565: java.lang.instrument specification should make it clear that -javaagent is optional Reviewed-by: sla, dcubed, mchung ! src/share/classes/java/lan

hg: jdk8/tl/jdk: 7183373: URLClassloader.close() does not close JAR files whose resources have been loaded via getResource()

Changeset: 4c9fcb5cbc07 Author:dingxmin Date: 2013-01-25 17:00 +0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/4c9fcb5cbc07 7183373: URLClassloader.close() does not close JAR files whose resources have been loaded via getResource() Reviewed-by: chegar ! src/share/classes/sun