Re: [8] code review for 8006994: Cleanup PKCS12 tests to ensure streams get closed

2013-02-04 Thread Sean Mullan
Looks good to me. --Sean On 02/01/2013 03:12 PM, Vincent Ryan wrote: Please review this fix to correct PKCS12 tests that are failing (on Windows): Webrev: http://cr.openjdk.java.net/~vinnie/8006994/webrev.00/ Thanks.

Re: [8] code review for 8006994: Cleanup PKCS12 tests to ensure streams get closed

2013-02-04 Thread Vincent Ryan
Thanks. On 4 Feb 2013, at 15:41, Sean Mullan wrote: Looks good to me. --Sean On 02/01/2013 03:12 PM, Vincent Ryan wrote: Please review this fix to correct PKCS12 tests that are failing (on Windows): Webrev: http://cr.openjdk.java.net/~vinnie/8006994/webrev.00/ Thanks.

hg: jdk8/tl/jdk: 8006994: Cleanup PKCS12 tests to ensure streams get closed

2013-02-04 Thread vincent . x . ryan
Changeset: 5bf1c9e6be60 Author:vinnie Date: 2013-02-04 17:20 + URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/5bf1c9e6be60 8006994: Cleanup PKCS12 tests to ensure streams get closed Reviewed-by: mullan ! test/java/security/KeyStore/PBETest.java !

[8] code review for 8007483: attributes are ignored when loading keys from a PKCS12 keystore

2013-02-04 Thread Vincent Ryan
Please review this fix to correct user's attributes being ignored when loading key entries from a PKCS12 keystore. Webrev: http://cr.openjdk.java.net/~vinnie/8007483/webrev.00/ Thanks.

hg: jdk8/tl/jdk: 8006295: Base64.Decoder.wrap(java.io.InputStream) returns InputStream which throws unspecified IOException on attempt to decode invalid Base64 byte stream; ...

2013-02-04 Thread xueming . shen
Changeset: e202f43a8b8a Author:sherman Date: 2013-02-04 11:58 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e202f43a8b8a 8006295: Base64.Decoder.wrap(java.io.InputStream) returns InputStream which throws unspecified IOException on attempt to decode invalid Base64 byte

hg: jdk8/tl/langtools: 8007490: NPE from DocumentationTool.run

2013-02-04 Thread jonathan . gibbons
Changeset: 1690928dc560 Author:jjg Date: 2013-02-04 15:30 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/1690928dc560 8007490: NPE from DocumentationTool.run Reviewed-by: darcy ! src/share/classes/com/sun/tools/javadoc/api/JavadocTool.java !

hg: jdk8/tl/jdk: 8007113: Upgrade AnnotatedElement.isAnnotionPresent to be a default method

2013-02-04 Thread joe . darcy
Changeset: e04467fa13af Author:darcy Date: 2013-02-04 17:56 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e04467fa13af 8007113: Upgrade AnnotatedElement.isAnnotionPresent to be a default method Reviewed-by: chegar, jfranck ! src/share/classes/java/lang/Class.java !

hg: jdk8/tl/langtools: 8007492: DocumentationTool cannot locate standard doclet when invoked from JRE

2013-02-04 Thread jonathan . gibbons
Changeset: 62d91c13dce2 Author:jjg Date: 2013-02-04 18:14 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/62d91c13dce2 8007492: DocumentationTool cannot locate standard doclet when invoked from JRE Reviewed-by: darcy !

hg: jdk8/tl: Added tag jdk8-b75 for changeset 2a713921952c

2013-02-04 Thread lana . steuck
Changeset: 5b19cef637a6 Author:katleman Date: 2013-01-31 17:04 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/rev/5b19cef637a6 Added tag jdk8-b75 for changeset 2a713921952c ! .hgtags

hg: jdk8/tl/corba: Added tag jdk8-b75 for changeset d4e68ce17795

2013-02-04 Thread lana . steuck
Changeset: 4a6be02e66a3 Author:katleman Date: 2013-01-31 17:04 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/4a6be02e66a3 Added tag jdk8-b75 for changeset d4e68ce17795 ! .hgtags

hg: jdk8/tl/hotspot: Added tag jdk8-b75 for changeset 6778d0b16593

2013-02-04 Thread lana . steuck
Changeset: 20b605466ccb Author:katleman Date: 2013-01-31 17:04 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/20b605466ccb Added tag jdk8-b75 for changeset 6778d0b16593 ! .hgtags

hg: jdk8/tl/jaxp: Added tag jdk8-b75 for changeset ff0b73a6b3f6

2013-02-04 Thread lana . steuck
Changeset: 8d65b381880b Author:katleman Date: 2013-01-31 17:04 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/8d65b381880b Added tag jdk8-b75 for changeset ff0b73a6b3f6 ! .hgtags

hg: jdk8/tl/jdk: 2 new changesets

2013-02-04 Thread lana . steuck
Changeset: 6ba6353ab42c Author:katleman Date: 2013-01-31 17:04 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/6ba6353ab42c Added tag jdk8-b75 for changeset 4a67fdb752b7 ! .hgtags Changeset: fd37f0846653 Author:lana Date: 2013-02-04 22:37 -0800 URL:

hg: jdk8/tl/jaxws: Added tag jdk8-b75 for changeset 966bf9f3c41a

2013-02-04 Thread lana . steuck
Changeset: a63ef2391c20 Author:katleman Date: 2013-01-31 17:04 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jaxws/rev/a63ef2391c20 Added tag jdk8-b75 for changeset 966bf9f3c41a ! .hgtags